61821 2011-05-31 16:55:06 -0700 [V8] Optimize fetches of indexed properties in custom bindings 2011-06-01 12:56:51 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kbr kbr dglazkov jamesr japhet levin oldest_to_newest 412993 0 kbr 2011-05-31 16:55:06 -0700 Currently the custom V8 bindings for typed arrays' set() method taking a JavaScript array allocate a new Number instance for each element fetched. The V8 API contains a method on the Object class which supports faster fetching of indexed properties. I'm not sure whether it was an oversight on my part or whether that method didn't exist at the time the code was written, but it should definitely be used. 412998 1 kbr 2011-05-31 16:57:47 -0700 The associated Chromium bug report is http://crbug.com/84007 . 413002 2 95513 kbr 2011-05-31 17:03:36 -0700 Created attachment 95513 Patch 413340 3 95513 antonm 2011-06-01 06:44:50 -0700 Comment on attachment 95513 Patch LGTM 413393 4 95513 japhet 2011-06-01 08:29:44 -0700 Comment on attachment 95513 Patch This is fine, though I notice that there are several other places in the v8 bindings where we are still using the the Get() variant you're removing here. Is there any reason we shouldn't change those too? 413562 5 kbr 2011-06-01 12:05:34 -0700 Good point. I've updated the synopsis and will upload a new patch shortly. 413592 6 95644 kbr 2011-06-01 12:49:40 -0700 Created attachment 95644 Patch 413594 7 95644 japhet 2011-06-01 12:50:34 -0700 Comment on attachment 95644 Patch Great, thanks! 413598 8 kbr 2011-06-01 12:56:51 -0700 "webkit-patch land" hung. Committed as http://trac.webkit.org/changeset/87837 . 95513 2011-05-31 17:03:36 -0700 2011-06-01 12:49:37 -0700 Patch bug-61821-20110531170335.patch text/plain 1938 kbr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3NzYyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMzEgIEtlbm5ldGgg UnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtWOF0gT3B0aW1pemUgY3VzdG9tIGJpbmRpbmdzIGZvciB0eXBl ZCBhcnJheXMnIHNldChBcnJheSkgbWV0aG9kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02MTgyMQorCisgICAgICAgIEF2b2lkIGFsbG9jYXRpbmcgZ2Fy YmFnZSBpbiBhZmZlY3RlZCBjdXN0b20gYmluZGluZ3MuIFRoaXMgc3BlZWRzCisgICAgICAgIHVw IHRoZSB0ZXN0IGNhc2UgYnkgYXQgbGVhc3QgYSBmYWN0b3Igb2YgdHdvLiBObyBuZXcgdGVzdHM7 CisgICAgICAgIGNvdmVyZWQgYnkgZXhpc3RpbmcgdHlwZWQgYXJyYXkgbGF5b3V0IHRlc3RzLgor CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4QXJyYXlCdWZmZXJWaWV3Q3VzdG9tLmg6 CisgICAgICAgIChXZWJDb3JlOjpzZXRXZWJHTEFycmF5SGVscGVyKToKKwogMjAxMS0wNS0yNyAg QWRyaWVubmUgV2Fsa2VyICA8ZW5uZUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEphbWVzIFJvYmluc29uLgpJbmRleDogU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9t L1Y4QXJyYXlCdWZmZXJWaWV3Q3VzdG9tLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvY3VzdG9tL1Y4QXJyYXlCdWZmZXJWaWV3Q3VzdG9tLmgJKHJldmlzaW9uIDg3 NzQ3KQorKysgU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4QXJyYXlCdWZmZXJW aWV3Q3VzdG9tLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0OSw3ICsxNDksNyBAQCB2ODo6SGFuZGxl PHY4OjpWYWx1ZT4gY29uc3RydWN0V2ViR0xBcnJhCiAgICAgaWYgKCFzcmNBcnJheS5Jc0VtcHR5 KCkpIHsKICAgICAgICAgLy8gTmVlZCB0byBjb3B5IHRoZSBpbmNvbWluZyBhcnJheSBpbnRvIHRo ZSBuZXdseSBjcmVhdGVkIEFycmF5QnVmZmVyVmlldy4KICAgICAgICAgZm9yICh1bnNpZ25lZCBp ID0gMDsgaSA8IGxlbjsgaSsrKSB7Ci0gICAgICAgICAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiB2 YWwgPSBzcmNBcnJheS0+R2V0KHY4OjpJbnRlZ2VyOjpOZXdGcm9tVW5zaWduZWQoaSkpOworICAg ICAgICAgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmFsID0gc3JjQXJyYXktPkdldChpKTsKICAg ICAgICAgICAgIGFycmF5LT5zZXQoaSwgdmFsLT5OdW1iZXJWYWx1ZSgpKTsKICAgICAgICAgfQog ICAgIH0KQEAgLTE5Niw3ICsxOTYsNyBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gc2V0V2ViR0xB cnJheUhlbHBlCiAgICAgICAgICAgICBWOFByb3h5OjpzZXRET01FeGNlcHRpb24oSU5ERVhfU0la RV9FUlIpOwogICAgICAgICBlbHNlCiAgICAgICAgICAgICBmb3IgKHVpbnQzMl90IGkgPSAwOyBp IDwgbGVuZ3RoOyBpKyspCi0gICAgICAgICAgICAgICAgaW1wbC0+c2V0KG9mZnNldCArIGksIGFy cmF5LT5HZXQodjg6OkludGVnZXI6Ok5ld0Zyb21VbnNpZ25lZChpKSktPk51bWJlclZhbHVlKCkp OworICAgICAgICAgICAgICAgIGltcGwtPnNldChvZmZzZXQgKyBpLCBhcnJheS0+R2V0KGkpLT5O dW1iZXJWYWx1ZSgpKTsKIAogICAgICAgICByZXR1cm4gdjg6OlVuZGVmaW5lZCgpOwogICAgIH0K 95644 2011-06-01 12:49:40 -0700 2011-06-01 12:50:34 -0700 Patch bug-61821-20110601124939.patch text/plain 5034 kbr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3ODM1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTEtMDYtMDEgIEtlbm5ldGgg UnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtWOF0gT3B0aW1pemUgZmV0Y2hlcyBvZiBpbmRleGVkIHByb3Bl cnRpZXMgaW4gY3VzdG9tIGJpbmRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02MTgyMQorCisgICAgICAgIEF2b2lkIGFsbG9jYXRpbmcgZ2FyYmFn ZSBpbiBhZmZlY3RlZCBjdXN0b20gYmluZGluZ3MuIFRoaXMgc3BlZWRzCisgICAgICAgIHVwIG9u ZSB0ZXN0IGNhc2UgYnkgYXQgbGVhc3QgYSBmYWN0b3Igb2YgdHdvLiBObyBuZXcgdGVzdHM7Cisg ICAgICAgIGNvdmVyZWQgYnkgZXhpc3RpbmcgbGF5b3V0IHRlc3RzICh0eXBlZCBhcnJheSBhbmQg b3RoZXJ3aXNlKS4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEFycmF5QnVmZmVy Vmlld0N1c3RvbS5oOgorICAgICAgICAoV2ViQ29yZTo6Y29uc3RydWN0V2ViR0xBcnJheSk6Cisg ICAgICAgIChXZWJDb3JlOjpzZXRXZWJHTEFycmF5SGVscGVyKToKKyAgICAgICAgKiBiaW5kaW5n cy92OC9jdXN0b20vVjhJbnNwZWN0b3JGcm9udGVuZEhvc3RDdXN0b20uY3BwOgorICAgICAgICAo V2ViQ29yZTo6VjhJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OnNob3dDb250ZXh0TWVudUNhbGxiYWNr KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhNZXNzYWdlUG9ydEN1c3RvbS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpnZXRNZXNzYWdlUG9ydEFycmF5KToKKyAgICAgICAgKiBiaW5k aW5ncy92OC9jdXN0b20vVjhXZWJHTFJlbmRlcmluZ0NvbnRleHRDdXN0b20uY3BwOgorICAgICAg ICAoV2ViQ29yZTo6anNBcnJheVRvRmxvYXRBcnJheSk6CisgICAgICAgIChXZWJDb3JlOjpqc0Fy cmF5VG9JbnRBcnJheSk6CisKIDIwMTEtMDYtMDEgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IENzYWJhIE9zenRyb2dvbsOhYy4KSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEFycmF5QnVmZmVyVmlld0N1c3Rv bS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEFy cmF5QnVmZmVyVmlld0N1c3RvbS5oCShyZXZpc2lvbiA4Nzc0NykKKysrIFNvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEFycmF5QnVmZmVyVmlld0N1c3RvbS5oCSh3b3JraW5nIGNv cHkpCkBAIC0xNDksNyArMTQ5LDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGNvbnN0cnVjdFdl YkdMQXJyYQogICAgIGlmICghc3JjQXJyYXkuSXNFbXB0eSgpKSB7CiAgICAgICAgIC8vIE5lZWQg dG8gY29weSB0aGUgaW5jb21pbmcgYXJyYXkgaW50byB0aGUgbmV3bHkgY3JlYXRlZCBBcnJheUJ1 ZmZlclZpZXcuCiAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBsZW47IGkrKykgewot ICAgICAgICAgICAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmFsID0gc3JjQXJyYXktPkdldCh2ODo6 SW50ZWdlcjo6TmV3RnJvbVVuc2lnbmVkKGkpKTsKKyAgICAgICAgICAgIHY4OjpMb2NhbDx2ODo6 VmFsdWU+IHZhbCA9IHNyY0FycmF5LT5HZXQoaSk7CiAgICAgICAgICAgICBhcnJheS0+c2V0KGks IHZhbC0+TnVtYmVyVmFsdWUoKSk7CiAgICAgICAgIH0KICAgICB9CkBAIC0xOTYsNyArMTk2LDcg QEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IHNldFdlYkdMQXJyYXlIZWxwZQogICAgICAgICAgICAg VjhQcm94eTo6c2V0RE9NRXhjZXB0aW9uKElOREVYX1NJWkVfRVJSKTsKICAgICAgICAgZWxzZQog ICAgICAgICAgICAgZm9yICh1aW50MzJfdCBpID0gMDsgaSA8IGxlbmd0aDsgaSsrKQotICAgICAg ICAgICAgICAgIGltcGwtPnNldChvZmZzZXQgKyBpLCBhcnJheS0+R2V0KHY4OjpJbnRlZ2VyOjpO ZXdGcm9tVW5zaWduZWQoaSkpLT5OdW1iZXJWYWx1ZSgpKTsKKyAgICAgICAgICAgICAgICBpbXBs LT5zZXQob2Zmc2V0ICsgaSwgYXJyYXktPkdldChpKS0+TnVtYmVyVmFsdWUoKSk7CiAKICAgICAg ICAgcmV0dXJuIHY4OjpVbmRlZmluZWQoKTsKICAgICB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9jdXN0b20vVjhJbnNwZWN0b3JGcm9udGVuZEhvc3RDdXN0b20uY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEluc3BlY3RvckZy b250ZW5kSG9zdEN1c3RvbS5jcHAJKHJldmlzaW9uIDg3NzQ3KQorKysgU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvY3VzdG9tL1Y4SW5zcGVjdG9yRnJvbnRlbmRIb3N0Q3VzdG9tLmNwcAkod29y a2luZyBjb3B5KQpAQCAtODMsNyArODMsNyBAQCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhJbnNw ZWN0b3JGcm9udGVuCiAgICAgVmVjdG9yPENvbnRleHRNZW51SXRlbSo+IGl0ZW1zOwogCiAgICAg Zm9yIChzaXplX3QgaSA9IDA7IGkgPCBhcnJheS0+TGVuZ3RoKCk7ICsraSkgewotICAgICAgICB2 ODo6TG9jYWw8djg6Ok9iamVjdD4gaXRlbSA9IHY4OjpMb2NhbDx2ODo6T2JqZWN0Pjo6Q2FzdChh cnJheS0+R2V0KHY4OjpJbnRlZ2VyOjpOZXcoaSkpKTsKKyAgICAgICAgdjg6OkxvY2FsPHY4OjpP YmplY3Q+IGl0ZW0gPSB2ODo6TG9jYWw8djg6Ok9iamVjdD46OkNhc3QoYXJyYXktPkdldChpKSk7 CiAgICAgICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IHR5cGUgPSBpdGVtLT5HZXQodjg6OlN0cmlu Zzo6TmV3KCJ0eXBlIikpOwogICAgICAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiBpZCA9IGl0ZW0t PkdldCh2ODo6U3RyaW5nOjpOZXcoImlkIikpOwogICAgICAgICB2ODo6TG9jYWw8djg6OlZhbHVl PiBsYWJlbCA9IGl0ZW0tPkdldCh2ODo6U3RyaW5nOjpOZXcoImxhYmVsIikpOwpJbmRleDogU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4TWVzc2FnZVBvcnRDdXN0b20uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE1lc3NhZ2VQ b3J0Q3VzdG9tLmNwcAkocmV2aXNpb24gODc3NDcpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9jdXN0b20vVjhNZXNzYWdlUG9ydEN1c3RvbS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg5 LDcgKzg5LDcgQEAgYm9vbCBnZXRNZXNzYWdlUG9ydEFycmF5KHY4OjpMb2NhbDx2ODo6VgogCiAg ICAgLy8gVmFsaWRhdGUgdGhlIHBhc3NlZCBhcnJheSBvZiBwb3J0cy4KICAgICBmb3IgKHVuc2ln bmVkIGludCBpID0gMDsgaSA8IGxlbmd0aDsgKytpKSB7Ci0gICAgICAgIHY4OjpMb2NhbDx2ODo6 VmFsdWU+IHBvcnQgPSBwb3J0cy0+R2V0KHY4OjpJbnRlZ2VyOjpOZXcoaSkpOworICAgICAgICB2 ODo6TG9jYWw8djg6OlZhbHVlPiBwb3J0ID0gcG9ydHMtPkdldChpKTsKICAgICAgICAgLy8gVmFs aWRhdGlvbiBvZiBub24tbnVsbCBvYmplY3RzLCBwZXIgSFRNTDUgc3BlYyA4LjMuMy4KICAgICAg ICAgaWYgKGlzVW5kZWZpbmVkT3JOdWxsKHBvcnQpKSB7CiAgICAgICAgICAgICB0aHJvd0Vycm9y KElOVkFMSURfU1RBVEVfRVJSKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOFdlYkdMUmVuZGVyaW5nQ29udGV4dEN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4V2ViR0xSZW5kZXJpbmdDb250ZXh0Q3Vz dG9tLmNwcAkocmV2aXNpb24gODc3NDcpCisrKyBTb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9j dXN0b20vVjhXZWJHTFJlbmRlcmluZ0NvbnRleHRDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC03Nyw3ICs3Nyw3IEBAIHN0YXRpYyBmbG9hdCoganNBcnJheVRvRmxvYXRBcnJheSh2ODo6SGEK ICAgICBpZiAoIXRyeUZhc3RNYWxsb2MobGVuICogc2l6ZW9mKGZsb2F0KSkuZ2V0VmFsdWUoZGF0 YSkpCiAgICAgICAgIHJldHVybiAwOwogICAgIGZvciAodWludDMyX3QgaSA9IDA7IGkgPCBsZW47 IGkrKykgewotICAgICAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWwgPSBhcnJheS0+R2V0KHY4 OjpJbnRlZ2VyOjpOZXcoaSkpOworICAgICAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWwgPSBh cnJheS0+R2V0KGkpOwogICAgICAgICBpZiAoIXZhbC0+SXNOdW1iZXIoKSkgewogICAgICAgICAg ICAgZmFzdEZyZWUoZGF0YSk7CiAgICAgICAgICAgICByZXR1cm4gMDsKQEAgLTk2LDcgKzk2LDcg QEAgc3RhdGljIGludCoganNBcnJheVRvSW50QXJyYXkodjg6OkhhbmRsZQogICAgIGlmICghdHJ5 RmFzdE1hbGxvYyhsZW4gKiBzaXplb2YoaW50KSkuZ2V0VmFsdWUoZGF0YSkpCiAgICAgICAgIHJl dHVybiAwOwogICAgIGZvciAodWludDMyX3QgaSA9IDA7IGkgPCBsZW47IGkrKykgewotICAgICAg ICB2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWwgPSBhcnJheS0+R2V0KHY4OjpJbnRlZ2VyOjpOZXco aSkpOworICAgICAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWwgPSBhcnJheS0+R2V0KGkpOwog ICAgICAgICBib29sIG9rOwogICAgICAgICBpbnQgaXZhbCA9IHRvSW50MzIodmFsLCBvayk7CiAg ICAgICAgIGlmICghb2spIHsK