61812 2011-05-31 15:18:02 -0700 TestWebKitApi breaks in release mode due to gtest incompatibility with fast malloc 2011-08-04 11:02:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 57513 65706 1 dslomov dslomov dglazkov dslomov eric levin oldest_to_newest 412920 0 dslomov 2011-05-31 15:18:02 -0700 TestWebkitAPI crashes on startup in release mode due to malloc/free mismatch: - TestWebKitAPI is compiled with fast malloc for all - gtest uses system malloc. 412931 1 95494 dslomov 2011-05-31 15:30:42 -0700 Created attachment 95494 This disables global fast malloc for TestWebKitAPI. 412974 2 levin 2011-05-31 16:25:55 -0700 It would be nice to explain this a bit more. Not a lot, just enough so that someone who looks at this (in the future) to understand why this was done would be able to see the problem. Then they could determine if it is still needed, etc. 414154 3 95494 eric 2011-06-02 08:41:07 -0700 Comment on attachment 95494 This disables global fast malloc for TestWebKitAPI. This needs a comment. Otherwise folks won't understand why we have that line there. 414311 4 dslomov 2011-06-02 11:40:35 -0700 (In reply to comment #3) > (From update of attachment 95494 [details]) > This needs a comment. Otherwise folks won't understand why we have that line there. Yeah I am convinced now that it is not a good fix. Sorry for the noise 419938 5 eric 2011-06-13 15:16:03 -0700 Sounds like this is WONTFIX then. 419940 6 eric 2011-06-13 15:16:30 -0700 Oh, nevermind. You're planning to fix this some other way. 446318 7 102873 dslomov 2011-08-03 21:23:46 -0700 Created attachment 102873 Only disable fast malloc for offending class in GTest 446323 8 102873 levin 2011-08-03 21:38:06 -0700 Comment on attachment 102873 Only disable fast malloc for offending class in GTest Given that this is in GTest, I guess it should follow their style for indenting. (It doesn't follow WebKit's style either). Other than it looks fine. 446620 9 dslomov 2011-08-04 10:54:01 -0700 Landed in http://trac.webkit.org/changeset/92387. Closing bug. 95494 2011-05-31 15:30:42 -0700 2011-08-03 21:23:46 -0700 This disables global fast malloc for TestWebKitAPI. 61812.patch text/plain 1427 dslomov ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlNDdj OWRlLi45NDE2NjdmIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMzEgIERtaXRyeSBMb21vdiAgPGRzbG9t b3ZAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE4MTIKKyAg ICAgICAgVGVzdFdlYktpdEFQSSBicmVha3MgaW4gcmVsZWFzZSBtb2RlIGR1ZSB0byBndGVzdCBp bmNvbXBhdGliaWxpdHkgd2l0aCAKKyAgICAgICAgZmFzdCBtYWxsb2MuCisgICAgICAgIFRoaXMg ZGlzYWJsZXMgZ2VuZXJpYyBmYXN0IG1hbGxvYyBpbiBUZXN0V2ViS2l0QVBJLiAKKworICAgICAg ICAqIFRlc3RXZWJLaXRBUEkvUGxhdGZvcm1VdGlsaXRpZXMuaDoKKyAgICAgICAgKiBUZXN0V2Vi S2l0QVBJL1Rlc3QuaDoKKwogMjAxMS0wNS0zMSAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgS2lsemVyLgpkaWZmIC0tZ2l0IGEvVG9v bHMvVGVzdFdlYktpdEFQSS9QbGF0Zm9ybVV0aWxpdGllcy5oIGIvVG9vbHMvVGVzdFdlYktpdEFQ SS9QbGF0Zm9ybVV0aWxpdGllcy5oCmluZGV4IGU3N2M4ODAuLmI5NzVlYjAgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1Rlc3RXZWJLaXRBUEkvUGxhdGZvcm1VdGlsaXRpZXMuaAorKysgYi9Ub29scy9UZXN0 V2ViS2l0QVBJL1BsYXRmb3JtVXRpbGl0aWVzLmgKQEAgLTI2LDkgKzI2LDExIEBACiAjaWZuZGVm IFBsYXRmb3JtVXRpbGl0aWVzX2gKICNkZWZpbmUgUGxhdGZvcm1VdGlsaXRpZXNfaAogCisjZGVm aW5lIEVOQUJMRV9HTE9CQUxfRkFTVE1BTExPQ19ORVcgMAorCisjaW5jbHVkZSA8Z3Rlc3QvZ3Rl c3QuaD4KICNpbmNsdWRlIDxXZWJLaXQyL1dLUmV0YWluUHRyLmg+CiAjaW5jbHVkZSA8V2ViS2l0 Mi9XZWJLaXQyLmg+Ci0jaW5jbHVkZSA8Z3Rlc3QvZ3Rlc3QuaD4KICNpbmNsdWRlIDxzdHJpbmc+ CiAjaW5jbHVkZSA8d3RmL1BsYXRmb3JtLmg+CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdC5oIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0LmgKaW5kZXggN2FkZDA4MC4u ZjU4NzJhMyAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0LmgKKysrIGIvVG9v bHMvVGVzdFdlYktpdEFQSS9UZXN0LmgKQEAgLTI1LDcgKzI1LDcgQEAKIAogI2lmbmRlZiBUZXN0 X2gKICNkZWZpbmUgVGVzdF9oCi0KKyNkZWZpbmUgRU5BQkxFX0dMT0JBTF9GQVNUTUFMTE9DX05F VyAwCiAjaW5jbHVkZSA8Z3Rlc3QvZ3Rlc3QuaD4KIAogbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkg ewo= 102873 2011-08-03 21:23:46 -0700 2011-08-03 21:38:06 -0700 Only disable fast malloc for offending class in GTest 61812.patch text/plain 1925 dslomov ZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZyBiL1NvdXJjZS9UaGlyZFBh cnR5L0NoYW5nZUxvZwppbmRleCAzZGZjZjFlLi44NWVhMzc2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTEtMDgtMDMgIERtaXRyeSBMb21vdiAgPGRzbG9tb3ZAZ29vZ2xl LmNvbT4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjE4MTIKKyAgICAgICAgVGVzdFdlYktpdEFwaSBicmVha3MgaW4gcmVsZWFzZSBtb2RlIGR1ZSB0 byBndGVzdCBpbmNvbXBhdGliaWxpdHkgd2l0aCBmYXN0IG1hbGxvYworCisgICAgICAgIERpc2Fi bGUgZmFzdCBtYWxsb2MgZm9yIG9mZmVuZGluZyBjbGFzcyAoOjpzdGQ6OnN0cnN0cmVhbSkgaW4g Z3Rlc3QuCisgICAgICAgIFRoaXMgbG9va3MgbGlrZSB0aGUgbW9zdCBub24taW50cnVzaXZlIHNv bHV0aW9uLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogZ3Rlc3QvaW5jbHVkZS9ndGVzdC9pbnRlcm5hbC9ndGVzdC1wb3J0Lmg6CisgICAgICAgICh0 ZXN0aW5nOjppbnRlcm5hbDo6U3RyU3RyZWFtOjpvcGVyYXRvciBuZXcpOgorICAgICAgICAodGVz dGluZzo6aW50ZXJuYWw6OlN0clN0cmVhbTo6b3BlcmF0b3IgbmV3W10pOgorICAgICAgICAodGVz dGluZzo6aW50ZXJuYWw6OlN0clN0cmVhbTo6b3BlcmF0b3IgZGVsZXRlKToKKyAgICAgICAgKHRl c3Rpbmc6OmludGVybmFsOjpTdHJTdHJlYW06Om9wZXJhdG9yIGRlbGV0ZVtdKToKKwogMjAxMS0w Ny0wNSAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIEltcG9ydCBx dW5pdCBKYXZhU2NyaXB0IHVuaXQgdGVzdGluZyBmcmFtZXdvcmsKZGlmZiAtLWdpdCBhL1NvdXJj ZS9UaGlyZFBhcnR5L2d0ZXN0L2luY2x1ZGUvZ3Rlc3QvaW50ZXJuYWwvZ3Rlc3QtcG9ydC5oIGIv U291cmNlL1RoaXJkUGFydHkvZ3Rlc3QvaW5jbHVkZS9ndGVzdC9pbnRlcm5hbC9ndGVzdC1wb3J0 LmgKaW5kZXggYTJhNjJiZS4uNDQxNmZjOCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkv Z3Rlc3QvaW5jbHVkZS9ndGVzdC9pbnRlcm5hbC9ndGVzdC1wb3J0LmgKKysrIGIvU291cmNlL1Ro aXJkUGFydHkvZ3Rlc3QvaW5jbHVkZS9ndGVzdC9pbnRlcm5hbC9ndGVzdC1wb3J0LmgKQEAgLTYw OSw3ICs2MDksMzMgQEAgbmFtZXNwYWNlIGludGVybmFsIHsKIAogY2xhc3MgU3RyaW5nOwogCi10 eXBlZGVmIDo6c3RkOjpzdHJpbmdzdHJlYW0gU3RyU3RyZWFtOworY2xhc3MgU3RyU3RyZWFtIDog cHVibGljIDo6c3RkOjpzdHJpbmdzdHJlYW0geworICBwdWJsaWM6CisgICAgdm9pZCogb3BlcmF0 b3IgbmV3KHNpemVfdCwgdm9pZCogcCkgeyByZXR1cm4gcDsgfQorICAgIHZvaWQqIG9wZXJhdG9y IG5ld1tdKHNpemVfdCwgdm9pZCogcCkgeyByZXR1cm4gcDsgfQorCisgICAgdm9pZCogb3BlcmF0 b3IgbmV3KHNpemVfdCBzaXplKQorICAgIHsKKyAgICAgIHJldHVybiBtYWxsb2Moc2l6ZSk7Cisg ICAgfQorCisgICAgdm9pZCBvcGVyYXRvciBkZWxldGUodm9pZCogcCkKKyAgICB7CisgICAgICBm cmVlKHApOworICAgIH0KKworICAgIHZvaWQqIG9wZXJhdG9yIG5ld1tdKHNpemVfdCBzaXplKQor ICAgIHsKKyAgICAgIHJldHVybiBtYWxsb2Moc2l6ZSk7CisgICAgfQorCisgICAgdm9pZCBvcGVy YXRvciBkZWxldGVbXSh2b2lkKiBwKQorICAgIHsKKyAgICAgIGZyZWUocCk7CisgICAgfQorfTsK KworCiAKIC8vIEEgaGVscGVyIGZvciBzdXBwcmVzc2luZyB3YXJuaW5ncyBvbiBjb25zdGFudCBj b25kaXRpb24uICBJdCBqdXN0CiAvLyByZXR1cm5zICdjb25kaXRpb24nLgo=