6180 2005-12-21 02:32:19 -0800 "text" output in fragment produced by XSLTProccessor is wrong (has xhtml garbage) 2006-01-04 13:22:12 -0800 1 1 1 Unclassified WebKit XML 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 5142 1 eric andersca ap oldest_to_newest 26305 0 eric 2005-12-21 02:32:19 -0800 "text" output in fragment produced by XSLTProccessor is wrong (has xhtml garbage) There is a new test case which covers this, just landed (or about to land): fast/xsl/xslt-processer.html: "2.5 transformed fragment containing only text" 27525 1 5431 eric 2006-01-02 17:19:13 -0800 Created attachment 5431 untested fix My tree is currently unbuildable (due to other half-patches I have applied), but I was in this code today, and saw a simple fix to this bug, which I've attached. I also included one additional fastMalloc usage. 27737 2 5484 andersca 2006-01-04 12:27:58 -0800 Created attachment 5484 Tweak patch and update tests 27739 3 5484 eric 2006-01-04 12:41:21 -0800 Comment on attachment 5484 Tweak patch and update tests Looks great. XSLT parameters are still broken. But this fixes what it claims to. r=me. 5431 2006-01-02 17:19:13 -0800 2006-01-04 12:27:58 -0800 untested fix text-fragment.patch text/plain 1680 eric SW5kZXg6IHhzbHRfcHJvY2Vzc29yaW1wbC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9y b290L1dlYkNvcmUva2h0bWwveHNsL3hzbHRfcHJvY2Vzc29yaW1wbC5jcHAsdgpyZXRyaWV2aW5n IHJldmlzaW9uIDEuMjEKZGlmZiAtcCAtdSAtcjEuMjEgeHNsdF9wcm9jZXNzb3JpbXBsLmNwcAot LS0geHNsdF9wcm9jZXNzb3JpbXBsLmNwcAkzMCBEZWMgMjAwNSAwNTozMzoxNyAtMDAwMAkxLjIx CisrKyB4c2x0X3Byb2Nlc3NvcmltcGwuY3BwCTMgSmFuIDIwMDYgMDE6MTk6MTQgLTAwMDAKQEAg LTE1MSw3ICsxNTEsNyBAQCBzdGF0aWMgY29uc3QgY2hhciAqKnhzbHRQYXJhbUFycmF5RnJvbVBh CiAgICAgaWYgKHBhcmFtZXRlcnMuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gMDsKIAotICAg IGNvbnN0IGNoYXIgKipwYXJhbWV0ZXJBcnJheSA9IChjb25zdCBjaGFyICoqKW1hbGxvYygoKHBh cmFtZXRlcnMuc2l6ZSgpICogMikgKyAxKSAqIHNpemVvZihjaGFyICopKTsKKyAgICBjb25zdCBj aGFyICoqcGFyYW1ldGVyQXJyYXkgPSAoY29uc3QgY2hhciAqKilmYXN0TWFsbG9jKCgocGFyYW1l dGVycy5zaXplKCkgKiAyKSArIDEpICogc2l6ZW9mKGNoYXIgKikpOwogCiAgICAgWFNMVFByb2Nl c3NvckltcGw6OlBhcmFtZXRlck1hcDo6aXRlcmF0b3IgZW5kID0gcGFyYW1ldGVycy5lbmQoKTsK ICAgICB1bnNpZ25lZCBpbmRleCA9IDA7CkBAIC0xNzEsMTAgKzE3MSwxMCBAQCBzdGF0aWMgdm9p ZCBmcmVlWHNsdFBhcmFtQXJyYXkoY29uc3QgY2hhCiAgICAgICAgIHJldHVybjsKICAgICAKICAg ICB3aGlsZSAoKnRlbXApIHsKLSAgICAgICAgZnJlZSgodm9pZCAqKSoodGVtcCsrKSk7CisgICAg ICAgIGZyZWUoKHZvaWQgKikqKHRlbXArKykpOyAvLyBzdHJkdXAgcmV0dXJucyBtYWxsb2MnZCBi bG9ja3MsIHNvIHdlIGhhdmUgdG8gdXNlIGZyZWUoKSBoZXJlCiAgICAgICAgIGZyZWUoKHZvaWQg KikqKHRlbXArKykpOwogICAgIH0KLSAgICBmcmVlKHBhcmFtcyk7CisgICAgZmFzdEZyZWUocGFy YW1zKTsKIH0KIAogCkBAIC0yMzEsOSArMjMxLDkgQEAgc3RhdGljIGlubGluZSBSZWZQdHI8RG9j dW1lbnRGcmFnbWVudEltcAogICAgIAogICAgIGlmIChzb3VyY2VNSU1FVHlwZSA9PSAidGV4dC9o dG1sIikKICAgICAgICAgcGFyc2VIVE1MRG9jdW1lbnRGcmFnbWVudChzb3VyY2VTdHJpbmcsIGZy YWdtZW50LmdldCgpKTsKKyAgICBlbHNlIGlmIChzb3VyY2VNSU1FVHlwZSA9PSAidGV4dC9wbGFp biIpCisgICAgICAgIGZyYWdtZW50LmFkZENoaWxkKG91dHB1dERvYy5jcmVhdGVUZXh0Tm9kZShz b3VyY2VTdHJpbmcpKTsKICAgICBlbHNlIHsKLSAgICAgICAgaWYgKHNvdXJjZU1JTUVUeXBlID09 ICJ0ZXh0L3BsYWluIikKLSAgICAgICAgICAgIHRyYW5zZm9ybVRleHRTdHJpbmdUb1hIVE1MRG9j dW1lbnRTdHJpbmcoc291cmNlU3RyaW5nKTsKICAgICAgICAgYm9vbCBzdWNjZXNzZnVsUGFyc2Ug PSBwYXJzZVhNTERvY3VtZW50RnJhZ21lbnQoc291cmNlU3RyaW5nLCBmcmFnbWVudC5nZXQoKSwg b3VwdXREb2MtPmRvY3VtZW50RWxlbWVudCgpKTsKICAgICAgICAgaWYgKCFzdWNjZXNzZnVsUGFy c2UpCiAgICAgICAgICAgICByZXR1cm4gMDsK 5484 2006-01-04 12:27:58 -0800 2006-01-04 12:41:21 -0800 Tweak patch and update tests xslt-text-fragment.txt text/plain 5559 andersca SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jv b3QvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIyMApkaWZm IC1wIC11IC1yMS4yMjAgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCi0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJNCBKYW4gMjAwNiAyMDowMTo1MCAtMDAwMAkxLjIyMAorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCTQgSmFuIDIwMDYgMjA6MjQ6MzQgLTAwMDAKQEAgLTEsMyArMSwxMyBAQAorMjAwNi0w MS0wNCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAbWFjLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIHVwZGF0ZSB0ZXN0cyBmb3IgaHR0 cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD02MTgwCisgICAgICAg ICJ0ZXh0IiBvdXRwdXQgaW4gZnJhZ21lbnQgcHJvZHVjZWQgYnkgWFNMVFByb2NjZXNzb3IgaXMg d3JvbmcgKGhhcyB4aHRtbCBnYXJiYWdlKQorICAgICAgICAKKyAgICAgICAgKiBmYXN0L3hzbC94 c2x0LXByb2Nlc3Nlci1leHBlY3RlZC50eHQ6CisgICAgICAgIFVwZGF0ZS4KKwogMjAwNS0wMS0w NCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogIAogICAgICAgICAgTGF5b3V0 IHRlc3QgZm9yIDxyZGFyOi8vcHJvYmxlbS80MjE0MDgwPiBkb2N1bWVudC5lbWJlZHM6IApJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC94c2wveHNsdC1wcm9jZXNzZXItZXhwZWN0ZWQudHh0Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9MYXlvdXRUZXN0cy9mYXN0L3hzbC94c2x0LXByb2Nl c3Nlci1leHBlY3RlZC50eHQsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuNApkaWZmIC1wIC11IC1y MS40IExheW91dFRlc3RzL2Zhc3QveHNsL3hzbHQtcHJvY2Vzc2VyLWV4cGVjdGVkLnR4dAotLS0g TGF5b3V0VGVzdHMvZmFzdC94c2wveHNsdC1wcm9jZXNzZXItZXhwZWN0ZWQudHh0CTMwIERlYyAy MDA1IDE0OjUzOjM5IC0wMDAwCTEuNAorKysgTGF5b3V0VGVzdHMvZmFzdC94c2wveHNsdC1wcm9j ZXNzZXItZXhwZWN0ZWQudHh0CTQgSmFuIDIwMDYgMjA6MjQ6NDIgLTAwMDAKQEAgLTksNyArOSw3 IEBACiA8L3hzbDp0ZXh0PjwveHNsOnRlbXBsYXRlPgogCiA8eHNsOnRlbXBsYXRlPgotPHhzbDp2 YWx1ZS1vZiBzZWxlY3Q9Ii4iLz4JCisJCTx4c2w6dmFsdWUtb2Ygc2VsZWN0PSIuIi8+CiA8L3hz bDp0ZW1wbGF0ZT4KIAogPC94c2w6c3R5bGVzaGVldD4KQEAgLTY2LDE0ICs2Niw5IEBAIFN1Y2Nl c3MKIDIuNCB0cmFuc2Zvcm0gdG8gc2FtZSBmcmFnbWVudCB0d2ljZToKIFN1Y2Nlc3MKIDIuNSB0 cmFuc2Zvcm1lZCBmcmFnbWVudCBjb250YWluaW5nIG9ubHkgdGV4dDoKLSoqKipGYWlsdXJlKioq KiAoZXhwZWN0ZWQ6ICJTVUNDRVNTIiBhY3R1YWw6ICI8aHRtbCB4bWxucz0iaHR0cDovL3d3dy53 My5vcmcvMTk5OS94aHRtbCI+Ci08aGVhZD48dGl0bGU+PC90aXRsZT48L2hlYWQ+Ci08Ym9keT4K LTxwcmU+PC9wcmU+Ci08L2JvZHk+Ci08L2h0bWw+IikKKyoqKipGYWlsdXJlKioqKiAoZXhwZWN0 ZWQ6ICJTVUNDRVNTIiBhY3R1YWw6ICIiKQogMi42IGZyYWdtZW50IHVzaW5nIHBhc3NlZCBwYXJh bWV0ZXJzOgotKioqKkZhaWx1cmUqKioqIChleHBlY3RlZDogIlNVQ0NFU1MiIGFjdHVhbDogIm51 bGwiKQorKioqKkZhaWx1cmUqKioqIChleHBlY3RlZDogIlNVQ0NFU1MiIGFjdHVhbDogIiIpCiAK IDMuMCBET01Eb2N1bWVudCB0cmFuc2Zvcm1Ub0RvY3VtZW50KGluIERPTU5vZGUgc291cmNlKToK IApJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290 L1dlYkNvcmUvQ2hhbmdlTG9nLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjg2CmRpZmYgLXAgLXUg LXIxLjg2IFdlYkNvcmUvQ2hhbmdlTG9nCi0tLSBXZWJDb3JlL0NoYW5nZUxvZwk0IEphbiAyMDA2 IDIwOjAxOjQ4IC0wMDAwCTEuODYKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCTQgSmFuIDIwMDYgMjA6 MjY6NTkgLTAwMDAKQEAgLTEsMyArMSwyMSBAQAorMjAwNi0wMS0wNCAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAbWFjLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBCYXNlZCBvbiBhIHBhdGNoIGJ5IEVyaWMuCisgICAgICAgIAorICAgICAg ICAtIGZpeCBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTYx ODAKKyAgICAgICAgInRleHQiIG91dHB1dCBpbiBmcmFnbWVudCBwcm9kdWNlZCBieSBYU0xUUHJv Y2Nlc3NvciBpcyB3cm9uZyAoaGFzIHhodG1sIGdhcmJhZ2UpCisgICAgICAgIAorICAgICAgICAq IGtodG1sL3hzbC94c2x0X3Byb2Nlc3NvcmltcGwuY3BwOgorICAgICAgICAoRE9NOjp4c2x0UGFy YW1BcnJheUZyb21QYXJhbWV0ZXJNYXApOgorICAgICAgICAoRE9NOjpmcmVlWHNsdFBhcmFtQXJy YXkpOgorICAgICAgICBVc2UgZmFzdE1hbGxvYy9mYXN0RnJlZS4KKyAgICAgICAgCisgICAgICAg IChET006OmNyZWF0ZUZyYWdtZW50RnJvbVNvdXJjZSk6CisgICAgICAgIElmIHRoZSBvdXRwdXQg aXMgInRleHQiLCBqdXN0IGNyZWF0ZSBhIHRleHQgbm9kZSBhbmQgYWRkCisgICAgICAgIGl0IHRv IHRoZSBmcmFnbWVudC4KKwogMjAwNS0xMi0zMCAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBw bGUuY29tPgogIAogICAgICAgICAgUmV2aWV3ZWQgYnkgZGFyaW4uCkluZGV4OiBXZWJDb3JlL2to dG1sL3hzbC94c2x0X3Byb2Nlc3NvcmltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMv cm9vdC9XZWJDb3JlL2todG1sL3hzbC94c2x0X3Byb2Nlc3NvcmltcGwuY3BwLHYKcmV0cmlldmlu ZyByZXZpc2lvbiAxLjIyCmRpZmYgLXAgLXUgLXIxLjIyIFdlYkNvcmUva2h0bWwveHNsL3hzbHRf cHJvY2Vzc29yaW1wbC5jcHAKLS0tIFdlYkNvcmUva2h0bWwveHNsL3hzbHRfcHJvY2Vzc29yaW1w bC5jcHAJMyBKYW4gMjAwNiAwMjowNzoxMSAtMDAwMAkxLjIyCisrKyBXZWJDb3JlL2todG1sL3hz bC94c2x0X3Byb2Nlc3NvcmltcGwuY3BwCTQgSmFuIDIwMDYgMjA6Mjc6MDEgLTAwMDAKQEAgLTI1 LDYgKzI1LDcgQEAKICNpbmNsdWRlICJ4c2x0X3Byb2Nlc3NvcmltcGwuaCIKICNpbmNsdWRlICJ4 c2xfc3R5bGVzaGVldGltcGwuaCIKICNpbmNsdWRlICJ4bWxfdG9rZW5pemVyLmgiCisjaW5jbHVk ZSAiZG9tX3RleHRpbXBsLmgiCiAjaW5jbHVkZSAiaHRtbHRva2VuaXplci5oIgogI2luY2x1ZGUg Imh0bWxfZG9jdW1lbnRpbXBsLmgiCiAjaW5jbHVkZSAibG9hZGVyLmgiCkBAIC0xNTIsNyArMTUz LDcgQEAgc3RhdGljIGNvbnN0IGNoYXIgKip4c2x0UGFyYW1BcnJheUZyb21QYQogICAgIGlmIChw YXJhbWV0ZXJzLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuIDA7CiAKLSAgICBjb25zdCBjaGFy ICoqcGFyYW1ldGVyQXJyYXkgPSAoY29uc3QgY2hhciAqKiltYWxsb2MoKChwYXJhbWV0ZXJzLnNp emUoKSAqIDIpICsgMSkgKiBzaXplb2YoY2hhciAqKSk7CisgICAgY29uc3QgY2hhciAqKnBhcmFt ZXRlckFycmF5ID0gKGNvbnN0IGNoYXIgKiopZmFzdE1hbGxvYygoKHBhcmFtZXRlcnMuc2l6ZSgp ICogMikgKyAxKSAqIHNpemVvZihjaGFyICopKTsKIAogICAgIFhTTFRQcm9jZXNzb3JJbXBsOjpQ YXJhbWV0ZXJNYXA6Oml0ZXJhdG9yIGVuZCA9IHBhcmFtZXRlcnMuZW5kKCk7CiAgICAgdW5zaWdu ZWQgaW5kZXggPSAwOwpAQCAtMTcyLDEwICsxNzMsMTAgQEAgc3RhdGljIHZvaWQgZnJlZVhzbHRQ YXJhbUFycmF5KGNvbnN0IGNoYQogICAgICAgICByZXR1cm47CiAgICAgCiAgICAgd2hpbGUgKCp0 ZW1wKSB7Ci0gICAgICAgIGZyZWUoKHZvaWQgKikqKHRlbXArKykpOworICAgICAgICBmcmVlKCh2 b2lkICopKih0ZW1wKyspKTsgLy8gc3RyZHVwIHJldHVybnMgbWFsbG9jJ2QgYmxvY2tzLCBzbyB3 ZSBoYXZlIHRvIHVzZSBmcmVlKCkgaGVyZQogICAgICAgICBmcmVlKCh2b2lkICopKih0ZW1wKysp KTsKICAgICB9Ci0gICAgZnJlZShwYXJhbXMpOworICAgIGZhc3RGcmVlKHBhcmFtcyk7CiB9CiAK IApAQCAtMjI2LDE2ICsyMjcsMTYgQEAgUmVmUHRyPERvY3VtZW50SW1wbD4gWFNMVFByb2Nlc3Nv ckltcGw6OgogICAgIHJldHVybiByZXN1bHQ7CiB9CiAKLXN0YXRpYyBpbmxpbmUgUmVmUHRyPERv Y3VtZW50RnJhZ21lbnRJbXBsPiBjcmVhdGVGcmFnbWVudEZyb21Tb3VyY2UoUVN0cmluZyBzb3Vy Y2VTdHJpbmcsIFFTdHJpbmcgc291cmNlTUlNRVR5cGUsIE5vZGVJbXBsICpzb3VyY2VOb2RlLCBE b2N1bWVudEltcGwgKm91cHV0RG9jKQorc3RhdGljIGlubGluZSBSZWZQdHI8RG9jdW1lbnRGcmFn bWVudEltcGw+IGNyZWF0ZUZyYWdtZW50RnJvbVNvdXJjZShRU3RyaW5nIHNvdXJjZVN0cmluZywg UVN0cmluZyBzb3VyY2VNSU1FVHlwZSwgTm9kZUltcGwgKnNvdXJjZU5vZGUsIERvY3VtZW50SW1w bCAqb3V0cHV0RG9jKQogewotICAgIFJlZlB0cjxEb2N1bWVudEZyYWdtZW50SW1wbD4gZnJhZ21l bnQgPSBuZXcgRG9jdW1lbnRGcmFnbWVudEltcGwob3VwdXREb2MpOworICAgIFJlZlB0cjxEb2N1 bWVudEZyYWdtZW50SW1wbD4gZnJhZ21lbnQgPSBuZXcgRG9jdW1lbnRGcmFnbWVudEltcGwob3V0 cHV0RG9jKTsKICAgICAKICAgICBpZiAoc291cmNlTUlNRVR5cGUgPT0gInRleHQvaHRtbCIpCiAg ICAgICAgIHBhcnNlSFRNTERvY3VtZW50RnJhZ21lbnQoc291cmNlU3RyaW5nLCBmcmFnbWVudC5n ZXQoKSk7CisgICAgZWxzZSBpZiAoc291cmNlTUlNRVR5cGUgPT0gInRleHQvcGxhaW4iKQorICAg ICAgICBmcmFnbWVudC0+YWRkQ2hpbGQobmV3IFRleHRJbXBsKG91dHB1dERvYywgc291cmNlU3Ry aW5nKSk7CiAgICAgZWxzZSB7Ci0gICAgICAgIGlmIChzb3VyY2VNSU1FVHlwZSA9PSAidGV4dC9w bGFpbiIpCi0gICAgICAgICAgICB0cmFuc2Zvcm1UZXh0U3RyaW5nVG9YSFRNTERvY3VtZW50U3Ry aW5nKHNvdXJjZVN0cmluZyk7Ci0gICAgICAgIGJvb2wgc3VjY2Vzc2Z1bFBhcnNlID0gcGFyc2VY TUxEb2N1bWVudEZyYWdtZW50KHNvdXJjZVN0cmluZywgZnJhZ21lbnQuZ2V0KCksIG91cHV0RG9j LT5kb2N1bWVudEVsZW1lbnQoKSk7CisgICAgICAgIGJvb2wgc3VjY2Vzc2Z1bFBhcnNlID0gcGFy c2VYTUxEb2N1bWVudEZyYWdtZW50KHNvdXJjZVN0cmluZywgZnJhZ21lbnQuZ2V0KCksIG91dHB1 dERvYy0+ZG9jdW1lbnRFbGVtZW50KCkpOwogICAgICAgICBpZiAoIXN1Y2Nlc3NmdWxQYXJzZSkK ICAgICAgICAgICAgIHJldHVybiAwOwogICAgIH0K