61790 2011-05-31 09:23:44 -0700 [Chromium] Build fails when ACCELERATED_2D_CANVAS is disabled 2022-02-27 23:35:38 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 junov junov senorblanco vangelis oldest_to_newest 412699 0 junov 2011-05-31 09:23:44 -0700 Builds currently fails with unresolved symbols if accelerated 2d canvas is disabled It looks like the ACCELERATED_COMPOSITING feature depends on symbols that are guarded by #if ENABLE(ACCELERATED_2D_CANVAS) This needs to be correct so that Chromium mac builds can be performed without the accelerated 2d canvas feature 412710 1 95443 junov 2011-05-31 09:38:20 -0700 Created attachment 95443 Patch 412727 2 95443 senorblanco 2011-05-31 10:12:48 -0700 Comment on attachment 95443 Patch Hmm. This doesn't look right to me. The ACCELERATED_2D_CANVAS guard should be correct. Could we figure out who is using these classes that is not protected by ACCELERATED_2D_CANVAS guard? 412731 3 senorblanco 2011-05-31 10:19:29 -0700 (In reply to comment #2) > (From update of attachment 95443 [details]) > Hmm. This doesn't look right to me. The ACCELERATED_2D_CANVAS guard should be correct. Could we figure out who is using these classes that is not protected by ACCELERATED_2D_CANVAS guard? Just to answer my own question: it looks like the compositor is using TilingData (in LayerTilerChromium), so that change is correct. Justin is going to change it to (USE(ACCELERATED_COMPOSITING) || ENABLE(ACCELERATED_2D_CANVAS)) just to be on the safe side (in case someone tries to compile accel 2D canvas without the compositor). The LoopBlinnMathUtils one is a little more perplexing; Jeff and Justin are still looking into it. 412741 4 95451 junov 2011-05-31 10:40:34 -0700 Created attachment 95451 Patch 412746 5 95451 senorblanco 2011-05-31 10:55:21 -0700 Comment on attachment 95451 Patch Looks good. r=me 412747 6 vangelis 2011-05-31 10:58:21 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 95443 [details] [details]) > > Hmm. This doesn't look right to me. The ACCELERATED_2D_CANVAS guard should be correct. Could we figure out who is using these classes that is not protected by ACCELERATED_2D_CANVAS guard? > > Just to answer my own question: it looks like the compositor is using TilingData (in LayerTilerChromium), so that change is correct. Justin is going to change it to (USE(ACCELERATED_COMPOSITING) || ENABLE(ACCELERATED_2D_CANVAS)) just to be on the safe side (in case someone tries to compile accel 2D canvas without the compositor). > > The LoopBlinnMathUtils one is a little more perplexing; Jeff and Justin are still looking into it. The compositor (CCLayerSorter.cpp specifically) is using LoopBlinnMathUtils 412757 7 95451 senorblanco 2011-05-31 11:18:35 -0700 Comment on attachment 95451 Patch We'll be back after these messages. 412783 8 95451 senorblanco 2011-05-31 12:24:58 -0700 Comment on attachment 95451 Patch ... and we're back! 412816 9 senorblanco 2011-05-31 13:22:06 -0700 Committed r87748: <http://trac.webkit.org/changeset/87748> 95443 2011-05-31 09:38:20 -0700 2011-05-31 10:40:28 -0700 Patch bug-61790-20110531123819.patch text/plain 1597 junov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3NzM2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMzEgIEp1c3RpbiBO b3Zvc2FkICA8anVub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gQnVpbGQgZmFpbHMgd2hlbiBBQ0NFTEVS QVRFRF8yRF9DQU5WQVMgaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYxNzkwCisgICAgICAgIENoYW5naW5nIHRoZSBidWlsZCBndWFy ZHMgaW4gdGhlc2UgdHdvIGZpbGVzIHRoYXQgYXJlIHJlcXVpcmVkCisgICAgICAgIGJ5IHRoZSBh Y2NlbGVyYXRlZCBjb21wb3NpdGluZyBmZWF0dXJlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZ3B1L0xvb3BCbGlubk1hdGhVdGlscy5jcHA6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZ3B1L1RpbGluZ0RhdGEuY3BwOgorCiAyMDExLTA1LTMxICBBbmRyZWFzIEtsaW5nICA8 a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9Mb29wQmxpbm5NYXRo VXRpbHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dwdS9Mb29wQmxpbm5NYXRoVXRpbHMuY3BwCShyZXZpc2lvbiA4NzU0MSkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9Mb29wQmxpbm5NYXRoVXRpbHMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yNSw3ICsyNSw3IEBACiAKICNpbmNsdWRlICJjb25maWcuaCIKIAotI2lm IEVOQUJMRShBQ0NFTEVSQVRFRF8yRF9DQU5WQVMpCisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBP U0lUSU5HKQogCiAjaW5jbHVkZSAiTG9vcEJsaW5uTWF0aFV0aWxzLmgiCiAKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvVGlsaW5nRGF0YS5jcHAJ KHJldmlzaW9uIDg3NTQxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1 L1RpbGluZ0RhdGEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMCw3ICszMCw3IEBACiAKICNpbmNs dWRlICJjb25maWcuaCIKIAotI2lmIEVOQUJMRShBQ0NFTEVSQVRFRF8yRF9DQU5WQVMpCisjaWYg VVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HKQogCiAjaW5jbHVkZSAiVGlsaW5nRGF0YS5oIgog Cg== 95451 2011-05-31 10:40:34 -0700 2022-02-27 23:35:38 -0800 Patch bug-61790-20110531134033.patch text/plain 1663 junov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3NzM2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMzEgIEp1c3RpbiBO b3Zvc2FkICA8anVub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gQnVpbGQgZmFpbHMgd2hlbiBBQ0NFTEVS QVRFRF8yRF9DQU5WQVMgaXMgZGlzYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTYxNzkwCisgICAgICAgIENoYW5naW5nIHRoZSBidWlsZCBndWFy ZHMgaW4gdGhlc2UgdHdvIGZpbGVzIHRoYXQgYXJlIHJlcXVpcmVkCisgICAgICAgIGJ5IHRoZSBh Y2NlbGVyYXRlZCBjb21wb3NpdGluZyBmZWF0dXJlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZ3B1L0xvb3BCbGlubk1hdGhVdGlscy5jcHA6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvZ3B1L1RpbGluZ0RhdGEuY3BwOgorCiAyMDExLTA1LTMxICBBbmRyZWFzIEtsaW5nICA8 a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0by4K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9Mb29wQmxpbm5NYXRo VXRpbHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dwdS9Mb29wQmxpbm5NYXRoVXRpbHMuY3BwCShyZXZpc2lvbiA4NzU0MSkKKysrIFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9Mb29wQmxpbm5NYXRoVXRpbHMuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0yNSw3ICsyNSw3IEBACiAKICNpbmNsdWRlICJjb25maWcuaCIKIAotI2lm IEVOQUJMRShBQ0NFTEVSQVRFRF8yRF9DQU5WQVMpCisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBP U0lUSU5HKSB8fCBFTkFCTEUoQUNDRUxFUkFURURfMkRfQ0FOVkFTKQogCiAjaW5jbHVkZSAiTG9v cEJsaW5uTWF0aFV0aWxzLmgiCiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dwdS9UaWxpbmdEYXRhLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9ncHUvVGlsaW5nRGF0YS5jcHAJKHJldmlzaW9uIDg3NTQxKQorKysgU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1RpbGluZ0RhdGEuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0zMCw3ICszMCw3IEBACiAKICNpbmNsdWRlICJjb25maWcuaCIKIAotI2lmIEVO QUJMRShBQ0NFTEVSQVRFRF8yRF9DQU5WQVMpCisjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lU SU5HKSB8fCBFTkFCTEUoQUNDRUxFUkFURURfMkRfQ0FOVkFTKQogCiAjaW5jbHVkZSAiVGlsaW5n RGF0YS5oIgogCg==