61746 2011-05-30 14:13:11 -0700 [efl] Add ewk API to enable/disable developer extras. 2011-05-31 18:05:29 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rakuco webkit-unassigned abarth commit-queue gyuyoung.kim kenneth leandro lucas.de.marchi rakuco tkent tonikitoo oldest_to_newest 412349 0 rakuco 2011-05-30 14:13:11 -0700 [efl] Add ewk API to enable/disable developer extras. 412350 1 95370 rakuco 2011-05-30 14:14:53 -0700 Created attachment 95370 Patch 412353 2 95370 abarth 2011-05-30 14:18:24 -0700 Comment on attachment 95370 Patch ok 412355 3 95370 lucas.de.marchi 2011-05-30 14:23:30 -0700 Comment on attachment 95370 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95370&action=review Otherwise, looks good > Source/WebKit/efl/ewk/ewk_view.cpp:2716 > +Eina_Bool ewk_view_setting_enable_developer_extras_set(Evas_Object* o, Eina_Bool enable) > +{ > + EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE); > + EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE); > + if (priv->settings.enable_developer_extras != enable) { Since this is EAPI and Eina_Bool could assume values other than 1 and 0, a protection is needed for the enable argument. See ewk_view_setting_enable_scripts_set() as an example. 412358 4 lucas.de.marchi 2011-05-30 14:25:44 -0700 (In reply to comment #2) > (From update of attachment 95370 [details]) > ok I didn't see that you had given r+/cq+. Anyway, I think it's better to fix the small issue I pointed out before landing this. 412363 5 abarth 2011-05-30 14:29:22 -0700 > I didn't see that you had given r+/cq+. Anyway, I think it's better to fix the small issue I pointed out before landing this. Definitely! 412398 6 gyuyoung.kim 2011-05-30 16:46:14 -0700 If Lucas comment is added to this patch, looks good to me. 412721 7 95447 leandro 2011-05-31 09:56:41 -0700 Created attachment 95447 Fixed patch 412969 8 lucas.de.marchi 2011-05-31 16:22:22 -0700 (In reply to comment #7) > Created an attachment (id=95447) [details] > Fixed patch Adam, now it seems good. Could you rubber stamp it? 413042 9 95447 commit-queue 2011-05-31 18:05:23 -0700 Comment on attachment 95447 Fixed patch Clearing flags on attachment: 95447 Committed r87765: <http://trac.webkit.org/changeset/87765> 413043 10 commit-queue 2011-05-31 18:05:29 -0700 All reviewed patches have been landed. Closing bug. 95370 2011-05-30 14:14:53 -0700 2011-05-31 09:56:41 -0700 Patch bug-61746-20110530181807.patch text/plain 4701 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogODc2OTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBkYjFjYmI5YTY1 YzRhODBhMmZjMzRmYTJiNjJkNjRkOTRiMTA1ZDhjLi4zNDJiZDc3MDZjODNlMzlmZmM3NWNhNzVj MmUxYjEzYzkzYWY5YTJkIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEt MDUtMzAgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2VmbF0gQWRkIGV3 ayBBUEkgdG8gZW5hYmxlL2Rpc2FibGUgZGV2ZWxvcGVyIGV4dHJhcy4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxNzQ2CisKKyAgICAgICAgQWRkIGV3 a192aWV3X3NldHRpbmdfZW5hYmxlX2RldmVsb3Blcl9leHRyYXNfe2dldCxzZXR9LCB3aGljaCBp cyB1c2VkCisgICAgICAgIHRvIGVuYWJsZSBvciBkaXNhYmxlIGRldmVsb3BlciBleHRyYXMgKGN1 cnJlbnRseSwgdGhlIFdlYiBJbnNwZWN0b3IpCisgICAgICAgIGluIGEgZ2l2ZW4gdmlldy4KKwor ICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6CisgICAgICAgIChfZXdrX3ZpZXdfcHJpdl9uZXcp OgorICAgICAgICAoZXdrX3ZpZXdfc2V0dGluZ19lbmFibGVfZGV2ZWxvcGVyX2V4dHJhc19nZXQp OgorICAgICAgICAoZXdrX3ZpZXdfc2V0dGluZ19lbmFibGVfZGV2ZWxvcGVyX2V4dHJhc19zZXQp OgorICAgICAgICAqIGV3ay9ld2tfdmlldy5oOgorCiAyMDExLTA1LTI4ICBBZGFtIEJhcnRoICA8 YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5 YWtvdi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAgYi9T b3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IDA1YjM2YTNiZWI1MzI2NmI3 MjBmOGZiZjhhZWVmZGJhOTQ3MzdiYmEuLjc3MmE4MjM4Y2ZhZjZlMDAwNzhlOTk3ZDVmODZlZWQ3 YzgyZDdhZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAK KysrIGIvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAtMTEyLDYgKzExMiw3 IEBAIHN0cnVjdCBfRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhIHsKICAgICAgICAgRWluYV9Cb29sIGF1 dG9fbG9hZF9pbWFnZXM6MTsKICAgICAgICAgRWluYV9Cb29sIGF1dG9fc2hyaW5rX2ltYWdlczox OwogICAgICAgICBFaW5hX0Jvb2wgZW5hYmxlX2F1dG9fcmVzaXplX3dpbmRvdzoxOworICAgICAg ICBFaW5hX0Jvb2wgZW5hYmxlX2RldmVsb3Blcl9leHRyYXM6MTsKICAgICAgICAgRWluYV9Cb29s IGVuYWJsZV9zY3JpcHRzOjE7CiAgICAgICAgIEVpbmFfQm9vbCBlbmFibGVfcGx1Z2luczoxOwog ICAgICAgICBFaW5hX0Jvb2wgZW5hYmxlX2ZyYW1lX2ZsYXR0ZW5pbmc6MTsKQEAgLTYwNyw2ICs2 MDgsNyBAQCBzdGF0aWMgRXdrX1ZpZXdfUHJpdmF0ZV9EYXRhKiBfZXdrX3ZpZXdfcHJpdl9uZXco RXdrX1ZpZXdfU21hcnRfRGF0YSogc2QpCiAgICAgcHJpdi0+c2V0dGluZ3MuYXV0b19sb2FkX2lt YWdlcyA9IHByaXYtPnBhZ2Vfc2V0dGluZ3MtPmxvYWRzSW1hZ2VzQXV0b21hdGljYWxseSgpOwog ICAgIHByaXYtPnNldHRpbmdzLmF1dG9fc2hyaW5rX2ltYWdlcyA9IHByaXYtPnBhZ2Vfc2V0dGlu Z3MtPnNocmlua3NTdGFuZGFsb25lSW1hZ2VzVG9GaXQoKTsKICAgICBwcml2LT5zZXR0aW5ncy5l bmFibGVfYXV0b19yZXNpemVfd2luZG93ID0gRUlOQV9UUlVFOworICAgIHByaXYtPnNldHRpbmdz LmVuYWJsZV9kZXZlbG9wZXJfZXh0cmFzID0gcHJpdi0+cGFnZV9zZXR0aW5ncy0+ZGV2ZWxvcGVy RXh0cmFzRW5hYmxlZCgpOwogICAgIHByaXYtPnNldHRpbmdzLmVuYWJsZV9zY3JpcHRzID0gcHJp di0+cGFnZV9zZXR0aW5ncy0+aXNKYXZhU2NyaXB0RW5hYmxlZCgpOwogICAgIHByaXYtPnNldHRp bmdzLmVuYWJsZV9wbHVnaW5zID0gcHJpdi0+cGFnZV9zZXR0aW5ncy0+YXJlUGx1Z2luc0VuYWJs ZWQoKTsKICAgICBwcml2LT5zZXR0aW5ncy5lbmFibGVfZnJhbWVfZmxhdHRlbmluZyA9IHByaXYt PnBhZ2Vfc2V0dGluZ3MtPmZyYW1lRmxhdHRlbmluZ0VuYWJsZWQoKTsKQEAgLTI2NzgsNiArMjY4 MCw0NiBAQCBFaW5hX0Jvb2wgZXdrX3ZpZXdfc2V0dGluZ19lbmNvZGluZ19kZXRlY3Rvcl9nZXQo RXZhc19PYmplY3QqIG8pCiAgICAgcmV0dXJuIHByaXYtPnNldHRpbmdzLmVuY29kaW5nX2RldGVj dG9yOwogfQogCisvKioKKyAqIFJldHVybnMgd2hldGhlciBkZXZlbG9wZXIgZXh0ZW5zaW9ucyBh cmUgZW5hYmxlZCBmb3IgdGhlIGdpdmVuIHZpZXcuCisgKgorICogQ3VycmVudGx5LCB0aGlzIGlz IHVzZWQgdG8ga25vdyB3aGV0aGVyIHRoZSBXZWIgSW5zcGVjdG9yIGlzIGVuYWJsZWQgZm9yIGEK KyAqIGdpdmVuIHZpZXcuCisgKgorICogQHBhcmFtIG8gdmlldyBvYmplY3QgdG8gY2hlY2suCisg KgorICogQHJldHVybiBAYyBFSU5BX1RSVUUgaWYgZGV2ZWxvcGVyIGV4dGVuc2lvbnMgYXJlIGVu YWJsZWQsIEBjIEVJTkFfRkFMU0UKKyAqICAgICAgICAgb3RoZXJ3aXNlLgorICovCitFaW5hX0Jv b2wgZXdrX3ZpZXdfc2V0dGluZ19lbmFibGVfZGV2ZWxvcGVyX2V4dHJhc19nZXQoRXZhc19PYmpl Y3QqIG8pCit7CisgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihvLCBzZCwgRUlOQV9GQUxT RSk7CisgICAgRVdLX1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNkLCBwcml2LCBFSU5BX0ZBTFNF KTsKKyAgICByZXR1cm4gcHJpdi0+c2V0dGluZ3MuZW5hYmxlX2RldmVsb3Blcl9leHRyYXM7Cit9 CisKKy8qKgorICogRW5hYmxlcy9kaXNhYmxlcyBkZXZlbG9wZXIgZXh0ZW5zaW9ucyBmb3IgdGhl IGdpdmVuIHZpZXcuCisgKgorICogVGhpcyBjdXJyZW50bHkgY29udHJvbHMgd2hldGhlciB0aGUg V2ViIEluc3BlY3RvciBzaG91bGQgYmUgZW5hYmxlZC4KKyAqCisgKiBAcGFyYW0gbyBUaGUgdmll dyB3aG9zZSBzZXR0aW5nIHdpbGwgYmUgY2hhbmdlZC4KKyAqIEBwYXJhbSBlbmFibGUgQGMgRUlO QV9UUlVFIHRvIGVuYWJsZSBkZXZlbG9wZXIgZXh0cmFzLCBAYyBFSU5BX0ZBTFNFIHRvCisgKiAg ICAgICAgICAgICAgIGRpc2FibGUuCisgKgorICogQHJldHVybiBAYyBFSU5BX1RSVUUgb24gc3Vj Y2VzcywgQEVJTkFfRkFMU0Ugb24gZmFpbHVyZS4KKyAqLworRWluYV9Cb29sIGV3a192aWV3X3Nl dHRpbmdfZW5hYmxlX2RldmVsb3Blcl9leHRyYXNfc2V0KEV2YXNfT2JqZWN0KiBvLCBFaW5hX0Jv b2wgZW5hYmxlKQoreworICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIEVJTkFf RkFMU0UpOworICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzZCwgcHJpdiwgRUlOQV9G QUxTRSk7CisgICAgaWYgKHByaXYtPnNldHRpbmdzLmVuYWJsZV9kZXZlbG9wZXJfZXh0cmFzICE9 IGVuYWJsZSkgeworICAgICAgICBwcml2LT5wYWdlX3NldHRpbmdzLT5zZXREZXZlbG9wZXJFeHRy YXNFbmFibGVkKGVuYWJsZSk7CisgICAgICAgIHByaXYtPnNldHRpbmdzLmVuYWJsZV9kZXZlbG9w ZXJfZXh0cmFzID0gZW5hYmxlOworICAgIH0KKyAgICByZXR1cm4gRUlOQV9UUlVFOworfQorCiBp bnQgZXdrX3ZpZXdfc2V0dGluZ19mb250X21pbmltdW1fc2l6ZV9nZXQoY29uc3QgRXZhc19PYmpl Y3QqIG8pCiB7CiAgICAgRVdLX1ZJRVdfU0RfR0VUX09SX1JFVFVSTihvLCBzZCwgMCk7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaCBiL1NvdXJjZS9XZWJLaXQv ZWZsL2V3ay9ld2tfdmlldy5oCmluZGV4IDc4YmNkNjQ5NzFiNjQ4NjY5YjJjYjA4NjI4MmFlNzY1 YjAxMzJkNTcuLjAzNjBmZWU3ZmZmOTkwOGY3MDkyN2I1NTAzOTkzMzhmZTRlOGIxODYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5oCisrKyBiL1NvdXJjZS9XZWJL aXQvZWZsL2V3ay9ld2tfdmlldy5oCkBAIC01MDAsNiArNTAwLDkgQEAgRUFQSSBFaW5hX0Jvb2wg ICAgZXdrX3ZpZXdfc2V0dGluZ19wYWdlX2NhY2hlX3NldChFdmFzX09iamVjdCogbywgRWluYV9C b29sIGVuYWIKIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3NldHRpbmdfZW5jb2RpbmdfZGV0 ZWN0b3JfZ2V0KEV2YXNfT2JqZWN0KiBvKTsKIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3Nl dHRpbmdfZW5jb2RpbmdfZGV0ZWN0b3Jfc2V0KEV2YXNfT2JqZWN0KiBvLCBFaW5hX0Jvb2wgZW5h YmxlKTsKIAorRUFQSSBFaW5hX0Jvb2wgICAgZXdrX3ZpZXdfc2V0dGluZ19lbmFibGVfZGV2ZWxv cGVyX2V4dHJhc19nZXQoRXZhc19PYmplY3QqIG8pOworRUFQSSBFaW5hX0Jvb2wgICAgZXdrX3Zp ZXdfc2V0dGluZ19lbmFibGVfZGV2ZWxvcGVyX2V4dHJhc19zZXQoRXZhc19PYmplY3QqIG8sIEVp bmFfQm9vbCBlbmFibGUpOworCiAvKiB0byBiZSB1c2VkIGJ5IHN1YmNsYXNzIGltcGxlbWVudGF0 aW9ucyAqLwogRUFQSSBFd2tfVmlld19TbWFydF9EYXRhICpld2tfdmlld19zbWFydF9kYXRhX2dl dChjb25zdCBFdmFzX09iamVjdCAqbyk7CiAK 95447 2011-05-31 09:56:41 -0700 2011-05-31 18:05:23 -0700 Fixed patch enable-dev-extras.patch text/plain 4726 leandro U3VidmVyc2lvbiBSZXZpc2lvbjogODc2OTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBkYjFjYmI5YTY1 YzRhODBhMmZjMzRmYTJiNjJkNjRkOTRiMTA1ZDhjLi4zNDJiZDc3MDZjODNlMzlmZmM3NWNhNzVj MmUxYjEzYzkzYWY5YTJkIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEt MDUtMzAgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KKworICAgICAgICBbZWZsXSBBZGQgZXdrIEFQ SSB0byBlbmFibGUvZGlzYWJsZSBkZXZlbG9wZXIgZXh0cmFzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE3NDYKKworICAgICAgICBBZGQgZXdrX3Zp ZXdfc2V0dGluZ19lbmFibGVfZGV2ZWxvcGVyX2V4dHJhc197Z2V0LHNldH0sIHdoaWNoIGlzIHVz ZWQKKyAgICAgICAgdG8gZW5hYmxlIG9yIGRpc2FibGUgZGV2ZWxvcGVyIGV4dHJhcyAoY3VycmVu dGx5LCB0aGUgV2ViIEluc3BlY3RvcikKKyAgICAgICAgaW4gYSBnaXZlbiB2aWV3LgorCisgICAg ICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAgKF9ld2tfdmlld19wcml2X25ldyk6Cisg ICAgICAgIChld2tfdmlld19zZXR0aW5nX2VuYWJsZV9kZXZlbG9wZXJfZXh0cmFzX2dldCk6Cisg ICAgICAgIChld2tfdmlld19zZXR0aW5nX2VuYWJsZV9kZXZlbG9wZXJfZXh0cmFzX3NldCk6Cisg ICAgICAgICogZXdrL2V3a192aWV3Lmg6CisKIDIwMTEtMDUtMzAgIFJhcGhhZWwgS3VibyBkYSBD b3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBU YW11cmEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIv U291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCAwNWIzNmEzYmViNTMyNjZi NzIwZjhmYmY4YWVlZmRiYTk0NzM3YmJhLi43NzJhODIzOGNmYWY2ZTAwMDc4ZTk5N2Q1Zjg2ZWVk N2M4MmQ3YWRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTExMiw2ICsxMTIs NyBAQCBzdHJ1Y3QgX0V3a19WaWV3X1ByaXZhdGVfRGF0YSB7CiAgICAgICAgIEVpbmFfQm9vbCBh dXRvX2xvYWRfaW1hZ2VzOjE7CiAgICAgICAgIEVpbmFfQm9vbCBhdXRvX3Nocmlua19pbWFnZXM6 MTsKICAgICAgICAgRWluYV9Cb29sIGVuYWJsZV9hdXRvX3Jlc2l6ZV93aW5kb3c6MTsKKyAgICAg ICAgRWluYV9Cb29sIGVuYWJsZV9kZXZlbG9wZXJfZXh0cmFzOjE7CiAgICAgICAgIEVpbmFfQm9v bCBlbmFibGVfc2NyaXB0czoxOwogICAgICAgICBFaW5hX0Jvb2wgZW5hYmxlX3BsdWdpbnM6MTsK ICAgICAgICAgRWluYV9Cb29sIGVuYWJsZV9mcmFtZV9mbGF0dGVuaW5nOjE7CkBAIC02MDcsNiAr NjA4LDcgQEAgc3RhdGljIEV3a19WaWV3X1ByaXZhdGVfRGF0YSogX2V3a192aWV3X3ByaXZfbmV3 KEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNkKQogICAgIHByaXYtPnNldHRpbmdzLmF1dG9fbG9hZF9p bWFnZXMgPSBwcml2LT5wYWdlX3NldHRpbmdzLT5sb2Fkc0ltYWdlc0F1dG9tYXRpY2FsbHkoKTsK ICAgICBwcml2LT5zZXR0aW5ncy5hdXRvX3Nocmlua19pbWFnZXMgPSBwcml2LT5wYWdlX3NldHRp bmdzLT5zaHJpbmtzU3RhbmRhbG9uZUltYWdlc1RvRml0KCk7CiAgICAgcHJpdi0+c2V0dGluZ3Mu ZW5hYmxlX2F1dG9fcmVzaXplX3dpbmRvdyA9IEVJTkFfVFJVRTsKKyAgICBwcml2LT5zZXR0aW5n cy5lbmFibGVfZGV2ZWxvcGVyX2V4dHJhcyA9IHByaXYtPnBhZ2Vfc2V0dGluZ3MtPmRldmVsb3Bl ckV4dHJhc0VuYWJsZWQoKTsKICAgICBwcml2LT5zZXR0aW5ncy5lbmFibGVfc2NyaXB0cyA9IHBy aXYtPnBhZ2Vfc2V0dGluZ3MtPmlzSmF2YVNjcmlwdEVuYWJsZWQoKTsKICAgICBwcml2LT5zZXR0 aW5ncy5lbmFibGVfcGx1Z2lucyA9IHByaXYtPnBhZ2Vfc2V0dGluZ3MtPmFyZVBsdWdpbnNFbmFi bGVkKCk7CiAgICAgcHJpdi0+c2V0dGluZ3MuZW5hYmxlX2ZyYW1lX2ZsYXR0ZW5pbmcgPSBwcml2 LT5wYWdlX3NldHRpbmdzLT5mcmFtZUZsYXR0ZW5pbmdFbmFibGVkKCk7CkBAIC0yNjc4LDYgKzI2 ODAsNDcgQEAgRWluYV9Cb29sIGV3a192aWV3X3NldHRpbmdfZW5jb2RpbmdfZGV0ZWN0b3JfZ2V0 KEV2YXNfT2JqZWN0KiBvKQogICAgIHJldHVybiBwcml2LT5zZXR0aW5ncy5lbmNvZGluZ19kZXRl Y3RvcjsKIH0KIAorLyoqCisgKiBSZXR1cm5zIHdoZXRoZXIgZGV2ZWxvcGVyIGV4dGVuc2lvbnMg YXJlIGVuYWJsZWQgZm9yIHRoZSBnaXZlbiB2aWV3LgorICoKKyAqIEN1cnJlbnRseSwgdGhpcyBp cyB1c2VkIHRvIGtub3cgd2hldGhlciB0aGUgV2ViIEluc3BlY3RvciBpcyBlbmFibGVkIGZvciBh CisgKiBnaXZlbiB2aWV3LgorICoKKyAqIEBwYXJhbSBvIHZpZXcgb2JqZWN0IHRvIGNoZWNrLgor ICoKKyAqIEByZXR1cm4gQGMgRUlOQV9UUlVFIGlmIGRldmVsb3BlciBleHRlbnNpb25zIGFyZSBl bmFibGVkLCBAYyBFSU5BX0ZBTFNFCisgKiAgICAgICAgIG90aGVyd2lzZS4KKyAqLworRWluYV9C b29sIGV3a192aWV3X3NldHRpbmdfZW5hYmxlX2RldmVsb3Blcl9leHRyYXNfZ2V0KEV2YXNfT2Jq ZWN0KiBvKQoreworICAgIEVXS19WSUVXX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIEVJTkFfRkFM U0UpOworICAgIEVXS19WSUVXX1BSSVZfR0VUX09SX1JFVFVSTihzZCwgcHJpdiwgRUlOQV9GQUxT RSk7CisgICAgcmV0dXJuIHByaXYtPnNldHRpbmdzLmVuYWJsZV9kZXZlbG9wZXJfZXh0cmFzOwor fQorCisvKioKKyAqIEVuYWJsZXMvZGlzYWJsZXMgZGV2ZWxvcGVyIGV4dGVuc2lvbnMgZm9yIHRo ZSBnaXZlbiB2aWV3LgorICoKKyAqIFRoaXMgY3VycmVudGx5IGNvbnRyb2xzIHdoZXRoZXIgdGhl IFdlYiBJbnNwZWN0b3Igc2hvdWxkIGJlIGVuYWJsZWQuCisgKgorICogQHBhcmFtIG8gVGhlIHZp ZXcgd2hvc2Ugc2V0dGluZyB3aWxsIGJlIGNoYW5nZWQuCisgKiBAcGFyYW0gZW5hYmxlIEBjIEVJ TkFfVFJVRSB0byBlbmFibGUgZGV2ZWxvcGVyIGV4dHJhcywgQGMgRUlOQV9GQUxTRSB0bworICog ICAgICAgICAgICAgICBkaXNhYmxlLgorICoKKyAqIEByZXR1cm4gQGMgRUlOQV9UUlVFIG9uIHN1 Y2Nlc3MsIEBFSU5BX0ZBTFNFIG9uIGZhaWx1cmUuCisgKi8KK0VpbmFfQm9vbCBld2tfdmlld19z ZXR0aW5nX2VuYWJsZV9kZXZlbG9wZXJfZXh0cmFzX3NldChFdmFzX09iamVjdCogbywgRWluYV9C b29sIGVuYWJsZSkKK3sKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNkLCBFSU5B X0ZBTFNFKTsKKyAgICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHByaXYsIEVJTkFf RkFMU0UpOworICAgIGVuYWJsZSA9ICEhZW5hYmxlOworICAgIGlmIChwcml2LT5zZXR0aW5ncy5l bmFibGVfZGV2ZWxvcGVyX2V4dHJhcyAhPSBlbmFibGUpIHsKKyAgICAgICAgcHJpdi0+cGFnZV9z ZXR0aW5ncy0+c2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZChlbmFibGUpOworICAgICAgICBwcml2 LT5zZXR0aW5ncy5lbmFibGVfZGV2ZWxvcGVyX2V4dHJhcyA9IGVuYWJsZTsKKyAgICB9CisgICAg cmV0dXJuIEVJTkFfVFJVRTsKK30KKwogaW50IGV3a192aWV3X3NldHRpbmdfZm9udF9taW5pbXVt X3NpemVfZ2V0KGNvbnN0IEV2YXNfT2JqZWN0KiBvKQogewogICAgIEVXS19WSUVXX1NEX0dFVF9P Ul9SRVRVUk4obywgc2QsIDApOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmggYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaAppbmRleCA3OGJjZDY0 OTcxYjY0ODY2OWIyY2IwODYyODJhZTc2NWIwMTMyZDU3Li4wMzYwZmVlN2ZmZjk5MDhmNzA5Mjdi NTUwMzk5MzM4ZmU0ZThiMTg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdr X3ZpZXcuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaApAQCAtNTAwLDYg KzUwMCw5IEBAIEVBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3NldHRpbmdfcGFnZV9jYWNoZV9z ZXQoRXZhc19PYmplY3QqIG8sIEVpbmFfQm9vbCBlbmFiCiBFQVBJIEVpbmFfQm9vbCAgICBld2tf dmlld19zZXR0aW5nX2VuY29kaW5nX2RldGVjdG9yX2dldChFdmFzX09iamVjdCogbyk7CiBFQVBJ IEVpbmFfQm9vbCAgICBld2tfdmlld19zZXR0aW5nX2VuY29kaW5nX2RldGVjdG9yX3NldChFdmFz X09iamVjdCogbywgRWluYV9Cb29sIGVuYWJsZSk7CiAKK0VBUEkgRWluYV9Cb29sICAgIGV3a192 aWV3X3NldHRpbmdfZW5hYmxlX2RldmVsb3Blcl9leHRyYXNfZ2V0KEV2YXNfT2JqZWN0KiBvKTsK K0VBUEkgRWluYV9Cb29sICAgIGV3a192aWV3X3NldHRpbmdfZW5hYmxlX2RldmVsb3Blcl9leHRy YXNfc2V0KEV2YXNfT2JqZWN0KiBvLCBFaW5hX0Jvb2wgZW5hYmxlKTsKKwogLyogdG8gYmUgdXNl ZCBieSBzdWJjbGFzcyBpbXBsZW1lbnRhdGlvbnMgKi8KIEVBUEkgRXdrX1ZpZXdfU21hcnRfRGF0 YSAqZXdrX3ZpZXdfc21hcnRfZGF0YV9nZXQoY29uc3QgRXZhc19PYmplY3QgKm8pOwogCg==