61745 2011-05-30 14:02:32 -0700 [efl] Disable tiled backing store debug messages by default. 2011-06-13 14:45:04 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rakuco webkit-unassigned leandro lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 412347 0 rakuco 2011-05-30 14:02:32 -0700 [efl] Disable tiled backing store debug messages by default. 412348 1 95369 rakuco 2011-05-30 14:05:29 -0700 Created attachment 95369 Patch 412351 2 95369 lucas.de.marchi 2011-05-30 14:17:58 -0700 Comment on attachment 95369 Patch LGTM 412498 3 95369 kenneth 2011-05-31 01:25:54 -0700 Comment on attachment 95369 Patch Please define it as 0 instead, and dont leave out commented code around 412711 4 95444 leandro 2011-05-31 09:40:31 -0700 Created attachment 95444 #undef DEBUG_MEM_LEAKS New patch attached. Uses #undef instead of leaving commented-out code. 419708 5 rakuco 2011-06-13 11:15:35 -0700 Kenneth, are you still there? :) 419889 6 95444 webkit.review.bot 2011-06-13 14:44:59 -0700 Comment on attachment 95444 #undef DEBUG_MEM_LEAKS Clearing flags on attachment: 95444 Committed r88700: <http://trac.webkit.org/changeset/88700> 419890 7 webkit.review.bot 2011-06-13 14:45:04 -0700 All reviewed patches have been landed. Closing bug. 95369 2011-05-30 14:05:29 -0700 2011-05-31 09:40:31 -0700 Patch bug-61745-20110530180843.patch text/plain 1380 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogODc2OTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBkYjFjYmI5YTY1 YzRhODBhMmZjMzRmYTJiNjJkNjRkOTRiMTA1ZDhjLi5iMjRlMzUxNjMxYjUwOGJmMWI5OGZjM2Ux MjM5YTkxNTczMWUzNTgxIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MDUtMzAgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2VmbF0gRGlzYWJs ZSB0aWxlZCBiYWNraW5nIHN0b3JlIGRlYnVnIG1lc3NhZ2VzIGJ5IGRlZmF1bHQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTc0NQorCisgICAgICAg IFRoZXNlIG1lc3NhZ2VzIHBvbGx1dGUgdGhlIG91dHB1dCBhbmQgYXJlIG9ubHkgdXNlZnVsIHRv IHBlb3BsZQorICAgICAgICB3b3JraW5nIG9uIFRCUyBpdHNlbGYuIEl0IG1ha2VzIG1vcmUgc2Vu c2UgdG8gaGF2ZSB0aGVtIGRpc2FibGVkIGJ5CisgICAgICAgIGRlZmF1bHQuCisKKyAgICAgICAg KiBld2svZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUuaDoKKwogMjAxMS0wNS0yOCAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9z a3VyeWFrb3YuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX2Jh Y2tpbmdfc3RvcmUuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfYmFja2luZ19z dG9yZS5oCmluZGV4IDRhZjU4YzgzNmUxNzRjNzgxZGE1MzllMWRjMGYxZDhhZTVkYTE3ZDMuLjBi OGFiYzAzZjQ5OWMyMGE4MGZhNWY4ZmM2M2FhZjg4ZmY5OTNkYWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfYmFja2luZ19zdG9yZS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfYmFja2luZ19zdG9yZS5oCkBAIC0zMSw3ICszMSw3IEBA CiAgKiB0cnkgImtpbGwgLVVTUjEgJFBJRCIgdG8gZ2V0IGluc3RhbnRhbmVvdXMgZGVidWcKICAq IHRyeSAia2lsbCAtVVNSMiAkUElEIiB0byBnZXQgaW5zdGFudGFuZW91cyBkZWJ1ZyBhbmQgZm9y Y2UgZmx1c2ggb2YgY2FjaGUKICAqLwotI2RlZmluZSBERUJVR19NRU1fTEVBS1MgMQorLy8gI2Rl ZmluZSBERUJVR19NRU1fTEVBS1MgMQogCiAjZGVmaW5lIFRJTEVfVyAoMjU2KQogI2RlZmluZSBU SUxFX0ggKDI1NikK 95444 2011-05-31 09:40:31 -0700 2011-06-13 14:44:59 -0700 #undef DEBUG_MEM_LEAKS no-debug-memleaks-undef.patch text/plain 1374 leandro U3VidmVyc2lvbiBSZXZpc2lvbjogODc2OTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBkYjFjYmI5YTY1 YzRhODBhMmZjMzRmYTJiNjJkNjRkOTRiMTA1ZDhjLi5iMjRlMzUxNjMxYjUwOGJmMWI5OGZjM2Ux MjM5YTkxNTczMWUzNTgxIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MDUtMzAgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2VmbF0gRGlzYWJs ZSB0aWxlZCBiYWNraW5nIHN0b3JlIGRlYnVnIG1lc3NhZ2VzIGJ5IGRlZmF1bHQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTc0NQorCisgICAgICAg IFRoZXNlIG1lc3NhZ2VzIHBvbGx1dGUgdGhlIG91dHB1dCBhbmQgYXJlIG9ubHkgdXNlZnVsIHRv IHBlb3BsZQorICAgICAgICB3b3JraW5nIG9uIFRCUyBpdHNlbGYuIEl0IG1ha2VzIG1vcmUgc2Vu c2UgdG8gaGF2ZSB0aGVtIGRpc2FibGVkIGJ5CisgICAgICAgIGRlZmF1bHQuCisKKyAgICAgICAg KiBld2svZXdrX3RpbGVkX2JhY2tpbmdfc3RvcmUuaDoKKwogMjAxMS0wNS0yOCAgQWRhbSBCYXJ0 aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9z a3VyeWFrb3YuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3RpbGVkX2Jh Y2tpbmdfc3RvcmUuaCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfYmFja2luZ19z dG9yZS5oCmluZGV4IDRhZjU4YzgzNmUxNzRjNzgxZGE1MzllMWRjMGYxZDhhZTVkYTE3ZDMuLjBi OGFiYzAzZjQ5OWMyMGE4MGZhNWY4ZmM2M2FhZjg4ZmY5OTNkYWUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfYmFja2luZ19zdG9yZS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQvZWZsL2V3ay9ld2tfdGlsZWRfYmFja2luZ19zdG9yZS5oCkBAIC0zMSw3ICszMSw3IEBA CiAgKiB0cnkgImtpbGwgLVVTUjEgJFBJRCIgdG8gZ2V0IGluc3RhbnRhbmVvdXMgZGVidWcKICAq IHRyeSAia2lsbCAtVVNSMiAkUElEIiB0byBnZXQgaW5zdGFudGFuZW91cyBkZWJ1ZyBhbmQgZm9y Y2UgZmx1c2ggb2YgY2FjaGUKICAqLwotI2RlZmluZSBERUJVR19NRU1fTEVBS1MgMQorI3VuZGVm IERFQlVHX01FTV9MRUFLUwogCiAjZGVmaW5lIFRJTEVfVyAoMjU2KQogI2RlZmluZSBUSUxFX0gg KDI1NikK