61744 2011-05-30 13:43:23 -0700 [efl] Do not enable the encoding detector by default. 2012-10-09 05:24:01 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98726 0 rakuco webkit-unassigned gyuyoung.kim leandro lucas.de.marchi rakuco tonikitoo webkit.review.bot oldest_to_newest 412341 0 rakuco 2011-05-30 13:43:23 -0700 [efl] Do not enable the encoding detector by default. 412343 1 95368 rakuco 2011-05-30 13:53:06 -0700 Created attachment 95368 Patch 412361 2 95368 lucas.de.marchi 2011-05-30 14:27:27 -0700 Comment on attachment 95368 Patch Out of curiosity, what tests fail with this turned on? Aren't they missing the encoding setting if they rely on them? 412427 3 rakuco 2011-05-30 19:06:17 -0700 In this specific case, that's dom/xhtml/level3/core/documentgetinputencoding01.xhtml, which checks exactly for this. 413120 4 95368 bfulgham 2011-05-31 21:03:54 -0700 Comment on attachment 95368 Patch Looks good to me. When landing, please update the ChangeLog to include the helpful information that this code is exercised by the "dom/xhtml/level3/core/documentgetinputencoding01.xhtml" test. 414827 5 95904 rakuco 2011-06-03 06:06:35 -0700 Created attachment 95904 Same patch, more detailed ChangeLog Sorry for the delay; this is the new patch explicitly mentioning dom/xhtml/level3/core/documentgetinputencoding01.xhtml. 414829 6 webkit.review.bot 2011-06-03 06:08:27 -0700 Attachment 95904 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 414831 7 rakuco 2011-06-03 06:11:10 -0700 Huh? Is there a way to re-run the style bot? 414872 8 lucas.de.marchi 2011-06-03 07:30:36 -0700 (In reply to comment #7) > Huh? Is there a way to re-run the style bot? I think that you need to upload it again. 414917 9 95917 rakuco 2011-06-03 08:42:41 -0700 Created attachment 95917 Same patch, more detailed ChangeLog, take #2 414920 10 webkit.review.bot 2011-06-03 08:44:40 -0700 Attachment 95917 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 418405 11 gyuyoung.kim 2011-06-09 17:09:03 -0700 It seems there is no style errors. So, you need to update this patch again. 418475 12 lucas.de.marchi 2011-06-09 19:43:56 -0700 Committed r88515: <http://trac.webkit.org/changeset/88515> 423241 13 95917 eric 2011-06-18 13:40:35 -0700 Comment on attachment 95917 Same patch, more detailed ChangeLog, take #2 Cleared review? from attachment 95917 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 737686 14 95917 kenneth 2012-10-09 05:12:36 -0700 Comment on attachment 95917 Same patch, more detailed ChangeLog, take #2 View in context: https://bugs.webkit.org/attachment.cgi?id=95917&action=review > a/Source/WebKit/efl/ChangeLog:9 > + This should match the behaviour of other ports more closely, and makes > + at least dom/xhtml/level3/core/documentgetinputencoding01.xhtml pass. So if all browsers enable (or should enable) it anyway, what is the point? Isn't this a bug in the decoding detector instead? 95368 2011-05-30 13:53:06 -0700 2011-06-03 06:06:35 -0700 Patch bug-61744-20110530175618.patch text/plain 1557 rakuco U3VidmVyc2lvbiBSZXZpc2lvbjogODc2OTUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZs L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZwppbmRleCBkYjFjYmI5YTY1 YzRhODBhMmZjMzRmYTJiNjJkNjRkOTRiMTA1ZDhjLi4yMDg0ODNkMWYzMjdjMjM5Y2RhZTU5YWQ1 YzZiZTI5ZTZkZjBhOTJlIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEt MDUtMzAgIFJhcGhhZWwgS3VibyBkYSBDb3N0YSAgPGt1Ym9AcHJvZnVzaW9uLm1vYmk+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW2VmbF0gRG8gbm90 IGVuYWJsZSB0aGUgZW5jb2RpbmcgZGV0ZWN0b3IgYnkgZGVmYXVsdC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxNzQ0CisKKyAgICAgICAgVGhpcyBz aG91bGQgbWF0Y2ggdGhlIGJlaGF2aW91ciBvZiBvdGhlciBwb3J0cyBtb3JlIGNsb3NlbHksIGFu ZCBmaXhlcworICAgICAgICBhIGZldyBmYWlsaW5nIHRlc3RzLgorCisgICAgICAgICogZXdrL2V3 a192aWV3LmNwcDoKKyAgICAgICAgKF9ld2tfdmlld19wcml2X25ldyk6CisKIDIwMTEtMDUtMjgg IEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBB bGV4ZXkgUHJvc2t1cnlha292LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggMDVi MzZhM2JlYjUzMjY2YjcyMGY4ZmJmOGFlZWZkYmE5NDczN2JiYS4uMjMyZGU1MWZmMjQwMzNkMDYy NWIyZTdjYmJmMDBlZWQxMjY1NmZlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdr L2V3a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBA IC01NzQsNyArNTc0LDcgQEAgc3RhdGljIEV3a19WaWV3X1ByaXZhdGVfRGF0YSogX2V3a192aWV3 X3ByaXZfbmV3KEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNkKQogICAgIHByaXYtPnBhZ2Vfc2V0dGlu Z3MtPnNldExvY2FsU3RvcmFnZUVuYWJsZWQodHJ1ZSk7CiAgICAgcHJpdi0+cGFnZV9zZXR0aW5n cy0+c2V0T2ZmbGluZVdlYkFwcGxpY2F0aW9uQ2FjaGVFbmFibGVkKHRydWUpOwogICAgIHByaXYt PnBhZ2Vfc2V0dGluZ3MtPnNldFVzZXNQYWdlQ2FjaGUodHJ1ZSk7Ci0gICAgcHJpdi0+cGFnZV9z ZXR0aW5ncy0+c2V0VXNlc0VuY29kaW5nRGV0ZWN0b3IodHJ1ZSk7CisgICAgcHJpdi0+cGFnZV9z ZXR0aW5ncy0+c2V0VXNlc0VuY29kaW5nRGV0ZWN0b3IoZmFsc2UpOwogCiAgICAgdXJsID0gcHJp di0+cGFnZV9zZXR0aW5ncy0+dXNlclN0eWxlU2hlZXRMb2NhdGlvbigpOwogICAgIHByaXYtPnNl dHRpbmdzLnVzZXJfc3R5bGVzaGVldCA9IGVpbmFfc3RyaW5nc2hhcmVfYWRkKHVybC5zdHJpbmco KS51dGY4KCkuZGF0YSgpKTsK 95904 2011-06-03 06:06:35 -0700 2011-06-03 08:42:41 -0700 Same patch, more detailed ChangeLog bug-61744.diff text/plain 1236 rakuco LS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCQorKysgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cJCkBAIC0xLDMgKzEsMTYgQEAgCisyMDExLTA1LTMwICBSYXBoYWVsIEt1Ym8g ZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtlZmxdIERvIG5vdCBlbmFibGUgdGhlIGVuY29kaW5n IGRldGVjdG9yIGJ5IGRlZmF1bHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02MTc0NAorCisgICAgICAgIFRoaXMgc2hvdWxkIG1hdGNoIHRoZSBiZWhh dmlvdXIgb2Ygb3RoZXIgcG9ydHMgbW9yZSBjbG9zZWx5LCBhbmQgbWFrZXMKKyAgICAgICAgYXQg bGVhc3QgZG9tL3hodG1sL2xldmVsMy9jb3JlL2RvY3VtZW50Z2V0aW5wdXRlbmNvZGluZzAxLnho dG1sIHBhc3MuCisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192 aWV3X3ByaXZfbmV3KToKKwogMjAxMS0wNS0yOCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCi0tLSBhL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAJCisrKyBhL1NvdXJjZS9XZWJLaXQvZWZs L2V3ay9ld2tfdmlldy5jcHAJCkBAIC01NzQsNyArNTc0LDcgQEAgc3RhdGljIEV3a19WaWV3X1By aXZhdGVfRGF0YSogX2V3a192aWV3X3ByaXZfbmV3KEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNkKQog ICAgIHByaXYtPnBhZ2Vfc2V0dGluZ3MtPnNldExvY2FsU3RvcmFnZUVuYWJsZWQodHJ1ZSk7CiAg ICAgcHJpdi0+cGFnZV9zZXR0aW5ncy0+c2V0T2ZmbGluZVdlYkFwcGxpY2F0aW9uQ2FjaGVFbmFi bGVkKHRydWUpOwogICAgIHByaXYtPnBhZ2Vfc2V0dGluZ3MtPnNldFVzZXNQYWdlQ2FjaGUodHJ1 ZSk7Ci0gICAgcHJpdi0+cGFnZV9zZXR0aW5ncy0+c2V0VXNlc0VuY29kaW5nRGV0ZWN0b3IodHJ1 ZSk7CisgICAgcHJpdi0+cGFnZV9zZXR0aW5ncy0+c2V0VXNlc0VuY29kaW5nRGV0ZWN0b3IoZmFs c2UpOwogCiAgICAgdXJsID0gcHJpdi0+cGFnZV9zZXR0aW5ncy0+dXNlclN0eWxlU2hlZXRMb2Nh dGlvbigpOwogICAgIHByaXYtPnNldHRpbmdzLnVzZXJfc3R5bGVzaGVldCA9IGVpbmFfc3RyaW5n c2hhcmVfYWRkKHVybC5zdHJpbmcoKS51dGY4KCkuZGF0YSgpKTsK 95917 2011-06-03 08:42:41 -0700 2012-10-09 05:12:36 -0700 Same patch, more detailed ChangeLog, take #2 bug-61744.diff text/plain 1246 rakuco LS0tIGEvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCQorKysgYS9Tb3VyY2UvV2ViS2l0L2Vm bC9DaGFuZ2VMb2cJCkBAIC0xLDMgKzEsMTYgQEAgCisyMDExLTA1LTMwICBSYXBoYWVsIEt1Ym8g ZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtlZmxdIERvIG5vdCBlbmFibGUgdGhlIGVuY29kaW5n IGRldGVjdG9yIGJ5IGRlZmF1bHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02MTc0NAorCisgICAgICAgIFRoaXMgc2hvdWxkIG1hdGNoIHRoZSBiZWhh dmlvdXIgb2Ygb3RoZXIgcG9ydHMgbW9yZSBjbG9zZWx5LCBhbmQgbWFrZXMKKyAgICAgICAgYXQg bGVhc3QgZG9tL3hodG1sL2xldmVsMy9jb3JlL2RvY3VtZW50Z2V0aW5wdXRlbmNvZGluZzAxLnho dG1sIHBhc3MuCisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoX2V3a192 aWV3X3ByaXZfbmV3KToKKwogMjAxMS0wNi0wMyAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3 LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg4MDE0 LgotLS0gYS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCQorKysgYS9Tb3VyY2Uv V2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCQpAQCAtNTc0LDcgKzU3NCw3IEBAIHN0YXRpYyBF d2tfVmlld19Qcml2YXRlX0RhdGEqIF9ld2tfdmlld19wcml2X25ldyhFd2tfVmlld19TbWFydF9E YXRhKiBzZCkKICAgICBwcml2LT5wYWdlX3NldHRpbmdzLT5zZXRMb2NhbFN0b3JhZ2VFbmFibGVk KHRydWUpOwogICAgIHByaXYtPnBhZ2Vfc2V0dGluZ3MtPnNldE9mZmxpbmVXZWJBcHBsaWNhdGlv bkNhY2hlRW5hYmxlZCh0cnVlKTsKICAgICBwcml2LT5wYWdlX3NldHRpbmdzLT5zZXRVc2VzUGFn ZUNhY2hlKHRydWUpOwotICAgIHByaXYtPnBhZ2Vfc2V0dGluZ3MtPnNldFVzZXNFbmNvZGluZ0Rl dGVjdG9yKHRydWUpOworICAgIHByaXYtPnBhZ2Vfc2V0dGluZ3MtPnNldFVzZXNFbmNvZGluZ0Rl dGVjdG9yKGZhbHNlKTsKIAogICAgIHVybCA9IHByaXYtPnBhZ2Vfc2V0dGluZ3MtPnVzZXJTdHls ZVNoZWV0TG9jYXRpb24oKTsKICAgICBwcml2LT5zZXR0aW5ncy51c2VyX3N0eWxlc2hlZXQgPSBl aW5hX3N0cmluZ3NoYXJlX2FkZCh1cmwuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7Cg==