61738 2011-05-30 10:42:53 -0700 compilation fails with libpng-1.5 2011-06-18 12:54:13 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 angelos webkit-unassigned webkit.review.bot oldest_to_newest 412290 0 95355 angelos 2011-05-30 10:42:53 -0700 Created attachment 95355 patch to use the current API WebCore::writeOutput() in WebCore/platform/image-encoders/skia/PNGImageEncoder.cpp tries to access (struct *png_struct)->io_ptr which is deprecated in libpng-1.4 and removed in 1.5. The new way is to use png_get_io_ptr(). Attached is a patch that uses this function. 412330 1 95363 angelos 2011-05-30 12:50:53 -0700 Created attachment 95363 Updated libpng15 patch 412491 2 angelos 2011-05-31 01:08:02 -0700 fyi, from the libpng manual: The png_get_io_ptr() function has been present since libpng-0.88, has never changed, and is unaffected by conditional compilation macros. so this patch is backwards compatible with pretty much every distribution that's newer than 1999. 412953 3 95363 ap 2011-05-31 15:45:09 -0700 Comment on attachment 95363 Updated libpng15 patch View in context: https://bugs.webkit.org/attachment.cgi?id=95363&action=review > WebCore/ChangeLog:8 > + No new tests. (OOPS!) Commit queue can't land the patch with this line. You should just remove it, as it's obvious why no test is needed. > WebCore/ChangeLog:11 > + * platform/image-encoders/skia/PNGImageEncoder.cpp: > + (WebCore::writeOutput): Use the new API As you explained in Bugzilla, the API is not new. 413188 4 95555 angelos 2011-06-01 00:26:25 -0700 Created attachment 95555 updated ChangeLog entry 423198 5 95555 webkit.review.bot 2011-06-18 12:54:09 -0700 Comment on attachment 95555 updated ChangeLog entry Clearing flags on attachment: 95555 Committed r89200: <http://trac.webkit.org/changeset/89200> 423199 6 webkit.review.bot 2011-06-18 12:54:13 -0700 All reviewed patches have been landed. Closing bug. 95355 2011-05-30 10:42:53 -0700 2011-05-30 12:50:53 -0700 patch to use the current API webkit-libpng15.patch text/plain 643 angelos SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9QTkdJbWFnZUVuY29k ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tp YS9QTkdJbWFnZUVuY29kZXIuY3BwCShyZXZpc2lvbiA4NzYyNykKKysrIFdlYkNvcmUvcGxhdGZv cm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9QTkdJbWFnZUVuY29kZXIuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00NCw3ICs0NCw3IEBACiAKIHN0YXRpYyB2b2lkIHdyaXRlT3V0cHV0KHBuZ19zdHJ1Y3Rw IHBuZywgcG5nX2J5dGVwIGRhdGEsIHBuZ19zaXplX3Qgc2l6ZSkKIHsKLSAgICBzdGF0aWNfY2Fz dDxWZWN0b3I8dW5zaWduZWQgY2hhcj4qPihwbmctPmlvX3B0ciktPmFwcGVuZChkYXRhLCBzaXpl KTsKKyAgICBzdGF0aWNfY2FzdDxWZWN0b3I8dW5zaWduZWQgY2hhcj4qPihwbmdfZ2V0X2lvX3B0 cihwbmcpKS0+YXBwZW5kKGRhdGEsIHNpemUpOwogfQogCiBzdGF0aWMgdm9pZCBwcmVNdWx0aXBs aWVkQkdSQXRvUkdCQShjb25zdCB2b2lkKiBwaXhlbHMsIGludCBwaXhlbENvdW50LCB1bnNpZ25l ZCBjaGFyKiBvdXRwdXQpCg== 95363 2011-05-30 12:50:53 -0700 2011-06-01 00:26:25 -0700 Updated libpng15 patch webkit-libpng15.patch text/plain 1300 angelos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA4NzY5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMzAgIENocmlzdG9waCBNZW5kZSAgPG1lbmRlLmNocmlz dG9waEBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgY29tcGlsYXRpb24gZmFpbHMgd2l0aCBsaWJwbmctMS41CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTczOAorCisgICAgICAgIE5vIG5l dyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tp YS9QTkdJbWFnZUVuY29kZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6d3JpdGVPdXRwdXQpOiBV c2UgdGhlIG5ldyBBUEkKKwogMjAxMS0wNS0zMCAgTm9hbSBSb3NlbnRoYWwgIDxub2FtLnJvc2Vu dGhhbEBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJp c3RpYW5zZW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL3NraWEvUE5H SW1hZ2VFbmNvZGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWVu Y29kZXJzL3NraWEvUE5HSW1hZ2VFbmNvZGVyLmNwcAkocmV2aXNpb24gODc2MjcpCisrKyBXZWJD b3JlL3BsYXRmb3JtL2ltYWdlLWVuY29kZXJzL3NraWEvUE5HSW1hZ2VFbmNvZGVyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDQsNyArNDQsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHN0YXRp YyB2b2lkIHdyaXRlT3V0cHV0KHBuZ19zdHJ1Y3RwIHBuZywgcG5nX2J5dGVwIGRhdGEsIHBuZ19z aXplX3Qgc2l6ZSkKIHsKLSAgICBzdGF0aWNfY2FzdDxWZWN0b3I8dW5zaWduZWQgY2hhcj4qPihw bmctPmlvX3B0ciktPmFwcGVuZChkYXRhLCBzaXplKTsKKyAgICBzdGF0aWNfY2FzdDxWZWN0b3I8 dW5zaWduZWQgY2hhcj4qPihwbmdfZ2V0X2lvX3B0cihwbmcpKS0+YXBwZW5kKGRhdGEsIHNpemUp OwogfQogCiBzdGF0aWMgdm9pZCBwcmVNdWx0aXBsaWVkQkdSQXRvUkdCQShjb25zdCB2b2lkKiBw aXhlbHMsIGludCBwaXhlbENvdW50LCB1bnNpZ25lZCBjaGFyKiBvdXRwdXQpCg== 95555 2011-06-01 00:26:25 -0700 2011-06-18 12:54:09 -0700 updated ChangeLog entry webkit-libpng15.patch text/plain 1296 angelos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA4NzY5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMzAgIENocmlzdG9waCBNZW5kZSAgPG1lbmRlLmNocmlz dG9waEBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgY29tcGlsYXRpb24gZmFpbHMgd2l0aCBsaWJwbmctMS41CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTczOAorCisgICAgICAgICogcGxh dGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9QTkdJbWFnZUVuY29kZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6d3JpdGVPdXRwdXQpOiBVc2UgZ2V0dGVyIGZ1bmN0aW9uIGluc3RlYWQgb2YgZGly ZWN0IGFjY2VzcworCiAyMDExLTA1LTMwICBOb2FtIFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFs QG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlh bnNlbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9QTkdJbWFn ZUVuY29kZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZW5jb2Rl cnMvc2tpYS9QTkdJbWFnZUVuY29kZXIuY3BwCShyZXZpc2lvbiA4NzYyNykKKysrIFdlYkNvcmUv cGxhdGZvcm0vaW1hZ2UtZW5jb2RlcnMvc2tpYS9QTkdJbWFnZUVuY29kZXIuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC00NCw3ICs0NCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogc3RhdGljIHZv aWQgd3JpdGVPdXRwdXQocG5nX3N0cnVjdHAgcG5nLCBwbmdfYnl0ZXAgZGF0YSwgcG5nX3NpemVf dCBzaXplKQogewotICAgIHN0YXRpY19jYXN0PFZlY3Rvcjx1bnNpZ25lZCBjaGFyPio+KHBuZy0+ aW9fcHRyKS0+YXBwZW5kKGRhdGEsIHNpemUpOworICAgIHN0YXRpY19jYXN0PFZlY3Rvcjx1bnNp Z25lZCBjaGFyPio+KHBuZ19nZXRfaW9fcHRyKHBuZykpLT5hcHBlbmQoZGF0YSwgc2l6ZSk7CiB9 CiAKIHN0YXRpYyB2b2lkIHByZU11bHRpcGxpZWRCR1JBdG9SR0JBKGNvbnN0IHZvaWQqIHBpeGVs cywgaW50IHBpeGVsQ291bnQsIHVuc2lnbmVkIGNoYXIqIG91dHB1dCkK