61723 2011-05-30 01:37:25 -0700 NRWT: Exception in verbose printing mode 2011-05-31 22:54:57 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 zhenghao webkit-unassigned commit-queue dpranke oldest_to_newest 412163 0 zhenghao 2011-05-30 01:37:25 -0700 File "/usr/local/google/code/webkit.chromium/webkit/Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py", line 351, in print_progress self._meter.update("%s (%d%%): %d ran as expected, %d didn't," AttributeError: 'NoneType' object has no attribute 'update' Caused by https://bugs.webkit.org/show_bug.cgi?id=60326 412165 1 95330 zhenghao 2011-05-30 01:42:52 -0700 Created attachment 95330 Proposed patch. delegate to self._update 413093 2 95330 dpranke 2011-05-31 19:45:16 -0700 Comment on attachment 95330 Proposed patch. LGTM. Good catch. 413151 3 commit-queue 2011-05-31 22:53:36 -0700 The commit-queue encountered the following flaky tests while processing attachment 95330: http/tests/inspector/console-websocket-error.html bug 57392 (authors: pfeldman@chromium.org and yutak@chromium.org) http/tests/websocket/tests/sub-protocol-with-space.html bug 61434 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 413152 4 95330 commit-queue 2011-05-31 22:54:52 -0700 Comment on attachment 95330 Proposed patch. Clearing flags on attachment: 95330 Committed r87774: <http://trac.webkit.org/changeset/87774> 413153 5 commit-queue 2011-05-31 22:54:57 -0700 All reviewed patches have been landed. Closing bug. 95330 2011-05-30 01:42:52 -0700 2011-05-31 22:54:52 -0700 Proposed patch. printing_verbose.patch text/plain 1500 zhenghao SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDg3NjgwKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTEtMDUtMzAgIEhhbyBaaGVuZyAgPHpoZW5naGFvQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZXhj ZXB0aW9uIGluIHZlcmJvc2UgcHJpbnRpbmcgbW9kZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxNzIzCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9wcmludGluZy5weToKKwogMjAxMS0wNS0y OSAgWXV0YSBLaXRhbXVyYSAgPHl1dGFrQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBLZW50IFRhbXVyYS4KSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL2xheW91dF9wYWNrYWdlL3ByaW50aW5nLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3ByaW50aW5nLnB5CShyZXZp c2lvbiA4NzY3OCkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91 dF9wYWNrYWdlL3ByaW50aW5nLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zNDgsMTIgKzM0OCwxMiBA QCBjbGFzcyBQcmludGVyKG9iamVjdCk6CiAgICAgICAgIGFjdGlvbiA9ICJUZXN0aW5nIgogICAg ICAgICBpZiByZXRyeWluZzoKICAgICAgICAgICAgIGFjdGlvbiA9ICJSZXRyeWluZyIKLSAgICAg ICAgc2VsZi5fbWV0ZXIudXBkYXRlKCIlcyAoJWQlJSk6ICVkIHJhbiBhcyBleHBlY3RlZCwgJWQg ZGlkbid0LCIKKyAgICAgICAgc2VsZi5fdXBkYXRlKCIlcyAoJWQlJSk6ICVkIHJhbiBhcyBleHBl Y3RlZCwgJWQgZGlkbid0LCIKICAgICAgICAgICAgICIgJWQgbGVmdCIgJSAoYWN0aW9uLCBwZXJj ZW50X2NvbXBsZXRlLCByZXN1bHRfc3VtbWFyeS5leHBlY3RlZCwKICAgICAgICAgICAgICByZXN1 bHRfc3VtbWFyeS51bmV4cGVjdGVkLCByZXN1bHRfc3VtbWFyeS5yZW1haW5pbmcpKQogCiAgICAg ICAgIGlmIHJlc3VsdF9zdW1tYXJ5LnJlbWFpbmluZyA9PSAwOgotICAgICAgICAgICAgc2VsZi5f bWV0ZXIudXBkYXRlKCcnKQorICAgICAgICAgICAgc2VsZi5fdXBkYXRlKCcnKQogCiAgICAgZGVm IHByaW50X3VuZXhwZWN0ZWRfcmVzdWx0cyhzZWxmLCB1bmV4cGVjdGVkX3Jlc3VsdHMpOgogICAg ICAgICAiIiJQcmludHMgYSBsaXN0IG9mIHRoZSB1bmV4cGVjdGVkIHJlc3VsdHMgdG8gdGhlIGJ1 aWxkYm90IHN0cmVhbS4iIiIK