61719 2011-05-29 20:58:54 -0700 FELightingNEON.h not compilable on arm 2011-05-31 07:04:05 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Linux RESOLVED FIXED Qt, QtTriaged P1 Normal --- 0 romaxa webkit-unassigned ademar benjamin commit-queue webkit.review.bot oldest_to_newest 412108 0 romaxa 2011-05-29 20:58:54 -0700 FELightingNEON.h:148 - ASSERT(m_lightSource.type == LS_DISTANT); - should be lightSource->type() 412110 1 95321 romaxa 2011-05-29 21:03:32 -0700 Created attachment 95321 Fix compilation with debug enabled 412111 2 webkit.review.bot 2011-05-29 21:05:45 -0700 Attachment 95321 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 412286 3 95353 romaxa 2011-05-30 10:30:23 -0700 Created attachment 95353 Fixed changelog 412564 4 95353 commit-queue 2011-05-31 05:43:24 -0700 Comment on attachment 95353 Fixed changelog Clearing flags on attachment: 95353 Committed r87723: <http://trac.webkit.org/changeset/87723> 412565 5 commit-queue 2011-05-31 05:43:28 -0700 All reviewed patches have been landed. Closing bug. 412599 6 ademar 2011-05-31 07:04:05 -0700 Revision r87723 cherry-picked into qtwebkit-2.2 with commit 79b6bea <http://gitorious.org/webkit/qtwebkit/commit/79b6bea> 95321 2011-05-29 21:03:32 -0700 2011-05-30 10:30:23 -0700 Fix compilation with debug enabled new_patch.diff text/plain 1371 romaxa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3NjYxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMjkgIE9sZWcgUm9t YXNoaW4gIDxvbGVnLnJvbWFzaGluQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2l0aCBkZWJ1ZyBlbmFi bGVkLCBtX2xpZ2h0U291cmNlLnR5cGUgaXMgbm90IHZhbGlkIGFueW1vcmUKKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvYXJtL0ZFTGlnaHRpbmdORU9OLmg6CisgICAgICAg IChXZWJDb3JlOjpGRUxpZ2h0aW5nOjpwbGF0Zm9ybUFwcGx5TmVvbik6CisKIDIwMTEtMDUtMjkg IEJyaWFuIFdlaW5zdGVpbiAgPGJ3ZWluc3RlaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZmlsdGVycy9hcm0vRkVMaWdodGluZ05FT04uaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9GRUxpZ2h0aW5nTkVPTi5oCShyZXZp c2lvbiA4NzY2MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMv YXJtL0ZFTGlnaHRpbmdORU9OLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0NSw3ICsxNDUsNyBAQCBp bmxpbmUgdm9pZCBGRUxpZ2h0aW5nOjpwbGF0Zm9ybUFwcGx5TmVvCiAgICAgICAgIGlmIChzcG90 TGlnaHRTb3VyY2UtPnNwZWN1bGFyRXhwb25lbnQoKSA9PSAxKQogICAgICAgICAgICAgbmVvbkRh dGEuZmxhZ3MgfD0gRkxBR19DT05FX0VYUE9ORU5UX0lTXzE7CiAgICAgfSBlbHNlIHsKLSAgICAg ICAgQVNTRVJUKG1fbGlnaHRTb3VyY2UudHlwZSA9PSBMU19ESVNUQU5UKTsKKyAgICAgICAgQVNT RVJUKG1fbGlnaHRTb3VyY2UtPnR5cGUoKSA9PSBMU19ESVNUQU5UKTsKICAgICAgICAgZmxvYXRB cmd1bWVudHMubGlnaHRYID0gcGFpbnRpbmdEYXRhLmxpZ2h0VmVjdG9yLngoKTsKICAgICAgICAg ZmxvYXRBcmd1bWVudHMubGlnaHRZID0gcGFpbnRpbmdEYXRhLmxpZ2h0VmVjdG9yLnkoKTsKICAg ICAgICAgZmxvYXRBcmd1bWVudHMubGlnaHRaID0gcGFpbnRpbmdEYXRhLmxpZ2h0VmVjdG9yLnoo KTsK 95353 2011-05-30 10:30:23 -0700 2011-05-31 05:43:23 -0700 Fixed changelog new_patch.diff text/plain 1426 romaxa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3NjYxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMjkgIE9sZWcgUm9t YXNoaW4gIDxvbGVnLnJvbWFzaGluQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggY29tcGlsYXRpb24gd2l0aCBkZWJ1ZyBlbmFi bGVkLCBtX2xpZ2h0U291cmNlLnR5cGUgaXMgbm90IHZhbGlkIGFueW1vcmUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxNzE5CisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2FybS9GRUxpZ2h0aW5nTkVPTi5oOgorICAgICAgICAo V2ViQ29yZTo6RkVMaWdodGluZzo6cGxhdGZvcm1BcHBseU5lb24pOgorCiAyMDExLTA1LTI5ICBC cmlhbiBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2ZpbHRlcnMvYXJtL0ZFTGlnaHRpbmdORU9OLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZmlsdGVycy9hcm0vRkVMaWdodGluZ05FT04uaAkocmV2aXNp b24gODc2NjEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL2Fy bS9GRUxpZ2h0aW5nTkVPTi5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDUsNyArMTQ1LDcgQEAgaW5s aW5lIHZvaWQgRkVMaWdodGluZzo6cGxhdGZvcm1BcHBseU5lbwogICAgICAgICBpZiAoc3BvdExp Z2h0U291cmNlLT5zcGVjdWxhckV4cG9uZW50KCkgPT0gMSkKICAgICAgICAgICAgIG5lb25EYXRh LmZsYWdzIHw9IEZMQUdfQ09ORV9FWFBPTkVOVF9JU18xOwogICAgIH0gZWxzZSB7Ci0gICAgICAg IEFTU0VSVChtX2xpZ2h0U291cmNlLnR5cGUgPT0gTFNfRElTVEFOVCk7CisgICAgICAgIEFTU0VS VChtX2xpZ2h0U291cmNlLT50eXBlKCkgPT0gTFNfRElTVEFOVCk7CiAgICAgICAgIGZsb2F0QXJn dW1lbnRzLmxpZ2h0WCA9IHBhaW50aW5nRGF0YS5saWdodFZlY3Rvci54KCk7CiAgICAgICAgIGZs b2F0QXJndW1lbnRzLmxpZ2h0WSA9IHBhaW50aW5nRGF0YS5saWdodFZlY3Rvci55KCk7CiAgICAg ICAgIGZsb2F0QXJndW1lbnRzLmxpZ2h0WiA9IHBhaW50aW5nRGF0YS5saWdodFZlY3Rvci56KCk7 Cg==