61714 2011-05-29 17:10:41 -0700 30 second rewind button obscured in fullscreen controller when video uses custom inline controls 2011-05-29 17:20:55 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 mitz mitz oldest_to_newest 412062 0 mitz 2011-05-29 17:10:41 -0700 30 second rewind button obscured in fullscreen controller when video uses custom inline controls 412063 1 95309 mitz 2011-05-29 17:15:57 -0700 Created attachment 95309 Let elements know when they become and cease being fullscreen and use that to update the media controls 412065 2 mitz 2011-05-29 17:20:55 -0700 Fixed in r87657. <http://trac.webkit.org/changeset/87657> We reused <rdar://problem/9515650> for this. 95309 2011-05-29 17:15:57 -0700 2011-05-29 17:16:36 -0700 Let elements know when they become and cease being fullscreen and use that to update the media controls bug-61714-20110529171556.patch text/plain 5681 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3NjU1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTEtMDUtMjkgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAzMCBzZWNvbmQgcmV3aW5kIGJ1dHRvbiBvYnNjdXJlZCBpbiBmdWxs c2NyZWVuIGNvbnRyb2xsZXIgd2hlbiB2aWRlbyB1c2VzIGN1c3RvbSBpbmxpbmUgY29udHJvbHMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxNzE0CisK KyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6 OndlYmtpdERpZEVudGVyRnVsbFNjcmVlbkZvckVsZW1lbnQpOiBDYWxsIGRpZEJlY29tZUZ1bGxz Y3JlZW5FbGVtZW50KCkgb24gdGhlCisgICAgICAgIG5ldyBmdWxsIHNjcmVlbiBlbGVtZW50Lgor ICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OndlYmtpdFdpbGxFeGl0RnVsbFNjcmVlbkZvckVs ZW1lbnQpOiBDYWxsIHdpbGxTdG9wQmVpbmdGdWxsc2NyZWVuRWxlbWVudCgpIG9uCisgICAgICAg IHRoZSBmdWxsIHNjcmVlbiBlbGVtZW50LgorICAgICAgICAqIGRvbS9FbGVtZW50Lmg6CisgICAg ICAgIChXZWJDb3JlOjpFbGVtZW50OjpkaWRCZWNvbWVGdWxsc2NyZWVuRWxlbWVudCk6IEFkZGVk IHdpdGggYSBkZWZhdWx0IGltcGxlbWVudGF0aW9uIHRoYXQgZG9lcyBub3RoaW5nLgorICAgICAg ICAoV2ViQ29yZTo6RWxlbWVudDo6d2lsbFN0b3BCZWluZ0Z1bGxzY3JlZW5FbGVtZW50KTogRGl0 dG8uCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkhUTUxNZWRpYUVsZW1lbnQ6OmRpZEJlY29tZUZ1bGxzY3JlZW5FbGVtZW50KTogQWRkZWQg dGhpcyBvdmVycmlkZSwgd2hpY2ggY2FsbHMKKyAgICAgICAgTWVkaWFDb250cm9sczo6ZW50ZXJl ZEZ1bGxzY3JlZW4oKS4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OndpbGxT dG9wQmVpbmdGdWxsc2NyZWVuRWxlbWVudCk6IEFkZGVkIHRoaXMgb3ZlcnJpZGUsIHdoaWNoIGNh bGxzCisgICAgICAgIE1lZGlhQ29udHJvbHM6OmV4aXRlZEZ1bGxzY3JlZW4oKS4KKyAgICAgICAg KiBodG1sL0hUTUxNZWRpYUVsZW1lbnQuaDoKKyAgICAgICAgKiBodG1sL3NoYWRvdy9NZWRpYUNv bnRyb2xFbGVtZW50cy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xGdWxsc2Ny ZWVuQnV0dG9uRWxlbWVudDo6cHJlRGlzcGF0Y2hFdmVudEhhbmRsZXIpOiBSZW1vdmVkIGNhbGxz IHRvCisgICAgICAgIGVudGVyZWRGdWxsc2NyZWVuKCkgYW5kIGV4aXRlZEZ1bGxzY3JlZW4oKSBm cm9tIGhlcmUsIHNpbmNlIHRoZXkgYXJlIG5vdyBjYWxsZWQgaW4gcmVzcG9uc2UgdG8KKyAgICAg ICAgY2hhbmdlcyB0byB0aGUgZnVsbHNjcmVlbi1uZXNzIG9mIHRoZSBlbGVtZW50LgorCiAyMDEx LTA1LTI5ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBLZXZpbiBEZWNrZXIuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9u IDg3NjU0KQorKysgU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDkwNSw3ICs0OTA1LDcgQEAgdm9pZCBEb2N1bWVudDo6d2Via2l0V2lsbEVudGVyRnVs bFNjcmVlbgogICAgIAogdm9pZCBEb2N1bWVudDo6d2Via2l0RGlkRW50ZXJGdWxsU2NyZWVuRm9y RWxlbWVudChFbGVtZW50KikKIHsKLSAgICBBU1NFUlQobV9mdWxsU2NyZWVuRWxlbWVudCk7Cisg ICAgbV9mdWxsU2NyZWVuRWxlbWVudC0+ZGlkQmVjb21lRnVsbHNjcmVlbkVsZW1lbnQoKTsKIAog ICAgIGlmIChtX2Z1bGxTY3JlZW5SZW5kZXJlcikgewogI2lmIFVTRShBQ0NFTEVSQVRFRF9DT01Q T1NJVElORykKQEAgLTQ5MjQsNiArNDkyNCw4IEBAIHZvaWQgRG9jdW1lbnQ6OndlYmtpdFdpbGxF eGl0RnVsbFNjcmVlbkYKIHsKICAgICBzZXRDb250YWluc0Z1bGxTY3JlZW5FbGVtZW50UmVjdXJz aXZlbHkob3duZXJFbGVtZW50KCksIGZhbHNlKTsKICAgICAKKyAgICBtX2Z1bGxTY3JlZW5FbGVt ZW50LT53aWxsU3RvcEJlaW5nRnVsbHNjcmVlbkVsZW1lbnQoKTsKKwogICAgIGlmIChtX2Z1bGxT Y3JlZW5SZW5kZXJlcikgewogICAgICAgICBzZXRBbmltYXRpbmdGdWxsU2NyZWVuKHRydWUpOwog I2lmIFVTRShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Rv bS9FbGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAko cmV2aXNpb24gODc2NTQpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCSh3b3JraW5n IGNvcHkpCkBAIC0yNzksNiArMjc5LDkgQEAgcHVibGljOgogICAgIC8vIFVzZSBEb2N1bWVudDo6 cmVnaXN0ZXJGb3JQcml2YXRlQnJvd3NpbmdTdGF0ZUNoYW5nZWRDYWxsYmFja3MoKSB0byBzdWJz Y3JpYmUgdG8gdGhpcy4KICAgICB2aXJ0dWFsIHZvaWQgcHJpdmF0ZUJyb3dzaW5nU3RhdGVEaWRD aGFuZ2UoKSB7IH0KIAorICAgIHZpcnR1YWwgdm9pZCBkaWRCZWNvbWVGdWxsc2NyZWVuRWxlbWVu dCgpIHsgfQorICAgIHZpcnR1YWwgdm9pZCB3aWxsU3RvcEJlaW5nRnVsbHNjcmVlbkVsZW1lbnQo KSB7IH0KKwogICAgIGJvb2wgaXNGaW5pc2hlZFBhcnNpbmdDaGlsZHJlbigpIGNvbnN0IHsgcmV0 dXJuIGlzUGFyc2luZ0NoaWxkcmVuRmluaXNoZWQoKTsgfQogICAgIHZpcnR1YWwgdm9pZCBmaW5p c2hQYXJzaW5nQ2hpbGRyZW4oKTsKICAgICB2aXJ0dWFsIHZvaWQgYmVnaW5QYXJzaW5nQ2hpbGRy ZW4oKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAkocmV2 aXNpb24gODc2NTQpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yNTU2LDYgKzI1NTYsMTggQEAgdm9pZCBIVE1MTWVkaWFFbGVt ZW50OjpleGl0RnVsbHNjcmVlbigpCiAgICAgfQogfQogCit2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6 OmRpZEJlY29tZUZ1bGxzY3JlZW5FbGVtZW50KCkKK3sKKyAgICBpZiAoaGFzTWVkaWFDb250cm9s cygpKQorICAgICAgICBtZWRpYUNvbnRyb2xzKCktPmVudGVyZWRGdWxsc2NyZWVuKCk7Cit9CisK K3ZvaWQgSFRNTE1lZGlhRWxlbWVudDo6d2lsbFN0b3BCZWluZ0Z1bGxzY3JlZW5FbGVtZW50KCkK K3sKKyAgICBpZiAoaGFzTWVkaWFDb250cm9scygpKQorICAgICAgICBtZWRpYUNvbnRyb2xzKCkt PmV4aXRlZEZ1bGxzY3JlZW4oKTsKK30KKwogUGxhdGZvcm1NZWRpYSBIVE1MTWVkaWFFbGVtZW50 OjpwbGF0Zm9ybU1lZGlhKCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9wbGF5ZXIgPyBtX3BsYXll ci0+cGxhdGZvcm1NZWRpYSgpIDogTm9QbGF0Zm9ybU1lZGlhOwpJbmRleDogU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MTWVkaWFFbGVtZW50LmgJKHJldmlzaW9uIDg3NjU0KQorKysgU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTIyNyw3ICsyMjcs MTAgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgcmVjYWxjU3R5bGUoU3R5bGVDaGFuZ2Up OwogICAgIAogICAgIHZpcnR1YWwgdm9pZCBkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50Kik7Ci0g ICAgCisKKyAgICB2aXJ0dWFsIHZvaWQgZGlkQmVjb21lRnVsbHNjcmVlbkVsZW1lbnQoKTsKKyAg ICB2aXJ0dWFsIHZvaWQgd2lsbFN0b3BCZWluZ0Z1bGxzY3JlZW5FbGVtZW50KCk7CisKICAgICAv LyBBY3RpdmVET01PYmplY3QgZnVuY3Rpb25zLgogICAgIHZpcnR1YWwgYm9vbCBjYW5TdXNwZW5k KCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIHN1c3BlbmQoUmVhc29uRm9yU3VzcGVuc2lvbik7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9s RWxlbWVudHMuY3BwCShyZXZpc2lvbiA4NzY1NCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvc2hh ZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODAwLDEzICs4 MDAsMTAgQEAgdm9pZCogTWVkaWFDb250cm9sRnVsbHNjcmVlbkJ1dHRvbkVsZW1lbgogICAgICAg ICAvLyB2aWRlbyBpbXBsZW1lbnRhdGlvbiB3aXRob3V0IHJlcXVpcmluZyB0aGVtIHRvIGltcGxl bWVudCB0aGVpciBvd24gZnVsbCAKICAgICAgICAgLy8gc2NyZWVuIGJlaGF2aW9yLgogICAgICAg ICBpZiAoZG9jdW1lbnQoKS0+c2V0dGluZ3MoKSAmJiBkb2N1bWVudCgpLT5zZXR0aW5ncygpLT5m dWxsU2NyZWVuRW5hYmxlZCgpKSB7Ci0gICAgICAgICAgICBpZiAoZG9jdW1lbnQoKS0+d2Via2l0 SXNGdWxsU2NyZWVuKCkgJiYgZG9jdW1lbnQoKS0+d2Via2l0Q3VycmVudEZ1bGxTY3JlZW5FbGVt ZW50KCkgPT0gbWVkaWFFbGVtZW50KCkpIHsKKyAgICAgICAgICAgIGlmIChkb2N1bWVudCgpLT53 ZWJraXRJc0Z1bGxTY3JlZW4oKSAmJiBkb2N1bWVudCgpLT53ZWJraXRDdXJyZW50RnVsbFNjcmVl bkVsZW1lbnQoKSA9PSBtZWRpYUVsZW1lbnQoKSkKICAgICAgICAgICAgICAgICBkb2N1bWVudCgp LT53ZWJraXRDYW5jZWxGdWxsU2NyZWVuKCk7Ci0gICAgICAgICAgICAgICAgbV9jb250cm9scy0+ ZXhpdGVkRnVsbHNjcmVlbigpOwotICAgICAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGVs c2UKICAgICAgICAgICAgICAgICBkb2N1bWVudCgpLT5yZXF1ZXN0RnVsbFNjcmVlbkZvckVsZW1l bnQobWVkaWFFbGVtZW50KCksIDAsIERvY3VtZW50OjpFeGVtcHRJRnJhbWVBbGxvd0Z1bFNjcmVl blJlcXVpcmVtZW50KTsKLSAgICAgICAgICAgICAgICBtX2NvbnRyb2xzLT5lbnRlcmVkRnVsbHNj cmVlbigpOwotICAgICAgICAgICAgfQogICAgICAgICB9IGVsc2UKICNlbmRpZgogICAgICAgICAg ICAgbWVkaWFFbGVtZW50KCktPmVudGVyRnVsbHNjcmVlbigpOwo=