61707 2011-05-29 13:07:52 -0700 Race condition in full screen controller, which leads to problem when web process crashes 2011-05-29 17:19:51 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 darin darin oldest_to_newest 412008 0 darin 2011-05-29 13:07:52 -0700 Race condition in full screen controller, which leads to problem when web process crashes 412009 1 95295 darin 2011-05-29 13:08:49 -0700 Created attachment 95295 Patch 412013 2 darin 2011-05-29 13:12:32 -0700 Committed r87644: <http://trac.webkit.org/changeset/87644> 412052 3 darin 2011-05-29 16:52:52 -0700 The initial patch was too simple-minded and could result in a WKView leak. 412056 4 95308 darin 2011-05-29 16:59:13 -0700 Created attachment 95308 Patch 412059 5 95308 darin 2011-05-29 17:04:50 -0700 Comment on attachment 95308 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95308&action=review > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:424 > + [self release]; // Balanced by retain in exitAcceleratedCompositingMode below. I have corrected this to say “above” locally. 412060 6 95308 mitz 2011-05-29 17:07:34 -0700 Comment on attachment 95308 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95308&action=review > Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:410 > + if (!_isExitingAcceleratedCompositingMode) > + return; This shouldn’t happen. It’s good to be prepared for this, but I suggest asserting that it doesn’t happen, in addition. >> Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm:424 >> + [self release]; // Balanced by retain in exitAcceleratedCompositingMode below. > > I have corrected this to say “above” locally. Please also correct the name of the method the comment is referring to! 412064 7 darin 2011-05-29 17:19:51 -0700 Committed r87656: <http://trac.webkit.org/changeset/87656> 95295 2011-05-29 13:08:49 -0700 2011-05-29 16:59:10 -0700 Patch bug-61707-20110529130847.patch text/plain 2066 darin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3NjQyKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMjkgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJhY2UgY29uZGl0aW9uIGluIGZ1bGwgc2NyZWVuIGNvbnRyb2xsZXIs IHdoaWNoIGxlYWRzIHRvIHByb2JsZW0gd2hlbiB3ZWIgcHJvY2VzcyBjcmFzaGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTcwNworCisgICAgICAg IFNhdyB0aGlzIHdoaWxlIGRlYnVnZ2luZyBhIGNyYXNoLiBXZSBkb24ndCBoYXZlIGEgd2F5IHRv IG1ha2UgcmVncmVzc2lvbiB0ZXN0cyBmb3IgdGhpcworICAgICAgICBraW5kIG9mIGlzc3VlIGF0 IHRoaXMgdGltZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93 Q29udHJvbGxlci5tbToKKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciBl eGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGVdKTogUmV0YWluIHRoZSBjb250cm9sbGVyCisg ICAgICAgIGhlcmUgc2luY2Ugd2UgYXJlIGtlZXBpbmcgYSBwb2ludGVyIHRvIGl0LgorICAgICAg ICAoZXhpdENvbXBvc2l0ZWRNb2RlUmVwYWludENvbXBsZXRlZCk6IFJlbGVhc2UgdGhlIGNvbnRy b2xsZXIgaGVyZS4KKwogMjAxMS0wNS0yOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyLm1tCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2lu ZG93Q29udHJvbGxlci5tbQkocmV2aXNpb24gODc2MzgpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0JKHdvcmtpbmcgY29weSkK QEAgLTM5NSw2ICszOTUsNyBAQCAtICh2b2lkKWV4aXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9k ZQogICAgICAgICByZXR1cm47CiAKICAgICBOU0Rpc2FibGVTY3JlZW5VcGRhdGVzKCk7CisgICAg W3NlbGYgcmV0YWluXTsgLy8gQmFsYW5jZWQgYnkgcmVsZWFzZSBpbiBleGl0Q29tcG9zaXRlZE1v ZGVSZXBhaW50Q29tcGxldGVkIGJlbG93LgogICAgIFtzZWxmIF9wYWdlXS0+Zm9yY2VSZXBhaW50 KFZvaWRDYWxsYmFjazo6Y3JlYXRlKHNlbGYsIGV4aXRDb21wb3NpdGVkTW9kZVJlcGFpbnRDb21w bGV0ZWQpKTsKIH0KIApAQCAtNDE0LDcgKzQxNSw5IEBAIC0gKHZvaWQpZXhpdENvbXBvc2l0ZWRN b2RlUmVwYWludENvbXBsZXQKIAogc3RhdGljIHZvaWQgZXhpdENvbXBvc2l0ZWRNb2RlUmVwYWlu dENvbXBsZXRlZChXS0Vycm9yUmVmLCB2b2lkKiBjb250ZXh0KQogewotICAgIFsoV0tGdWxsU2Ny ZWVuV2luZG93Q29udHJvbGxlciopY29udGV4dCBleGl0Q29tcG9zaXRlZE1vZGVSZXBhaW50Q29t cGxldGVkXTsKKyAgICBXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyICpjb250cm9sbGVyID0g c3RhdGljX2Nhc3Q8V0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciAqPihjb250ZXh0KTsKKyAg ICBbY29udHJvbGxlciBleGl0Q29tcG9zaXRlZE1vZGVSZXBhaW50Q29tcGxldGVkXTsKKyAgICBb Y29udHJvbGxlciByZWxlYXNlXTsgLy8gQmFsYW5jZWQgYnkgcmV0YWluIGluIGV4aXRBY2NlbGVy YXRlZENvbXBvc2l0aW5nTW9kZSBhYm92ZS4KIH0KIAogLSAoV2ViQ29yZTo6SW50UmVjdClnZXRG dWxsU2NyZWVuUmVjdAo= 95308 2011-05-29 16:59:13 -0700 2011-05-29 17:07:34 -0700 Patch bug-61707-20110529165912.patch text/plain 4061 darin SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3NjU0KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTEtMDUtMjkgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFJhY2UgY29uZGl0aW9uIGluIGZ1bGwgc2NyZWVuIGNvbnRyb2xsZXIs IHdoaWNoIGxlYWRzIHRvIHByb2JsZW0gd2hlbiB3ZWIgcHJvY2VzcyBjcmFzaGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTcwNworCisgICAgICAg IFNlY29uZCB0cnkgYXQgdGhpcy4gRmlyc3QgdHJ5IGNvdWxkIGxlYWQgdG8gYSBXS1ZpZXcgbGVh ay4KKworICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxl ci5oOiBBZGRlZCBfaXNFeGl0aW5nQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUuCisgICAgICAg IE5lZWRlZCB0byB0cmFjayB3aGV0aGVyIHdlIGhhdmUgcmV0YWluZWQgc28gd2UgZG9uJ3QgbGVh ayBpZiB0aGUgcGFnZSBnb2VzIGF3YXkgYmVmb3JlCisgICAgICAgIHdlIGdldCB0aGUgY2FsbGJh Y2suCisKKyAgICAgICAgKiBVSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xs ZXIubW06CisgICAgICAgICgtW1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgZXhpdEFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdNb2RlXSk6IEFkZGVkIGNvZGUgdG8gc2V0CisgICAgICAgIHRoZSBu ZXcgdmFyaWFibGUgdG8gWUVTLgorICAgICAgICAoLVtXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9s bGVyIGV4aXRDb21wb3NpdGVkTW9kZVJlcGFpbnRDb21wbGV0ZWRdKTogQWRkZWQgY29kZSB0bwor ICAgICAgICBkZWFsIHdpdGggdGhlIG5ldyBib29sZWFuIGFuZCB0byByZWxlYXNlLgorICAgICAg ICAoZXhpdENvbXBvc2l0ZWRNb2RlUmVwYWludENvbXBsZXRlZCk6IFJlbW92ZWQgdGhlIHJlbGVh c2UgdGhhdCB3YXMgaGVyZS4KKyAgICAgICAgKC1bV0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxl ciBjbG9zZV0pOiBBZGRlZCBhIGNhbGwgdG8gZXhpdENvbXBvc2l0ZWRNb2RlUmVwYWludENvbXBs ZXRlZAorICAgICAgICBoZXJlLiBXZSdyZSBhcyBjb21wbGV0ZSBhcyB3ZSdsbCBldmVyIGJlIHdo ZW4gd2UncmUgY2xvc2VkOyB3ZSBjYW4ndCBnZXQgdGhlIGNhbGxiYWNrCisgICAgICAgIGFmdGVy IHRoYXQgcG9pbnQuCisKIDIwMTEtMDUtMjkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBTb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0Nv bnRyb2xsZXIuaAkocmV2aXNpb24gODc2NTMpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNTEs NiArNTEsNyBAQCBAaW50ZXJmYWNlIFdLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIgCiAgICAg Qk9PTCBfaXNXaW5kb3dMb2FkZWQ7CiAgICAgQk9PTCBfZm9yY2VEaXNhYmxlQW5pbWF0aW9uOwog ICAgIEJPT0wgX2lzUGxheWluZzsKKyAgICBCT09MIF9pc0V4aXRpbmdBY2NlbGVyYXRlZENvbXBv c2l0aW5nTW9kZTsKICAgICBDR1JlY3QgX2luaXRpYWxGcmFtZTsgICAgCiAgICAgdWludDMyX3Qg X2lkbGVEaXNwbGF5U2xlZXBBc3NlcnRpb247CiAgICAgdWludDMyX3QgX2lkbGVTeXN0ZW1TbGVl cEFzc2VydGlvbjsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV0tGdWxsU2Ny ZWVuV2luZG93Q29udHJvbGxlci5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvbWFjL1dLRnVsbFNjcmVlbldpbmRvd0NvbnRyb2xsZXIubW0JKHJldmlzaW9uIDg3NjUz KQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XS0Z1bGxTY3JlZW5XaW5kb3dDb250 cm9sbGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zOTQsMTMgKzM5NCwyMSBAQCAtICh2b2lkKWV4 aXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nTW9kZQogICAgIGlmICghX2xheWVySG9zdGluZ1ZpZXcp CiAgICAgICAgIHJldHVybjsKIAotICAgIE5TRGlzYWJsZVNjcmVlblVwZGF0ZXMoKTsKKyAgICBp ZiAoX2lzRXhpdGluZ0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKQorICAgICAgICByZXR1cm47 CisKICAgICBbc2VsZiByZXRhaW5dOyAvLyBCYWxhbmNlZCBieSByZWxlYXNlIGluIGV4aXRDb21w b3NpdGVkTW9kZVJlcGFpbnRDb21wbGV0ZWQgYmVsb3cuCisgICAgX2lzRXhpdGluZ0FjY2VsZXJh dGVkQ29tcG9zaXRpbmdNb2RlID0gWUVTOworCisgICAgTlNEaXNhYmxlU2NyZWVuVXBkYXRlcygp OwogICAgIFtzZWxmIF9wYWdlXS0+Zm9yY2VSZXBhaW50KFZvaWRDYWxsYmFjazo6Y3JlYXRlKHNl bGYsIGV4aXRDb21wb3NpdGVkTW9kZVJlcGFpbnRDb21wbGV0ZWQpKTsKIH0KIAogLSAodm9pZCll eGl0Q29tcG9zaXRlZE1vZGVSZXBhaW50Q29tcGxldGVkCi17ICAgIAoreworICAgIGlmICghX2lz RXhpdGluZ0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKQorICAgICAgICByZXR1cm47CisKICAg ICBbQ0FUcmFuc2FjdGlvbiBiZWdpbl07CiAgICAgW0NBVHJhbnNhY3Rpb24gc2V0RGlzYWJsZUFj dGlvbnM6WUVTXTsKICAgICBbX2xheWVySG9zdGluZ1ZpZXcuZ2V0KCkgcmVtb3ZlRnJvbVN1cGVy dmlld107CkBAIC00MTEsMTMgKzQxOSwxNCBAQCAtICh2b2lkKWV4aXRDb21wb3NpdGVkTW9kZVJl cGFpbnRDb21wbGV0CiAgICAgCiAgICAgX2xheWVySG9zdGluZ1ZpZXcgPSAwOwogICAgIE5TRW5h YmxlU2NyZWVuVXBkYXRlcygpOworCisgICAgX2lzRXhpdGluZ0FjY2VsZXJhdGVkQ29tcG9zaXRp bmdNb2RlID0gTk87CisgICAgW3NlbGYgcmVsZWFzZV07IC8vIEJhbGFuY2VkIGJ5IHJldGFpbiBp biBleGl0QWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUgYmVsb3cuCiB9CiAKIHN0YXRpYyB2b2lk IGV4aXRDb21wb3NpdGVkTW9kZVJlcGFpbnRDb21wbGV0ZWQoV0tFcnJvclJlZiwgdm9pZCogY29u dGV4dCkKIHsKLSAgICBXS0Z1bGxTY3JlZW5XaW5kb3dDb250cm9sbGVyICpjb250cm9sbGVyID0g c3RhdGljX2Nhc3Q8V0tGdWxsU2NyZWVuV2luZG93Q29udHJvbGxlciAqPihjb250ZXh0KTsKLSAg ICBbY29udHJvbGxlciBleGl0Q29tcG9zaXRlZE1vZGVSZXBhaW50Q29tcGxldGVkXTsKLSAgICBb Y29udHJvbGxlciByZWxlYXNlXTsgLy8gQmFsYW5jZWQgYnkgcmV0YWluIGluIGV4aXRBY2NlbGVy YXRlZENvbXBvc2l0aW5nTW9kZSBhYm92ZS4KKyAgICBbc3RhdGljX2Nhc3Q8V0tGdWxsU2NyZWVu V2luZG93Q29udHJvbGxlciAqPihjb250ZXh0KSBleGl0Q29tcG9zaXRlZE1vZGVSZXBhaW50Q29t cGxldGVkXTsKIH0KIAogLSAoV2ViQ29yZTo6SW50UmVjdClnZXRGdWxsU2NyZWVuUmVjdApAQCAt NDM5LDYgKzQ0OCw5IEBAIC0gKHZvaWQpY2xvc2UKICAgICBpZiAoX2lzRXhpdGluZ0Z1bGxTY3Jl ZW4pCiAgICAgICAgIFtzZWxmIGZpbmlzaGVkRXhpdEZ1bGxTY3JlZW5BbmltYXRpb246WUVTXTsK IAorICAgIGlmIChfaXNFeGl0aW5nQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUpCisgICAgICAg IFtzZWxmIGV4aXRDb21wb3NpdGVkTW9kZVJlcGFpbnRDb21wbGV0ZWRdOworCiAgICAgW3N1cGVy IGNsb3NlXTsKIH0KIAo=