61697 2011-05-28 19:26:55 -0700 a:hover fails to work if it is the same color as a:link 2024-05-30 00:20:26 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified REOPENED https://bugs.webkit.org/show_bug.cgi?id=22539 https://bugs.webkit.org/show_bug.cgi?id=156849 https://bugs.webkit.org/show_bug.cgi?id=264641 InRadar P2 Normal --- 274889 1 joepeck m_dubet ahmad.saleem792 ap bfulgham commit-queue hyatt koivisto mihnea mustaf.here ntim rniwa simon.fraser webkit-bug-importer webkitbugzilla zalan oldest_to_newest 411928 0 95279 joepeck 2011-05-28 19:26:55 -0700 Created attachment 95279 [REDUCTION] Test Case Reduction attached. This fails: <style> a:link { color: red; } a:hover { color: red; } <style> <a>Does not become red when hovered.</a> This works: <style> a:link { color: yellow; } a:hover { color: red; } <style> <a>Does become red when hovered.</a> 414838 1 mihnea 2011-06-03 06:25:52 -0700 In the first case, the color does not change when hover, so technically there is no style difference. In this case, RenderStyle::diff returns StyleDifferenceEqual and the link is displayed using the color associated with the :visited style. Would it be an acceptable solution to modify RenderStyle::diff function to return StyleDifferenceRepaint when inherited_flags._insideLink != NotInsideLink? 424380 2 mustaf.here 2011-06-21 04:14:11 -0700 (In reply to comment #1) > In the first case, the color does not change when hover, so technically there is no style difference. In this case, RenderStyle::diff returns StyleDifferenceEqual and the link is displayed using the color associated with the :visited style. > > Would it be an acceptable solution to modify RenderStyle::diff function to return StyleDifferenceRepaint when inherited_flags._insideLink != NotInsideLink? when I first ran the test case in Safari, I saw the issue. But then when I cleared the history & reload the test case again, everything was working fine. Don't know why the behavior was different in the first case 1886331 3 ahmad.saleem792 2022-07-24 04:51:30 -0700 I am able to reproduce this bug in Safari 15.6 on macOS 12.5 using attached test case and upon hover on first line, it does not turn to red while all other browsers (Chrome Canary 106 and Firefox Nightly 104) does change the text to red upon hover. Just wanted to share update testing results. Thanks! 1886416 4 rniwa 2022-07-24 14:49:04 -0700 wow, this is such a bizarre bug. 1886456 5 webkit-bug-importer 2022-07-24 20:06:58 -0700 <rdar://problem/97529381> 1888016 6 rniwa 2022-07-31 21:02:31 -0700 If I add a different background color, it would work as well so it's probably some style invalidation bug. 1888022 7 ntim 2022-07-31 21:50:15 -0700 I have an idea how to fix this. 1888161 8 ntim 2022-08-01 13:24:09 -0700 actually nevermind 2023656 9 webkitbugzilla 2024-03-25 08:16:07 -0700 In case it's helpful, I encountered a similar behaviour where a:hover fails to work if it's the same as a, and there's a rule for a:visited. The rule for a:hover should override the a:visited, but it doesn't when it's the same as a plain a. I suspect this has the same root cause as this bug. This fails: <style> a { color: green; } a:visited { color: red; } a:hover { color: green; } </style> <a href="https://webkit.org">WebKit website</a> <br> <a href="https://developer.mozilla.org/en-US/">MDN Web Docs</a> This works: <style> a { color: green; } a:visited { color: red; } a:hover { color: blue; } </style> <a href="https://webkit.org">WebKit website</a> <br> <a href="https://developer.mozilla.org/en-US/">MDN Web Docs</a> This also works: <style> a { color: green; } a:visited { color: red; } a:hover { color: green; background: yellow; } </style> <a href="https://webkit.org">WebKit website</a> <br> <a href="https://developer.mozilla.org/en-US/">MDN Web Docs</a> 2024019 10 rniwa 2024-03-26 14:29:41 -0700 I can reproduce this on STP189. 2025750 11 m_dubet 2024-04-03 11:30:35 -0700 Pull request: https://github.com/WebKit/WebKit/pull/26797 2038321 12 ews-feeder 2024-05-28 16:34:36 -0700 Committed 279411@main (e451a390febd): <https://commits.webkit.org/279411@main> Reviewed commits have been landed. Closing PR #26797 and removing active labels. 2038711 13 commit-queue 2024-05-30 00:20:26 -0700 Re-opened since this is blocked by bug 274889 95279 2011-05-28 19:26:55 -0700 2011-05-28 19:26:55 -0700 [REDUCTION] Test Case reduction.html text/html 239 joepeck PHN0eWxlPgphLm9uZTpsaW5rIHtjb2xvcjpyZWQ7fQphLm9uZTpob3ZlciB7Y29sb3I6cmVkO30K YS50d286bGluayB7Y29sb3I6Z3JlZW47fQphLnR3bzpob3ZlciB7Y29sb3I6cmVkO30KPC9zdHls ZT4KPGEgY2xhc3M9Im9uZSIgaHJlZj0iIj5XaHkgaXMgdGhpcyBub3QgcmVkIHdoZW4gaG92ZXJl ZD88L2E+PGJyPgo8YSBjbGFzcz0idHdvIiBocmVmPSIiPlRoaXMgaXMgcmVkIHdoZW4gaG92ZXJl ZC48L2E+PGJyPgo=