61687 2011-05-28 09:28:45 -0700 [Texmap][Qt] Disable accelerated plugins/media until they're working. 2011-05-30 12:07:53 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 1 noam webkit-unassigned ademar commit-queue kenneth laszlo.gombos oldest_to_newest 411855 0 noam 2011-05-28 09:28:45 -0700 This will allow us to enable texture mapper without causing regressions. 411856 1 95263 noam 2011-05-28 09:35:44 -0700 Created attachment 95263 Patch 412300 2 95263 commit-queue 2011-05-30 11:28:21 -0700 Comment on attachment 95263 Patch Clearing flags on attachment: 95263 Committed r87694: <http://trac.webkit.org/changeset/87694> 412301 3 commit-queue 2011-05-30 11:28:26 -0700 All reviewed patches have been landed. Closing bug. 412318 4 ademar 2011-05-30 12:04:14 -0700 The changelog reads: """ Until this works properly, we should indicate that our media implementation in texture mapper doesn't support accelerated compositing. This makes LayoutTests/compositing/video/* work again. """ Does it mean that the current implementation (as in qtwebkit-2.2, for example) is broken? I'm asking because if the plugins are broken with AC, then we better disable it on the branch as well (cherry-pick this commit). 412320 5 noam 2011-05-30 12:07:53 -0700 (In reply to comment #4) > The changelog reads: > > """ > Until this works properly, we should indicate that our media implementation in texture mapper doesn't support accelerated compositing. > > This makes LayoutTests/compositing/video/* work again. > """ > > Does it mean that the current implementation (as in qtwebkit-2.2, for example) is broken? I'm asking because if the plugins are broken with AC, then we better disable it on the branch as well (cherry-pick this commit). No, this is just for texture-mapper. Doesn't apply to the release branch :) 95263 2011-05-28 09:35:44 -0700 2011-05-30 11:28:21 -0700 Patch patch.diff text/plain 3866 noam ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjNGU3YWQ0Li45YzVkY2VkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDUtMjggIE5vYW0gUm9zZW50aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtUZXht YXBdW1F0XSBEaXNhYmxlIGFjY2VsZXJhdGVkIHBsdWdpbnMvbWVkaWEgdW50aWwgdGhleSdyZSB3 b3JraW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NjE2ODcKKworICAgICAgICBVbnRpbCB0aGlzIHdvcmtzIHByb3Blcmx5LCB3ZSBzaG91bGQgaW5k aWNhdGUgdGhhdCBvdXIgbWVkaWEgaW1wbGVtZW50YXRpb24KKyAgICAgICAgaW4gdGV4dHVyZSBt YXBwZXIgZG9lc24ndCBzdXBwb3J0IGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nLgorCisgICAgICAg IFRoaXMgbWFrZXMgTGF5b3V0VGVzdHMvY29tcG9zaXRpbmcvdmlkZW8vKiB3b3JrIGFnYWluLgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQcml2YXRlUXQuaDoK KyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZVF0OjpzdXBwb3J0c0FjY2VsZXJh dGVkUmVuZGVyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZVF0Ojpw bGF0Zm9ybUxheWVyKToKKwogMjAxMS0wNS0yNiAgRGF2aWQgTGV2aW4gIDxsZXZpbkBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRG1pdHJ5IFRpdG92LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQcml2YXRlUXQu aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L01lZGlhUGxheWVyUHJpdmF0 ZVF0LmgKaW5kZXggNDgxZmE4Ni4uNjdmNjRjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvcXQvTWVkaWFQbGF5ZXJQcml2YXRlUXQuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9NZWRpYVBsYXllclByaXZhdGVRdC5oCkBAIC0x MDMsMTEgKzEwMywxMSBAQCBwdWJsaWM6CiAjaWYgVVNFKEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5H KQogI2lmIFVTRShURVhUVVJFX01BUFBFUikKICAgICAvLyB3aGV0aGVyIGFjY2VsZXJhdGVkIHJl bmRlcmluZyBpcyBzdXBwb3J0ZWQgYnkgdGhlIG1lZGlhIGVuZ2luZSBmb3IgdGhlIGN1cnJlbnQg bWVkaWEuCi0gICAgdmlydHVhbCBib29sIHN1cHBvcnRzQWNjZWxlcmF0ZWRSZW5kZXJpbmcoKSBj b25zdCB7IHJldHVybiB0cnVlOyB9CisgICAgdmlydHVhbCBib29sIHN1cHBvcnRzQWNjZWxlcmF0 ZWRSZW5kZXJpbmcoKSBjb25zdCB7IHJldHVybiBmYWxzZTsgfQogICAgIC8vIGNhbGxlZCB3aGVu IHRoZSByZW5kZXJpbmcgc3lzdGVtIGZsaXBzIHRoZSBpbnRvIG9yIG91dCBvZiBhY2NlbGVyYXRl ZCByZW5kZXJpbmcgbW9kZS4KICAgICB2aXJ0dWFsIHZvaWQgYWNjZWxlcmF0ZWRSZW5kZXJpbmdT dGF0ZUNoYW5nZWQoKSB7IH0KICAgICAvLyBDb25zdC1jYXN0aW5nIGhlcmUgaXMgc2FmZSwgc2lu Y2UgYWxsIG9mIFRleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVyJ3MgZnVuY3Rpb25zIGFyZSBjb25z dC5nCi0gICAgdmlydHVhbCBQbGF0Zm9ybUxheWVyKiBwbGF0Zm9ybUxheWVyKCkgY29uc3QgeyBy ZXR1cm4gY29uc3RfY2FzdDxNZWRpYVBsYXllclByaXZhdGVRdCo+KHRoaXMpOyB9CisgICAgdmly dHVhbCBQbGF0Zm9ybUxheWVyKiBwbGF0Zm9ybUxheWVyKCkgY29uc3QgeyByZXR1cm4gMDsgfQog ICAgIHZpcnR1YWwgdm9pZCBwYWludFRvVGV4dHVyZU1hcHBlcihUZXh0dXJlTWFwcGVyKiwgY29u c3QgRmxvYXRSZWN0JiB0YXJnZXRSZWN0LCBjb25zdCBUcmFuc2Zvcm1hdGlvbk1hdHJpeCYsIGZs b2F0IG9wYWNpdHksIEJpdG1hcFRleHR1cmUqIG1hc2spIGNvbnN0OwogI2Vsc2UKICAgICB2aXJ0 dWFsIGJvb2wgc3VwcG9ydHNBY2NlbGVyYXRlZFJlbmRlcmluZygpIGNvbnN0IHsgcmV0dXJuIGZh bHNlOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3Bw IGIvU291cmNlL1dlYktpdC9xdC9BcGkvcXdlYnNldHRpbmdzLmNwcAppbmRleCA4ODBlZjQ5Li5j YTI1N2NkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0FwaS9xd2Vic2V0dGluZ3MuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvQXBpL3F3ZWJzZXR0aW5ncy5jcHAKQEAgLTE3Miw5ICsx NzIsMTMgQEAgdm9pZCBRV2ViU2V0dGluZ3NQcml2YXRlOjphcHBseSgpCiAgICAgICAgIHZhbHVl ID0gYXR0cmlidXRlcy52YWx1ZShRV2ViU2V0dGluZ3M6OkFjY2VsZXJhdGVkQ29tcG9zaXRpbmdF bmFibGVkLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBnbG9iYWwtPmF0 dHJpYnV0ZXMudmFsdWUoUVdlYlNldHRpbmdzOjpBY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxl ZCkpOwogCisgICAgICAgIHNldHRpbmdzLT5zZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nRW5hYmxl ZCh2YWx1ZSk7CiAgICAgICAgIHNldHRpbmdzLT5zZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nRm9y M0RUcmFuc2Zvcm1zRW5hYmxlZCh2YWx1ZSk7CiAgICAgICAgIHNldHRpbmdzLT5zZXRBY2NlbGVy YXRlZENvbXBvc2l0aW5nRm9yQW5pbWF0aW9uRW5hYmxlZCh2YWx1ZSk7Ci0gICAgICAgIHNldHRp bmdzLT5zZXRBY2NlbGVyYXRlZENvbXBvc2l0aW5nRm9yVmlkZW9FbmFibGVkKHZhbHVlKTsKKyNp ZiBVU0UoVEVYVFVSRV9NQVBQRVIpCisgICAgICAgIHNldHRpbmdzLT5zZXRBY2NlbGVyYXRlZENv bXBvc2l0aW5nRm9yVmlkZW9FbmFibGVkKGZhbHNlKTsKKyAgICAgICAgc2V0dGluZ3MtPnNldEFj Y2VsZXJhdGVkQ29tcG9zaXRpbmdGb3JQbHVnaW5zRW5hYmxlZChmYWxzZSk7CisjZW5kaWYKICNl bmRpZgogI2lmIEVOQUJMRShXRUJHTCkKICAgICAgICAgdmFsdWUgPSBhdHRyaWJ1dGVzLnZhbHVl KFFXZWJTZXR0aW5nczo6V2ViR0xFbmFibGVkLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9x dC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCA0MWE2YWMwLi40 NjZjMzYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA1LTI4ICBOb2Ft IFJvc2VudGhhbCAgPG5vYW0ucm9zZW50aGFsQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbVGV4bWFwXVtRdF0gRGlzYWJsZSBhY2Nl bGVyYXRlZCBwbHVnaW5zL21lZGlhIGluIHVudGlsIHRoZXkncmUgd29ya2luZy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxNjg3CisKKyAgICAgICAg VHVybiBvZmYgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgZm9yIG1lZGlhIGFuZCBwbHVnaW5zIHdo ZW4gaW4gdGV4dHVyZS1tYXBwZXIuCisKKyAgICAgICAgKiBBcGkvcXdlYnNldHRpbmdzLmNwcDoK KyAgICAgICAgKFFXZWJTZXR0aW5nc1ByaXZhdGU6OmFwcGx5KToKKwogMjAxMS0wNS0yNiAgQWxl eGlzIE1lbmFyZCAgPGFsZXhpcy5tZW5hcmRAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBVbnJl dmlld2VkIGJ1aWxkIGZpeCBmb3IgUXQgYW5kIFF1aWNrVGltZSBiYWNrZW5kLgo=