61679 2011-05-27 17:51:03 -0700 screen.width and screen.height are stale after screen resize on Chromium Linux 2011-05-31 17:51:46 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Minor --- 0 derat webkit-unassigned commit-queue tony oldest_to_newest 411740 0 derat 2011-05-27 17:51:03 -0700 On Chromium Linux, we currently use XDisplayWidth() and XDisplayHeight() to get the screen dimensions in WebScreenInfoFactory (this code is only used for Chrome OS; the Linux port calls it but then overwrites the data that it returns). These dimensions are stale after the screen is resized. I have a patch to make us instead query the root window's geometry each time. Even better would be using XRandR to query the monitor dimensions, but that's a more involved change. 411741 1 95236 derat 2011-05-27 17:58:45 -0700 Created attachment 95236 Patch 411743 2 95236 tony 2011-05-27 18:02:31 -0700 Comment on attachment 95236 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95236&action=review > Source/WebKit/chromium/src/x11/WebScreenInfoFactory.cpp:54 > + XGetGeometry( > + display, root, &rootRet, &x, &y, &width, &height, &border, &depth); Should you check the return status? 411745 3 derat 2011-05-27 18:08:06 -0700 I don't think it'd accomplish anything: 1. I think that it's impossible for this to fail, and (more importantly), 2. If it does fail, we'll get an error back from the X server and crash. Xlib return values are sort of a joke. :-( 413024 4 commit-queue 2011-05-31 17:42:07 -0700 The commit-queue encountered the following flaky tests while processing attachment 95236: http/tests/websocket/tests/handshake-fail-by-sub-protocol-mismatch.html bug 53809 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 413026 5 95236 commit-queue 2011-05-31 17:43:43 -0700 Comment on attachment 95236 Patch Clearing flags on attachment: 95236 Committed r87764: <http://trac.webkit.org/changeset/87764> 413027 6 commit-queue 2011-05-31 17:43:47 -0700 All reviewed patches have been landed. Closing bug. 413034 7 commit-queue 2011-05-31 17:51:46 -0700 The commit-queue encountered the following flaky tests while processing attachment 95236: http/tests/websocket/tests/error-detect.html bug 54012 (author: abarth@webkit.org) The commit-queue is continuing to process your patch. 95236 2011-05-27 17:58:45 -0700 2011-05-31 17:43:43 -0700 Patch bug-61679-20110527175844.patch text/plain 3777 derat U3VidmVyc2lvbiBSZXZpc2lvbjogODc0MTgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg YmNlNzI1M2YzNjVhMjY1ZmFmZmU5YjIxZGUxMmMxYjE5NTA0ZmJkOS4uYzFmNWQ2MTkzNzc1NDFm Y2U1OGZlYzJiMDQyYzE2MDY4MjkwZDE5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAxMS0wNS0yNyAgRGFuaWVsIEVyYXQgIDxkZXJhdEBjaHJvbWl1bS5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFr ZSBXZWJTY3JlZW5JbmZvRmFjdG9yeSByZXR1cm4gZnJlc2ggc2NyZWVuIGRpbWVuc2lvbnMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTY3OQorCisg ICAgICAgICogcHVibGljL3gxMS9XZWJTY3JlZW5JbmZvRmFjdG9yeS5oOgorICAgICAgICAqIHNy Yy94MTEvV2ViU2NyZWVuSW5mb0ZhY3RvcnkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJTY3Jl ZW5JbmZvRmFjdG9yeTo6c2NyZWVuSW5mbyk6CisKIDIwMTEtMDUtMjYgIFNhaWxlc2ggQWdyYXdh bCAgPHNhaWxAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgQ2hhbmcu CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy94MTEvV2ViU2NyZWVu SW5mb0ZhY3RvcnkuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL3gxMS9XZWJTY3Jl ZW5JbmZvRmFjdG9yeS5oCmluZGV4IDVlMzBkYThmYjI2ZmMyMjE2Njk2MDM4OTU3ZDBlNWQ2YmQy YWE3OGUuLjViNDQ4NjhjYzViNjA0NTFkMjY5MDQ3NTkzODMxOTRlMDZmYTk5NzYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL3gxMS9XZWJTY3JlZW5JbmZvRmFjdG9y eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL3gxMS9XZWJTY3JlZW5JbmZv RmFjdG9yeS5oCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAoQykgMjAwOSBHb29n bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDExIEdvb2ds ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMgYXJlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy94MTEvV2ViU2Ny ZWVuSW5mb0ZhY3RvcnkuY3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMveDExL1dlYlNj cmVlbkluZm9GYWN0b3J5LmNwcAppbmRleCA1NDg4ODBjZmM5NjdlZDBhMjA1OGI5NzVhY2QyMWQ1 ZDliMzlhNDY3Li43ZTFmOTZlY2UwYTgwNzQ5NmMwMjI0M2YwYWJjMGIzOTZmYjg0NzhkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy94MTEvV2ViU2NyZWVuSW5mb0ZhY3Rv cnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL3gxMS9XZWJTY3JlZW5JbmZv RmFjdG9yeS5jcHAKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDA5IEdv b2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTEgR29v Z2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQg dXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1vZGlm aWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0 aW9ucyBhcmUKQEAgLTM3LDIyICszNywyOSBAQAogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAorLy8g RklYTUU6IFRha2UgYW4gWCB3aW5kb3cgYW5kIHVzZSBYUmFuZFIgdG8gZmluZCB0aGUgZGltZW5z aW9ucyBvZiB0aGUgbW9uaXRvcgorLy8gdGhhdCBpdCdzIG9uIChwcm9iYWJseSB1c2luZyBYUlJH ZXRTY3JlZW5JbmZvKCkgYW5kIFhSUkNvbmZpZ1NpemVzKCkgZnJvbQorLy8gWDExL2V4dGVuc2lv bnMvWHJhbmRyLmgpLiBHREsgcHJvdmlkZXMgYSBnZGtfc2NyZWVuX2dldF9tb25pdG9yX2dlb21l dHJ5KCkKKy8vIGZ1bmN0aW9uLCBidXQgaXQgYXBwZWFycyB0byByZXR1cm4gc3RhbGUgZGF0YSBh ZnRlciB0aGUgc2NyZWVuIGlzIHJlc2l6ZWQuCiBXZWJTY3JlZW5JbmZvIFdlYlNjcmVlbkluZm9G YWN0b3J5OjpzY3JlZW5JbmZvKERpc3BsYXkqIGRpc3BsYXksIGludCBzY3JlZW5OdW1iZXIpCiB7 CisgICAgLy8gWERpc3BsYXlXaWR0aCgpIGFuZCBYRGlzcGxheUhlaWdodCgpIHJldHVybiBjYWNo ZWQgdmFsdWVzLiBUbyBlbnN1cmUgdGhhdAorICAgIC8vIHdlIHJldHVybiB0aGUgY29ycmVjdCBk aW1lbnNpb25zIGFmdGVyIHRoZSBzY3JlZW4gaXMgcmVzaXplZCwgcXVlcnkgdGhlCisgICAgLy8g cm9vdCB3aW5kb3cncyBnZW9tZXRyeSBlYWNoIHRpbWUuCisgICAgV2luZG93IHJvb3QgPSBSb290 V2luZG93KGRpc3BsYXksIHNjcmVlbk51bWJlcik7CisgICAgV2luZG93IHJvb3RSZXQ7CisgICAg aW50IHgsIHk7CisgICAgdW5zaWduZWQgaW50IHdpZHRoLCBoZWlnaHQsIGJvcmRlciwgZGVwdGg7 CisgICAgWEdldEdlb21ldHJ5KAorICAgICAgICBkaXNwbGF5LCByb290LCAmcm9vdFJldCwgJngs ICZ5LCAmd2lkdGgsICZoZWlnaHQsICZib3JkZXIsICZkZXB0aCk7CisKICAgICBXZWJTY3JlZW5J bmZvIHJlc3VsdHM7Ci0gICAgLy8gRklYTUU6IG5vdCBhbGwgc2NyZWVucyB3aXRoIHVzZSA4YnBw LgorICAgIC8vIEZJWE1FOiBOb3QgYWxsIHNjcmVlbnMgdXNlIDhicHAuCiAgICAgcmVzdWx0cy5k ZXB0aFBlckNvbXBvbmVudCA9IDg7Ci0KLSAgICBpbnQgZGlzcGxheVdpZHRoID0gWERpc3BsYXlX aWR0aChkaXNwbGF5LCBzY3JlZW5OdW1iZXIpOwotICAgIGludCBkaXNwbGF5SGVpZ2h0ID0gWERp c3BsYXlIZWlnaHQoZGlzcGxheSwgc2NyZWVuTnVtYmVyKTsKLSAgICByZXN1bHRzLmRlcHRoID0g WERpc3BsYXlQbGFuZXMoZGlzcGxheSwgc2NyZWVuTnVtYmVyKTsKLSAgICByZXN1bHRzLmlzTW9u b2Nocm9tZSA9IHJlc3VsdHMuZGVwdGggPT0gMTsKLQotICAgIHJlc3VsdHMucmVjdCA9IFdlYlJl Y3QoMCwgMCwgZGlzcGxheVdpZHRoLCBkaXNwbGF5SGVpZ2h0KTsKLQotICAgIC8vIEkgZG9uJ3Qg a25vdyBvZiBhIHdheSB0byBxdWVyeSB0aGUgIm1heGltaXplIiBzaXplIG9mIHRoZSB3aW5kb3cg KGUuZy4KLSAgICAvLyBzY3JlZW4gc2l6ZSBsZXNzIHNpZGViYXJzIGV0Yykgc2luY2UgdGhpcyBp cyBzb21ldGhpbmcgd2hpY2ggb25seSB0aGUKLSAgICAvLyB3aW5kb3cgbWFuYWdlciBrbm93cy4K KyAgICByZXN1bHRzLmRlcHRoID0gZGVwdGg7CisgICAgcmVzdWx0cy5pc01vbm9jaHJvbWUgPSBk ZXB0aCA9PSAxOworICAgIHJlc3VsdHMucmVjdCA9IFdlYlJlY3QoeCwgeSwgd2lkdGgsIGhlaWdo dCk7CisgICAgLy8gRklYTUU6IFF1ZXJ5IHRoZSBfTkVUX1dPUktBUkVBIHByb3BlcnR5IGZyb20g RVdNSC4KICAgICByZXN1bHRzLmF2YWlsYWJsZVJlY3QgPSByZXN1bHRzLnJlY3Q7CiAKICAgICBy ZXR1cm4gcmVzdWx0czsK