61678 2011-05-27 17:16:40 -0700 JS API is too aggressive about throwing exceptions for NULL get or set operations 2011-05-27 17:29:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren oliver webkit.review.bot oldest_to_newest 411729 0 ggaren 2011-05-27 17:16:40 -0700 JS API is too aggressive about throwing exceptions for NULL get or set operations 411730 1 95233 ggaren 2011-05-27 17:19:50 -0700 Created attachment 95233 Patch 411732 2 ggaren 2011-05-27 17:20:25 -0700 <rdar://problem/9518965> 411736 3 webkit.review.bot 2011-05-27 17:22:48 -0700 Attachment 95233 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSCallbackObject..." exit_code: 1 Source/JavaScriptCore/API/tests/testapi.c:314: MyObject_set_nullGetForwardSet is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 411737 4 ggaren 2011-05-27 17:29:00 -0700 Committed r87588: <http://trac.webkit.org/changeset/87588> 95233 2011-05-27 17:19:50 -0700 2011-05-27 17:26:47 -0700 Patch bug-61678-20110527171949.patch text/plain 6422 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODc1ODYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAK KzIwMTEtMDUtMjcgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBKUyBBUEkgaXMgdG9vIGFn Z3Jlc3NpdmUgYWJvdXQgdGhyb3dpbmcgZXhjZXB0aW9ucyBmb3IgTlVMTCBnZXQgb3Igc2V0IG9w ZXJhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTYxNjc4CisKKyAgICAgICAgKiBBUEkvSlNDYWxsYmFja09iamVjdC5oOiBDaGFuZ2VkIG91ciBz dGF0aWNWYWx1ZUdldHRlciB0byBhIHJlZ3VsYXIKKyAgICAgICAgZnVuY3Rpb24gdGhhdCByZXR1 cm5zIGEgSlNWYWx1ZSwgc28gaXQgY2FuIGZhaWwgYW5kIHN0aWxsIGZvcndhcmQgdG8KKyAgICAg ICAgbm9ybWFsIHByb3BlcnR5IGxvb2t1cC4KKworICAgICAgICAqIEFQSS9KU0NhbGxiYWNrT2Jq ZWN0RnVuY3Rpb25zLmg6CisgICAgICAgIChKU0M6Ojo6Z2V0T3duUHJvcGVydHlTbG90KTogRG9u J3QgdGhyb3cgYW4gZXhjZXB0aW9uIHdoZW4gZmFpbGluZyB0bworICAgICAgICBhY2Nlc3MgYSBz dGF0aWMgcHJvcGVydHkgLS0ganVzdCBmb3J3YXJkIHRoZSBhY2Nlc3MuIFRoaXMgYWxsb3dzIG9i amVjdHMKKyAgICAgICAgdG8gb2JzZXJ2ZSBnZXQvc2V0IG9wZXJhdGlvbnMgYnV0IHN0aWxsIGxl dCB0aGUgSlMgb2JqZWN0IG1hbmFnZSBsaWZldGltZS4KKworICAgICAgICAoSlNDOjo6OnB1dCk6 IERpdHRvLgorCisgICAgICAgIChKU0M6Ojo6Z2V0U3RhdGljVmFsdWUpOiBTYW1lIGFzIEpTQ2Fs bGJhY2tPYmplY3QuaC4KKworICAgICAgICAqIEFQSS90ZXN0cy90ZXN0YXBpLmM6CisgICAgICAg IChNeU9iamVjdF9zZXRfbnVsbEdldEZvcndhcmRTZXQpOgorICAgICAgICAqIEFQSS90ZXN0cy90 ZXN0YXBpLmpzOiBVcGRhdGVkIHRlc3RzIHRvIHJlZmxlY3Qgc2xpZ2h0bHkgbGVzcyBzdHJpY3QK KyAgICAgICAgYmVoYXZpb3IsIHdoaWNoIG1hdGNoZXMgaGVhZGVyZG9jIGNsYWltcy4KKwogMjAx MS0wNS0yNyAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IE9saXZlciBIdW50LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9K U0NhbGxiYWNrT2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQ SS9KU0NhbGxiYWNrT2JqZWN0LmgJKHJldmlzaW9uIDg3NTg2KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL0FQSS9KU0NhbGxiYWNrT2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTE4OCw3ICsx ODgsNyBAQCBwcml2YXRlOgogICAgIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxM IGNhbGwoRXhlY1N0YXRlKik7CiAgICAgc3RhdGljIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NB TEwgY29uc3RydWN0KEV4ZWNTdGF0ZSopOwogICAgCi0gICAgc3RhdGljIEpTVmFsdWUgc3RhdGlj VmFsdWVHZXR0ZXIoRXhlY1N0YXRlKiwgSlNWYWx1ZSwgY29uc3QgSWRlbnRpZmllciYpOworICAg IEpTVmFsdWUgZ2V0U3RhdGljVmFsdWUoRXhlY1N0YXRlKiwgY29uc3QgSWRlbnRpZmllciYpOwog ICAgIHN0YXRpYyBKU1ZhbHVlIHN0YXRpY0Z1bmN0aW9uR2V0dGVyKEV4ZWNTdGF0ZSosIEpTVmFs dWUsIGNvbnN0IElkZW50aWZpZXImKTsKICAgICBzdGF0aWMgSlNWYWx1ZSBjYWxsYmFja0dldHRl cihFeGVjU3RhdGUqLCBKU1ZhbHVlLCBjb25zdCBJZGVudGlmaWVyJik7CiAKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDYWxsYmFja09iamVjdEZ1bmN0aW9ucy5oCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDYWxsYmFja09iamVjdEZ1bmN0aW9u cy5oCShyZXZpc2lvbiA4NzU4NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDYWxs YmFja09iamVjdEZ1bmN0aW9ucy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDksOCArMTQ5LDExIEBA IGJvb2wgSlNDYWxsYmFja09iamVjdDxCYXNlPjo6Z2V0T3duUHJvcGUKICAgICAgICAgCiAgICAg ICAgIGlmIChPcGFxdWVKU0NsYXNzU3RhdGljVmFsdWVzVGFibGUqIHN0YXRpY1ZhbHVlcyA9IGpz Q2xhc3MtPnN0YXRpY1ZhbHVlcyhleGVjKSkgewogICAgICAgICAgICAgaWYgKHN0YXRpY1ZhbHVl cy0+Y29udGFpbnMocHJvcGVydHlOYW1lLmltcGwoKSkpIHsKLSAgICAgICAgICAgICAgICBzbG90 LnNldEN1c3RvbSh0aGlzLCBzdGF0aWNWYWx1ZUdldHRlcik7Ci0gICAgICAgICAgICAgICAgcmV0 dXJuIHRydWU7CisgICAgICAgICAgICAgICAgSlNWYWx1ZSB2YWx1ZSA9IGdldFN0YXRpY1ZhbHVl KGV4ZWMsIHByb3BlcnR5TmFtZSk7CisgICAgICAgICAgICAgICAgaWYgKHZhbHVlKSB7CisgICAg ICAgICAgICAgICAgICAgIHNsb3Quc2V0VmFsdWUodmFsdWUpOworICAgICAgICAgICAgICAgICAg ICByZXR1cm4gdHJ1ZTsKKyAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAg IH0KICAgICAgICAgCkBAIC0yMjUsOCArMjI4LDcgQEAgdm9pZCBKU0NhbGxiYWNrT2JqZWN0PEJh c2U+OjpwdXQoRXhlY1N0YQogICAgICAgICAgICAgICAgICAgICAgICAgdGhyb3dFcnJvcihleGVj LCB0b0pTKGV4ZWMsIGV4Y2VwdGlvbikpOwogICAgICAgICAgICAgICAgICAgICBpZiAocmVzdWx0 IHx8IGV4Y2VwdGlvbikKICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAg ICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgICAgICAgICAgdGhyb3dFcnJvcihleGVjLCBjcmVh dGVSZWZlcmVuY2VFcnJvcihleGVjLCAiQXR0ZW1wdCB0byBzZXQgYSBwcm9wZXJ0eSB0aGF0IGlz IG5vdCBzZXR0YWJsZS4iKSk7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogICAg ICAgICB9CiAgICAgICAgIApAQCAtNTE1LDE0ICs1MTcsMTIgQEAgYm9vbCBKU0NhbGxiYWNrT2Jq ZWN0PEJhc2U+Ojppbmhlcml0cyhKUwogfQogCiB0ZW1wbGF0ZSA8Y2xhc3MgQmFzZT4KLUpTVmFs dWUgSlNDYWxsYmFja09iamVjdDxCYXNlPjo6c3RhdGljVmFsdWVHZXR0ZXIoRXhlY1N0YXRlKiBl eGVjLCBKU1ZhbHVlIHNsb3RCYXNlLCBjb25zdCBJZGVudGlmaWVyJiBwcm9wZXJ0eU5hbWUpCitK U1ZhbHVlIEpTQ2FsbGJhY2tPYmplY3Q8QmFzZT46OmdldFN0YXRpY1ZhbHVlKEV4ZWNTdGF0ZSog ZXhlYywgY29uc3QgSWRlbnRpZmllciYgcHJvcGVydHlOYW1lKQogewotICAgIEpTQ2FsbGJhY2tP YmplY3QqIHRoaXNPYmogPSBhc0NhbGxiYWNrT2JqZWN0KHNsb3RCYXNlKTsKLSAgICAKLSAgICBK U09iamVjdFJlZiB0aGlzUmVmID0gdG9SZWYodGhpc09iaik7CisgICAgSlNPYmplY3RSZWYgdGhp c1JlZiA9IHRvUmVmKHRoaXMpOwogICAgIFJlZlB0cjxPcGFxdWVKU1N0cmluZz4gcHJvcGVydHlO YW1lUmVmOwogICAgIAotICAgIGZvciAoSlNDbGFzc1JlZiBqc0NsYXNzID0gdGhpc09iai0+Y2xh c3NSZWYoKTsganNDbGFzczsganNDbGFzcyA9IGpzQ2xhc3MtPnBhcmVudENsYXNzKQorICAgIGZv ciAoSlNDbGFzc1JlZiBqc0NsYXNzID0gY2xhc3NSZWYoKTsganNDbGFzczsganNDbGFzcyA9IGpz Q2xhc3MtPnBhcmVudENsYXNzKQogICAgICAgICBpZiAoT3BhcXVlSlNDbGFzc1N0YXRpY1ZhbHVl c1RhYmxlKiBzdGF0aWNWYWx1ZXMgPSBqc0NsYXNzLT5zdGF0aWNWYWx1ZXMoZXhlYykpCiAgICAg ICAgICAgICBpZiAoU3RhdGljVmFsdWVFbnRyeSogZW50cnkgPSBzdGF0aWNWYWx1ZXMtPmdldChw cm9wZXJ0eU5hbWUuaW1wbCgpKSkKICAgICAgICAgICAgICAgICBpZiAoSlNPYmplY3RHZXRQcm9w ZXJ0eUNhbGxiYWNrIGdldFByb3BlcnR5ID0gZW50cnktPmdldFByb3BlcnR5KSB7CkBAIC01NDIs NyArNTQyLDcgQEAgSlNWYWx1ZSBKU0NhbGxiYWNrT2JqZWN0PEJhc2U+OjpzdGF0aWNWYQogICAg ICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIHRvSlMoZXhlYywgdmFsdWUpOwogICAgICAgICAg ICAgICAgIH0KIAotICAgIHJldHVybiB0aHJvd0Vycm9yKGV4ZWMsIGNyZWF0ZVJlZmVyZW5jZUVy cm9yKGV4ZWMsICJTdGF0aWMgdmFsdWUgcHJvcGVydHkgZGVmaW5lZCB3aXRoIE5VTEwgZ2V0UHJv cGVydHkgY2FsbGJhY2suIikpOworICAgIHJldHVybiBKU1ZhbHVlKCk7CiB9CiAKIHRlbXBsYXRl IDxjbGFzcyBCYXNlPgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0 YXBpLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90ZXN0 YXBpLmMJKHJldmlzaW9uIDg3NTg2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0 cy90ZXN0YXBpLmMJKHdvcmtpbmcgY29weSkKQEAgLTMxMSw4ICszMTEsMTkgQEAgc3RhdGljIEpT VmFsdWVSZWYgTXlPYmplY3RfY29udmVydFRvVHlwZQogICAgIHJldHVybiBKU1ZhbHVlTWFrZU51 bGwoY29udGV4dCk7CiB9CiAKK3N0YXRpYyBib29sIE15T2JqZWN0X3NldF9udWxsR2V0Rm9yd2Fy ZFNldChKU0NvbnRleHRSZWYgY3R4LCBKU09iamVjdFJlZiBvYmplY3QsIEpTU3RyaW5nUmVmIHBy b3BlcnR5TmFtZSwgSlNWYWx1ZVJlZiB2YWx1ZSwgSlNWYWx1ZVJlZiogZXhjZXB0aW9uKQorewor ICAgIFVOVVNFRF9QQVJBTShjdHgpOworICAgIFVOVVNFRF9QQVJBTShvYmplY3QpOworICAgIFVO VVNFRF9QQVJBTShwcm9wZXJ0eU5hbWUpOworICAgIFVOVVNFRF9QQVJBTSh2YWx1ZSk7CisgICAg VU5VU0VEX1BBUkFNKGV4Y2VwdGlvbik7CisgICAgcmV0dXJuIGZhbHNlOyAvLyBGb3J3YXJkIHRv IHBhcmVudCBjbGFzcy4KK30KKwogc3RhdGljIEpTU3RhdGljVmFsdWUgZXZpbFN0YXRpY1ZhbHVl c1tdID0gewogICAgIHsgIm51bGxHZXRTZXQiLCAwLCAwLCBrSlNQcm9wZXJ0eUF0dHJpYnV0ZU5v bmUgfSwKKyAgICB7ICJudWxsR2V0Rm9yd2FyZFNldCIsIDAsIE15T2JqZWN0X3NldF9udWxsR2V0 Rm9yd2FyZFNldCwga0pTUHJvcGVydHlBdHRyaWJ1dGVOb25lIH0sCiAgICAgeyAwLCAwLCAwLCAw IH0KIH07CiAKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvdGVzdHMvdGVzdGFwaS5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL3Rlc3RzL3Rlc3RhcGku anMJKHJldmlzaW9uIDg3NTg2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS90ZXN0cy90 ZXN0YXBpLmpzCSh3b3JraW5nIGNvcHkpCkBAIC05NCw2ICs5NCw5IEBAIHNob3VsZEJlKCJNeU9i amVjdCgndGhyb3dPbkNhbGwnKSIsICJhbiAKIHNob3VsZEJlKCJuZXcgTXlPYmplY3QoJ3Rocm93 T25Db25zdHJ1Y3QnKSIsICJhbiBleGNlcHRpb24iKTsKIHNob3VsZEJlKCIndGhyb3dPbkhhc0lu c3RhbmNlJyBpbnN0YW5jZW9mIE15T2JqZWN0IiwgImFuIGV4Y2VwdGlvbiIpOwogCitNeU9iamVj dC5udWxsR2V0Rm9yd2FyZFNldCA9IDE7CitzaG91bGRCZSgiTXlPYmplY3QubnVsbEdldEZvcndh cmRTZXQiLCAxKTsKKwogdmFyIGZvdW5kTXlQcm9wZXJ0eU5hbWUgPSBmYWxzZTsKIHZhciBmb3Vu ZFJlZ3VsYXJUeXBlID0gZmFsc2U7CiBmb3IgKHZhciBwIGluIE15T2JqZWN0KSB7CkBAIC0xNjIs OCArMTY1LDggQEAgc2hvdWxkQmUoImNvbnN0cnVjdGVkT2JqZWN0LnZhbHVlIiwgMSk7CiBzaG91 bGRCZSgibXlPYmplY3QgaW5zdGFuY2VvZiBNeU9iamVjdCIsIHRydWUpOwogc2hvdWxkQmUoIihu ZXcgT2JqZWN0KCkpIGluc3RhbmNlb2YgTXlPYmplY3QiLCBmYWxzZSk7CiAKLXNob3VsZFRocm93 KCJNeU9iamVjdC5udWxsR2V0U2V0ID0gMSIpOwotc2hvdWxkVGhyb3coIk15T2JqZWN0Lm51bGxH ZXRTZXQiKTsKK015T2JqZWN0Lm51bGxHZXRTZXQgPSAxOworc2hvdWxkQmUoIk15T2JqZWN0Lm51 bGxHZXRTZXQiLCAxKTsKIHNob3VsZFRocm93KCJNeU9iamVjdC5udWxsQ2FsbCgpIik7CiBzaG91 bGRUaHJvdygiTXlPYmplY3QuaGFzUHJvcGVydHlMaWUiKTsKIAo=