6167 2005-12-20 09:24:32 -0800 RenderStyle default constructor should initialize its members for speed 2005-12-22 08:45:18 -0800 1 1 1 Unclassified WebKit CSS 420+ Mac OS X 10.4 RESOLVED FIXED P2 Enhancement --- 1 darin darin hyatt mjs oldest_to_newest 26272 0 darin 2005-12-20 09:24:32 -0800 The default constructor for RenderStyle doesn't initialize its members. Instead it lets them all get default initialized and then uses assignment to set their initial values. This results in extra code because of the DataRef operator= implementation. Also, DataRef's operator= should have the "==" check removed since that extra branch makes things a little slower. 26340 1 5215 darin 2005-12-21 22:47:47 -0800 Created attachment 5215 both performance improvements described in the bug text 26342 2 5216 darin 2005-12-21 22:51:25 -0800 Created attachment 5216 both performance improvements described in the bug text 26347 3 5215 eric 2005-12-22 01:32:00 -0800 Comment on attachment 5215 both performance improvements described in the bug text Another great looking patch. I assume this is a performance win? r=me. 26349 4 5215 eric 2005-12-22 01:38:39 -0800 Comment on attachment 5215 both performance improvements described in the bug text oops, wrong one. 26350 5 5216 eric 2005-12-22 01:39:01 -0800 Comment on attachment 5216 both performance improvements described in the bug text r=me. It looks like void RenderStyle::cleanup() could just be killed entirely now. 26378 6 darin 2005-12-22 08:32:22 -0800 I left the cleanup function in there because Maciej has the commented-out counts in it. I would have removed it entirely if that wasn't there. 5215 2005-12-21 22:47:47 -0800 2005-12-22 01:38:39 -0800 both performance improvements described in the bug text FasterRenderStyleConstructionPatch.txt text/plain 4875 darin SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9D aGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjMKZGlmZiAtcCAtdSAtcjEuMjMgQ2hh bmdlTG9nCi0tLSBDaGFuZ2VMb2cJMjIgRGVjIDIwMDUgMDQ6MTE6MzUgLTAwMDAJMS4yMworKysg Q2hhbmdlTG9nCTIyIERlYyAyMDA1IDA2OjQ4OjAyIC0wMDAwCkBAIC0xLDUgKzEsMjMgQEAKIDIw MDUtMTItMjEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0dHA6Ly9idWd6aWxsYS5v cGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE2NworICAgICAgICAgIFJlbmRlclN0eWxl IGRlZmF1bHQgY29uc3RydWN0b3Igc2hvdWxkIGluaXRpYWxpemUgaXRzIG1lbWJlcnMgZm9yIHNw ZWVkCisKKyAgICAgICAgKiBraHRtbC9yZW5kZXJpbmcvRGF0YVJlZi5oOiAoa2h0bWw6OkRhdGFS ZWY6Om9wZXJhdG9yPSk6IEVsaW1pbmF0ZSBhbiBleHRyYQorICAgICAgICBicmFuY2ggYnkgZG9p bmcgcmVmIGJlZm9yZSBkZXJlZiBpbnN0ZWFkIG9mID09IGNoZWNrLgorCisgICAgICAgICoga2h0 bWwvcmVuZGVyaW5nL3JlbmRlcl9zdHlsZS5jcHA6CisgICAgICAgIChraHRtbDo6aW5pdERlZmF1 bHRTdHlsZSk6IEFkZGVkLiBGdW5jdGlvbiB0byBpbml0aWFsaXplIHRoZSBkZWZhdWx0IHN0eWxl CisgICAgICAgIGZvciB1c2UgaW4gY29uc3RydWN0b3IuCisgICAgICAgIChraHRtbDo6UmVuZGVy U3R5bGU6OlJlbmRlclN0eWxlKTogQ2hhbmdlZCBjb25zdHJ1Y3RvciB0byBpbml0YWxpemUgYWxs IHRoZQorICAgICAgICBtZW1iZXJzIHdpdGggY29uc3RydWN0b3Igc3ludGF4IGluc3RlYWQgb2Yg dXNpbmcgYXNzaWdubWVudCBvbiBhbGwgb2YgdGhlbS4KKyAgICAgICAgKiBraHRtbC9yZW5kZXJp bmcvcmVuZGVyX3N0eWxlLmg6IFJlbW92ZWQgc3RhdGljIGRhdGEgbWVtYmVyIF9kZWZhdWx0IC0t CisgICAgICAgIGl0J3Mgbm93IGEgZmlsZSBzY29wZSBnbG9iYWwgaW5zdGVhZC4KKworMjAwNS0x Mi0yMSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQg YnkgSnVzdGluLgogCiAgICAgICAgIC0gZml4IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjE0MgpJbmRleDoga2h0bWwvcmVuZGVyaW5nL0RhdGFSZWYuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvRGF0 YVJlZi5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIKZGlmZiAtcCAtdSAtcjEuMiBraHRtbC9y ZW5kZXJpbmcvRGF0YVJlZi5oCi0tLSBraHRtbC9yZW5kZXJpbmcvRGF0YVJlZi5oCTExIERlYyAy MDA1IDA5OjI2OjEzIC0wMDAwCTEuMgorKysga2h0bWwvcmVuZGVyaW5nL0RhdGFSZWYuaAkyMiBE ZWMgMjAwNSAwNjo0ODoyMSAtMDAwMApAQCAtNzUsMTMgKzc1LDEwIEBAIHB1YmxpYzoKIAogICAg IERhdGFSZWY8REFUQT4mIG9wZXJhdG9yPShjb25zdCBEYXRhUmVmPERBVEE+JiBkKQogICAgIHsK LSAgICAJaWYgKG1fZGF0YSA9PSBkLm1fZGF0YSkKLQkgICAgcmV0dXJuICp0aGlzOworCWQubV9k YXRhLT5yZWYoKTsKICAgICAJaWYgKG1fZGF0YSkKICAgICAJICAgIG1fZGF0YS0+ZGVyZWYoKTsK ICAgICAJbV9kYXRhID0gZC5tX2RhdGE7Ci0JbV9kYXRhLT5yZWYoKTsKLQogCXJldHVybiAqdGhp czsKICAgICB9CiAKSW5kZXg6IGtodG1sL3JlbmRlcmluZy9yZW5kZXJfc3R5bGUuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJf c3R5bGUuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjc5CmRpZmYgLXAgLXUgLXIxLjc5IGto dG1sL3JlbmRlcmluZy9yZW5kZXJfc3R5bGUuY3BwCi0tLSBraHRtbC9yZW5kZXJpbmcvcmVuZGVy X3N0eWxlLmNwcAkxMSBEZWMgMjAwNSAwOToyNjoxNSAtMDAwMAkxLjc5CisrKyBraHRtbC9yZW5k ZXJpbmcvcmVuZGVyX3N0eWxlLmNwcAkyMiBEZWMgMjAwNSAwNjo0ODoyMiAtMDAwMApAQCAtMzQs MTAgKzM0LDExIEBACiAKICNpbmNsdWRlICJrZGVidWcuaCIKIAotdXNpbmcgbmFtZXNwYWNlIGto dG1sOwordXNpbmcgbmFtZXNwYWNlIERPTTsKIAotdXNpbmcgRE9NOjpET01TdHJpbmdJbXBsOwot dXNpbmcgRE9NOjpET01TdHJpbmc7CituYW1lc3BhY2Uga2h0bWwgeworCitzdGF0aWMgUmVuZGVy U3R5bGUgKmRlZmF1bHRTdHlsZTsKIAogU3R5bGVTdXJyb3VuZERhdGE6OlN0eWxlU3Vycm91bmRE YXRhKCkKICAgICA6IG1hcmdpbiggRml4ZWQgKSwgcGFkZGluZyggQXV0byApCkBAIC01MTIsMzEg KzUxMywzMiBAQCB2b2lkIFJlbmRlclN0eWxlOjphcmVuYURlbGV0ZShSZW5kZXJBcmVuCiAgICAg YXJlbmEtPmZyZWUoKihzaXplX3QgKil0aGlzLCB0aGlzKTsKIH0KIAotUmVuZGVyU3R5bGU6OlJl bmRlclN0eWxlKCkKLTptX3BzZXVkb1N0YXRlKFBzZXVkb1Vua25vd24pLCBtX2FmZmVjdGVkQnlB dHRyaWJ1dGVTZWxlY3RvcnMoZmFsc2UpCitpbmxpbmUgUmVuZGVyU3R5bGUgKmluaXREZWZhdWx0 U3R5bGUoKQogewotICAgIG1fcmVmID0gMDsKLSAgICAKLSAgICBpZiAoIV9kZWZhdWx0KQotCV9k ZWZhdWx0ID0gOjpuZXcgUmVuZGVyU3R5bGUodHJ1ZSk7Ci0KLSAgICBib3ggPSBfZGVmYXVsdC0+ Ym94OwotICAgIHZpc3VhbCA9IF9kZWZhdWx0LT52aXN1YWw7Ci0gICAgYmFja2dyb3VuZCA9IF9k ZWZhdWx0LT5iYWNrZ3JvdW5kOwotICAgIHN1cnJvdW5kID0gX2RlZmF1bHQtPnN1cnJvdW5kOwot ICAgIGNzczNOb25Jbmhlcml0ZWREYXRhID0gX2RlZmF1bHQtPmNzczNOb25Jbmhlcml0ZWREYXRh OwotICAgIGNzczNJbmhlcml0ZWREYXRhID0gX2RlZmF1bHQtPmNzczNJbmhlcml0ZWREYXRhOwot ICAgIAotICAgIGluaGVyaXRlZCA9IF9kZWZhdWx0LT5pbmhlcml0ZWQ7CisgICAgaWYgKCFkZWZh dWx0U3R5bGUpCisgICAgICAgIGRlZmF1bHRTdHlsZSA9IG5ldyBSZW5kZXJTdHlsZSh0cnVlKTsK KyAgICByZXR1cm4gZGVmYXVsdFN0eWxlOworfQogCitSZW5kZXJTdHlsZTo6UmVuZGVyU3R5bGUo KQorICAgIDogYm94KGluaXREZWZhdWx0U3R5bGUoKS0+Ym94KQorICAgICwgdmlzdWFsKGRlZmF1 bHRTdHlsZS0+dmlzdWFsKQorICAgICwgYmFja2dyb3VuZChkZWZhdWx0U3R5bGUtPmJhY2tncm91 bmQpCisgICAgLCBzdXJyb3VuZChkZWZhdWx0U3R5bGUtPnN1cnJvdW5kKQorICAgICwgY3NzM05v bkluaGVyaXRlZERhdGEoZGVmYXVsdFN0eWxlLT5jc3MzTm9uSW5oZXJpdGVkRGF0YSkKKyAgICAs IGNzczNJbmhlcml0ZWREYXRhKGRlZmF1bHRTdHlsZS0+Y3NzM0luaGVyaXRlZERhdGEpCisgICAg LCBpbmhlcml0ZWQoZGVmYXVsdFN0eWxlLT5pbmhlcml0ZWQpCisgICAgLCBwc2V1ZG9TdHlsZSgw KQorICAgICwgY29udGVudCgwKQorICAgICwgbV9wc2V1ZG9TdGF0ZShQc2V1ZG9Vbmtub3duKQor ICAgICwgbV9hZmZlY3RlZEJ5QXR0cmlidXRlU2VsZWN0b3JzKGZhbHNlKQorICAgICwgbV9yZWYo MCkKICNpZiBTVkdfU1VQUE9SVAotICAgIG1fc3ZnU3R5bGUgPSBfZGVmYXVsdC0+bV9zdmdTdHls ZTsKKyAgICAsIG1fc3ZnU3R5bGUoZGVmYXVsdFN0eWxlLT5tX3N2Z1N0eWxlKQogI2VuZGlmCiAK LSAgICBzZXRCaXREZWZhdWx0cygpOwotCi0gICAgcHNldWRvU3R5bGUgPSAwOwotICAgIGNvbnRl bnQgPSAwOworeworICAgIHNldEJpdERlZmF1bHRzKCk7IC8vIFdvdWxkIGl0IGJlIGZhc3RlciB0 byBjb3B5IHRoaXMgZnJvbSB0aGUgZGVmYXVsdCBzdHlsZT8KIH0KIAogUmVuZGVyU3R5bGU6OlJl bmRlclN0eWxlKGJvb2wpCkBAIC04NzAsNyArODcyLDYgQEAgUmVuZGVyU3R5bGU6OkRpZmYgUmVu ZGVyU3R5bGU6OmRpZmYoIGNvbgogfQogCiAKLVJlbmRlclN0eWxlKiBSZW5kZXJTdHlsZTo6X2Rl ZmF1bHQgPSAwOwogLy9pbnQgUmVuZGVyU3R5bGU6OmNvdW50ZXIgPSAwOwogLy9pbnQgU2hhcmVk RGF0YTo6Y291bnRlciA9IDA7CiAKQEAgLTExMjgsMyArMTEyOSw1IEBAIGNvbnN0IFFWYWx1ZUxp c3Q8U3R5bGVEYXNoYm9hcmRSZWdpb24+JiAKICAgICB9CiAgICAgcmV0dXJuIG5vbmVMaXN0Owog fQorCit9CkluZGV4OiBraHRtbC9yZW5kZXJpbmcvcmVuZGVyX3N0eWxlLmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpS Q1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9zdHlsZS5o LHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEwMApkaWZmIC1wIC11IC1yMS4xMDAga2h0bWwvcmVu ZGVyaW5nL3JlbmRlcl9zdHlsZS5oCi0tLSBraHRtbC9yZW5kZXJpbmcvcmVuZGVyX3N0eWxlLmgJ NiBEZWMgMjAwNSAwMTo1MzoxMyAtMDAwMAkxLjEwMAorKysga2h0bWwvcmVuZGVyaW5nL3JlbmRl cl9zdHlsZS5oCTIyIERlYyAyMDA1IDA2OjQ4OjIzIC0wMDAwCkBAIC0xMDMyLDkgKzEwMzIsNiBA QCBwcm90ZWN0ZWQ6CiAgICAgCiAvLyAhRU5EIFNZTkMhCiAKLS8vIHN0YXRpYyBkZWZhdWx0IHN0 eWxlCi0gICAgc3RhdGljIFJlbmRlclN0eWxlKiBfZGVmYXVsdDsKLQogcHJvdGVjdGVkOgogICAg IHZvaWQgc2V0Qml0RGVmYXVsdHMoKQogICAgIHsK 5216 2005-12-21 22:51:25 -0800 2005-12-22 01:39:01 -0800 both performance improvements described in the bug text FasterRenderStyleConstructionPatch.txt text/plain 5007 darin SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9D aGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMjMKZGlmZiAtcCAtdSAtcjEuMjMgQ2hh bmdlTG9nCi0tLSBDaGFuZ2VMb2cJMjIgRGVjIDIwMDUgMDQ6MTE6MzUgLTAwMDAJMS4yMworKysg Q2hhbmdlTG9nCTIyIERlYyAyMDA1IDA2OjUyOjA2IC0wMDAwCkBAIC0xLDUgKzEsMjMgQEAKIDIw MDUtMTItMjEgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0dHA6Ly9idWd6aWxsYS5v cGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE2NworICAgICAgICAgIFJlbmRlclN0eWxl IGRlZmF1bHQgY29uc3RydWN0b3Igc2hvdWxkIGluaXRpYWxpemUgaXRzIG1lbWJlcnMgZm9yIHNw ZWVkCisKKyAgICAgICAgKiBraHRtbC9yZW5kZXJpbmcvRGF0YVJlZi5oOiAoa2h0bWw6OkRhdGFS ZWY6Om9wZXJhdG9yPSk6IEVsaW1pbmF0ZSBhbiBleHRyYQorICAgICAgICBicmFuY2ggYnkgZG9p bmcgcmVmIGJlZm9yZSBkZXJlZiBpbnN0ZWFkIG9mID09IGNoZWNrLgorCisgICAgICAgICoga2h0 bWwvcmVuZGVyaW5nL3JlbmRlcl9zdHlsZS5jcHA6CisgICAgICAgIChraHRtbDo6aW5pdERlZmF1 bHRTdHlsZSk6IEFkZGVkLiBGdW5jdGlvbiB0byBpbml0aWFsaXplIHRoZSBkZWZhdWx0IHN0eWxl CisgICAgICAgIGZvciB1c2UgaW4gY29uc3RydWN0b3IuCisgICAgICAgIChraHRtbDo6UmVuZGVy U3R5bGU6OlJlbmRlclN0eWxlKTogQ2hhbmdlZCBjb25zdHJ1Y3RvciB0byBpbml0YWxpemUgYWxs IHRoZQorICAgICAgICBtZW1iZXJzIHdpdGggY29uc3RydWN0b3Igc3ludGF4IGluc3RlYWQgb2Yg dXNpbmcgYXNzaWdubWVudCBvbiBhbGwgb2YgdGhlbS4KKyAgICAgICAgKiBraHRtbC9yZW5kZXJp bmcvcmVuZGVyX3N0eWxlLmg6IFJlbW92ZWQgc3RhdGljIGRhdGEgbWVtYmVyIF9kZWZhdWx0IC0t CisgICAgICAgIGl0J3Mgbm93IGEgZmlsZSBzY29wZSBnbG9iYWwgaW5zdGVhZC4KKworMjAwNS0x Mi0yMSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CisKICAgICAgICAgUmV2aWV3ZWQg YnkgSnVzdGluLgogCiAgICAgICAgIC0gZml4IGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjE0MgpJbmRleDoga2h0bWwvcmVuZGVyaW5nL0RhdGFSZWYuaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9raHRtbC9yZW5kZXJpbmcvRGF0 YVJlZi5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjIKZGlmZiAtcCAtdSAtcjEuMiBraHRtbC9y ZW5kZXJpbmcvRGF0YVJlZi5oCi0tLSBraHRtbC9yZW5kZXJpbmcvRGF0YVJlZi5oCTExIERlYyAy MDA1IDA5OjI2OjEzIC0wMDAwCTEuMgorKysga2h0bWwvcmVuZGVyaW5nL0RhdGFSZWYuaAkyMiBE ZWMgMjAwNSAwNjo1MjoyNCAtMDAwMApAQCAtNzUsMTMgKzc1LDEwIEBAIHB1YmxpYzoKIAogICAg IERhdGFSZWY8REFUQT4mIG9wZXJhdG9yPShjb25zdCBEYXRhUmVmPERBVEE+JiBkKQogICAgIHsK LSAgICAJaWYgKG1fZGF0YSA9PSBkLm1fZGF0YSkKLQkgICAgcmV0dXJuICp0aGlzOworCWQubV9k YXRhLT5yZWYoKTsKICAgICAJaWYgKG1fZGF0YSkKICAgICAJICAgIG1fZGF0YS0+ZGVyZWYoKTsK ICAgICAJbV9kYXRhID0gZC5tX2RhdGE7Ci0JbV9kYXRhLT5yZWYoKTsKLQogCXJldHVybiAqdGhp czsKICAgICB9CiAKSW5kZXg6IGtodG1sL3JlbmRlcmluZy9yZW5kZXJfc3R5bGUuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJDb3JlL2todG1sL3JlbmRlcmluZy9yZW5kZXJf c3R5bGUuY3BwLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjc5CmRpZmYgLXAgLXUgLXIxLjc5IGto dG1sL3JlbmRlcmluZy9yZW5kZXJfc3R5bGUuY3BwCi0tLSBraHRtbC9yZW5kZXJpbmcvcmVuZGVy X3N0eWxlLmNwcAkxMSBEZWMgMjAwNSAwOToyNjoxNSAtMDAwMAkxLjc5CisrKyBraHRtbC9yZW5k ZXJpbmcvcmVuZGVyX3N0eWxlLmNwcAkyMiBEZWMgMjAwNSAwNjo1MjoyNSAtMDAwMApAQCAtMzQs MTAgKzM0LDExIEBACiAKICNpbmNsdWRlICJrZGVidWcuaCIKIAotdXNpbmcgbmFtZXNwYWNlIGto dG1sOwordXNpbmcgbmFtZXNwYWNlIERPTTsKIAotdXNpbmcgRE9NOjpET01TdHJpbmdJbXBsOwot dXNpbmcgRE9NOjpET01TdHJpbmc7CituYW1lc3BhY2Uga2h0bWwgeworCitzdGF0aWMgUmVuZGVy U3R5bGUgKmRlZmF1bHRTdHlsZTsKIAogU3R5bGVTdXJyb3VuZERhdGE6OlN0eWxlU3Vycm91bmRE YXRhKCkKICAgICA6IG1hcmdpbiggRml4ZWQgKSwgcGFkZGluZyggQXV0byApCkBAIC01MTIsMzEg KzUxMywzMiBAQCB2b2lkIFJlbmRlclN0eWxlOjphcmVuYURlbGV0ZShSZW5kZXJBcmVuCiAgICAg YXJlbmEtPmZyZWUoKihzaXplX3QgKil0aGlzLCB0aGlzKTsKIH0KIAotUmVuZGVyU3R5bGU6OlJl bmRlclN0eWxlKCkKLTptX3BzZXVkb1N0YXRlKFBzZXVkb1Vua25vd24pLCBtX2FmZmVjdGVkQnlB dHRyaWJ1dGVTZWxlY3RvcnMoZmFsc2UpCitpbmxpbmUgUmVuZGVyU3R5bGUgKmluaXREZWZhdWx0 U3R5bGUoKQogewotICAgIG1fcmVmID0gMDsKLSAgICAKLSAgICBpZiAoIV9kZWZhdWx0KQotCV9k ZWZhdWx0ID0gOjpuZXcgUmVuZGVyU3R5bGUodHJ1ZSk7Ci0KLSAgICBib3ggPSBfZGVmYXVsdC0+ Ym94OwotICAgIHZpc3VhbCA9IF9kZWZhdWx0LT52aXN1YWw7Ci0gICAgYmFja2dyb3VuZCA9IF9k ZWZhdWx0LT5iYWNrZ3JvdW5kOwotICAgIHN1cnJvdW5kID0gX2RlZmF1bHQtPnN1cnJvdW5kOwot ICAgIGNzczNOb25Jbmhlcml0ZWREYXRhID0gX2RlZmF1bHQtPmNzczNOb25Jbmhlcml0ZWREYXRh OwotICAgIGNzczNJbmhlcml0ZWREYXRhID0gX2RlZmF1bHQtPmNzczNJbmhlcml0ZWREYXRhOwot ICAgIAotICAgIGluaGVyaXRlZCA9IF9kZWZhdWx0LT5pbmhlcml0ZWQ7CisgICAgaWYgKCFkZWZh dWx0U3R5bGUpCisgICAgICAgIGRlZmF1bHRTdHlsZSA9IDo6bmV3IFJlbmRlclN0eWxlKHRydWUp OworICAgIHJldHVybiBkZWZhdWx0U3R5bGU7Cit9CiAKK1JlbmRlclN0eWxlOjpSZW5kZXJTdHls ZSgpCisgICAgOiBib3goaW5pdERlZmF1bHRTdHlsZSgpLT5ib3gpCisgICAgLCB2aXN1YWwoZGVm YXVsdFN0eWxlLT52aXN1YWwpCisgICAgLCBiYWNrZ3JvdW5kKGRlZmF1bHRTdHlsZS0+YmFja2dy b3VuZCkKKyAgICAsIHN1cnJvdW5kKGRlZmF1bHRTdHlsZS0+c3Vycm91bmQpCisgICAgLCBjc3Mz Tm9uSW5oZXJpdGVkRGF0YShkZWZhdWx0U3R5bGUtPmNzczNOb25Jbmhlcml0ZWREYXRhKQorICAg ICwgY3NzM0luaGVyaXRlZERhdGEoZGVmYXVsdFN0eWxlLT5jc3MzSW5oZXJpdGVkRGF0YSkKKyAg ICAsIGluaGVyaXRlZChkZWZhdWx0U3R5bGUtPmluaGVyaXRlZCkKKyAgICAsIHBzZXVkb1N0eWxl KDApCisgICAgLCBjb250ZW50KDApCisgICAgLCBtX3BzZXVkb1N0YXRlKFBzZXVkb1Vua25vd24p CisgICAgLCBtX2FmZmVjdGVkQnlBdHRyaWJ1dGVTZWxlY3RvcnMoZmFsc2UpCisgICAgLCBtX3Jl ZigwKQogI2lmIFNWR19TVVBQT1JUCi0gICAgbV9zdmdTdHlsZSA9IF9kZWZhdWx0LT5tX3N2Z1N0 eWxlOworICAgICwgbV9zdmdTdHlsZShkZWZhdWx0U3R5bGUtPm1fc3ZnU3R5bGUpCiAjZW5kaWYK IAotICAgIHNldEJpdERlZmF1bHRzKCk7Ci0KLSAgICBwc2V1ZG9TdHlsZSA9IDA7Ci0gICAgY29u dGVudCA9IDA7Cit7CisgICAgc2V0Qml0RGVmYXVsdHMoKTsgLy8gV291bGQgaXQgYmUgZmFzdGVy IHRvIGNvcHkgdGhpcyBmcm9tIHRoZSBkZWZhdWx0IHN0eWxlPwogfQogCiBSZW5kZXJTdHlsZTo6 UmVuZGVyU3R5bGUoYm9vbCkKQEAgLTg3MCwxNCArODcyLDExIEBAIFJlbmRlclN0eWxlOjpEaWZm IFJlbmRlclN0eWxlOjpkaWZmKCBjb24KIH0KIAogCi1SZW5kZXJTdHlsZSogUmVuZGVyU3R5bGU6 Ol9kZWZhdWx0ID0gMDsKIC8vaW50IFJlbmRlclN0eWxlOjpjb3VudGVyID0gMDsKIC8vaW50IFNo YXJlZERhdGE6OmNvdW50ZXIgPSAwOwogCiB2b2lkIFJlbmRlclN0eWxlOjpjbGVhbnVwKCkKIHsK LSAgICBkZWxldGUgX2RlZmF1bHQ7Ci0gICAgX2RlZmF1bHQgPSAwOwogLy8gICAgY291bnRlciA9 IDA7CiAvLyAgICBTaGFyZWREYXRhOjpjb3VudGVyID0gMDsKIH0KQEAgLTExMjgsMyArMTEyNyw1 IEBAIGNvbnN0IFFWYWx1ZUxpc3Q8U3R5bGVEYXNoYm9hcmRSZWdpb24+JiAKICAgICB9CiAgICAg cmV0dXJuIG5vbmVMaXN0OwogfQorCit9CkluZGV4OiBraHRtbC9yZW5kZXJpbmcvcmVuZGVyX3N0 eWxlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dlYkNvcmUva2h0bWwvcmVuZGVy aW5nL3JlbmRlcl9zdHlsZS5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjEwMApkaWZmIC1wIC11 IC1yMS4xMDAga2h0bWwvcmVuZGVyaW5nL3JlbmRlcl9zdHlsZS5oCi0tLSBraHRtbC9yZW5kZXJp bmcvcmVuZGVyX3N0eWxlLmgJNiBEZWMgMjAwNSAwMTo1MzoxMyAtMDAwMAkxLjEwMAorKysga2h0 bWwvcmVuZGVyaW5nL3JlbmRlcl9zdHlsZS5oCTIyIERlYyAyMDA1IDA2OjUyOjI3IC0wMDAwCkBA IC0xMDMyLDkgKzEwMzIsNiBAQCBwcm90ZWN0ZWQ6CiAgICAgCiAvLyAhRU5EIFNZTkMhCiAKLS8v IHN0YXRpYyBkZWZhdWx0IHN0eWxlCi0gICAgc3RhdGljIFJlbmRlclN0eWxlKiBfZGVmYXVsdDsK LQogcHJvdGVjdGVkOgogICAgIHZvaWQgc2V0Qml0RGVmYXVsdHMoKQogICAgIHsK