61646 2011-05-27 10:14:15 -0700 Duplicate Fonts Put in Font Cache on Mac Due to Duplicate CGFontRefs for Same Font 2011-05-27 10:52:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P1 Major --- 1 msaboff msaboff aroben oldest_to_newest 411513 0 msaboff 2011-05-27 10:14:15 -0700 Core Text has code paths that call into CGFontCreateFontsWithPath() directly, bypassing CG’s font database. This can and does (in TOT WebKit, for example) result in multiple distinct CGFont objects being created for the exact same font. See <rdar://problem/9089228>for details. Every time we get a new and distinct CGFontRef, we create a new FontCache entry and abandon the old one. The cache fails to find the earlier entry due to FontPlatformData::platformIsEqual() in FontPlatformDataCocoa.mm comparing the saved m_cfFont. 411517 1 95189 msaboff 2011-05-27 10:20:40 -0700 Created attachment 95189 Patch to only compare the CGFontRefs if needed 411522 2 msaboff 2011-05-27 10:28:54 -0700 <rdar://problem/9515696> 411531 3 95189 aroben 2011-05-27 10:43:10 -0700 Comment on attachment 95189 Patch to only compare the CGFontRefs if needed View in context: https://bugs.webkit.org/attachment.cgi?id=95189&action=review > Source/WebCore/ChangeLog:9 > + Change the platformIsEqual to just compare the m_font members if > + both are not null. This doesn't match the code change. We compare the m_font members if either one is not null, not if both are not null. 411537 4 95189 hyatt 2011-05-27 10:47:54 -0700 Comment on attachment 95189 Patch to only compare the CGFontRefs if needed r=me 411542 5 msaboff 2011-05-27 10:52:19 -0700 Committed r87524: <http://trac.webkit.org/changeset/87524> 95189 2011-05-27 10:20:40 -0700 2011-05-27 10:47:54 -0700 Patch to only compare the CGFontRefs if needed 61646.patch text/plain 1527 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3NTIwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMjcgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYxNjQ2CisgICAgICAgIER1cGxpY2F0ZSBGb250cyBQdXQgaW4gRm9udCBDYWNoZSBvbiBN YWMgRHVlIHRvIER1cGxpY2F0ZSBDR0ZvbnRSZWZzIGZvciBTYW1lIEZvbnQKKworICAgICAgICBD aGFuZ2UgdGhlIHBsYXRmb3JtSXNFcXVhbCB0byBqdXN0IGNvbXBhcmUgdGhlIG1fZm9udCBtZW1i ZXJzIGlmCisgICAgICAgIGJvdGggYXJlIG5vdCBudWxsLgorCisgICAgICAgIE5vIHRlc3RzIGFk ZGVkIC0gZnVuY3Rpb25hbGl0eSB1bmNoYW5nZWQsIGZpeGluZyBtZW1vcnkgYWJhbmRvbm1lbnQu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250UGxhdGZvcm1EYXRhQ29j b2EubW06CisgICAgICAgIChXZWJDb3JlOjpGb250UGxhdGZvcm1EYXRhOjpwbGF0Zm9ybUlzRXF1 YWwpOgorCiAyMDExLTA1LTI3ICBTdGVwaGFuaWUgTGV3aXMgIDxzbGV3aXNAYXBwbGUuY29tPgog CiAgICAgICAgIFJ1YmJlciBTdGFtcGVkIGJ5IEFkYW0gUm9iZW4uCkluZGV4OiBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb2NvYS9Gb250UGxhdGZvcm1EYXRhQ29jb2EubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY29jb2EvRm9udFBs YXRmb3JtRGF0YUNvY29hLm1tCShyZXZpc2lvbiA4NzUxMSkKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2NvY29hL0ZvbnRQbGF0Zm9ybURhdGFDb2NvYS5tbQkod29ya2luZyBj b3B5KQpAQCAtMTA2LDggKzEwNiw5IEBAIGNvbnN0IEZvbnRQbGF0Zm9ybURhdGEmIEZvbnRQbGF0 Zm9ybURhdGEKIAogYm9vbCBGb250UGxhdGZvcm1EYXRhOjpwbGF0Zm9ybUlzRXF1YWwoY29uc3Qg Rm9udFBsYXRmb3JtRGF0YSYgb3RoZXIpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIG1fZm9udCA9PSBv dGhlci5tX2ZvbnQKLSAgICAgICAgJiYgbV9jZ0ZvbnQgPT0gb3RoZXIubV9jZ0ZvbnQ7CisgICAg aWYgKG1fZm9udCB8fCBvdGhlci5tX2ZvbnQpCisgICAgICAgIHJldHVybiBtX2ZvbnQgPT0gb3Ro ZXIubV9mb250OworICAgIHJldHVybiBtX2NnRm9udCA9PSBvdGhlci5tX2NnRm9udDsKIH0KIAog dm9pZCBGb250UGxhdGZvcm1EYXRhOjpzZXRGb250KE5TRm9udCAqZm9udCkK