61627 2011-05-27 06:23:59 -0700 [GTK] Remove Connection::setShouldCloseConnectionOnProcessTermination() 2011-06-22 08:44:25 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned andersca oldest_to_newest 411380 0 cgarcia 2011-05-27 06:23:59 -0700 Once bug #61287 (and #61538 for platforms where SOCK_SEQPACKET is not available) is fixed and processes are correctly notified when the other ends closes the connection we don't need Connection::setShouldCloseConnectionOnProcessTermination() anymore. 411383 1 95164 cgarcia 2011-05-27 06:29:01 -0700 Created attachment 95164 Patch This patch depends on bug #61287. 418556 2 cgarcia 2011-06-10 00:41:17 -0700 Remove dependency on bug #61287, since we finally moved to stream sockets in GTK port. We can now remove Connection::setShouldCloseConnectionOnProcessTermination(). 425250 3 95164 mrobinson 2011-06-22 08:25:01 -0700 Comment on attachment 95164 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95164&action=review Great. :) > Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:65 > + int socket = GPOINTER_TO_INT(userData); > + close(socket); This can be one line here. > Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:96 > + // Monitor the child process, it calls waitpid to avoid the child process to become a zombie, avoid the child process to become a zombie -> prevent the child process from becomming a zombie 425265 4 cgarcia 2011-06-22 08:44:25 -0700 Committed r89433: <http://trac.webkit.org/changeset/89433> 95164 2011-05-27 06:29:01 -0700 2011-06-22 08:25:01 -0700 Patch wk2-remove-set-should-close.diff text/plain 4293 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAzODFhMjYyLi4wZDdhNGIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTEtMDUtMjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IFJlbW92ZSBDb25uZWN0aW9uOjpzZXRTaG91bGRDbG9zZUNvbm5lY3Rpb25PblByb2Nlc3NUZXJt aW5hdGlvbigpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MTYyNworCisgICAgICAgIERvbid0IHVzZSBDb25uZWN0aW9uOjpzZXRTaG91bGRDbG9zZUNv bm5lY3Rpb25PblByb2Nlc3NUZXJtaW5hdGlvbigpIGZvciB0aGUKKyAgICAgICAgR1RLIHBvcnQs IHdoZW4gdGhlIHByb2Nlc3MgZmluaXNoZXMgdGhlIGNvbm5lY3Rpb24gaXMgY2xvc2VkIGFuZAor ICAgICAgICB0aGUgb3RoZXIgcHJvY2VzcyBpcyBhbHJlYWR5IG5vdGlmaWVkLiBXZSBzdGlsbCBu ZWVkIHRvIG1vbml0b3IKKyAgICAgICAgdGhlIGNoaWxkIHByb2Nlc3Mgc28gdGhhdCBpdCBkb2Vz bid0IGJlY29tZSBhIHpvbWJpZSB3aGVuIGl0IGRudGFiaQorCisgICAgICAgICogUGxhdGZvcm0v Q29yZUlQQy9Db25uZWN0aW9uLmg6CisgICAgICAgICogUGxhdGZvcm0vQ29yZUlQQy91bml4L0Nv bm5lY3Rpb25Vbml4LmNwcDoKKyAgICAgICAgKiBVSVByb2Nlc3MvTGF1bmNoZXIvZ3RrL1Byb2Nl c3NMYXVuY2hlckd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OmNoaWxkRmluaXNoZWRGdW5jdGlv bik6CisgICAgICAgIChXZWJLaXQ6OlByb2Nlc3NMYXVuY2hlcjo6bGF1bmNoUHJvY2Vzcyk6Cisg ICAgICAgICogVUlQcm9jZXNzL1dlYlByb2Nlc3NQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlByb2Nlc3NQcm94eTo6ZGlkRmluaXNoTGF1bmNoaW5nKToKKwogMjAxMS0wNS0yNiAgQ2hy aXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQ Qy9Db25uZWN0aW9uLmggYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rp b24uaAppbmRleCA2MjljN2IwLi4yYjk5ZTdkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9Q bGF0Zm9ybS9Db3JlSVBDL0Nvbm5lY3Rpb24uaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bS9Db3JlSVBDL0Nvbm5lY3Rpb24uaApAQCAtMTE4LDcgKzExOCw3IEBAIHB1YmxpYzoKIAogI2lm IFBMQVRGT1JNKE1BQykKICAgICB2b2lkIHNldFNob3VsZENsb3NlQ29ubmVjdGlvbk9uTWFjaEV4 Y2VwdGlvbnMoKTsKLSNlbGlmIFBMQVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEspCisjZWxpZiBQ TEFURk9STShRVCkKICAgICB2b2lkIHNldFNob3VsZENsb3NlQ29ubmVjdGlvbk9uUHJvY2Vzc1Rl cm1pbmF0aW9uKFdlYktpdDo6UGxhdGZvcm1Qcm9jZXNzSWRlbnRpZmllcik7CiAjZW5kaWYKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vQ29yZUlQQy91bml4L0Nvbm5lY3Rp b25Vbml4LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0NvcmVJUEMvdW5peC9Db25uZWN0 aW9uVW5peC5jcHAKaW5kZXggOTJmZmZmMy4uNGE3YTNjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvUGxhdGZvcm0vQ29yZUlQQy91bml4L0Nvbm5lY3Rpb25Vbml4LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9QbGF0Zm9ybS9Db3JlSVBDL3VuaXgvQ29ubmVjdGlvblVuaXguY3BwCkBAIC0z OTEsNyArMzkxLDcgQEAgYm9vbCBDb25uZWN0aW9uOjpzZW5kT3V0Z29pbmdNZXNzYWdlKE1lc3Nh Z2VJRCBtZXNzYWdlSUQsIFBhc3NPd25QdHI8QXJndW1lbnRFbmMKICAgICByZXR1cm4gdHJ1ZTsK IH0KIAotI2lmIFBMQVRGT1JNKFFUKSB8fCBQTEFURk9STShHVEspCisjaWYgUExBVEZPUk0oUVQp CiB2b2lkIENvbm5lY3Rpb246OnNldFNob3VsZENsb3NlQ29ubmVjdGlvbk9uUHJvY2Vzc1Rlcm1p bmF0aW9uKFdlYktpdDo6UGxhdGZvcm1Qcm9jZXNzSWRlbnRpZmllciBwcm9jZXNzKQogewogICAg IG1fY29ubmVjdGlvblF1ZXVlLnNjaGVkdWxlV29ya09uVGVybWluYXRpb24ocHJvY2VzcywgV29y a0l0ZW06OmNyZWF0ZSh0aGlzLCAmQ29ubmVjdGlvbjo6Y29ubmVjdGlvbkRpZENsb3NlKSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvZ3RrL1Byb2Nlc3NM YXVuY2hlckd0ay5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvTGF1bmNoZXIvZ3RrL1By b2Nlc3NMYXVuY2hlckd0ay5jcHAKaW5kZXggZjg3NzIwOS4uNzY0NDIzZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL2d0ay9Qcm9jZXNzTGF1bmNoZXJHdGsu Y3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9ndGsvUHJvY2Vzc0xh dW5jaGVyR3RrLmNwcApAQCAtNTYsNiArNTYsMTUgQEAgc3RhdGljIHZvaWQgY2hpbGRTZXR1cEZ1 bmN0aW9uKGdwb2ludGVyIHVzZXJEYXRhKQogI2VuZGlmCiB9CiAKK3N0YXRpYyB2b2lkIGNoaWxk RmluaXNoZWRGdW5jdGlvbihHUGlkLCBnaW50IHN0YXR1cywgZ3BvaW50ZXIgdXNlckRhdGEpCit7 CisgICAgaWYgKFdJRkVYSVRFRChzdGF0dXMpICYmICFXRVhJVFNUQVRVUyhzdGF0dXMpKQorICAg ICAgICByZXR1cm47CisKKyAgICBpbnQgc29ja2V0ID0gR1BPSU5URVJfVE9fSU5UKHVzZXJEYXRh KTsKKyAgICBjbG9zZShzb2NrZXQpOworfQorCiB2b2lkIFByb2Nlc3NMYXVuY2hlcjo6bGF1bmNo UHJvY2VzcygpCiB7CiAgICAgR1BpZCBwaWQgPSAwOwpAQCAtODMsNiArOTIsMTEgQEAgdm9pZCBQ cm9jZXNzTGF1bmNoZXI6OmxhdW5jaFByb2Nlc3MoKQogCiAgICAgY2xvc2Uoc29ja2V0c1swXSk7 CiAgICAgbV9wcm9jZXNzSWRlbnRpZmllciA9IHBpZDsKKworICAgIC8vIE1vbml0b3IgdGhlIGNo aWxkIHByb2Nlc3MsIGl0IGNhbGxzIHdhaXRwaWQgdG8gYXZvaWQgdGhlIGNoaWxkIHByb2Nlc3Mg dG8gYmVjb21lIGEgem9tYmllLAorICAgIC8vIGFuZCBpdCBhbGxvd3MgdXMgdG8gY2xvc2UgdGhl IHNvY2tldCB3aGVuIHRoZSBjaGlsZCBwcm9jZXNzIGNyYXNoZXMuCisgICAgZ19jaGlsZF93YXRj aF9hZGQobV9wcm9jZXNzSWRlbnRpZmllciwgY2hpbGRGaW5pc2hlZEZ1bmN0aW9uLCBHSU5UX1RP X1BPSU5URVIoc29ja2V0c1sxXSkpOworCiAgICAgLy8gV2UndmUgZmluaXNoZWQgbGF1bmNoaW5n IHRoZSBwcm9jZXNzLCBtZXNzYWdlIGJhY2sgdG8gdGhlIG1haW4gcnVuIGxvb3AuCiAgICAgUnVu TG9vcDo6bWFpbigpLT5zY2hlZHVsZVdvcmsoV29ya0l0ZW06OmNyZWF0ZSh0aGlzLCAmUHJvY2Vz c0xhdW5jaGVyOjpkaWRGaW5pc2hMYXVuY2hpbmdQcm9jZXNzLCBtX3Byb2Nlc3NJZGVudGlmaWVy LCBzb2NrZXRzWzFdKSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViUHJvY2Vzc1Byb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNz UHJveHkuY3BwCmluZGV4IGY1NjQ2YjAuLjNhZTllMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJQcm9jZXNzUHJveHkuY3BwCkBAIC0zNTIsNyArMzUyLDcgQEAgdm9pZCBXZWJQ cm9jZXNzUHJveHk6OmRpZEZpbmlzaExhdW5jaGluZyhDb3JlSVBDOjpDb25uZWN0aW9uOjpJZGVu dGlmaWVyIGNvbm5lY3QKICAgICBtX2Nvbm5lY3Rpb24gPSBDb3JlSVBDOjpDb25uZWN0aW9uOjpj cmVhdGVTZXJ2ZXJDb25uZWN0aW9uKGNvbm5lY3Rpb25JZGVudGlmaWVyLCB0aGlzLCBSdW5Mb29w OjptYWluKCkpOwogI2lmIFBMQVRGT1JNKE1BQykKICAgICBtX2Nvbm5lY3Rpb24tPnNldFNob3Vs ZENsb3NlQ29ubmVjdGlvbk9uTWFjaEV4Y2VwdGlvbnMoKTsKLSNlbGlmIFBMQVRGT1JNKFFUKSB8 fCBQTEFURk9STShHVEspCisjZWxpZiBQTEFURk9STShRVCkKICAgICBtX2Nvbm5lY3Rpb24tPnNl dFNob3VsZENsb3NlQ29ubmVjdGlvbk9uUHJvY2Vzc1Rlcm1pbmF0aW9uKHByb2Nlc3NJZGVudGlm aWVyKCkpOwogI2VuZGlmCiAK