61600 2011-05-26 21:03:18 -0700 SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative 2011-06-29 02:32:39 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 rsleevi rwlbuis eric krit leo.yang rniwa rwlbuis thakis tony webkit.review.bot zimmermann oldest_to_newest 411111 0 rsleevi 2011-05-26 21:03:18 -0700 This was reported downstream in Chromium by a user running a static analyzer over the Chromium sources, which include WebKit. The text of the original report (from PVS studio) is: V501 There are identical sub-expressions 'cy ().isRelative ()' to the left and to the right of the '||' operator. webcore_svg svgradialgradientelement.cpp 253 bool SVGRadialGradientElement::selfHasRelativeLengths() const { return cy().isRelative() || cy().isRelative() || r().isRelative() || fx().isRelative() || fy().isRelative(); } The logic error is that cy().isRelative() is checked twice, rather than checking cx() and then cy() 411112 1 95104 rsleevi 2011-05-26 21:05:33 -0700 Created attachment 95104 Patch 1 Patch to fix the above. As this is my first WebKit patch, please let me know if I'm incorrect in adding r? and cq? 411114 2 webkit.review.bot 2011-05-26 21:07:20 -0700 Attachment 95104 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/svg/SVGRadial..." exit_code: 1 ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 411116 3 95105 rsleevi 2011-05-26 21:09:43 -0700 Created attachment 95105 Patch 2 411117 4 webkit.review.bot 2011-05-26 21:10:59 -0700 Attachment 95105 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/svg/SVGRadial..." exit_code: 1 ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 411121 5 95106 rsleevi 2011-05-26 21:15:15 -0700 Created attachment 95106 Attempt to fix style errors 411130 6 95106 eric 2011-05-26 21:43:25 -0700 Comment on attachment 95106 Attempt to fix style errors How do we test this? 411146 7 rsleevi 2011-05-26 22:03:15 -0700 (In reply to comment #6) > (From update of attachment 95106 [details]) > How do we test this? Unfortunately, I'm not sure. I'm not familiar with the WebKit code to know what may cause this path to be hit, just that it was "clearly" wrong. Either one of the calls to cy.isRelative() should be removed (since it is redundant) or the more likely answer, that because isRelative() has no side-effects/is const, the likely intent was for cx() and cy() to be checked, just as fx() and fy() are checked. For what it's worth, the downstream report is at http://code.google.com/p/chromium/issues/detail?id=84141 (originally http://code.google.com/p/chromium/issues/detail?id=83873#c2 ) 411185 8 zimmermann 2011-05-26 23:03:10 -0700 (In reply to comment #7) > (In reply to comment #6) > > (From update of attachment 95106 [details] [details]) > > How do we test this? > > Unfortunately, I'm not sure. I'm not familiar with the WebKit code to know what may cause this path to be hit, just that it was "clearly" wrong. Either one of the calls to cy.isRelative() should be removed (since it is redundant) or the more likely answer, that because isRelative() has no side-effects/is const, the likely intent was for cx() and cy() to be checked, just as fx() and fy() are checked. > > For what it's worth, the downstream report is at http://code.google.com/p/chromium/issues/detail?id=84141 (originally http://code.google.com/p/chromium/issues/detail?id=83873#c2 ) I have a suggestion for a test: Use LayoutTests/svg/custom/relative-sized-content.xhtml as template. The hasRelativeLength() stuff is relevant, when you eg. apply your radialGradient with cx/cy in percentages to a target rectangle, which itself is relatively postionioned. Currently when resizing the window you won't see any changes of 'cx' (if it is relative, and 'cy' is absolute). You can "mimic" window size changes, by embedding your <svg> in an outer <div> and resize that, this is what the test example I cited above does. To summarize: You'll need a svg with width/height 100%, a rect with w/h="100%" a radGrad with cy="50" (sth. absolute) and a percentage based cx. That should expose the bug.... Good catch, btw... 411506 9 tony 2011-05-27 09:59:36 -0700 @zimmermann: Do you think you can write a test for this? This bug was caught by a static code analysis tool and Ryan was just trying to be helpful by writing the patch to fix the bug. I think this is his first webkit patch so it might be quicker if you can write the layout test. 421179 10 zimmermann 2011-06-15 04:20:40 -0700 CC'ing Leo/Dirk/Rob - does any of you have some time for this? I'm still blocked by the CSS & SVG Font patches. 421252 11 rwlbuis 2011-06-15 07:23:20 -0700 Hi Niko, (In reply to comment #10) > CC'ing Leo/Dirk/Rob - does any of you have some time for this? I'm still blocked by the CSS & SVG Font patches. Yes I'll have a look. Cheers, Rob. 421491 12 rwlbuis 2011-06-15 12:13:28 -0700 I looked into this but I am not sure whether these relative values are used at all, or at least when having the viewport width changed. Basically once the viewport changes the client for the gradient resource is removed from dictionary of clients, then in applyResource it is newly calculated and the percentage calculation will be fine. Let me know if I am missing anything... Cheers, Rob. 421955 13 zimmermann 2011-06-16 08:01:22 -0700 (In reply to comment #12) > I looked into this but I am not sure whether these relative values are used at all, or at least when having the viewport width changed. Basically once the viewport changes the client for the gradient resource is removed from dictionary of clients, then in applyResource it is newly calculated and the percentage calculation will be fine. Let me know if I am missing anything... > Cheers, > > Rob. Rob is right, we discussed this on IRC. When assigning absolute values to the <rect> that uses the gradient, it still works. This is the reason: Breakpoint 8, WebCore::RenderSVGResourceGradient::removeClientFromCache (this=0x11b48cc98, client=0x11b43cc08, markForInvalidation=false) at RenderSVGResourceGradient.cpp:68 68 ASSERT(client); (gdb) bt #0 WebCore::RenderSVGResourceGradient::removeClientFromCache (this=0x11b48cc98, client=0x11b43cc08, markForInvalidation=false) at RenderSVGResourceGradient.cpp:68 #1 0x00000001021e33a0 in WebCore::SVGResources::removeClientFromCache (this=0x11b43cd20, object=0x11b43cc08, markForInvalidation=false) at SVGResources.cpp:316 #2 0x00000001021ee8c3 in WebCore::invalidateResourcesOfChildren (start=0x11b43cc08) at SVGRenderSupport.cpp:210 #3 0x00000001021f10b8 in WebCore::SVGRenderSupport::layoutChildren (start=0x11b442738, selfNeedsLayout=false) at SVGRenderSupport.cpp:258 #4 0x00000001021f825f in WebCore::RenderSVGRoot::layout (this=0x11b442738) at RenderSVGRoot.cpp:240 #5 0x000000010220b10b in WebCore::RenderObject::layoutIfNeeded (this=0x11b442738) at RenderObject.h:539 #6 0x000000010212ba60 in WebCore::RenderBlock::layoutInlineChildren (this=0x11b449278, relayoutChildren=true, repaintLogicalTop=@0x7fff5fbfd8a8, repaintLogicalBottom=@0x7fff5fbfd8a4) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlockLineLayout.cpp:1175 #7 0x000000010210869b in WebCore::RenderBlock::layoutBlock (this=0x11b449278, relayoutChildren=true, pageLogicalHeight=0) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1236 #8 0x000000010210026c in WebCore::RenderBlock::layout (this=0x11b449278) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1134 #9 0x0000000102107067 in WebCore::RenderBlock::layoutBlockChild (this=0x1081d7a38, child=0x11b449278, marginInfo=@0x7fff5fbfda70, previousFloatLogicalBottom=@0x7fff5fbfdae4, maxFloatLogicalBottom=@0x7fff5fbfdc80) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1977 #10 0x0000000102108046 in WebCore::RenderBlock::layoutBlockChildren (this=0x1081d7a38, relayoutChildren=false, maxFloatLogicalBottom=@0x7fff5fbfdc80) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1915 #11 0x00000001021086b4 in WebCore::RenderBlock::layoutBlock (this=0x1081d7a38, relayoutChildren=false, pageLogicalHeight=0) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1238 #12 0x000000010210026c in WebCore::RenderBlock::layout (this=0x1081d7a38) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1134 #13 0x0000000102107067 in WebCore::RenderBlock::layoutBlockChild (this=0x1081ecd88, child=0x1081d7a38, marginInfo=@0x7fff5fbfde50, previousFloatLogicalBottom=@0x7fff5fbfdec4, maxFloatLogicalBottom=@0x7fff5fbfe060) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1977 #14 0x0000000102108046 in WebCore::RenderBlock::layoutBlockChildren (this=0x1081ecd88, relayoutChildren=false, maxFloatLogicalBottom=@0x7fff5fbfe060) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1915 #15 0x00000001021086b4 in WebCore::RenderBlock::layoutBlock (this=0x1081ecd88, relayoutChildren=false, pageLogicalHeight=0) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1238 #16 0x000000010210026c in WebCore::RenderBlock::layout (this=0x1081ecd88) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1134 #17 0x0000000102107067 in WebCore::RenderBlock::layoutBlockChild (this=0x106da8178, child=0x1081ecd88, marginInfo=@0x7fff5fbfe230, previousFloatLogicalBottom=@0x7fff5fbfe2a4, maxFloatLogicalBottom=@0x7fff5fbfe440) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1977 #18 0x0000000102108046 in WebCore::RenderBlock::layoutBlockChildren (this=0x106da8178, relayoutChildren=false, maxFloatLogicalBottom=@0x7fff5fbfe440) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1915 #19 0x00000001021086b4 in WebCore::RenderBlock::layoutBlock (this=0x106da8178, relayoutChildren=false, pageLogicalHeight=0) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1238 #20 0x000000010210026c in WebCore::RenderBlock::layout (this=0x106da8178) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderBlock.cpp:1134 #21 0x000000010226fad9 in WebCore::RenderView::layout (this=0x106da8178) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderView.cpp:130 #22 0x0000000101aa0617 in WebCore::FrameView::layout (this=0x11a659690, allowSubtree=true) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/page/FrameView.cpp:1000 #23 0x00000001018c3bad in WebCore::Document::updateLayout (this=0x107119000) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/dom/Document.cpp:1612 #24 0x0000000102189d69 in WebCore::RenderLayer::hitTest (this=0x106deaf28, request=@0x7fff5fbfeab0, result=@0x7fff5fbfe850) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/rendering/RenderLayer.cpp:2846 #25 0x00000001018c2f1b in WebCore::Document::prepareMouseEvent (this=0x107119000, request=@0x7fff5fbfeab0, documentPoint=@0x7fff5fbfe940, event=@0x7fff5fbfebd0) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/dom/Document.cpp:2625 #26 0x0000000101a00529 in WebCore::EventHandler::prepareMouseEvent (this=0x1070d8818, request=@0x7fff5fbfeab0, mev=@0x7fff5fbfebd0) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/page/EventHandler.cpp:1930 #27 0x0000000101a07d90 in WebCore::EventHandler::handleMouseMoveEvent (this=0x1070d8818, mouseEvent=@0x7fff5fbfebd0, hoveredNode=0x7fff5fbfeb00) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/page/EventHandler.cpp:1610 #28 0x0000000101a08333 in WebCore::EventHandler::mouseMoved (this=0x1070d8818, event=@0x7fff5fbfebd0) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/page/EventHandler.cpp:1542 #29 0x0000000101a0e306 in WebCore::EventHandler::mouseMoved (this=0x1070d8818, event=0x11b473fc0) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebCore/page/mac/EventHandlerMac.mm:606 #30 0x00000001010de126 in -[WebHTMLView(WebPrivate) _updateMouseoverWithEvent:] (self=0x106dee300, _cmd=0x7fff8481d2b5, event=0x11b473fc0) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebKit/mac/WebView/WebHTMLView.mm:1619 #31 0x00000001010c9b21 in -[WebHTMLView(WebPrivate) _updateMouseoverWithFakeEvent] (self=0x106dee300, _cmd=0x7fff8483af0e) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebKit/mac/WebView/WebHTMLView.mm:1201 #32 0x00000001010d4188 in -[WebHTMLView mouseUp:] (self=0x106dee300, _cmd=0x7fff82b1368c, event=0x11b40b610) at /Users/nikolaszimmermann/Coding/WebKit/Source/WebKit/mac/WebView/WebHTMLView.mm:3665 #33 0x00007fff8250d3d9 in -[NSWindow sendEvent:] () #34 0x00000001000421b5 in ?? () #35 0x0000000100042142 in ?? () #36 0x00007fff82442a86 in -[NSApplication sendEvent:] () #37 0x0000000100038e72 in ?? () #38 0x00007fff823d94da in -[NSApplication run] () #39 0x00007fff823d21a8 in NSApplicationMain () #40 0x0000000100009f18 in ?? () (gdb) 428426 14 thakis 2011-06-27 16:16:11 -0700 So what's the way forward here? Accept the patch as-is? 428664 15 95106 krit 2011-06-27 23:53:16 -0700 Comment on attachment 95106 Attempt to fix style errors View in context: https://bugs.webkit.org/attachment.cgi?id=95106&action=review r=m, but please fix the changelog. Not sure if you have commit rights. If not, please upload a new patch and set 'r' and 'cq' to '?'. I'll review it again. > ChangeLog:8 > + Reviewed by NOBODY (OOPS!). > + > + Correct the logic for checking for relative lengths in an SVGRadialGradientElement to consider cx() in addition to cy() > + https://bugs.webkit.org/show_bug.cgi?id=61600. > + > + * Source/WebCore/svg/SVGRadialGradientElement.cpp: This should be: Reviewed by NOBODY (OOPS!). SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative https://bugs.webkit.org/show_bug.cgi?id=61600. Correct the logic for checking for relative lengths in an SVGRadialGradientElement to consider cx() in addition to cy() ... (With correct indention of course) Please add a comment that there is no way to test it and why it can't be tested as well. 429463 16 99050 rsleevi 2011-06-29 00:40:57 -0700 Created attachment 99050 Patch 429464 17 99050 krit 2011-06-29 00:43:56 -0700 Comment on attachment 99050 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99050&action=review r- because you're not a commiter yet and can't correct the patch before landing it. > Source/WebCore/ChangeLog:9 > + No new tests, as there is no way to currently test this. With the bug present, a side-effect is causing the expected/correct image to be rendered. This is because the cached SVG resource is getting invalided through a different path, forcing a repaint. The repaint takes into consideration the proper dimensions, hiding the bug. Just a snippet, can you please break the line? This comment is too long to stay in one line. Lines shouldn't be longer than the line with the sentence "Correct the logic....". 429465 18 99051 rsleevi 2011-06-29 00:52:26 -0700 Created attachment 99051 Patch 429466 19 99051 rsleevi 2011-06-29 00:55:57 -0700 Comment on attachment 99051 Patch Updated the ChangeLog per your request. Since this has happened with both patches that I've submitted - where they didn't conform to certain styles/expectations - is there any documentation about this on webkit.org that I might read, saving cycles for both myself and reviewer? I've read much of the documentation, technical articles, and read perhaps way too much on the Wiki, but it seems these minor things keep biting me. 429477 20 krit 2011-06-29 01:51:06 -0700 (In reply to comment #19) > (From update of attachment 99051 [details]) > Updated the ChangeLog per your request. > > Since this has happened with both patches that I've submitted - where they didn't conform to certain styles/expectations - is there any documentation about this on webkit.org that I might read, saving cycles for both myself and reviewer? > > I've read much of the documentation, technical articles, and read perhaps way too much on the Wiki, but it seems these minor things keep biting me. You can use the script: Tools/Scripts/prepare-ChangeLog --bug <bug number> --email=<your email> It will create the ChangeLogs for you. You just have to fill the description. 429481 21 rsleevi 2011-06-29 01:56:25 -0700 (In reply to comment #20) > (In reply to comment #19) > > (From update of attachment 99051 [details] [details]) > > Updated the ChangeLog per your request. > > > > Since this has happened with both patches that I've submitted - where they didn't conform to certain styles/expectations - is there any documentation about this on webkit.org that I might read, saving cycles for both myself and reviewer? > > > > I've read much of the documentation, technical articles, and read perhaps way too much on the Wiki, but it seems these minor things keep biting me. > > You can use the script: > > > Tools/Scripts/prepare-ChangeLog --bug <bug number> --email=<your email> > > It will create the ChangeLogs for you. You just have to fill the description. Thanks. Unfortunately, that's exactly the tool I was using, which didn't help with this particular style issue. I suppose I expected it to complain about the line length (since check-webkit-style is so good about such issues), or, failing that, I was hoping to find documentation somewhere as far as expectations for comment style, tests format, etc, similar to the WebKit coding style documentation. While less of an issue with this bug, compared to the other bug I filed, I wanted to try to be a bit more proactive in understanding "The WebKit Way" for such contributions. Thanks for the r+/cq+. 429490 22 99051 webkit.review.bot 2011-06-29 02:32:33 -0700 Comment on attachment 99051 Patch Clearing flags on attachment: 99051 Committed r90003: <http://trac.webkit.org/changeset/90003> 429491 23 webkit.review.bot 2011-06-29 02:32:39 -0700 All reviewed patches have been landed. Closing bug. 95104 2011-05-26 21:05:33 -0700 2011-05-26 21:09:43 -0700 Patch 1 svgradialgradientelement.patch text/plain 1071 rsleevi SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDg3NDY0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMTEtMDUt MjYgIFJ5YW4gU2xlZXZpICA8cnNsZWV2aUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29ycmVjdCB0aGUgbG9naWMgZm9yIGNo ZWNraW5nIGZvciByZWxhdGl2ZSBsZW5ndGhzIGluIGFuIFNWR1JhZGlhbEdyYWRpZW50RWxlbWVu dCB0byBjb25zaWRlciBjeCgpIGluIGFkZGl0aW9uIHRvIGN5KCkuCisKKyAgICAgICAgKiBTb3Vy Y2UvV2ViQ29yZS9zdmcvU1ZHUmFkaWFsR3JhZGllbnRFbGVtZW50LmNwcDoKKwogMjAxMS0wNS0y NSAgR3JlZ2cgVGF2YXJlcyAgPGdtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEtlbm5ldGggUnVzc2VsbC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdSYWRpYWxH cmFkaWVudEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdS YWRpYWxHcmFkaWVudEVsZW1lbnQuY3BwCShyZXZpc2lvbiA4NzQ2NCkKKysrIFNvdXJjZS9XZWJD b3JlL3N2Zy9TVkdSYWRpYWxHcmFkaWVudEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z MDAsNyArMzAwLDcgQEAgdm9pZCBTVkdSYWRpYWxHcmFkaWVudEVsZW1lbnQ6OmNhbGN1bGF0ZQog CiBib29sIFNWR1JhZGlhbEdyYWRpZW50RWxlbWVudDo6c2VsZkhhc1JlbGF0aXZlTGVuZ3Rocygp IGNvbnN0CiB7Ci0gICAgcmV0dXJuIGN5KCkuaXNSZWxhdGl2ZSgpCisgICAgcmV0dXJuIGN4KCku aXNSZWxhdGl2ZSgpCiAgICAgICAgIHx8IGN5KCkuaXNSZWxhdGl2ZSgpCiAgICAgICAgIHx8IHIo KS5pc1JlbGF0aXZlKCkKICAgICAgICAgfHwgZngoKS5pc1JlbGF0aXZlKCkK 95105 2011-05-26 21:09:43 -0700 2011-05-26 21:15:15 -0700 Patch 2 svgradialgradientelement.patch text/plain 1119 rsleevi SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDg3NDY0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUt MjYgIFJ5YW4gU2xlZXZpICA8cnNsZWV2aUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29ycmVjdCB0aGUgbG9naWMgZm9yIGNo ZWNraW5nIGZvciByZWxhdGl2ZSBsZW5ndGhzIGluIGFuIFNWR1JhZGlhbEdyYWRpZW50RWxlbWVu dCB0byBjb25zaWRlciBjeCgpIGluIGFkZGl0aW9uIHRvIGN5KCkKKwlodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE2MDAuCisKKyAgICAgICAgKiBTb3VyY2UvV2ViQ29y ZS9zdmcvU1ZHUmFkaWFsR3JhZGllbnRFbGVtZW50LmNwcDoKKwogMjAxMS0wNS0yNSAgR3JlZ2cg VGF2YXJlcyAgPGdtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5l dGggUnVzc2VsbC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdSYWRpYWxHcmFkaWVudEVs ZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3N2Zy9TVkdSYWRpYWxHcmFk aWVudEVsZW1lbnQuY3BwCShyZXZpc2lvbiA4NzQ2NCkKKysrIFNvdXJjZS9XZWJDb3JlL3N2Zy9T VkdSYWRpYWxHcmFkaWVudEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zMDAsNyArMzAw LDcgQEAgdm9pZCBTVkdSYWRpYWxHcmFkaWVudEVsZW1lbnQ6OmNhbGN1bGF0ZQogCiBib29sIFNW R1JhZGlhbEdyYWRpZW50RWxlbWVudDo6c2VsZkhhc1JlbGF0aXZlTGVuZ3RocygpIGNvbnN0CiB7 Ci0gICAgcmV0dXJuIGN5KCkuaXNSZWxhdGl2ZSgpCisgICAgcmV0dXJuIGN4KCkuaXNSZWxhdGl2 ZSgpCiAgICAgICAgIHx8IGN5KCkuaXNSZWxhdGl2ZSgpCiAgICAgICAgIHx8IHIoKS5pc1JlbGF0 aXZlKCkKICAgICAgICAgfHwgZngoKS5pc1JlbGF0aXZlKCkK 95106 2011-05-26 21:15:15 -0700 2011-06-29 00:40:51 -0700 Attempt to fix style errors svgradialgradientelement.patch text/plain 1126 rsleevi SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDg3NDY0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUt MjYgIFJ5YW4gU2xlZXZpICA8cnNsZWV2aUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29ycmVjdCB0aGUgbG9naWMgZm9yIGNo ZWNraW5nIGZvciByZWxhdGl2ZSBsZW5ndGhzIGluIGFuIFNWR1JhZGlhbEdyYWRpZW50RWxlbWVu dCB0byBjb25zaWRlciBjeCgpIGluIGFkZGl0aW9uIHRvIGN5KCkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxNjAwLgorCisgICAgICAgICogU291cmNl L1dlYkNvcmUvc3ZnL1NWR1JhZGlhbEdyYWRpZW50RWxlbWVudC5jcHA6CisKIDIwMTEtMDUtMjUg IEdyZWdnIFRhdmFyZXMgIDxnbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBLZW5uZXRoIFJ1c3NlbGwuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHUmFkaWFsR3Jh ZGllbnRFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHUmFk aWFsR3JhZGllbnRFbGVtZW50LmNwcAkocmV2aXNpb24gODc0NjQpCisrKyBTb3VyY2UvV2ViQ29y ZS9zdmcvU1ZHUmFkaWFsR3JhZGllbnRFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAw LDcgKzMwMCw3IEBAIHZvaWQgU1ZHUmFkaWFsR3JhZGllbnRFbGVtZW50OjpjYWxjdWxhdGUKIAog Ym9vbCBTVkdSYWRpYWxHcmFkaWVudEVsZW1lbnQ6OnNlbGZIYXNSZWxhdGl2ZUxlbmd0aHMoKSBj b25zdAogewotICAgIHJldHVybiBjeSgpLmlzUmVsYXRpdmUoKQorICAgIHJldHVybiBjeCgpLmlz UmVsYXRpdmUoKQogICAgICAgICB8fCBjeSgpLmlzUmVsYXRpdmUoKQogICAgICAgICB8fCByKCku aXNSZWxhdGl2ZSgpCiAgICAgICAgIHx8IGZ4KCkuaXNSZWxhdGl2ZSgpCg== 99050 2011-06-29 00:40:57 -0700 2011-06-29 00:52:21 -0700 Patch bug-61600-20110629034055.patch text/plain 1819 rsleevi U3VidmVyc2lvbiBSZXZpc2lvbjogODk5OTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMTZiNGI5N2U0NzZjMzRj NzdjMjVmZTlmMWM2NDE2MzM4NmNhZDhiLi43MzhmOGZhZjg3NTM2NGI2ZGRjM2UxMjRiZGMyY2Iy MGIzYmVlYjcwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMjggIFJ5YW4g U2xlZXZpICA8cnNsZWV2aUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU1ZHUmFkaWFsR3JhZGllbnRFbGVtZW50OjpzZWxmSGFz UmVsYXRpdmVMZW5ndGhzKCkgZG9lc24ndCBjb25zaWRlciBpZiBjeCgpIGlzIHJlbGF0aXZlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTYwMAorCisg ICAgICAgIENvcnJlY3QgdGhlIGxvZ2ljIGZvciBjaGVja2luZyBmb3IgcmVsYXRpdmUgbGVuZ3Ro cyBpbiBhIFNWR1JhZGlhbEdyYWRpZW50RWxlbWVudCB0byBjb25zaWRlciBjeCgpIGluIGFkZGl0 aW9uIHRvIGN5KCkKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhcyB0aGVyZSBpcyBubyB3YXkgdG8g Y3VycmVudGx5IHRlc3QgdGhpcy4gV2l0aCB0aGUgYnVnIHByZXNlbnQsIGEgc2lkZS1lZmZlY3Qg aXMgY2F1c2luZyB0aGUgZXhwZWN0ZWQvY29ycmVjdCBpbWFnZSB0byBiZSByZW5kZXJlZC4gVGhp cyBpcyBiZWNhdXNlIHRoZSBjYWNoZWQgU1ZHIHJlc291cmNlIGlzIGdldHRpbmcgaW52YWxpZGVk IHRocm91Z2ggYSBkaWZmZXJlbnQgcGF0aCwgZm9yY2luZyBhIHJlcGFpbnQuIFRoZSByZXBhaW50 IHRha2VzIGludG8gY29uc2lkZXJhdGlvbiB0aGUgcHJvcGVyIGRpbWVuc2lvbnMsIGhpZGluZyB0 aGUgYnVnLgorCisgICAgICAgICogc3ZnL1NWR1JhZGlhbEdyYWRpZW50RWxlbWVudC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpTVkdSYWRpYWxHcmFkaWVudEVsZW1lbnQ6OnNlbGZIYXNSZWxhdGl2 ZUxlbmd0aHMpOgorCiAyMDExLTA2LTI4ICBEaW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VudCBUYW11cmEuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHUmFkaWFsR3JhZGllbnRFbGVtZW50LmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3N2Zy9TVkdSYWRpYWxHcmFkaWVudEVsZW1lbnQuY3BwCmluZGV4IGQ3NWRjZmNh OWUwY2M4NDhkYjIxYTcwNTFiMzIxN2UzZGQwY2E0ZTkuLjg4ZjE0OThhY2I0M2FkMTBkNjc1N2Jk ZmY0Mzg3MDdjNzFkZTQwMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdSYWRp YWxHcmFkaWVudEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdSYWRpYWxH cmFkaWVudEVsZW1lbnQuY3BwCkBAIC0zMDUsNyArMzA1LDcgQEAgdm9pZCBTVkdSYWRpYWxHcmFk aWVudEVsZW1lbnQ6OmNhbGN1bGF0ZUZvY2FsQ2VudGVyUG9pbnRzQW5kUmFkaXVzKGNvbnN0IFJh ZGlhbEcKIAogYm9vbCBTVkdSYWRpYWxHcmFkaWVudEVsZW1lbnQ6OnNlbGZIYXNSZWxhdGl2ZUxl bmd0aHMoKSBjb25zdAogewotICAgIHJldHVybiBjeSgpLmlzUmVsYXRpdmUoKQorICAgIHJldHVy biBjeCgpLmlzUmVsYXRpdmUoKQogICAgICAgICB8fCBjeSgpLmlzUmVsYXRpdmUoKQogICAgICAg ICB8fCByKCkuaXNSZWxhdGl2ZSgpCiAgICAgICAgIHx8IGZ4KCkuaXNSZWxhdGl2ZSgpCg== 99051 2011-06-29 00:52:26 -0700 2011-06-29 02:32:33 -0700 Patch bug-61600-20110629035225.patch text/plain 1847 rsleevi U3VidmVyc2lvbiBSZXZpc2lvbjogODk5OTAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMTZiNGI5N2U0NzZjMzRj NzdjMjVmZTlmMWM2NDE2MzM4NmNhZDhiLi41NmRmYjcyMWQ2YTVlZDQ1ZTQ5MmVmYTBmNTUyZDk0 ZGMwYzVjYjg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDYtMjggIFJ5YW4g U2xlZXZpICA8cnNsZWV2aUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgU1ZHUmFkaWFsR3JhZGllbnRFbGVtZW50OjpzZWxmSGFz UmVsYXRpdmVMZW5ndGhzKCkgZG9lc24ndCBjb25zaWRlciBpZiBjeCgpIGlzIHJlbGF0aXZlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTYwMAorCisg ICAgICAgIENvcnJlY3QgdGhlIGxvZ2ljIGZvciBjaGVja2luZyBmb3IgcmVsYXRpdmUgbGVuZ3Ro cyBpbiBhIFNWR1JhZGlhbEdyYWRpZW50RWxlbWVudCB0byBjb25zaWRlciBjeCgpIGluIGFkZGl0 aW9uIHRvIGN5KCkKKyAgICAgICAgCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYXMgdGhlcmUgaXMg bm8gd2F5IHRvIGN1cnJlbnRseSB0ZXN0IHRoaXMuIFdpdGggdGhlIGJ1ZyBwcmVzZW50LCBhIHNp ZGUtZWZmZWN0IGlzIGNhdXNpbmcgdGhlCisgICAgICAgIGV4cGVjdGVkL2NvcnJlY3QgaW1hZ2Ug dG8gYmUgcmVuZGVyZWQuIFRoaXMgaXMgYmVjYXVzZSB0aGUgY2FjaGVkIFNWRyByZXNvdXJjZSBp cyBnZXR0aW5nIGludmFsaWRlZCB0aHJvdWdoIGEKKyAgICAgICAgZGlmZmVyZW50IHBhdGgsIGZv cmNpbmcgYSByZXBhaW50LiBUaGUgcmVwYWludCB0YWtlcyBpbnRvIGNvbnNpZGVyYXRpb24gdGhl IHByb3BlciBkaW1lbnNpb25zLCBoaWRpbmcgdGhlIGJ1Zy4KKworICAgICAgICAqIHN2Zy9TVkdS YWRpYWxHcmFkaWVudEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHUmFkaWFsR3Jh ZGllbnRFbGVtZW50OjpzZWxmSGFzUmVsYXRpdmVMZW5ndGhzKToKKwogMjAxMS0wNi0yOCAgRGlt aXRyaSBHbGF6a292ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3ZnL1NWR1JhZGlh bEdyYWRpZW50RWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHUmFkaWFsR3JhZGll bnRFbGVtZW50LmNwcAppbmRleCBkNzVkY2ZjYTllMGNjODQ4ZGIyMWE3MDUxYjMyMTdlM2RkMGNh NGU5Li44OGYxNDk4YWNiNDNhZDEwZDY3NTdiZGZmNDM4NzA3YzcxZGU0MDMzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHUmFkaWFsR3JhZGllbnRFbGVtZW50LmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9zdmcvU1ZHUmFkaWFsR3JhZGllbnRFbGVtZW50LmNwcApAQCAtMzA1LDcg KzMwNSw3IEBAIHZvaWQgU1ZHUmFkaWFsR3JhZGllbnRFbGVtZW50OjpjYWxjdWxhdGVGb2NhbENl bnRlclBvaW50c0FuZFJhZGl1cyhjb25zdCBSYWRpYWxHCiAKIGJvb2wgU1ZHUmFkaWFsR3JhZGll bnRFbGVtZW50OjpzZWxmSGFzUmVsYXRpdmVMZW5ndGhzKCkgY29uc3QKIHsKLSAgICByZXR1cm4g Y3koKS5pc1JlbGF0aXZlKCkKKyAgICByZXR1cm4gY3goKS5pc1JlbGF0aXZlKCkKICAgICAgICAg fHwgY3koKS5pc1JlbGF0aXZlKCkKICAgICAgICAgfHwgcigpLmlzUmVsYXRpdmUoKQogICAgICAg ICB8fCBmeCgpLmlzUmVsYXRpdmUoKQo=