61588 2011-05-26 17:10:15 -0700 Add a key handling logging channel for WebKit2 2011-05-27 07:19:12 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jeffm jeffm oldest_to_newest 411031 0 jeffm 2011-05-26 17:10:15 -0700 Add a key handling logging channel for WebKit2 411034 1 jeffm 2011-05-26 17:11:40 -0700 This will help when investigating bug 58374. 411038 2 95086 jeffm 2011-05-26 17:16:51 -0700 Created attachment 95086 Patch 411135 3 95086 ap 2011-05-26 21:51:11 -0700 Comment on attachment 95086 Patch r=me, but please consider just using TextInput channel. 411418 4 jeffm 2011-05-27 07:17:48 -0700 (In reply to comment #3) > (From update of attachment 95086 [details]) > r=me, but please consider just using TextInput channel. Thanks for the review, but I disagree. Text input is completely different from key handling at this level. 411419 5 jeffm 2011-05-27 07:19:12 -0700 Committed r87509: <http://trac.webkit.org/changeset/87509> 95086 2011-05-26 17:16:51 -0700 2011-05-26 21:51:10 -0700 Patch bug-61588-20110526171651.patch text/plain 4906 jeffm SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3NDUzKQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTEtMDUtMjYgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBhIGtleSBoYW5kbGluZyBsb2dnaW5nIGNoYW5uZWwgZm9yIFdl YktpdDIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYx NTg4CisgICAgICAgIAorICAgICAgICBBZGRlZCBhIG5ldyBMb2dLZXlIYW5kbGluZyBjaGFubmVs LCBhbmQgbG9nZ2VkIHNvbWUga2V5IGV2ZW50cyBpbiBXZWJQYWdlUHJveHkuCisgICAgICAgIEkg YWxzbyBmaXhlZCBhIG1pc3NwZWxsaW5nIG9mIGNvYWxlc2NpbmcgaW4gYSBjb21tZW50IGluIFdl YlBhZ2VQcm94eS5jcHAuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Mb2dnaW5nLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6aW5pdGlhbGl6ZUxvZ0NoYW5uZWxzSWZOZWNlc3NhcnkpOiBJbml0aWFsaXpl IExvZ0tleUhhbmRsaW5nIGNoYW5uZWwuCisgICAgICAgICogUGxhdGZvcm0vTG9nZ2luZy5oOiBB ZGRlZCBMb2dLZXlIYW5kbGluZyBjaGFubmVsLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHA6IEZpeGVkIG1pc3NwZWxsaW5nIG9mIGNvYWxlc2NpbmcgaW4gYSBjb21tZW50 LgorICAgICAgICAoV2ViS2l0Ojp3ZWJLZXlib2FyZEV2ZW50VHlwZVN0cmluZyk6IEFkZGVkIHRv IHN1cHBvcnQgbG9nZ2luZy4KKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpoYW5kbGVL ZXlib2FyZEV2ZW50KTogTG9nIHRoZSBrZXlib2FyZCBldmVudC4KKyAgICAgICAgKFdlYktpdDo6 V2ViUGFnZVByb3h5OjpkaWRSZWNlaXZlRXZlbnQpOiBMb2cgdGhlIGtleWJvYXJkIGV2ZW50Lgor CiAyMDExLTA1LTI2ICBRaSBaaGFuZyAgPHFpLjIuemhhbmdAbm9raWEuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bS9Mb2dnaW5nLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Mb2dn aW5nLmNwcAkocmV2aXNpb24gODc0NTEpCisrKyBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Mb2dn aW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzUsNiArMzUsNyBAQCBXVEZMb2dDaGFubmVsIExv Z0NvbnRleHRNZW51ICA9IHsgMHgwMDAwCiBXVEZMb2dDaGFubmVsIExvZ1RleHRJbnB1dCAgICA9 IHsgMHgwMDAwMDAwNCwgIldlYktpdDJMb2dMZXZlbCIsIFdURkxvZ0NoYW5uZWxPZmYgfTsKIFdU RkxvZ0NoYW5uZWwgTG9nVmlldyAgICAgICAgID0geyAweDAwMDAwMDA4LCAiV2ViS2l0MkxvZ0xl dmVsIiwgV1RGTG9nQ2hhbm5lbE9mZiB9OwogV1RGTG9nQ2hhbm5lbCBMb2dJY29uRGF0YWJhc2Ug PSB7IDB4MDAwMDAwMTAsICJXZWJLaXQyTG9nTGV2ZWwiLCBXVEZMb2dDaGFubmVsT2ZmIH07CitX VEZMb2dDaGFubmVsIExvZ0tleUhhbmRsaW5nICA9IHsgMHgwMDAwMDAyMCwgIldlYktpdDJMb2dM ZXZlbCIsIFdURkxvZ0NoYW5uZWxPZmYgfTsKIAogI2lmICFQTEFURk9STShNQUMpCiB2b2lkIGlu aXRpYWxpemVMb2dDaGFubmVsKFdURkxvZ0NoYW5uZWwqIGNoYW5uZWwpCkBAIC01Miw2ICs1Myw3 IEBAIHZvaWQgaW5pdGlhbGl6ZUxvZ0NoYW5uZWxzSWZOZWNlc3NhcnkoKQogCiAgICAgaW5pdGlh bGl6ZUxvZ0NoYW5uZWwoJkxvZ0NvbnRleHRNZW51KTsKICAgICBpbml0aWFsaXplTG9nQ2hhbm5l bCgmTG9nSWNvbkRhdGFiYXNlKTsKKyAgICBpbml0aWFsaXplTG9nQ2hhbm5lbCgmTG9nS2V5SGFu ZGxpbmcpOwogICAgIGluaXRpYWxpemVMb2dDaGFubmVsKCZMb2dTZXNzaW9uU3RhdGUpOwogICAg IGluaXRpYWxpemVMb2dDaGFubmVsKCZMb2dUZXh0SW5wdXQpOwogICAgIGluaXRpYWxpemVMb2dD aGFubmVsKCZMb2dWaWV3KTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0xvZ2dpbmcu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Mb2dnaW5nLmgJKHJldmlz aW9uIDg3NDUxKQorKysgU291cmNlL1dlYktpdDIvUGxhdGZvcm0vTG9nZ2luZy5oCSh3b3JraW5n IGNvcHkpCkBAIC0zOCw2ICszOCw3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogCiBleHRlcm4gV1RG TG9nQ2hhbm5lbCBMb2dDb250ZXh0TWVudTsKIGV4dGVybiBXVEZMb2dDaGFubmVsIExvZ0ljb25E YXRhYmFzZTsKK2V4dGVybiBXVEZMb2dDaGFubmVsIExvZ0tleUhhbmRsaW5nOwogZXh0ZXJuIFdU RkxvZ0NoYW5uZWwgTG9nU2Vzc2lvblN0YXRlOwogZXh0ZXJuIFdURkxvZ0NoYW5uZWwgTG9nVGV4 dElucHV0OwogZXh0ZXJuIFdURkxvZ0NoYW5uZWwgTG9nVmlldzsKSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCShyZXZpc2lvbiA4NzQ1MSkKKysrIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0z Miw2ICszMiw3IEBACiAjaW5jbHVkZSAiRG93bmxvYWRQcm94eS5oIgogI2luY2x1ZGUgIkRyYXdp bmdBcmVhUHJveHkuaCIKICNpbmNsdWRlICJGaW5kSW5kaWNhdG9yLmgiCisjaW5jbHVkZSAiTG9n Z2luZy5oIgogI2luY2x1ZGUgIk1lc3NhZ2VJRC5oIgogI2luY2x1ZGUgIk5hdGl2ZVdlYktleWJv YXJkRXZlbnQuaCIKICNpbmNsdWRlICJOYXRpdmVXZWJNb3VzZUV2ZW50LmgiCkBAIC05MCw3ICs5 MSw3IEBACiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWRMZWFrQ291bnRlci5oPgogI2VuZGlmCiAK LS8vIFRoaXMgY29udHJvbHMgd2hhdCBzdHJhdGVneSB3ZSB1c2UgZm9yIG1vdXNlIHdoZWVsIGNv YWxlc2luZy4KKy8vIFRoaXMgY29udHJvbHMgd2hhdCBzdHJhdGVneSB3ZSB1c2UgZm9yIG1vdXNl IHdoZWVsIGNvYWxlc2NpbmcuCiAjZGVmaW5lIE1FUkdFX1dIRUVMX0VWRU5UUyAxCiAKICNkZWZp bmUgTUVTU0FHRV9DSEVDSyhhc3NlcnRpb24pIE1FU1NBR0VfQ0hFQ0tfQkFTRShhc3NlcnRpb24s IHByb2Nlc3MoKS0+Y29ubmVjdGlvbigpKQpAQCAtMTA1LDYgKzEwNiwyOSBAQCBXS1BhZ2VEZWJ1 Z1BhaW50RmxhZ3MgV2ViUGFnZVByb3h5OjpzX2RlCiBzdGF0aWMgV1RGOjpSZWZDb3VudGVkTGVh a0NvdW50ZXIgd2ViUGFnZVByb3h5Q291bnRlcigiV2ViUGFnZVByb3h5Iik7CiAjZW5kaWYKIAor I2lmICFMT0dfRElTQUJMRUQKK3N0YXRpYyBjb25zdCBjaGFyKiB3ZWJLZXlib2FyZEV2ZW50VHlw ZVN0cmluZyhXZWJFdmVudDo6VHlwZSB0eXBlKQoreworICAgIHN3aXRjaCAodHlwZSkgeworICAg IGNhc2UgV2ViRXZlbnQ6OktleURvd246CisgICAgICAgIHJldHVybiAiS2V5RG93biI7CisgICAg CisgICAgY2FzZSBXZWJFdmVudDo6S2V5VXA6CisgICAgICAgIHJldHVybiAiS2V5VXAiOworICAg IAorICAgIGNhc2UgV2ViRXZlbnQ6OlJhd0tleURvd246CisgICAgICAgIHJldHVybiAiUmF3S2V5 RG93biI7CisgICAgCisgICAgY2FzZSBXZWJFdmVudDo6Q2hhcjoKKyAgICAgICAgcmV0dXJuICJD aGFyIjsKKyAgICAKKyAgICBkZWZhdWx0OgorICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK KyAgICAgICAgcmV0dXJuICI8dW5rbm93bj4iOworICAgIH0KK30KKyNlbmRpZiAvLyAhTE9HX0RJ U0FCTEVECisKIFBhc3NSZWZQdHI8V2ViUGFnZVByb3h5PiBXZWJQYWdlUHJveHk6OmNyZWF0ZShQ YWdlQ2xpZW50KiBwYWdlQ2xpZW50LCBQYXNzUmVmUHRyPFdlYlByb2Nlc3NQcm94eT4gcHJvY2Vz cywgV2ViUGFnZUdyb3VwKiBwYWdlR3JvdXAsIHVpbnQ2NF90IHBhZ2VJRCkKIHsKICAgICByZXR1 cm4gYWRvcHRSZWYobmV3IFdlYlBhZ2VQcm94eShwYWdlQ2xpZW50LCBwcm9jZXNzLCBwYWdlR3Jv dXAsIHBhZ2VJRCkpOwpAQCAtOTAxLDYgKzkyNSw4IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpoYW5k bGVLZXlib2FyZEV2ZW50KGMKIHsKICAgICBpZiAoIWlzVmFsaWQoKSkKICAgICAgICAgcmV0dXJu OworICAgIAorICAgIExPRyhLZXlIYW5kbGluZywgIldlYlBhZ2VQcm94eTo6aGFuZGxlS2V5Ym9h cmRFdmVudDogJXMiLCB3ZWJLZXlib2FyZEV2ZW50VHlwZVN0cmluZyhldmVudC50eXBlKCkpKTsK IAogICAgIG1fa2V5RXZlbnRRdWV1ZS5hcHBlbmQoZXZlbnQpOwogCkBAIC0yNzA5LDYgKzI3MzUs OCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZGlkUmVjZWl2ZUV2ZW50KHVpbnQzCiAgICAgY2FzZSBX ZWJFdmVudDo6S2V5VXA6CiAgICAgY2FzZSBXZWJFdmVudDo6UmF3S2V5RG93bjoKICAgICBjYXNl IFdlYkV2ZW50OjpDaGFyOiB7CisgICAgICAgIExPRyhLZXlIYW5kbGluZywgIldlYlBhZ2VQcm94 eTo6ZGlkUmVjZWl2ZUV2ZW50OiAlcyIsIHdlYktleWJvYXJkRXZlbnRUeXBlU3RyaW5nKHR5cGUp KTsKKwogICAgICAgICBOYXRpdmVXZWJLZXlib2FyZEV2ZW50IGV2ZW50ID0gbV9rZXlFdmVudFF1 ZXVlLmZpcnN0KCk7CiAgICAgICAgIE1FU1NBR0VfQ0hFQ0sodHlwZSA9PSBldmVudC50eXBlKCkp OwogCg==