61573 2011-05-26 15:53:26 -0700 Update LayoutTests/media/broken-video to test for correct error codes 2011-12-21 16:25:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 scottfr webkit-unassigned eric.carlson eric scherkus webkit.review.bot oldest_to_newest 410951 0 scottfr 2011-05-26 15:53:26 -0700 Update LayoutTests/media/broken-video to test for correct error codes 410952 1 95062 scottfr 2011-05-26 15:55:29 -0700 Created attachment 95062 Patch 410959 2 95064 scottfr 2011-05-26 16:00:13 -0700 Created attachment 95064 Patch 432785 3 95064 eric.carlson 2011-07-06 08:13:38 -0700 Comment on attachment 95064 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95064&action=review r=me with the changes suggested. > LayoutTests/media/broken-video.html:2 > +<p>Test that QuickTime file with broken headers and content generates a SRC_NOT_SUPPORTED error.<p> This comment is incorrect as the test will not open a QuickTime movie, the two files that can be opened are garbage.mp4 and garbage.ogv. You also added a check for networkState so you may as well mention that as well. Something like "Tests that an invalid video file generates a MEDIA_ERR_SRC_NOT_SUPPORTED error and sets networkState to NETWORK_NO_SOURCE" perhaps? > LayoutTests/media/broken-video.html:11 > + testExpected("video.error.code", "4"); > + testExpected("video.networkState", "3"); I would prefer to have the named constants used here: testExpected("video.error.code", MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED); testExpected("video.networkState", HTMLMediaElement.NETWORK_NO_SOURCE); 432968 4 99868 scottfr 2011-07-06 13:16:32 -0700 Created attachment 99868 Patch 432972 5 scottfr 2011-07-06 13:20:41 -0700 (In reply to comment #3) > (From update of attachment 95064 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95064&action=review > > r=me with the changes suggested. > > > LayoutTests/media/broken-video.html:2 > > +<p>Test that QuickTime file with broken headers and content generates a SRC_NOT_SUPPORTED error.<p> > > This comment is incorrect as the test will not open a QuickTime movie, the two files that can be opened are garbage.mp4 and garbage.ogv. You also added a check for networkState so you may as well mention that as well. Something like "Tests that an invalid video file generates a MEDIA_ERR_SRC_NOT_SUPPORTED error and sets networkState to NETWORK_NO_SOURCE" perhaps? I thought the bit about QuickTime was weird, but I was trying to retain similarity to the original. Your suggestion is better. > > > LayoutTests/media/broken-video.html:11 > > + testExpected("video.error.code", "4"); > > + testExpected("video.networkState", "3"); > > I would prefer to have the named constants used here: > > testExpected("video.error.code", MediaError.MEDIA_ERR_SRC_NOT_SUPPORTED); > testExpected("video.networkState", HTMLMediaElement.NETWORK_NO_SOURCE); I didn't realize those existed. Fixed. 433431 6 99868 eric.carlson 2011-07-07 07:47:44 -0700 Comment on attachment 99868 Patch Thanks! 433576 7 99868 webkit.review.bot 2011-07-07 10:25:15 -0700 Comment on attachment 99868 Patch Rejecting attachment 99868 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2 Last 500 characters of output: b36a3fe474ec4831060744c9f3b0a94152ac3270 r90571 = 596b2635f80798fd6b8b5b058c781afb4001c10c Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/8990983 525713 8 99868 eric 2011-12-21 15:25:07 -0800 Comment on attachment 99868 Patch The cq bot seems sick. 525715 9 eric 2011-12-21 15:25:54 -0800 I doubt this will land correctly given it's been 5 months. If it fails to land we should just r- this. The author will need to post an updated patch. 525808 10 99868 webkit.review.bot 2011-12-21 16:25:38 -0800 Comment on attachment 99868 Patch Clearing flags on attachment: 99868 Committed r103472: <http://trac.webkit.org/changeset/103472> 525809 11 webkit.review.bot 2011-12-21 16:25:43 -0800 All reviewed patches have been landed. Closing bug. 95062 2011-05-26 15:55:29 -0700 2011-05-26 16:00:09 -0700 Patch bug-61573-20110526155527.patch text/plain 1540 scottfr U3VidmVyc2lvbiBSZXZpc2lvbjogODczOTUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL21lZGlh L2Jyb2tlbi12aWRlby1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9icm9rZW4tdmlk ZW8tZXhwZWN0ZWQudHh0CmluZGV4IDA3MjYzNzAyMmJjODBlNTljMDdlZWQ0ZTc3OGI5N2RkMDg4 M2Y1NjUuLjhmMWY0NGIxNzgwMTk0NDhkMWYyY2Q3YjNhZDVkZjIyZjA1MGRmM2IgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL21lZGlhL2Jyb2tlbi12aWRlby1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvbWVkaWEvYnJva2VuLXZpZGVvLWV4cGVjdGVkLnR4dApAQCAtMSw2ICsxLDggQEAK LVRlc3QgdGhhdCBRdWlja1RpbWUgZmlsZSB3aXRoIGJyb2tlbiBjb250ZW50IGdlbmVyYXRlcyBh biBlcnJvci4KK1Rlc3QgdGhhdCBRdWlja1RpbWUgZmlsZSB3aXRoIGJyb2tlbiBoZWFkZXJzIGFu ZCBjb250ZW50IGdlbmVyYXRlcyBhIFNSQ19OT1RfU1VQUE9SVEVEIGVycm9yLgogCiBFVkVOVChl cnJvcikKIEVYUEVDVEVEICh2aWRlby5lcnJvciA9PSAnW29iamVjdCBNZWRpYUVycm9yXScpIE9L CitFWFBFQ1RFRCAodmlkZW8uZXJyb3IuY29kZSA9PSAnNCcpIE9LCitFWFBFQ1RFRCAodmlkZW8u bmV0d29ya1N0YXRlID09ICczJykgT0sKIEVORCBPRiBURVNUCiAKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL21lZGlhL2Jyb2tlbi12aWRlby5odG1sIGIvTGF5b3V0VGVzdHMvbWVkaWEvYnJva2Vu LXZpZGVvLmh0bWwKaW5kZXggM2FhODQyNDdlMmI3YzI1NzEzZGQxMGQzNTgwMWQ4MWFmNzM2OWVi Yy4uYmU4NDZkYzJjYmVkNmY3MTUwMGUwM2MzZDYyMDEwODgyNTg5ODEwMiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvbWVkaWEvYnJva2VuLXZpZGVvLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvbWVk aWEvYnJva2VuLXZpZGVvLmh0bWwKQEAgLTEsNSArMSw1IEBACiA8dmlkZW8gY29udHJvbHM+PC92 aWRlbz4KLTxwPlRlc3QgdGhhdCBRdWlja1RpbWUgZmlsZSB3aXRoIGJyb2tlbiBjb250ZW50IGdl bmVyYXRlcyBhbiBlcnJvci48cD4KKzxwPlRlc3QgdGhhdCBRdWlja1RpbWUgZmlsZSB3aXRoIGJy b2tlbiBoZWFkZXJzIGFuZCBjb250ZW50IGdlbmVyYXRlcyBhIFNSQ19OT1RfU1VQUE9SVEVEIGVy cm9yLjxwPgogPHNjcmlwdCBzcmM9bWVkaWEtZmlsZS5qcz48L3NjcmlwdD4KIDxzY3JpcHQgc3Jj PXZpZGVvLXRlc3QuanM+PC9zY3JpcHQ+CiAKQEAgLTcsNiArNyw4IEBACiAgICAgdmlkZW8uc3Jj ID0gZmluZE1lZGlhRmlsZSgidmlkZW8iLCAiY29udGVudC9nYXJiYWdlIik7CiAgICAgd2FpdEZv ckV2ZW50KCJlcnJvciIsIGZ1bmN0aW9uICgpIHsKICAgICAgICAgdGVzdEV4cGVjdGVkKCJ2aWRl by5lcnJvciIsICJbb2JqZWN0IE1lZGlhRXJyb3JdIik7CisgICAgICAgIHRlc3RFeHBlY3RlZCgi dmlkZW8uZXJyb3IuY29kZSIsICI0Iik7CisgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8ubmV0 d29ya1N0YXRlIiwgIjMiKTsKICAgICAgICAgZW5kVGVzdCgpOwogICAgIH0pOwogPC9zY3JpcHQ+ Cg== 95064 2011-05-26 16:00:13 -0700 2011-07-06 13:16:27 -0700 Patch bug-61573-20110526160012.patch text/plain 2169 scottfr U3VidmVyc2lvbiBSZXZpc2lvbjogODczOTUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBlZDU1M2RhYTc2NDJjMWJiNDA3ZmM5 NTg1MjQyNGFlZDEyZmQzYjc1Li4wYjg1YzA3YWJiNTdlM2FjZTNlOTUwNzc2NTZlMTRhZTcxODcw ZjdjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDUtMjYgIFNjb3R0IEZyYW5rbGluICA8 c2NvdHRmckBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFVwZGF0ZSBMYXlvdXRUZXN0cy9tZWRpYS9icm9rZW4tdmlkZW8gdG8gdGVz dCBmb3IgY29ycmVjdCBlcnJvciBjb2RlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjE1NzMKKworICAgICAgICAqIG1lZGlhL2Jyb2tlbi12aWRlby1l eHBlY3RlZC50eHQ6CisgICAgICAgICogbWVkaWEvYnJva2VuLXZpZGVvLmh0bWw6CisKIDIwMTEt MDUtMjYgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVk aWEvYnJva2VuLXZpZGVvLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL21lZGlhL2Jyb2tlbi12 aWRlby1leHBlY3RlZC50eHQKaW5kZXggMDcyNjM3MDIyYmM4MGU1OWMwN2VlZDRlNzc4Yjk3ZGQw ODgzZjU2NS4uOGYxZjQ0YjE3ODAxOTQ0OGQxZjJjZDdiM2FkNWRmMjJmMDUwZGYzYiAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvbWVkaWEvYnJva2VuLXZpZGVvLWV4cGVjdGVkLnR4dAorKysgYi9M YXlvdXRUZXN0cy9tZWRpYS9icm9rZW4tdmlkZW8tZXhwZWN0ZWQudHh0CkBAIC0xLDYgKzEsOCBA QAotVGVzdCB0aGF0IFF1aWNrVGltZSBmaWxlIHdpdGggYnJva2VuIGNvbnRlbnQgZ2VuZXJhdGVz IGFuIGVycm9yLgorVGVzdCB0aGF0IFF1aWNrVGltZSBmaWxlIHdpdGggYnJva2VuIGhlYWRlcnMg YW5kIGNvbnRlbnQgZ2VuZXJhdGVzIGEgU1JDX05PVF9TVVBQT1JURUQgZXJyb3IuCiAKIEVWRU5U KGVycm9yKQogRVhQRUNURUQgKHZpZGVvLmVycm9yID09ICdbb2JqZWN0IE1lZGlhRXJyb3JdJykg T0sKK0VYUEVDVEVEICh2aWRlby5lcnJvci5jb2RlID09ICc0JykgT0sKK0VYUEVDVEVEICh2aWRl by5uZXR3b3JrU3RhdGUgPT0gJzMnKSBPSwogRU5EIE9GIFRFU1QKIApkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvbWVkaWEvYnJva2VuLXZpZGVvLmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS9icm9r ZW4tdmlkZW8uaHRtbAppbmRleCAzYWE4NDI0N2UyYjdjMjU3MTNkZDEwZDM1ODAxZDgxYWY3MzY5 ZWJjLi5iZTg0NmRjMmNiZWQ2ZjcxNTAwZTAzYzNkNjIwMTA4ODI1ODk4MTAyIDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9tZWRpYS9icm9rZW4tdmlkZW8uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9t ZWRpYS9icm9rZW4tdmlkZW8uaHRtbApAQCAtMSw1ICsxLDUgQEAKIDx2aWRlbyBjb250cm9scz48 L3ZpZGVvPgotPHA+VGVzdCB0aGF0IFF1aWNrVGltZSBmaWxlIHdpdGggYnJva2VuIGNvbnRlbnQg Z2VuZXJhdGVzIGFuIGVycm9yLjxwPgorPHA+VGVzdCB0aGF0IFF1aWNrVGltZSBmaWxlIHdpdGgg YnJva2VuIGhlYWRlcnMgYW5kIGNvbnRlbnQgZ2VuZXJhdGVzIGEgU1JDX05PVF9TVVBQT1JURUQg ZXJyb3IuPHA+CiA8c2NyaXB0IHNyYz1tZWRpYS1maWxlLmpzPjwvc2NyaXB0PgogPHNjcmlwdCBz cmM9dmlkZW8tdGVzdC5qcz48L3NjcmlwdD4KIApAQCAtNyw2ICs3LDggQEAKICAgICB2aWRlby5z cmMgPSBmaW5kTWVkaWFGaWxlKCJ2aWRlbyIsICJjb250ZW50L2dhcmJhZ2UiKTsKICAgICB3YWl0 Rm9yRXZlbnQoImVycm9yIiwgZnVuY3Rpb24gKCkgewogICAgICAgICB0ZXN0RXhwZWN0ZWQoInZp ZGVvLmVycm9yIiwgIltvYmplY3QgTWVkaWFFcnJvcl0iKTsKKyAgICAgICAgdGVzdEV4cGVjdGVk KCJ2aWRlby5lcnJvci5jb2RlIiwgIjQiKTsKKyAgICAgICAgdGVzdEV4cGVjdGVkKCJ2aWRlby5u ZXR3b3JrU3RhdGUiLCAiMyIpOwogICAgICAgICBlbmRUZXN0KCk7CiAgICAgfSk7CiA8L3Njcmlw dD4K 99868 2011-07-06 13:16:32 -0700 2011-12-21 16:25:38 -0800 Patch bug-61573-20110706131631.patch text/plain 2309 scottfr U3VidmVyc2lvbiBSZXZpc2lvbjogOTA0NjkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA1NWM5ZjVkY2NjZWE3YThiYjllZGYz NjJiYjhiMTgyMzMxMmExODk3Li40ZTUwNmZhNzNhYTdkNjQxZmMyMTgxZjY3NjgyYjkyYzY1M2Fj ZDczIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDctMDYgIFNjb3R0IEZyYW5rbGluICA8 c2NvdHRmckBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFVwZGF0ZSBMYXlvdXRUZXN0cy9tZWRpYS9icm9rZW4tdmlkZW8gdG8gdGVz dCBmb3IgY29ycmVjdCBlcnJvciBjb2RlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjE1NzMKKworICAgICAgICAqIG1lZGlhL2Jyb2tlbi12aWRlby1l eHBlY3RlZC50eHQ6CisgICAgICAgICogbWVkaWEvYnJva2VuLXZpZGVvLmh0bWw6CisKIDIwMTEt MDctMDYgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0g U2VlbXMgdGhhdCBJIHN0aWxsIGRvbid0IGdldCB0aGUgc3ludGF4IHJpZ2h0CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9tZWRpYS9icm9rZW4tdmlkZW8tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvbWVkaWEvYnJva2VuLXZpZGVvLWV4cGVjdGVkLnR4dAppbmRleCAwNzI2MzcwMjJiYzgwZTU5 YzA3ZWVkNGU3NzhiOTdkZDA4ODNmNTY1Li43ZjBiNjllNGIxNTc4MzU1MTczMDkwZDVkYWU4Nzk4 YzgyMDk3NDgzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9tZWRpYS9icm9rZW4tdmlkZW8tZXhw ZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL21lZGlhL2Jyb2tlbi12aWRlby1leHBlY3RlZC50 eHQKQEAgLTEsNiArMSw4IEBACi1UZXN0IHRoYXQgUXVpY2tUaW1lIGZpbGUgd2l0aCBicm9rZW4g Y29udGVudCBnZW5lcmF0ZXMgYW4gZXJyb3IuCitUZXN0IHRoYXQgYW4gaW52YWxpZCB2aWRlbyBm aWxlIGdlbmVyYXRlcyBhIE1FRElBX0VSUl9TUkNfTk9UX1NVUFBPUlRFRCBlcnJvciBhbmQgc2V0 cyBuZXR3b3JrU3RhdGUgdG8gTkVUV09SS19OT19TT1VSQ0UuCiAKIEVWRU5UKGVycm9yKQogRVhQ RUNURUQgKHZpZGVvLmVycm9yID09ICdbb2JqZWN0IE1lZGlhRXJyb3JdJykgT0sKK0VYUEVDVEVE ICh2aWRlby5lcnJvci5jb2RlID09ICc0JykgT0sKK0VYUEVDVEVEICh2aWRlby5uZXR3b3JrU3Rh dGUgPT0gJzMnKSBPSwogRU5EIE9GIFRFU1QKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVk aWEvYnJva2VuLXZpZGVvLmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS9icm9rZW4tdmlkZW8uaHRt bAppbmRleCAzYWE4NDI0N2UyYjdjMjU3MTNkZDEwZDM1ODAxZDgxYWY3MzY5ZWJjLi4zMzFjOGFl ODUwMzlmYmJjYTUyNzY5YTc1ZDI4MzEzY2MzZmI2ZjMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9tZWRpYS9icm9rZW4tdmlkZW8uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9icm9rZW4t dmlkZW8uaHRtbApAQCAtMSw1ICsxLDUgQEAKIDx2aWRlbyBjb250cm9scz48L3ZpZGVvPgotPHA+ VGVzdCB0aGF0IFF1aWNrVGltZSBmaWxlIHdpdGggYnJva2VuIGNvbnRlbnQgZ2VuZXJhdGVzIGFu IGVycm9yLjxwPgorPHA+VGVzdCB0aGF0IGFuIGludmFsaWQgdmlkZW8gZmlsZSBnZW5lcmF0ZXMg YSBNRURJQV9FUlJfU1JDX05PVF9TVVBQT1JURUQgZXJyb3IgYW5kIHNldHMgbmV0d29ya1N0YXRl IHRvIE5FVFdPUktfTk9fU09VUkNFLjwvcD4KIDxzY3JpcHQgc3JjPW1lZGlhLWZpbGUuanM+PC9z Y3JpcHQ+CiA8c2NyaXB0IHNyYz12aWRlby10ZXN0LmpzPjwvc2NyaXB0PgogCkBAIC03LDYgKzcs OCBAQAogICAgIHZpZGVvLnNyYyA9IGZpbmRNZWRpYUZpbGUoInZpZGVvIiwgImNvbnRlbnQvZ2Fy YmFnZSIpOwogICAgIHdhaXRGb3JFdmVudCgiZXJyb3IiLCBmdW5jdGlvbiAoKSB7CiAgICAgICAg IHRlc3RFeHBlY3RlZCgidmlkZW8uZXJyb3IiLCAiW29iamVjdCBNZWRpYUVycm9yXSIpOworICAg ICAgICB0ZXN0RXhwZWN0ZWQoInZpZGVvLmVycm9yLmNvZGUiLCBNZWRpYUVycm9yLk1FRElBX0VS Ul9TUkNfTk9UX1NVUFBPUlRFRCk7CisgICAgICAgIHRlc3RFeHBlY3RlZCgidmlkZW8ubmV0d29y a1N0YXRlIiwgSFRNTE1lZGlhRWxlbWVudC5ORVRXT1JLX05PX1NPVVJDRSk7CiAgICAgICAgIGVu ZFRlc3QoKTsKICAgICB9KTsKIDwvc2NyaXB0Pgo=