61569 2011-05-26 15:10:46 -0700 Fullscreen content is sometimes obscured by taskbar (which even covers up the "exit fullscreen" button) 2011-05-26 15:44:37 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC All RESOLVED FIXED InRadar P2 Normal --- 1 jeffm jeffm aroben jer.noble webkit.review.bot oldest_to_newest 410900 0 jeffm 2011-05-26 15:10:46 -0700 From Adam Roben: To reproduce: 1. Go to http://flexibits.com/fantastical 2. Click on "Watch the screencast" 3. Click the fullscreen button in the video controls to enter fullscreen Sometimes, the taskbar will appear in front of the fullscreen window. This obscures the video controls, including the "exit fullscreen" button. 410901 1 jeffm 2011-05-26 15:11:39 -0700 This appears to only happen the first time you take a video fullscreen. If I exit full screen and enter it again, the taskbar is hidden. 410902 2 jeffm 2011-05-26 15:12:03 -0700 Going to fullscreen involves: 1) Creating two initially hidden fullscreen windows, specifically MediaPlayerPrivateFullscreenWindow, one for the black "background" and one that contains the content. 2) Calling AnimateWindow() on the background window to animate showing it. 3) Forcing the WebView to repaint (which is synchronous in WK1, async in WK2). 4) When FullScreenController is notified that the WebView has repainted, it uses AnimateWindow() on the real fullscreen window to animate showing it. When the taskbar is hidden correctly, it appears to hide during step 2, which makes sense since showing the background window is the first time we show a fullscreen window. This would also seem to rule out any differences between WK1 and WK2, since the first call to AnimateWindow() happens before any web process messaging. I verified that after the calls to AnimateWindow() in step 2 and 4, the fullscreen window we just animated showing is the active window, which in theory should force Windows to hide the taskbar. 410903 3 jeffm 2011-05-26 15:12:15 -0700 I tried replacing the calls to AnimateWindow() with SetWindowPos(), but this bug still occurs. 410904 4 jeffm 2011-05-26 15:12:30 -0700 Jer and I found a kind of ugly workaround for this that involves making the fullscreen window a topmost window before animating it. The task bar is still visible when the background window animates in, but it disappears when the real fullscreen window animates in. 410905 5 jeffm 2011-05-26 15:12:55 -0700 <rdar://problem/9454315> 410921 6 95056 jeffm 2011-05-26 15:31:40 -0700 Created attachment 95056 Patch to make fullscreen window a topmost window. 410923 7 webkit.review.bot 2011-05-26 15:34:01 -0700 Attachment 95056 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/win/FullScreenController.cpp:89: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 410927 8 95056 sfalken 2011-05-26 15:36:11 -0700 Comment on attachment 95056 Patch to make fullscreen window a topmost window. You should change wParam == 0 to !wParam 410932 9 jeffm 2011-05-26 15:41:06 -0700 I'll fix this before landing the patch. 410938 10 jeffm 2011-05-26 15:44:37 -0700 Committed <http://trac.webkit.org/changeset/87442> 95056 2011-05-26 15:31:40 -0700 2011-05-26 15:36:11 -0700 Patch to make fullscreen window a topmost window. MakeFullscreenWindowTopmost.patch text/plain 2853 jeffm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3NDM4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDUtMjYgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZ1bGxzY3JlZW4gY29udGVudCBpcyBzb21ldGltZXMgb2JzY3VyZWQg YnkgdGFza2JhciAod2hpY2ggZXZlbiBjb3ZlcnMgdXAgdGhlICJleGl0IGZ1bGxzY3JlZW4iIGJ1 dHRvbikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYx NTY5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85NDU0MzE1PgorCisgICAgICAgIE5vcm1hbGx5 LCB3aGVuIHRoZSBiYWNrZ3JvdW5kIGZ1bGxzY3JlZW4gd2luZG93IGlzIGFuaW1hdGVkIGluLCB0 aGUgV2luZG93cyB0YXNrYmFyIHdpbGwgYmUgaGlkZGVuLCBidXQgdGhpcyBkb2Vzbid0IGFsd2F5 cyB3b3JrIGZvciBzb21lIHJlYXNvbi4KKyAgICAgICAgV29ya2Fyb3VuZCB0aGlzIGlzc3VlIGJ5 IHNldHRpbmcgdGhlIHJlYWwgZnVsbHNjcmVlbiB3aW5kb3cgdG8gYmUgYSB0b3Btb3N0IHdpbmRv dy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9GdWxsU2NyZWVuQ29udHJvbGxl ci5jcHA6CisgICAgICAgIChGdWxsU2NyZWVuQ29udHJvbGxlcjo6UHJpdmF0ZTo6ZnVsbHNjcmVl bkNsaWVudFduZFByb2MpOiBFeGl0IGZ1bGxzY3JlZW4gd2hlbiBtX2Z1bGxTY3JlZW5XaW5kb3cg aXMgZGVhY3RpdmF0ZWQuCisgICAgICAgIChGdWxsU2NyZWVuQ29udHJvbGxlcjo6ZW50ZXJGdWxs U2NyZWVuUmVwYWludENvbXBsZXRlZCk6IE1ha2UgbV9mdWxsU2NyZWVuV2luZG93IGEgdG9wbW9z dCB3aW5kb3cgYmVmb3JlIGFuaW1hdGluZyBpdCBpbiB0byBlbnN1cmUgdGhlIHRhc2tiYXIgaXMg aGlkZGVuLgorCiAyMDExLTA1LTI2ICBMZXZpIFdlaW50cmF1YiAgPGxldml3QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3dpbi9GdWxsU2NyZWVuQ29udHJvbGxlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0Z1bGxTY3JlZW5D b250cm9sbGVyLmNwcAkocmV2aXNpb24gODczODIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy93aW4vRnVsbFNjcmVlbkNvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC04NCw2ICs4NCwxMSBAQCBMUkVTVUxUIEZ1bGxTY3JlZW5Db250cm9sbGVyOjpQcml2YXRlOjpm CiAgICAgICAgIGlmIChtX2NsaWVudC0+ZnVsbFNjcmVlbkNsaWVudFdpbmRvdygpKQogICAgICAg ICAgICAgOjpTZXRXaW5kb3dQb3MobV9jbGllbnQtPmZ1bGxTY3JlZW5DbGllbnRXaW5kb3coKSwg MCwgMCwgMCwgbV9mdWxsU2NyZWVuRnJhbWUud2lkdGgoKSwgbV9mdWxsU2NyZWVuRnJhbWUuaGVp Z2h0KCksIFNXUF9OT1JFUE9TSVRJT04gIHwgU1dQX05PTU9WRSk7CiAgICAgICAgIGJyZWFrOwor ICAgIGNhc2UgV01fQUNUSVZBVEU6CisgICAgICAgIC8vIEJlY2F1c2UgbV9mdWxsU2NyZWVuV2lu ZG93IGlzIGEgdG9wbW9zdCB3aW5kb3csIHdlIG5lZWQgdG8gZXhpdCBmdWxsIHNjcmVlbiBleHBs aWNpdGx5IHdoZW4gaXQncyBkZWFjdGl2YXRlZC4KKyAgICAgICAgaWYgKCh3UGFyYW0gPT0gMCkg JiYgbV9mdWxsU2NyZWVuV2luZG93ICYmIChod25kID09IG1fZnVsbFNjcmVlbldpbmRvdy0+aHdu ZCgpKSkKKyAgICAgICAgICAgIG1fY29udHJvbGxlci0+ZXhpdEZ1bGxTY3JlZW4oKTsKKyAgICAg ICAgYnJlYWs7CiAgICAgY2FzZSBXTV9LRVlET1dOOgogICAgICAgICBpZiAod1BhcmFtID09IFZL X0VTQ0FQRSkgewogICAgICAgICAgICAgbV9jb250cm9sbGVyLT5leGl0RnVsbFNjcmVlbigpOwpA QCAtMTUyLDYgKzE1Nyw5IEBAIHZvaWQgRnVsbFNjcmVlbkNvbnRyb2xsZXI6OmVudGVyRnVsbFNj cmUKICAgICAgICAgcmV0dXJuOwogICAgIG1fcHJpdmF0ZS0+bV9pc0VudGVyaW5nRnVsbFNjcmVl biA9IGZhbHNlOwogCisgICAgLy8gTm9ybWFsbHksIHdoZW4gdGhlIGJhY2tncm91bmQgZnVsbHNj cmVlbiB3aW5kb3cgaXMgYW5pbWF0ZWQgaW4sIHRoZSBXaW5kb3dzIHRhc2tiYXIgd2lsbCBiZSBo aWRkZW4sIGJ1dCB0aGlzIGRvZXNuJ3QgYWx3YXlzIHdvcmsgZm9yIHNvbWUgcmVhc29uLgorICAg IC8vIFNldHRpbmcgdGhlIHJlYWwgZnVsbHNjcmVlbiB3aW5kb3cgdG8gYmUgYSB0b3Btb3N0IHdp bmRvdyB3aWxsIGZvcmNlIHRoZSB0YXNrYmFyIHRvIGJlIGhpZGRlbiB3aGVuIHdlIGNhbGwgQW5p bWF0ZVdpbmRvdygpIGJlbG93IGlmIGl0IHdhc24ndCBiZWZvcmUuCisgICAgOjpTZXRXaW5kb3dQ b3MobV9wcml2YXRlLT5tX2Z1bGxTY3JlZW5XaW5kb3ctPmh3bmQoKSwgSFdORF9UT1BNT1NULCAw LCAwLCAwLCAwLCBTV1BfTk9NT1ZFIHwgU1dQX05PU0laRSB8IFNXUF9OT0FDVElWQVRFKTsKICAg ICA6OkFuaW1hdGVXaW5kb3cobV9wcml2YXRlLT5tX2Z1bGxTY3JlZW5XaW5kb3ctPmh3bmQoKSwg a0Z1bGxTY3JlZW5BbmltYXRpb25EdXJhdGlvbiwgQVdfQkxFTkQgfCBBV19BQ1RJVkFURSk7CiB9 CiAK