61564 2011-05-26 14:30:56 -0700 REGRESSION(r87368): Wrong approach, will do the wrong thing if the element needs simplified normal flow layout but is not positioned (Requested by jamesr on #webkit). 2011-05-26 14:42:48 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60689 1 webkit.review.bot webkit.review.bot ademar commit-queue jamesr oldest_to_newest 410836 0 webkit.review.bot 2011-05-26 14:30:56 -0700 http://trac.webkit.org/changeset/87368 broke the build: Wrong approach, will do the wrong thing if the element needs simplified normal flow layout but is not positioned (Requested by jamesr on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 410837 1 95042 webkit.review.bot 2011-05-26 14:31:19 -0700 Created attachment 95042 ROLLOUT of r87368 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 410848 2 95042 commit-queue 2011-05-26 14:39:45 -0700 Comment on attachment 95042 ROLLOUT of r87368 Clearing flags on attachment: 95042 Committed r87432: <http://trac.webkit.org/changeset/87432> 410849 3 commit-queue 2011-05-26 14:39:49 -0700 All reviewed patches have been landed. Closing bug. 410852 4 ademar 2011-05-26 14:42:48 -0700 Revision r87432 cherry-picked into qtwebkit-2.2 with commit d462b6b <http://gitorious.org/webkit/qtwebkit/commit/d462b6b> 95042 2011-05-26 14:31:19 -0700 2011-05-26 14:39:45 -0700 ROLLOUT of r87368 bug-61564-20110526213024.patch text/plain 4815 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogODc0MjkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAwYzk4ZGRlYzExZDBjNDhmNzM0NGFk Zjk1YjIyZGM5YzgxOTU3OTNlLi5kZmU3NTRkNGNkY2M0MjZlZTJiMzI0MGM5ZjQ0ZmFiNTFlMjVi MDBjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDUtMjYgIFNoZXJpZmYgQm90ICA8d2Vi a2l0LnJldmlldy5ib3RAZ21haWwuY29tPgorCisgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHI4NzM2OC4KKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvODcz NjgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxNTY0 CisKKyAgICAgICAgV3JvbmcgYXBwcm9hY2gsIHdpbGwgZG8gdGhlIHdyb25nIHRoaW5nIGlmIHRo ZSBlbGVtZW50IG5lZWRzCisgICAgICAgIHNpbXBsaWZpZWQgbm9ybWFsIGZsb3cgbGF5b3V0IGJ1 dCBpcyBub3QgcG9zaXRpb25lZCAoUmVxdWVzdGVkCisgICAgICAgIGJ5IGphbWVzciBvbiAjd2Vi a2l0KS4KKworICAgICAgICAqIHRyYW5zZm9ybXMvMmQvc2V0LXRyYW5zZm9ybS1hbmQtdG9wLWV4 cGVjdGVkLnR4dDogUmVtb3ZlZC4KKyAgICAgICAgKiB0cmFuc2Zvcm1zLzJkL3NldC10cmFuc2Zv cm0tYW5kLXRvcC5odG1sOiBSZW1vdmVkLgorCiAyMDExLTA1LTAyICBSb2JlcnQgSG9nYW4gIDxy b2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvdHJhbnNmb3Jtcy8yZC9zZXQtdHJhbnNmb3JtLWFuZC10b3At ZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvdHJhbnNmb3Jtcy8yZC9zZXQtdHJhbnNmb3JtLWFu ZC10b3AtZXhwZWN0ZWQudHh0CmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAxOTg0Mjdj Y2QwZjhmN2Q2OGU4MzZkZDVhMjE4MjE3ZjE4MTQxMzVhLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRlc3RzL3RyYW5zZm9ybXMvMmQvc2V0LXRy YW5zZm9ybS1hbmQtdG9wLWV4cGVjdGVkLnR4dAorKysgL2Rldi9udWxsCkBAIC0xICswLDAgQEAK LVBBU1MgLSBFbGVtZW50IG1vdmVkIHBhc3QgeT0yNTBweApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvdHJhbnNmb3Jtcy8yZC9zZXQtdHJhbnNmb3JtLWFuZC10b3AuaHRtbCBiL0xheW91dFRlc3Rz L3RyYW5zZm9ybXMvMmQvc2V0LXRyYW5zZm9ybS1hbmQtdG9wLmh0bWwKZGVsZXRlZCBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDk2MDc1YjUyNjkwY2NiZDFlMjJhN2UzNWMyYmM2ZTc0NjQ3ZTllODcu LjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVz dHMvdHJhbnNmb3Jtcy8yZC9zZXQtdHJhbnNmb3JtLWFuZC10b3AuaHRtbAorKysgL2Rldi9udWxs CkBAIC0xLDUzICswLDAgQEAKLTxodG1sPgotPGhlYWQ+Ci08c3R5bGU+Ci0uYm94IHsKLSAgICB3 aWR0aDogMTAwcHg7Ci0gICAgaGVpZ2h0OiAxMDBweDsKLSAgICBiYWNrZ3JvdW5kLWNvbG9yOiBy ZWQ7Ci0gICAgcG9zaXRpb246IGFic29sdXRlOwotICAgIHRvcDogNjBweDsKLSAgICBsZWZ0OiA0 MHB4OwotfQotPC9zdHlsZT4KLTxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KLQotZnVu Y3Rpb24gcnVuVGVzdCgpIHsKLQotICAgIHZhciBpZDEgPSAiYSI7Ci0gICAgdmFyIGVsZW1lbnQx ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImEiKTsKLSAgICB2YXIgeTEgPSB3ZWJraXRDb252 ZXJ0UG9pbnRGcm9tTm9kZVRvUGFnZShlbGVtZW50MSwgbmV3IFdlYktpdFBvaW50KDAsMCkpLnk7 Ci0KLSAgICB2YXIgcmVzdWx0U3RyaW5nID0gJyc7Ci0gICAgaWYgKHkxID4gMjUwKSB7Ci0gICAg ICAgIHJlc3VsdFN0cmluZyArPSAiUEFTUyAtIEVsZW1lbnQgbW92ZWQgcGFzdCB5PTI1MHB4IjsK LSAgICB9IGVsc2UgewotICAgICAgICByZXN1bHRTdHJpbmcgKz0gIkZBSUwgLSBFbGVtZW50IHN0 aWxsIGF0IHk9IiArIHkxICsgInB4IjsKLSAgICB9Ci0KLSAgICBkb2N1bWVudC5ib2R5LmFwcGVu ZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKHJlc3VsdFN0cmluZykpOwotCi0gICAgaWYg KHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewotICAgICAgICB3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwotICAgICAgICB3aW5kb3cubGF5b3V0VGVzdENvbnRy b2xsZXIubm90aWZ5RG9uZSgpOwotICAgIH0KLX0KLTwvc2NyaXB0PgotPC9oZWFkPgotPGJvZHk+ Ci0KLTxkaXYgY2xhc3M9ImJveCIgaWQ9ImEiPjwvZGl2PgotCi08c2NyaXB0PgotICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCi0gICAgICAgIHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlci53YWl0VW50aWxEb25lKCk7Ci0KLSAgICBzZXRUaW1lb3V0KG1vdmUsIDEwKTsKLSAg ICBmdW5jdGlvbiBtb3ZlKCkgewotICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYScp LnN0eWxlLnRvcCA9ICIzMDBweCI7Ci0gICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdh Jykuc3R5bGUud2Via2l0VHJhbnNmb3JtID0gInJvdGF0ZSg0NWRlZykiOwotICAgICAgICBzZXRU aW1lb3V0KHJ1blRlc3QsIDApOwotICAgIH0KLTwvc2NyaXB0PgotPC9ib2R5PgotPC9odG1sPgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDIxMGQ5MTRjNjVjN2E5YzBmYTllN2QwNTc5OTJiZDhjZTY0OTZlYjEuLmIw MWVkYTIzMjk1YWZiOTg2ZGVmZDg3OGQ3MDE3NTc0YjdmMDdiOWQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxMS0wNS0yNiAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBn bWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg3MzY4LgorICAg ICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC84NzM2OAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE1NjQKKworICAgICAgICBXcm9u ZyBhcHByb2FjaCwgd2lsbCBkbyB0aGUgd3JvbmcgdGhpbmcgaWYgdGhlIGVsZW1lbnQgbmVlZHMK KyAgICAgICAgc2ltcGxpZmllZCBub3JtYWwgZmxvdyBsYXlvdXQgYnV0IGlzIG5vdCBwb3NpdGlv bmVkIChSZXF1ZXN0ZWQKKyAgICAgICAgYnkgamFtZXNyIG9uICN3ZWJraXQpLgorCisgICAgICAg ICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2Jq ZWN0OjpuZWVkc1Bvc2l0aW9uZWRNb3ZlbWVudExheW91dCk6CisKIDIwMTEtMDUtMDIgIFJvYmVy dCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0g Um9iZW4uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0 LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKaW5kZXggZDIyYjM5 NzRhZGJjODk3YTdhZmU1YTA1ZWYyM2VhNjkzY2Y5Zjg5ZC4uZTUwYTdmY2ZkMzRjNWM5NWQ1Yzdh ZDg2YTVlOTMyNDgzMTYxNDRhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlck9iamVjdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmpl Y3QuaApAQCAtNDMxLDcgKzQzMSw3IEBAIHB1YmxpYzoKICAgICBib29sIGhhc0JhY2tncm91bmQo KSBjb25zdCB7IHJldHVybiBzdHlsZSgpLT5oYXNCYWNrZ3JvdW5kKCk7IH0KICAgICBib29sIG5l ZWRzTGF5b3V0KCkgY29uc3QgeyByZXR1cm4gbV9uZWVkc0xheW91dCB8fCBtX25vcm1hbENoaWxk TmVlZHNMYXlvdXQgfHwgbV9wb3NDaGlsZE5lZWRzTGF5b3V0IHx8IG1fbmVlZHNTaW1wbGlmaWVk Tm9ybWFsRmxvd0xheW91dCB8fCBtX25lZWRzUG9zaXRpb25lZE1vdmVtZW50TGF5b3V0OyB9CiAg ICAgYm9vbCBzZWxmTmVlZHNMYXlvdXQoKSBjb25zdCB7IHJldHVybiBtX25lZWRzTGF5b3V0OyB9 Ci0gICAgYm9vbCBuZWVkc1Bvc2l0aW9uZWRNb3ZlbWVudExheW91dCgpIGNvbnN0IHsgcmV0dXJu IG1fbmVlZHNQb3NpdGlvbmVkTW92ZW1lbnRMYXlvdXQgfHwgbV9uZWVkc1NpbXBsaWZpZWROb3Jt YWxGbG93TGF5b3V0OyB9CisgICAgYm9vbCBuZWVkc1Bvc2l0aW9uZWRNb3ZlbWVudExheW91dCgp IGNvbnN0IHsgcmV0dXJuIG1fbmVlZHNQb3NpdGlvbmVkTW92ZW1lbnRMYXlvdXQ7IH0KICAgICBi b29sIG5lZWRzUG9zaXRpb25lZE1vdmVtZW50TGF5b3V0T25seSgpIGNvbnN0IHsgcmV0dXJuIG1f bmVlZHNQb3NpdGlvbmVkTW92ZW1lbnRMYXlvdXQgJiYgIW1fbmVlZHNMYXlvdXQgJiYgIW1fbm9y bWFsQ2hpbGROZWVkc0xheW91dCAmJiAhbV9wb3NDaGlsZE5lZWRzTGF5b3V0ICYmICFtX25lZWRz U2ltcGxpZmllZE5vcm1hbEZsb3dMYXlvdXQ7IH0KICAgICBib29sIHBvc0NoaWxkTmVlZHNMYXlv dXQoKSBjb25zdCB7IHJldHVybiBtX3Bvc0NoaWxkTmVlZHNMYXlvdXQ7IH0KICAgICBib29sIG5l ZWRzU2ltcGxpZmllZE5vcm1hbEZsb3dMYXlvdXQoKSBjb25zdCB7IHJldHVybiBtX25lZWRzU2lt cGxpZmllZE5vcm1hbEZsb3dMYXlvdXQ7IH0K