6156 2005-12-19 22:21:08 -0800 Leaks when running SVG tests 2005-12-20 01:32:08 -0800 1 1 1 Unclassified WebKit SVG 420+ Mac OS X 10.4 RESOLVED FIXED P4 Normal --- 1 eric eric oliver oldest_to_newest 26233 0 eric 2005-12-19 22:21:08 -0800 Leaks when running SVG tests Close a few of the leaks when running the SVG tests. The only remaining leaks are in throwError and are of UStrings. I expect those may be related to http://bugzilla.opendarwin.org/show_bug.cgi?id=6096 26234 1 5168 eric 2005-12-19 22:21:39 -0800 Created attachment 5168 Close a couple small leaks from SVG code 26235 2 5168 eric 2005-12-19 22:22:46 -0800 Comment on attachment 5168 Close a couple small leaks from SVG code There are two leaks closed here. One is specific to DumpRenderTree and is in the Path->String conversion code. The second is in the lighting code. The way that I closed it is by making the KCanvas lighting element own the light source. I'm not sure that's really the best solution long term, but was the quickest way to victory for now, and is something that can be revisited when we revisit how filters are handled in KCanvas. 5168 2005-12-19 22:21:39 -0800 2005-12-20 01:38:44 -0800 Close a couple small leaks from SVG code svg-leaks.patch text/plain 3949 eric SW5kZXg6IGtjYW52YXMvS0NhbnZhc0ZpbHRlcnMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9j dnMvcm9vdC9XZWJDb3JlL2tjYW52YXMvS0NhbnZhc0ZpbHRlcnMuY3BwLHYKcmV0cmlldmluZyBy ZXZpc2lvbiAxLjExCmRpZmYgLXAgLXUgLXIxLjExIGtjYW52YXMvS0NhbnZhc0ZpbHRlcnMuY3Bw Ci0tLSBrY2FudmFzL0tDYW52YXNGaWx0ZXJzLmNwcAkxMiBEZWMgMjAwNSAxNzoyNTo1NSAtMDAw MAkxLjExCisrKyBrY2FudmFzL0tDYW52YXNGaWx0ZXJzLmNwcAkyMCBEZWMgMjAwNSAwNjoxMjoz MSAtMDAwMApAQCAtMjg3LDYgKzI4NywyMiBAQCBRVGV4dFN0cmVhbSAmS0NhbnZhc0ZFQ29udm9s dmVNYXRyaXg6OmV4CiAgICByZXR1cm4gdHM7CiB9CiAKK3ZvaWQgS0NhbnZhc0ZFRGlmZnVzZUxp Z2h0aW5nOjpzZXRMaWdodFNvdXJjZShLQ0xpZ2h0U291cmNlICpsaWdodFNvdXJjZSkKK3sKKyAg ICBpZiAobV9saWdodFNvdXJjZSAhPSBsaWdodFNvdXJjZSkgeworICAgICAgICBkZWxldGUgbV9s aWdodFNvdXJjZTsKKyAgICAgICAgbV9saWdodFNvdXJjZSA9IGxpZ2h0U291cmNlOworICAgIH0K K30KKwordm9pZCBLQ2FudmFzRkVTcGVjdWxhckxpZ2h0aW5nOjpzZXRMaWdodFNvdXJjZShLQ0xp Z2h0U291cmNlICpsaWdodFNvdXJjZSkKK3sKKyAgICBpZiAobV9saWdodFNvdXJjZSAhPSBsaWdo dFNvdXJjZSkgeworICAgICAgICBkZWxldGUgbV9saWdodFNvdXJjZTsKKyAgICAgICAgbV9saWdo dFNvdXJjZSA9IGxpZ2h0U291cmNlOworICAgIH0KK30KKwogUVRleHRTdHJlYW0gJktDYW52YXNG RURpZmZ1c2VMaWdodGluZzo6ZXh0ZXJuYWxSZXByZXNlbnRhdGlvbihRVGV4dFN0cmVhbSAmdHMp IGNvbnN0CiB7CiAgICAgdHMgPDwgIlt0eXBlPURJRkZVU0UtTElHSFRJTkddICI7CkluZGV4OiBr Y2FudmFzL0tDYW52YXNGaWx0ZXJzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290L1dl YkNvcmUva2NhbnZhcy9LQ2FudmFzRmlsdGVycy5oLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE1 CmRpZmYgLXAgLXUgLXIxLjE1IGtjYW52YXMvS0NhbnZhc0ZpbHRlcnMuaAotLS0ga2NhbnZhcy9L Q2FudmFzRmlsdGVycy5oCTEyIERlYyAyMDA1IDE3OjI1OjU1IC0wMDAwCTEuMTUKKysrIGtjYW52 YXMvS0NhbnZhc0ZpbHRlcnMuaAkyMCBEZWMgMjAwNSAwNjoxMjozMSAtMDAwMApAQCAtNDM4LDYg KzQzOCw5IEBAIHByaXZhdGU6CiBjbGFzcyBLQ2FudmFzRkVEaWZmdXNlTGlnaHRpbmcgOiBwdWJs aWMgS0NhbnZhc0ZpbHRlckVmZmVjdAogewogcHVibGljOgorICAgIEtDYW52YXNGRURpZmZ1c2VM aWdodGluZygpIDogbV9saWdodFNvdXJjZSgwKSB7IH0KKyAgICB+S0NhbnZhc0ZFRGlmZnVzZUxp Z2h0aW5nKCkgeyBkZWxldGUgbV9saWdodFNvdXJjZTsgfQorCiAgICAgUUNvbG9yIGxpZ2h0aW5n Q29sb3IoKSBjb25zdCB7IHJldHVybiBtX2xpZ2h0aW5nQ29sb3I7IH0KICAgICB2b2lkIHNldExp Z2h0aW5nQ29sb3IoY29uc3QgUUNvbG9yICZsaWdodGluZ0NvbG9yKSB7IG1fbGlnaHRpbmdDb2xv ciA9IGxpZ2h0aW5nQ29sb3I7IH0KIApAQCAtNDUzLDggKzQ1Niw4IEBAIHB1YmxpYzoKICAgICBm bG9hdCBrZXJuZWxVbml0TGVuZ3RoWSgpIGNvbnN0IHsgcmV0dXJuIG1fa2VybmVsVW5pdExlbmd0 aFk7IH0KICAgICB2b2lkIHNldEtlcm5lbFVuaXRMZW5ndGhZKGZsb2F0IGtlcm5lbFVuaXRMZW5n dGhZKSB7IG1fa2VybmVsVW5pdExlbmd0aFkgPSBrZXJuZWxVbml0TGVuZ3RoWTsgfQogCi0gICAg Y29uc3QgS0NMaWdodFNvdXJjZSAqIGxpZ2h0U291cmNlKCkgY29uc3QgeyByZXR1cm4gbV9saWdo dFNvdXJjZTsgfQotICAgIHZvaWQgc2V0TGlnaHRTb3VyY2UoS0NMaWdodFNvdXJjZSAqIGxpZ2h0 U291cmNlKSB7IG1fbGlnaHRTb3VyY2UgPSBsaWdodFNvdXJjZTsgfQorICAgIGNvbnN0IEtDTGln aHRTb3VyY2UgKmxpZ2h0U291cmNlKCkgY29uc3QgeyByZXR1cm4gbV9saWdodFNvdXJjZTsgfQor ICAgIHZvaWQgc2V0TGlnaHRTb3VyY2UoS0NMaWdodFNvdXJjZSAqbGlnaHRTb3VyY2UpOwogICAg IAogICAgIFFUZXh0U3RyZWFtICZleHRlcm5hbFJlcHJlc2VudGF0aW9uKFFUZXh0U3RyZWFtICYp IGNvbnN0OwogCkBAIC01OTUsNiArNTk4LDkgQEAgcHJpdmF0ZToKIGNsYXNzIEtDYW52YXNGRVNw ZWN1bGFyTGlnaHRpbmcgOiBwdWJsaWMgS0NhbnZhc0ZpbHRlckVmZmVjdAogewogcHVibGljOgor ICAgIEtDYW52YXNGRVNwZWN1bGFyTGlnaHRpbmcoKSA6IG1fbGlnaHRTb3VyY2UoMCkgeyB9Cisg ICAgfktDYW52YXNGRVNwZWN1bGFyTGlnaHRpbmcoKSB7IGRlbGV0ZSBtX2xpZ2h0U291cmNlOyB9 CisKICAgICBRQ29sb3IgbGlnaHRpbmdDb2xvcigpIGNvbnN0IHsgcmV0dXJuIG1fbGlnaHRpbmdD b2xvcjsgfQogICAgIHZvaWQgc2V0TGlnaHRpbmdDb2xvcihjb25zdCBRQ29sb3IgJmxpZ2h0aW5n Q29sb3IpIHsgbV9saWdodGluZ0NvbG9yID0gbGlnaHRpbmdDb2xvcjsgfQogCkBAIC02MTMsOCAr NjE5LDggQEAgcHVibGljOgogICAgIGZsb2F0IGtlcm5lbFVuaXRMZW5ndGhZKCkgY29uc3QgeyBy ZXR1cm4gbV9rZXJuZWxVbml0TGVuZ3RoWTsgfQogICAgIHZvaWQgc2V0S2VybmVsVW5pdExlbmd0 aFkoZmxvYXQga2VybmVsVW5pdExlbmd0aFkpIHsgbV9rZXJuZWxVbml0TGVuZ3RoWSA9IGtlcm5l bFVuaXRMZW5ndGhZOyB9CiAgICAgCi0gICAgY29uc3QgS0NMaWdodFNvdXJjZSAqIGxpZ2h0U291 cmNlKCkgY29uc3QgeyByZXR1cm4gbV9saWdodFNvdXJjZTsgfQotICAgIHZvaWQgc2V0TGlnaHRT b3VyY2UoS0NMaWdodFNvdXJjZSAqIGxpZ2h0U291cmNlKSB7IG1fbGlnaHRTb3VyY2UgPSBsaWdo dFNvdXJjZTsgfQorICAgIGNvbnN0IEtDTGlnaHRTb3VyY2UgKmxpZ2h0U291cmNlKCkgY29uc3Qg eyByZXR1cm4gbV9saWdodFNvdXJjZTsgfQorICAgIHZvaWQgc2V0TGlnaHRTb3VyY2UoS0NMaWdo dFNvdXJjZSAqbGlnaHRTb3VyY2UpOwogICAgIAogICAgIFFUZXh0U3RyZWFtICZleHRlcm5hbFJl cHJlc2VudGF0aW9uKFFUZXh0U3RyZWFtICYpIGNvbnN0OwogICAgIApJbmRleDoga2NhbnZhcy9k ZXZpY2UvcXVhcnR6L0tSZW5kZXJpbmdEZXZpY2VRdWFydHoubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9yb290L1dlYkNvcmUva2NhbnZhcy9kZXZpY2UvcXVhcnR6L0tSZW5kZXJpbmdEZXZp Y2VRdWFydHoubW0sdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuOApkaWZmIC1wIC11IC1yMS44IGtj YW52YXMvZGV2aWNlL3F1YXJ0ei9LUmVuZGVyaW5nRGV2aWNlUXVhcnR6Lm1tCi0tLSBrY2FudmFz L2RldmljZS9xdWFydHovS1JlbmRlcmluZ0RldmljZVF1YXJ0ei5tbQk2IERlYyAyMDA1IDAxOjIz OjIyIC0wMDAwCTEuOAorKysga2NhbnZhcy9kZXZpY2UvcXVhcnR6L0tSZW5kZXJpbmdEZXZpY2VR dWFydHoubW0JMjAgRGVjIDIwMDUgMDY6MTI6MzIgLTAwMDAKQEAgLTE3Myw2ICsxNzMsNyBAQCBR U3RyaW5nIEtSZW5kZXJpbmdEZXZpY2VRdWFydHo6OnN0cmluZ0ZvCiAgICAgICAgIENHUGF0aFJl ZiBjZ1BhdGggPSBzdGF0aWNfY2FzdDxjb25zdCBLQ2FudmFzUGF0aFF1YXJ0eiAqPihwYXRoKS0+ Y2dQYXRoKCk7CiAgICAgICAgIENGU3RyaW5nUmVmIHBhdGhTdHJpbmcgPSBDRlN0cmluZ0Zyb21D R1BhdGgoY2dQYXRoKTsKICAgICAgICAgcmVzdWx0ID0gUVN0cmluZzo6ZnJvbUNGU3RyaW5nKHBh dGhTdHJpbmcpOworICAgICAgICBDRlJlbGVhc2UocGF0aFN0cmluZyk7CiAgICAgfQogICAgIHJl dHVybiByZXN1bHQ7CiB9Cg==