61545 2011-05-26 11:01:19 -0700 [chromium] Be robust to empty viewports in the compositor 2011-05-26 12:06:58 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne enne jamesr nduca oldest_to_newest 410597 0 enne 2011-05-26 11:01:19 -0700 [chromium] Be robust to empty viewports in the compositor 410613 1 95008 enne 2011-05-26 11:13:10 -0700 Created attachment 95008 Patch 410617 2 enne 2011-05-26 11:17:03 -0700 See: http://code.google.com/p/chromium/issues/detail?id=83961 The order of events that causes this is that the layer renderer is created and a doComposite event is called while the layer renderer (and the main frame) have an empty viewport rect. This might be able to be fixed at a higher level too, but I think this code should be robust to the possibility of an empty content rect. 410625 3 95008 jamesr 2011-05-26 11:26:38 -0700 Comment on attachment 95008 Patch R=me. the m_updateRect = IntRect() before the early out confused me for a bit, maybe stick the clear inside the branch? 410630 4 enne 2011-05-26 11:29:07 -0700 (In reply to comment #3) > (From update of attachment 95008 [details]) > R=me. the m_updateRect = IntRect() before the early out confused me for a bit, maybe stick the clear inside the branch? Thanks. I'll clean that up before landing. 410713 5 enne 2011-05-26 12:06:58 -0700 Committed r87409: <http://trac.webkit.org/changeset/87409> 95008 2011-05-26 11:13:10 -0700 2011-05-26 11:26:38 -0700 Patch bug-61545-20110526111309.patch text/plain 4144 enne U3VidmVyc2lvbiBSZXZpc2lvbjogODczMTYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBkMmFiMGQ1MzRiMzIyM2E0 ODY5ZDA1OWUwNTlhZjk0NGJhNGE4YmEzLi43NjIwZDBiZjI0MDBhMzJmZjUxZjg3MGFjMTNiMTAx MDNkMmI4MDY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDUtMjYgIEFkcmll bm5lIFdhbGtlciAgPGVubmVAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEJlIHJvYnVzdCB0byBlbXB0eSB2aWV3 cG9ydHMgaW4gdGhlIGNvbXBvc2l0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTYxNTQ1CisKKyAgICAgICAgSXQncyBwb3NzaWJsZSBmb3IgYSBmcmFt ZSB0byBiZSByZXF1ZXN0ZWQgdG8gYmUgZHJhd24gYmVmb3JlIGl0IGlzCisgICAgICAgIG5vbi1l bXB0eS4gIFRoZSBjb21wb3NpdG9yIHNob3VsZCBiZSByb2J1c3QgdG8gdGhhdCBwb3NzaWJpbGl0 eS4gIFRoZQorICAgICAgICBjaGFuZ2VzIGluIExheWVyVGlsZXJDaHJvbWl1bSBhcmUgdGhlIG9u bHkgcmVxdWlyZWQgY2hhbmdlcyB0byBoYW5kbGUKKyAgICAgICAgdGhpcywgYnV0IGhhdmluZyBh biBlYXJseSBvdXQgaW4gTGF5ZXJSZW5kZXJlckNocm9taXVtIHNlZW1lZCBsaWtlIGEKKyAgICAg ICAgZ29vZCBzYW5pdHkgY2hlY2suCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJS ZW5kZXJlckNocm9taXVtOjp1cGRhdGVBbmREcmF3TGF5ZXJzKToKKyAgICAgICAgKFdlYkNvcmU6 OkxheWVyUmVuZGVyZXJDaHJvbWl1bTo6ZHJhd0xheWVycyk6CisgICAgICAgICogcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVtLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkxheWVyVGlsZXJDaHJvbWl1bTo6cHJlcGFyZVRvVXBkYXRlKToKKyAgICAgICAgKFdlYkNv cmU6OkxheWVyVGlsZXJDaHJvbWl1bTo6dXBkYXRlUmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpM YXllclRpbGVyQ2hyb21pdW06OmRyYXcpOgorCiAyMDExLTA1LTI1ICBDYWlvIE1hcmNlbG8gZGUg T2xpdmVpcmEgRmlsaG8gIDxjYWlvLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21p dW0uY3BwCmluZGV4IDM2NTk5YmJjZTkzYTdlZGM2YWJmN2FlMjYzOTI0YTQyOTE0MWI5OTUuLjgz OGI3MmZiNGNmYjRmM2UzMjFkMWIwMTZmNzM4ZDRiOGVmN2Y0NzYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1 bS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5 ZXJSZW5kZXJlckNocm9taXVtLmNwcApAQCAtMjExLDYgKzIxMSw5IEBAIHZvaWQgTGF5ZXJSZW5k ZXJlckNocm9taXVtOjpzZXRWaWV3cG9ydChjb25zdCBJbnRSZWN0JiB2aXNpYmxlUmVjdCwgY29u c3QgSW50UmVjCiAKIHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjp1cGRhdGVBbmREcmF3TGF5 ZXJzKCkKIHsKKyAgICBpZiAobV92aWV3cG9ydFZpc2libGVSZWN0LmlzRW1wdHkoKSkKKyAgICAg ICAgcmV0dXJuOworCiAgICAgLy8gRklYTUU6IHVzZSB0aGUgZnJhbWUgYmVnaW4gdGltZSBmcm9t IHRoZSBvdmVyYWxsIGNvbXBvc2l0b3Igc2NoZWR1bGVyLgogICAgIC8vIFRoaXMgdmFsdWUgaXMg Y3VycmVudGx5IGluYWNjZXNzaWJsZSBiZWNhdXNlIGl0IGlzIHVwIGluIENocm9taXVtJ3MKICAg ICAvLyBSZW5kZXJXaWRnZXQuCkBAIC00MzQsNiArNDM3LDkgQEAgdm9pZCBMYXllclJlbmRlcmVy Q2hyb21pdW06OnBhaW50TGF5ZXJDb250ZW50cyhjb25zdCBMYXllckxpc3QmIHJlbmRlclN1cmZh Y2VMYXkKIAogdm9pZCBMYXllclJlbmRlcmVyQ2hyb21pdW06OmRyYXdMYXllcnMoY29uc3QgTGF5 ZXJMaXN0JiByZW5kZXJTdXJmYWNlTGF5ZXJMaXN0KQogeworICAgIGlmIChtX3ZpZXdwb3J0Vmlz aWJsZVJlY3QuaXNFbXB0eSgpKQorICAgICAgICByZXR1cm47CisKICAgICBUUkFDRV9FVkVOVCgi TGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5ZXJzIiwgdGhpcywgMCk7CiAgICAgQ0NMYXll ckltcGwqIHJvb3REcmF3TGF5ZXIgPSBtX3Jvb3RMYXllci0+Y2NMYXllckltcGwoKTsKICAgICBt YWtlQ29udGV4dEN1cnJlbnQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL0xheWVyVGlsZXJDaHJvbWl1bS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclRpbGVyQ2hyb21pdW0uY3BwCmluZGV4 IGRiNTMxYzUwZWQ4ODA1ZTFjZmFiYzhlN2Q4MTA5OWZhOGJkYTliNDMuLmI1MGY1MzEyYjdhYjkw MTcwNGFkNjFjOTM5NzFlMzc4ODM0NDc2NWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyVGlsZXJDaHJvbWl1bS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJUaWxlckNocm9taXVt LmNwcApAQCAtMjIyLDcgKzIyMiw5IEBAIHZvaWQgTGF5ZXJUaWxlckNocm9taXVtOjppbnZhbGlk YXRlRW50aXJlTGF5ZXIoKQogCiB2b2lkIExheWVyVGlsZXJDaHJvbWl1bTo6cHJlcGFyZVRvVXBk YXRlKGNvbnN0IEludFJlY3QmIGNvbnRlbnRSZWN0KQogewotICAgIGlmIChtX3NraXBzRHJhdykK KyAgICBtX3VwZGF0ZVJlY3QgPSBJbnRSZWN0KCk7CisKKyAgICBpZiAobV9za2lwc0RyYXcgfHwg Y29udGVudFJlY3QuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47CiAKICAgICAvLyBJbnZhbGlk YXRlIG9sZCB0aWxlcyB0aGF0IHdlcmUgcHJldmlvdXNseSB1c2VkIGJ1dCBhcmVuJ3QgaW4gdXNl IHRoaXMKQEAgLTI2Myw3ICsyNjUsNyBAQCB2b2lkIExheWVyVGlsZXJDaHJvbWl1bTo6cHJlcGFy ZVRvVXBkYXRlKGNvbnN0IEludFJlY3QmIGNvbnRlbnRSZWN0KQogdm9pZCBMYXllclRpbGVyQ2hy b21pdW06OnVwZGF0ZVJlY3QoKQogewogICAgIC8vIFBhaW50aW5nIGNvdWxkIGNhdXNlIGNvbXBv c2l0aW5nIHRvIGdldCB0dXJuZWQgb2ZmLCB3aGljaCBtYXkgY2F1c2UgdGhlIHRpbGVyIHRvIGJl Y29tZSBpbnZhbGlkYXRlZCBtaWQtdXBkYXRlLgotICAgIGlmICghbV90aWxpbmdEYXRhLnRvdGFs U2l6ZVgoKSB8fCAhbV90aWxpbmdEYXRhLnRvdGFsU2l6ZVkoKSkKKyAgICBpZiAoIW1fdGlsaW5n RGF0YS50b3RhbFNpemVYKCkgfHwgIW1fdGlsaW5nRGF0YS50b3RhbFNpemVZKCkgfHwgbV91cGRh dGVSZWN0LmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJuOwogCiAgICAgR3JhcGhpY3NDb250ZXh0 M0QqIGNvbnRleHQgPSBsYXllclJlbmRlcmVyQ29udGV4dCgpOwpAQCAtMzMzLDcgKzMzNSw3IEBA IHZvaWQgTGF5ZXJUaWxlckNocm9taXVtOjpzZXRMYXllclBvc2l0aW9uKGNvbnN0IEludFBvaW50 JiBsYXllclBvc2l0aW9uKQogCiB2b2lkIExheWVyVGlsZXJDaHJvbWl1bTo6ZHJhdyhjb25zdCBJ bnRSZWN0JiBjb250ZW50UmVjdCwgY29uc3QgVHJhbnNmb3JtYXRpb25NYXRyaXgmIGdsb2JhbFRy YW5zZm9ybSwgZmxvYXQgb3BhY2l0eSkKIHsKLSAgICBpZiAobV9za2lwc0RyYXcgfHwgIW1fdGls ZXMuc2l6ZSgpKQorICAgIGlmIChtX3NraXBzRHJhdyB8fCAhbV90aWxlcy5zaXplKCkgfHwgY29u dGVudFJlY3QuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47CiAKICAgICBHcmFwaGljc0NvbnRl eHQzRCogY29udGV4dCA9IGxheWVyUmVuZGVyZXJDb250ZXh0KCk7Cg==