61542 2011-05-26 10:14:57 -0700 Add a ResourceRequestBase::TargetType for XMLHttpRequests 2011-08-02 12:06:29 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 0 vsevik webkit-unassigned ap caseq jochen pfeldman yurys oldest_to_newest 410565 0 vsevik 2011-05-26 10:14:57 -0700 Add a ResourceRequestBase::TargetType for XMLHttpRequests. This is needed by inspector to distinguish XHR network callbacks early. 410569 1 94999 vsevik 2011-05-26 10:18:23 -0700 Created attachment 94999 Patch 410822 2 94999 ap 2011-05-26 14:21:06 -0700 Comment on attachment 94999 Patch TargetType is going away from ResourceRequestBase, see bug 48483. Some other solution will be needed for Web Inspector. 410839 3 ap 2011-05-26 14:33:46 -0700 (I really hope that Inspector hasn't started using this field yet... It would be so much harder to move to a correct place then.) 410945 4 vsevik 2011-05-26 15:46:02 -0700 (In reply to comment #3) > (I really hope that Inspector hasn't started using this field yet... It would be so much harder to move to a correct place then.) No, inspector does not use it yet. This bug could be closed then. Maybe it's worth adding a comment to ResourceRequestBase saying that this field is not for use in WebCore? 410960 5 ap 2011-05-26 16:03:07 -0700 > Maybe it's worth adding a comment to ResourceRequestBase saying that this field is not for use in WebCore? Yes! I've previously added a comment to the header, but it turned out to be insufficiently clear or noticeable. // FIXME: This should be moved out of ResourceRequestBase, <https://bugs.webkit.org/show_bug.cgi?id=48483>. 445405 6 ap 2011-08-02 12:06:29 -0700 *** Bug 65544 has been marked as a duplicate of this bug. *** 94999 2011-05-26 10:18:23 -0700 2011-05-26 14:21:06 -0700 Patch targ text/plain 2136 vsevik ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MmExMDkyLi43YjQ5MjA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDUtMjYgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgUmVz b3VyY2VSZXF1ZXN0QmFzZTo6VGFyZ2V0VHlwZSBmb3IgWE1MSHR0cFJlcXVlc3RzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTU0MgorCisgICAgICAg IE5vIG5ldyBmdW5jdGlvbmFsaXR5IGFkZGVkLCBzbyBubyBhZGRpdGlvbmFsIHRlc3RzLgorCisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmg6CisKIDIwMTEt MDUtMjYgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuaAppbmRleCA0YzdhYmNiLi4xZWUx NmEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNl UmVxdWVzdEJhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291 cmNlUmVxdWVzdEJhc2UuaApAQCAtNjcsNiArNjcsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAg ICAgICAgICAgICBUYXJnZXRJc1ByZWZldGNoLAogICAgICAgICAgICAgVGFyZ2V0SXNQcmVyZW5k ZXIsCiAgICAgICAgICAgICBUYXJnZXRJc0Zhdmljb24sCisgICAgICAgICAgICBUYXJnZXRJc1hN TEh0dHBSZXF1ZXN0LAogICAgICAgICB9OwogCiAgICAgICAgIHN0YXRpYyBQYXNzT3duUHRyPFJl c291cmNlUmVxdWVzdD4gYWRvcHQoUGFzc093blB0cjxDcm9zc1RocmVhZFJlc291cmNlUmVxdWVz dERhdGE+KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggYzBmMTQyYS4uZWM0ZmVlNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMS0wNS0yNiAg VnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBSZXNvdXJjZVJlcXVlc3RCYXNl OjpUYXJnZXRUeXBlIGZvciBYTUxIdHRwUmVxdWVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxNTQyCisKKyAgICAgICAgKiBwdWJsaWMvV2ViVVJM UmVxdWVzdC5oOgorCiAyMDExLTA1LTI1ICBTaGlzaGlyIEFncmF3YWwgIDxzaGlzaGlyQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxSZXF1ZXN0LmggYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJVUkxSZXF1ZXN0LmgKaW5kZXggNzVhNTFjMi4u NzUyZWNiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViVVJM UmVxdWVzdC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlVSTFJlcXVl c3QuaApAQCAtNzEsNiArNzEsNyBAQCBwdWJsaWM6CiAgICAgICAgIFRhcmdldElzUHJlZmV0Y2gg PSAxMSwKICAgICAgICAgVGFyZ2V0SXNQcmVyZW5kZXIgPSAxMiwKICAgICAgICAgVGFyZ2V0SXNG YXZpY29uID0gMTMsCisgICAgICAgIFRhcmdldElzWE1MSHR0cFJlcXVlc3QgPSAxNCwKICAgICB9 OwogCiAgICAgY2xhc3MgRXh0cmFEYXRhIHsK