61515 2011-05-26 02:33:06 -0700 [Chromium] fix a layout test crash except for mac (LayoutTest/fast/forms/select-script-onchange.html) 2012-03-16 15:26:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Linux RESOLVED DUPLICATE 63857 P2 Normal --- 0 toyoshim webkit-unassigned eric tkent webkit.review.bot oldest_to_newest 410316 0 toyoshim 2011-05-26 02:33:06 -0700 LayoutTest/fast/forms/select-script-onchange.html crashes on chromium-linux and chromium-win. Pop-up keystrokes depends on platform and classed into two groups. As WebCore/dom/SelectElement.cpp said like: // Configure platform-specific behavior when focused pop-up receives arrow/space/return keystroke. // (PLATFORM(MAC) and PLATFORM(GTK) are always false in Chromium, hence the extra tests.) #if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && OS(DARWIN)) #define ARROW_KEYS_POP_MENU 1 #define SPACE_OR_RETURN_POP_MENU 0 #elif PLATFORM(GTK) || (PLATFORM(CHROMIUM) && OS(UNIX)) #define ARROW_KEYS_POP_MENU 0 #define SPACE_OR_RETURN_POP_MENU 1 #else #define ARROW_KEYS_POP_MENU 0 #define SPACE_OR_RETURN_POP_MENU 0 #endif This test sends "t\r" keyDown event to change the selected item. It cause calling WebViewHost::createPopupMenu() on SPACE_OR_RETURN_POP_MENU platform, and it's not implemented by DumpRenderTree for chromium (Tools/DumpRenderTree/chromium/WebViewHost.cpp:241). Originally "\r" must be intended to call htmlForm->submitImplicitly() on ARROW_KEYS_POP_MENU platform. But this function isn't called on SPACE_OR_RETURN_POP_MENU platform. So, I just skip it on SPACE_OR_RETURN_POP_MENU platform. Crash dump is following [11297:11297:4333840847280:ERROR:process_util_posix.cc(108)] Received signal 11 base::debug::StackTrace::StackTrace() [0x91b81a] base::(anonymous namespace)::StackDumpSignalHandler() [0x8e42cb] 0x7f8ebbed3af0 WebKit::WebPopupMenuImpl::Init() [0x4fbb82] WebKit::ChromeClientImpl::popupOpened() [0x4be183] WebCore::PopupContainer::showPopup() [0xd6cf6d] WebCore::PopupContainer::showInRect() [0xd6d98c] WebCore::PopupMenuChromium::show() [0xd71993] WebCore::RenderMenuList::showPopup() [0x159fbb2] WebCore::SelectElement::menuListDefaultEventHandler() [0x10a0a3b] WebCore::SelectElement::defaultEventHandler() [0x10a1a9c] WebCore::HTMLSelectElement::defaultEventHandler() [0x675866] WebCore::EventDispatcher::dispatchEvent() [0x1046f51] WebCore::EventDispatchMediator::dispatchEvent() [0x104572c] WebCore::KeyboardEventDispatchMediator::dispatchEvent() [0x1054729] WebCore::EventDispatcher::dispatchEvent() [0x10458dd] WebCore::Node::dispatchKeyEvent() [0x106819f] WebCore::EventHandler::keyEvent() [0x126ba76] WebKit::WebViewImpl::charEvent() [0x4a8a5f] WebKit::WebViewImpl::handleInputEvent() [0x4aa330] EventSender::keyDown() [0x43083d] (snip) 410333 1 94954 toyoshim 2011-05-26 03:31:50 -0700 Created attachment 94954 Patch 410335 2 webkit.review.bot 2011-05-26 03:34:25 -0700 Attachment 94954 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 LayoutTests/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] LayoutTests/ChangeLog:10: Line contains tab character. [whitespace/tab] [5] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 410337 3 toyoshim 2011-05-26 03:38:47 -0700 This change use navigator.userAgent to switch codes which depends on platform. Another idea is preparing two different tests for each platform and just skip a test for another. Actually, I'm not familier with platform dependent tests. So I could not decide which is better approach. 410340 4 94956 toyoshim 2011-05-26 03:41:22 -0700 Created attachment 94956 Fix style bugs 410417 5 94956 tkent 2011-05-26 07:25:20 -0700 Comment on attachment 94956 Fix style bugs (In reply to comment #0) > It cause calling WebViewHost::createPopupMenu() on SPACE_OR_RETURN_POP_MENU platform, > and it's not implemented by DumpRenderTree for chromium > (Tools/DumpRenderTree/chromium/WebViewHost.cpp:241). Right. So we should implement popup menu in DRT/Chromium. > Originally "\r" must be intended to call htmlForm->submitImplicitly() on ARROW_KEYS_POP_MENU platform. No. Select elements in the test don't have their parent forms. So submitImplicitly() is not called. 411096 6 toyoshim 2011-05-26 20:16:24 -0700 Hi, Kent-san. Thank you for review. (In reply to comment #5) > Right. So we should implement popup menu in DRT/Chromium. OK. I understand DRT/Chromium needs pseudo popup implementation. But, originally this test doesn't require popup menu. So I think it's independent issue. This test works on Mac as... 1. popup.focus() Set active focus to second select form. 2. eventSender.keyDown("t", null); Select the second item 'two' by initial word 't'. 3. eventSender.keyDown("\r", null); Fix the selection. And on Linux and Windows as... 1. popup.focus() Set active focus to second select form. 2. eventSender.keyDown("t", null); Select the second item 'two' by initial word 't'. 3. eventSender.keyDown("\r", null); Show pulldown menu for select items. The process 3 cause quite different action for Linux and Windows. Because pop-up keystrokes configuration is different as I described. Popup menu is not intended. That's why I just skip the "\r" event in this change. 411103 7 tkent 2011-05-26 20:25:29 -0700 (In reply to comment #6) > But, originally this test doesn't require popup menu. It's right. But showing a pop-menu should be harmless. Actually this test doesn't fail on Qt and Apple Windows. So we don't need to remove the \r. 411106 8 toyoshim 2011-05-26 20:30:11 -0700 > It's right. But showing a pop-menu should be harmless. Actually this test doesn't fail on Qt and Apple Windows. So we don't need to remove the \r. OK. I see the background. I withdraw this patch. 432600 9 eric 2011-07-05 20:44:50 -0700 What's the status of this old patch? 433383 10 tkent 2011-07-07 04:08:05 -0700 I think the problem was resolved by another patch. https://bugs.webkit.org/show_bug.cgi?id=63857 433564 11 eric 2011-07-07 10:17:17 -0700 *** This bug has been marked as a duplicate of bug 63857 *** 94954 2011-05-26 03:31:50 -0700 2011-05-26 03:41:14 -0700 Patch bug-61515-20110526193149.patch text/plain 2168 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogODcyNjYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjYTFlNWEzYjhlYTI3ZTEyMThhMTBm ZWI1YzE2NzBmZTI5Y2FiY2JmLi43ODgwNGQxNTMxODNiNDQwM2I5NWI3NzEzNWRlNDMyN2ViMzcw OWU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMjYgIFRha2FzaGkgVG95b3NoaW1h ICA8dG95b3NoaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gZml4IGEgbGF5b3V0IHRlc3QgY3Jhc2ggZXhj ZXB0IGZvciBtYWMKKwkoTGF5b3V0VGVzdC9mYXN0L2Zvcm1zL3NlbGVjdC1zY3JpcHQtb25jaGFu Z2UuaHRtbCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTYxNTE1CisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3NlbGVjdC1zY3JpcHQtb25jaGFuZ2UuaHRt bDogQXZvaWQgIlxyIiBldmVudCBleGNlcHQgZm9yCisJbWFjLgorCiAyMDExLTA1LTI0ICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEBjb2RlYXVyb3JhLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBIYWppbWUgTW9yaXRhLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jt cy9zZWxlY3Qtc2NyaXB0LW9uY2hhbmdlLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Nl bGVjdC1zY3JpcHQtb25jaGFuZ2UuaHRtbAppbmRleCA1ZjU2MDQ0NDZkZTE5MWM0ZjQxZmRmODU5 OTJiNTJlM2YwYjY5YTMxLi43ZmNjYTJlNTJhMWJkMDE2N2YxZjVmNWY2NzhkMTg5NTFlOTk3NTYw IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdC1zY3JpcHQtb25jaGFu Z2UuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdC1zY3JpcHQtb25jaGFu Z2UuaHRtbApAQCAtMTksNyArMTksMTYgQEAKICAgICAgICAgICAgICAgICBwb3B1cC5mb2N1cygp OwogCiAgICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIua2V5RG93bigidCIsIG51bGwpOwotICAg ICAgICAgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oIlxyIiwgbnVsbCk7CisgICAgICAgICAg ICAgICAgLy8gUG9wLXVwIGtleXN0cm9rZSBjb25maWd1cmF0aW9uIGRlcGVuZHMgcGxhdGZvcm0u CisgICAgICAgICAgICAgICAgLy8gIlxyIiBldmVudCB3YW50cyB0byBzaG93IHVuaW1wbGVtZW50 ZWQgcG9wdXAgb24KKyAgICAgICAgICAgICAgICAvLyBTUEFDRV9PUl9SRVRVUk5fUE9QX01FTlUu CisgICAgICAgICAgICAgICAgLy8gU2VlIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTYxNTE1IC4KKyAgICAgICAgICAgICAgICBpZiAobmF2aWdhdG9yLnVzZXJBZ2VudC5p bmRleE9mKCJNYWNpbnRvc2giKSAhPSAtMSkgeworICAgICAgICAgICAgICAgICAgICAvLyBLZXlz dHJva2UgY29uZmlndXJhdGlvbiBpcyBBUlJPV19LRVlTX1BPUF9NRU5VLgorICAgICAgICAgICAg ICAgICAgICAvLyAiXHIiIGV2ZW50IGNhbGwgaHRtbEZvcm0tPnN1Ym1pdEltcGxpY2l0bHkoKSB3 aGljaAorICAgICAgICAgICAgICAgICAgICAvLyBjYXVzZWQgdGhlIGlzc3VlLgorICAgICAgICAg ICAgICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCJcciIsIG51bGwpOworICAgICAgICAgICAg ICAgIH0KIAogICAgICAgICAgICAgICAgIHZhciBwb3B1cCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJzd2l0Y2hlcjMiKTsKICAgICAgICAgICAgICAgICBwb3B1cC5mb2N1cygpOwpAQCAtMjcs NyArMzYsOCBAQAogICAgICAgICAgICAgICAgIGNoZWNrKCk7CiAgICAgICAgICAgIH0KIAotICAg ICAgICAgICBmdW5jdGlvbiBjaGVjaygpIHsKKyAgICAgICAgICAgZnVuY3Rpb24gY2hlY2soKQor ICAgICAgICAgICB7CiAgICAgICAgICAgICAgICAgc2V0VGltZW91dCgiZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJ3N3aXRjaGVyMycpLnNlbGVjdGVkSW5kZXggPSAxOyIsIDApOwogCiAgICAgICAg ICAgICAgICAgdmFyIHBvcHVwID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInN3aXRjaGVyMiIp Owo= 94956 2011-05-26 03:41:22 -0700 2012-03-16 15:26:33 -0700 Fix style bugs bug-61515-20110526194120.patch text/plain 2182 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogODcyNjYKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBjYTFlNWEzYjhlYTI3ZTEyMThhMTBm ZWI1YzE2NzBmZTI5Y2FiY2JmLi5jODBjZjQ1ZTQzM2Y4YWE4Mzc5YTkyYzI2MGE2MDA0ZjViNGFj NTI0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMjYgIFRha2FzaGkgVG95b3NoaW1h ICA8dG95b3NoaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gZml4IGEgbGF5b3V0IHRlc3QgY3Jhc2ggZXhj ZXB0IGZvciBtYWMKKyAgICAgICAgKExheW91dFRlc3QvZmFzdC9mb3Jtcy9zZWxlY3Qtc2NyaXB0 LW9uY2hhbmdlLmh0bWwpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02MTUxNQorCisgICAgICAgICogZmFzdC9mb3Jtcy9zZWxlY3Qtc2NyaXB0LW9uY2hh bmdlLmh0bWw6IEF2b2lkICJcciIgZXZlbnQgZXhjZXB0IGZvcgorICAgICAgICBtYWMuCisKIDIw MTEtMDUtMjQgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QGNvZGVhdXJvcmEub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IEhhamltZSBNb3JpdGEuCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL3NlbGVjdC1zY3JpcHQtb25jaGFuZ2UuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvc2VsZWN0LXNjcmlwdC1vbmNoYW5nZS5odG1sCmluZGV4IDVmNTYwNDQ0NmRl MTkxYzRmNDFmZGY4NTk5MmI1MmUzZjBiNjlhMzEuLjdmY2NhMmU1MmExYmQwMTY3ZjFmNWY1ZjY3 OGQxODk1MWU5OTc1NjAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VsZWN0 LXNjcmlwdC1vbmNoYW5nZS5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvc2VsZWN0 LXNjcmlwdC1vbmNoYW5nZS5odG1sCkBAIC0xOSw3ICsxOSwxNiBAQAogICAgICAgICAgICAgICAg IHBvcHVwLmZvY3VzKCk7CiAKICAgICAgICAgICAgICAgICBldmVudFNlbmRlci5rZXlEb3duKCJ0 IiwgbnVsbCk7Ci0gICAgICAgICAgICAgICAgZXZlbnRTZW5kZXIua2V5RG93bigiXHIiLCBudWxs KTsKKyAgICAgICAgICAgICAgICAvLyBQb3AtdXAga2V5c3Ryb2tlIGNvbmZpZ3VyYXRpb24gZGVw ZW5kcyBwbGF0Zm9ybS4KKyAgICAgICAgICAgICAgICAvLyAiXHIiIGV2ZW50IHdhbnRzIHRvIHNo b3cgdW5pbXBsZW1lbnRlZCBwb3B1cCBvbgorICAgICAgICAgICAgICAgIC8vIFNQQUNFX09SX1JF VFVSTl9QT1BfTUVOVS4KKyAgICAgICAgICAgICAgICAvLyBTZWUgaHR0cDovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE1MTUgLgorICAgICAgICAgICAgICAgIGlmIChuYXZpZ2F0 b3IudXNlckFnZW50LmluZGV4T2YoIk1hY2ludG9zaCIpICE9IC0xKSB7CisgICAgICAgICAgICAg ICAgICAgIC8vIEtleXN0cm9rZSBjb25maWd1cmF0aW9uIGlzIEFSUk9XX0tFWVNfUE9QX01FTlUu CisgICAgICAgICAgICAgICAgICAgIC8vICJcciIgZXZlbnQgY2FsbCBodG1sRm9ybS0+c3VibWl0 SW1wbGljaXRseSgpIHdoaWNoCisgICAgICAgICAgICAgICAgICAgIC8vIGNhdXNlZCB0aGUgaXNz dWUuCisgICAgICAgICAgICAgICAgICAgIGV2ZW50U2VuZGVyLmtleURvd24oIlxyIiwgbnVsbCk7 CisgICAgICAgICAgICAgICAgfQogCiAgICAgICAgICAgICAgICAgdmFyIHBvcHVwID0gZG9jdW1l bnQuZ2V0RWxlbWVudEJ5SWQoInN3aXRjaGVyMyIpOwogICAgICAgICAgICAgICAgIHBvcHVwLmZv Y3VzKCk7CkBAIC0yNyw3ICszNiw4IEBACiAgICAgICAgICAgICAgICAgY2hlY2soKTsKICAgICAg ICAgICAgfQogCi0gICAgICAgICAgIGZ1bmN0aW9uIGNoZWNrKCkgeworICAgICAgICAgICBmdW5j dGlvbiBjaGVjaygpCisgICAgICAgICAgIHsKICAgICAgICAgICAgICAgICBzZXRUaW1lb3V0KCJk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgnc3dpdGNoZXIzJykuc2VsZWN0ZWRJbmRleCA9IDE7Iiwg MCk7CiAKICAgICAgICAgICAgICAgICB2YXIgcG9wdXAgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgic3dpdGNoZXIyIik7Cg==