61504 2011-05-25 21:52:10 -0700 [Qt] Multiple drop events when doing DnD of images. 2011-06-02 07:45:29 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P1 Normal --- 1 adawit webkit-unassigned ademar aparna.nand ariya.hidayat ben commit-queue kling oldest_to_newest 410186 0 adawit 2011-05-25 21:52:10 -0700 Based on a downstream report, https://bugs.kde.org/show_bug.cgi?id=237759, dragging and dropping any image from any website using QtWebKit from the 2.2 branch produces multiple drop events. This can be reproduced using QtTestBrowser and visiting any site that contains an image. Though I highly doubt it, this issue could potentially be solved the patch that was proposed to fix bug# 58732, but was never landed in webkit ?? Dunno, but the issue is 100% perence reproducable for me. 411349 1 kling 2011-05-27 05:31:57 -0700 Do we have a test case for this? 411896 2 95271 adawit 2011-05-28 13:39:40 -0700 Created attachment 95271 Test case 411981 3 aparna.nand 2011-05-29 10:45:10 -0700 Can you please give more clarity on steps to reproduce the problem? For example, I have opened QtTestBrowser and visited a site that has images. Am I expected to drag the image into some folder? 411990 4 adawit 2011-05-29 11:46:10 -0700 (In reply to comment #3) > Can you please give more clarity on steps to reproduce the problem? For example, I have opened QtTestBrowser and visited a site that has images. Am I expected to drag the image into some folder? Yes. There is no need to visit another site. Simply click on the attached test case file, then drag and drop the image to a folder of your choice. 412299 5 aparna.nand 2011-05-30 11:25:32 -0700 Finally able to reproduce the problem on trunk. Had problems seeing the bug in nautilus initially. Had to change the folder permissions to be able to see the bug. 412332 6 kling 2011-05-30 12:53:59 -0700 This looks suspicious: <http://trac.webkit.org/changeset/49201> 412541 7 aparna.nand 2011-05-31 03:59:04 -0700 (In reply to comment #6) > This looks suspicious: <http://trac.webkit.org/changeset/49201> Your suspicion is right. The image url is getting appended twice in the above code. 413129 8 95546 aparna.nand 2011-05-31 21:49:34 -0700 Created attachment 95546 Patch v01 for review The patch fixes problem which was caused by duplicate url entries. 414031 9 95546 kling 2011-06-02 04:42:36 -0700 Comment on attachment 95546 Patch v01 for review r=me. 414037 10 95546 commit-queue 2011-06-02 05:11:02 -0700 Comment on attachment 95546 Patch v01 for review Clearing flags on attachment: 95546 Committed r87897: <http://trac.webkit.org/changeset/87897> 414038 11 commit-queue 2011-06-02 05:11:07 -0700 All reviewed patches have been landed. Closing bug. 414062 12 ademar 2011-06-02 06:10:46 -0700 (In reply to comment #10) > (From update of attachment 95546 [details]) > Clearing flags on attachment: 95546 > > Committed r87897: <http://trac.webkit.org/changeset/87897> No tests? Maybe a test like the one from bug #61314 could be used? 414113 13 ademar 2011-06-02 07:45:29 -0700 Revision r87897 cherry-picked into qtwebkit-2.2 with commit 11f8b63 <http://gitorious.org/webkit/qtwebkit/commit/11f8b63> 95271 2011-05-28 13:39:40 -0700 2011-05-28 13:39:40 -0700 Test case test_case_qtwebkit_bug_61504.html text/html 153 adawit PGh0bWw+CjxoZWFkPgo8dGl0bGU+SW1hZ2UgRG5EIFRlc3QgQ2FzZTwvdGl0bGU+CjwvaGVhZD4K PGJvZHk+CjxpbWcgc3JjPSJodHRwOi8vdHJhYy53ZWJraXQub3JnL2Nocm9tZS9zaXRlL2ljb24u cG5nIiBhbHQ9IndlYmtpdCBpY29uIj4KPC9ib2R5Pgo8L2h0bWw+ 95546 2011-05-31 21:49:34 -0700 2011-06-02 05:11:02 -0700 Patch v01 for review patch_61504 text/plain 1550 aparna.nand ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMGIwOWI3Li44MDBmNDZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDUtMzEgIEFwYXJuYSBOYW5keWFsICA8YXBhcm5hLm5hbmRAd2lwcm8uY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gTXVs dGlwbGUgZHJvcCBldmVudHMgd2hlbiBkb2luZyBEbkQgb2YgaW1hZ2VzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE1MDQKKworICAgICAgICBEdXBs aWNhdGUgZW50cmllcyBvZiB0aGUgdXJsIHdlcmUgZ2V0dGluZyBhZGRlZCBpbnRvIGRyYWcgZGF0 YQorICAgICAgICB3aGljaCBpcyByZW1vdmVkLiBUaGUgZHVwbGljYXRlIGVudHJpZXMgd2VyZSBj YXVzaW5nIHRoZSBzYW1lIGltYWdlCisgICAgICAgIHVybCB0byBiZSBjb3BpZWQgdHdpY2UuIFRo ZSBjb2RlIGNoYW5nZXMgbm93IG1hdGNoIG90aGVyIHdlYmtpdCBwb3J0cy4KKworICAgICAgICAq IHBsYXRmb3JtL3F0L0NsaXBib2FyZFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNsaXBib2Fy ZFF0OjpkZWNsYXJlQW5kV3JpdGVEcmFnSW1hZ2UpOgorCiAyMDExLTA1LTMxICBYYW4gTG9wZXog IDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYXJ0aW4gUm9iaW5z b24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9DbGlwYm9hcmRRdC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9DbGlwYm9hcmRRdC5jcHAKaW5kZXggYmQ3 YWE3Yy4uZTQzYzY3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvQ2xp cGJvYXJkUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L0NsaXBib2FyZFF0 LmNwcApAQCAtMjk4LDExICsyOTgsMTAgQEAgdm9pZCBDbGlwYm9hcmRRdDo6ZGVjbGFyZUFuZFdy aXRlRHJhZ0ltYWdlKEVsZW1lbnQqIGVsZW1lbnQsIGNvbnN0IEtVUkwmIHVybCwgY28KIAogICAg IFFMaXN0PFFVcmw+IHVybHM7CiAgICAgdXJscy5hcHBlbmQodXJsKTsKLSAgICB1cmxzLmFwcGVu ZChmdWxsVVJMKTsKIAogICAgIG1fd3JpdGFibGVEYXRhLT5zZXRUZXh0KHRpdGxlKTsKICAgICBt X3dyaXRhYmxlRGF0YS0+c2V0VXJscyh1cmxzKTsKLSAgICBtX3dyaXRhYmxlRGF0YS0+c2V0SHRt bChjcmVhdGVNYXJrdXAoZWxlbWVudCwgSW5jbHVkZU5vZGUsIDAsIEFic29sdXRlVVJMcykpOwor ICAgIG1fd3JpdGFibGVEYXRhLT5zZXRIdG1sKGltYWdlVG9NYXJrdXAoZnVsbFVSTCwgZWxlbWVu dCkpOwogI2lmbmRlZiBRVF9OT19DTElQQk9BUkQKICAgICBpZiAoaXNGb3JDb3B5QW5kUGFzdGUo KSkKICAgICAgICAgUUFwcGxpY2F0aW9uOjpjbGlwYm9hcmQoKS0+c2V0TWltZURhdGEobV93cml0 YWJsZURhdGEpOwo=