61488 2011-05-25 17:22:09 -0700 REGRESSION(r87333): Breaks Chromium build due to pure virtual methods. (Requested by aklein on #webkit). 2011-05-25 17:24:17 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60518 1 webkit.review.bot webkit.review.bot adamk fishd oldest_to_newest 410043 0 webkit.review.bot 2011-05-25 17:22:09 -0700 http://trac.webkit.org/changeset/87333 broke the build: Breaks Chromium build due to pure virtual methods. (Requested by aklein on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 410044 1 94884 webkit.review.bot 2011-05-25 17:22:27 -0700 Created attachment 94884 ROLLOUT of r87333 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment. 410047 2 94884 adamk 2011-05-25 17:24:13 -0700 Comment on attachment 94884 ROLLOUT of r87333 Clearing flags on attachment: 94884 Committed r87338: <http://trac.webkit.org/changeset/87338> 410048 3 adamk 2011-05-25 17:24:17 -0700 All reviewed patches have been landed. Closing bug. 94884 2011-05-25 17:22:27 -0700 2011-05-25 17:24:13 -0700 ROLLOUT of r87333 bug-61488-20110526002135.patch text/plain 5041 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogODczMzcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg N2U5Mjc2ZGFmM2U1NzViOTkyNzAxM2NjMThhNDQ3OTdmZTZkZTIxMS4uZTUwZjZjZDJlNTM4M2Zm YWQzZGQ3NTIxY2U4M2M1NTIzOTIwNzYwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOCBAQAorMjAxMS0wNS0yNSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJv dEBnbWFpbC5jb20+CisKKyAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg3MzMzLgor ICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC84NzMzMworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE0ODgKKworICAgICAgICBC cmVha3MgQ2hyb21pdW0gYnVpbGQgZHVlIHRvIHB1cmUgdmlydHVhbCBtZXRob2RzLiAoUmVxdWVz dGVkCisgICAgICAgIGJ5IGFrbGVpbiBvbiAjd2Via2l0KS4KKworICAgICAgICAqIHB1YmxpYy9X ZWJXaWRnZXQuaDoKKyAgICAgICAgKiBzcmMvV2ViUG9wdXBNZW51SW1wbC5jcHA6CisgICAgICAg ICogc3JjL1dlYlBvcHVwTWVudUltcGwuaDoKKyAgICAgICAgKiBzcmMvV2ViVmlld0ltcGwuY3Bw OgorICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5oOgorCiAyMDExLTA1LTI1ICBTYWlsZXNoIEFn cmF3YWwgIDxzYWlsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBG aXNoZXIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJXaWRn ZXQuaCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYldpZGdldC5oCmluZGV4IGU2 ZTc4ODU2NWM5OWI1OGY5OTA2M2U2YzFjNGI5ODAzMDViZmM5NzEuLjEwMTQzZTEyOWU3ZmQwZTEy YjIzZjJiNzIwNTI3NTcxNjEyYzgyYzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYldpZGdldC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYldpZGdldC5oCkBAIC01NSwxOSArNTUsOSBAQCBwdWJsaWM6CiAgICAgLy8gUmV0dXJucyB0 aGUgY3VycmVudCBzaXplIG9mIHRoZSBXZWJXaWRnZXQuCiAgICAgdmlydHVhbCBXZWJTaXplIHNp emUoKSA9IDA7CiAKLSAgICAvLyBVc2VkIHRvIGdyb3VwIGEgc2VyaWVzIG9mIHJlc2l6ZSBldmVu dHMuIEZvciBleGFtcGxlLCBpZiB0aGUgdXNlcgotICAgIC8vIGRyYWdzIGEgcmVzaXplciB0aGVu IHdpbGxTdGFydExpdmVSZXNpemUgd2lsbCBiZSBjYWxsZWQsIGZvbGxvd2VkIGJ5IGEKLSAgICAv LyBzZXF1ZW5jZSBvZiByZXNpemUgZXZlbnRzLCBlbmRpbmcgd2l0aCB3aWxsRW5kTGl2ZVJlc2l6 ZSB3aGVuIHRoZSB1c2VyCi0gICAgLy8gbGV0cyBnbyBvZiB0aGUgcmVzaXplci4KLSAgICB2aXJ0 dWFsIHZvaWQgd2lsbFN0YXJ0TGl2ZVJlc2l6ZSgpID0gMDsKLQogICAgIC8vIENhbGxlZCB0byBy ZXNpemUgdGhlIFdlYldpZGdldC4KICAgICB2aXJ0dWFsIHZvaWQgcmVzaXplKGNvbnN0IFdlYlNp emUmKSA9IDA7CiAKLSAgICAvLyBFbmRzIGEgZ3JvdXAgb2YgcmVzaXplIGV2ZW50cyB0aGF0IHdh cyBzdGFydGVkIHdpdGggYSBjYWxsIHRvCi0gICAgLy8gd2lsbFN0YXJ0TGl2ZVJlc2l6ZS4KLSAg ICB2aXJ0dWFsIHZvaWQgd2lsbEVuZExpdmVSZXNpemUoKSA9IDA7Ci0KICAgICAvLyBDYWxsZWQg dG8gdXBkYXRlIGltcGVyYXRpdmUgYW5pbWF0aW9uIHN0YXRlLiAgVGhpcyBzaG91bGQgYmUgY2Fs bGVkIGJlZm9yZQogICAgIC8vIHBhaW50LCBhbHRob3VnaCB0aGUgY2xpZW50IGNhbiByYXRlLWxp bWl0IHRoZXNlIGNhbGxzLgogICAgIHZpcnR1YWwgdm9pZCBhbmltYXRlKCkgPSAwOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUG9wdXBNZW51SW1wbC5jcHAgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJQb3B1cE1lbnVJbXBsLmNwcAppbmRleCA5NjFj ZTI0NWUzYjNiNGUwNDg4YmI1Nzc5ZDNjYjIwZWYyNzZjNTRhLi4wZjMxODkyZmQ4NzQ5NWU1NjUw NTdlYzlmYzFkYWIzMTBjNzhiNGNiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJQb3B1cE1lbnVJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJQb3B1cE1lbnVJbXBsLmNwcApAQCAtMTM2LDEwICsxMzYsNiBAQCB2b2lkIFdlYlBvcHVw TWVudUltcGw6OmNsb3NlKCkKICAgICBkZXJlZigpOyAgLy8gQmFsYW5jZXMgcmVmKCkgZnJvbSBX ZWJXaWRnZXQ6OkNyZWF0ZQogfQogCi12b2lkIFdlYlBvcHVwTWVudUltcGw6OndpbGxTdGFydExp dmVSZXNpemUoKQotewotfQotCiB2b2lkIFdlYlBvcHVwTWVudUltcGw6OnJlc2l6ZShjb25zdCBX ZWJTaXplJiBuZXdTaXplKQogewogICAgIGlmIChtX3NpemUgPT0gbmV3U2l6ZSkKQEAgLTE1Nywx MCArMTUzLDYgQEAgdm9pZCBXZWJQb3B1cE1lbnVJbXBsOjpyZXNpemUoY29uc3QgV2ViU2l6ZSYg bmV3U2l6ZSkKICAgICB9CiB9CiAKLXZvaWQgV2ViUG9wdXBNZW51SW1wbDo6d2lsbEVuZExpdmVS ZXNpemUoKQotewotfQotCiB2b2lkIFdlYlBvcHVwTWVudUltcGw6OmFuaW1hdGUoKQogewogfQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUG9wdXBNZW51SW1wbC5o IGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViUG9wdXBNZW51SW1wbC5oCmluZGV4IGE5 MWZhZjFjMGI5NGRmNDBkNjRiN2QzM2E5ODM1MDQ0MzRkZTE0ZDAuLjVhZTFiNDhkYmUxNDM4NzE5 ZWE3YTI1ZDA0NDNmY2QwNTFmNDcyMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlBvcHVwTWVudUltcGwuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJQb3B1cE1lbnVJbXBsLmgKQEAgLTYyLDkgKzYyLDcgQEAgcHVibGljOgogICAgIC8vIFdl YldpZGdldAogICAgIHZpcnR1YWwgdm9pZCBjbG9zZSgpOwogICAgIHZpcnR1YWwgV2ViU2l6ZSBz aXplKCkgeyByZXR1cm4gbV9zaXplOyB9Ci0gICAgdmlydHVhbCB2b2lkIHdpbGxTdGFydExpdmVS ZXNpemUoKTsKICAgICB2aXJ0dWFsIHZvaWQgcmVzaXplKGNvbnN0IFdlYlNpemUmKTsKLSAgICB2 aXJ0dWFsIHZvaWQgd2lsbEVuZExpdmVSZXNpemUoKTsKICAgICB2aXJ0dWFsIHZvaWQgYW5pbWF0 ZSgpOwogICAgIHZpcnR1YWwgdm9pZCBsYXlvdXQoKTsKICAgICB2aXJ0dWFsIHZvaWQgcGFpbnQo V2ViQ2FudmFzKiBjYW52YXMsIGNvbnN0IFdlYlJlY3QmIHJlY3QpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwIGIvU291cmNlL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IGIwNTkxZDVmZmI0ZjA5ZTNiM2U4MWIz YzZjMjBhN2EyZmRhZGViMzEuLjdmMGUzODdkOWJiMDgzMmQ0NDljZWU3NGYxZWIwMWQ0OTQyMmE4 ZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBsLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTk3 MiwxMiArOTcyLDYgQEAgdm9pZCBXZWJWaWV3SW1wbDo6Y2xvc2UoKQogICAgIGRlcmVmKCk7ICAv LyBCYWxhbmNlcyByZWYoKSBhY3F1aXJlZCBpbiBXZWJWaWV3OjpjcmVhdGUKIH0KIAotdm9pZCBX ZWJWaWV3SW1wbDo6d2lsbFN0YXJ0TGl2ZVJlc2l6ZSgpCi17Ci0gICAgaWYgKG1haW5GcmFtZUlt cGwoKSAmJiBtYWluRnJhbWVJbXBsKCktPmZyYW1lVmlldygpKQotICAgICAgICBtYWluRnJhbWVJ bXBsKCktPmZyYW1lVmlldygpLT53aWxsU3RhcnRMaXZlUmVzaXplKCk7Ci19Ci0KIHZvaWQgV2Vi Vmlld0ltcGw6OnJlc2l6ZShjb25zdCBXZWJTaXplJiBuZXdTaXplKQogewogICAgIGlmIChtX3Np emUgPT0gbmV3U2l6ZSkKQEAgLTEwMDgsMTIgKzEwMDIsNiBAQCB2b2lkIFdlYlZpZXdJbXBsOjpy ZXNpemUoY29uc3QgV2ViU2l6ZSYgbmV3U2l6ZSkKICNlbmRpZgogfQogCi12b2lkIFdlYlZpZXdJ bXBsOjp3aWxsRW5kTGl2ZVJlc2l6ZSgpCi17Ci0gICAgaWYgKG1haW5GcmFtZUltcGwoKSAmJiBt YWluRnJhbWVJbXBsKCktPmZyYW1lVmlldygpKQotICAgICAgICBtYWluRnJhbWVJbXBsKCktPmZy YW1lVmlldygpLT53aWxsRW5kTGl2ZVJlc2l6ZSgpOwotfQotCiB2b2lkIFdlYlZpZXdJbXBsOjph bmltYXRlKCkKIHsKICAgICBUUkFDRV9FVkVOVCgiV2ViVmlld0ltcGw6OmFuaW1hdGUiLCB0aGlz LCAwKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZpZXdJbXBs LmggYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5oCmluZGV4IDg5OGU1 NjVhZDc5Njc0NGYyMjJkZjAyODBkYjUzNDUwMzc3NDliNTQuLmYyOTA4Mjc2OWYzZmIyZDI2OGUw YTQ3YmRlMzk3ZTE3NDhhYmM2MzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuaApAQCAtOTEsOSArOTEsNyBAQCBwdWJsaWM6CiAgICAgLy8gV2ViV2lkZ2V0IG1ldGhv ZHM6CiAgICAgdmlydHVhbCB2b2lkIGNsb3NlKCk7CiAgICAgdmlydHVhbCBXZWJTaXplIHNpemUo KSB7IHJldHVybiBtX3NpemU7IH0KLSAgICB2aXJ0dWFsIHZvaWQgd2lsbFN0YXJ0TGl2ZVJlc2l6 ZSgpOwogICAgIHZpcnR1YWwgdm9pZCByZXNpemUoY29uc3QgV2ViU2l6ZSYpOwotICAgIHZpcnR1 YWwgdm9pZCB3aWxsRW5kTGl2ZVJlc2l6ZSgpOwogICAgIHZpcnR1YWwgdm9pZCBhbmltYXRlKCk7 CiAgICAgdmlydHVhbCB2b2lkIGxheW91dCgpOwogICAgIHZpcnR1YWwgdm9pZCBwYWludChXZWJD YW52YXMqLCBjb25zdCBXZWJSZWN0Jik7Cg==