61483 2011-05-25 16:49:02 -0700 Textarea will not accept space characters at end of line 2011-07-01 23:20:18 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Regression P2 Normal --- 54598 1 peterbraden rniwa alexander.a.cabal ap enrica peterbraden rniwa oldest_to_newest 410027 0 peterbraden 2011-05-25 16:49:02 -0700 Overview: Typing space at the end of a line with certain character combinations will not insert a space and wrap. Additionally, after typing other characters which cause the line to wrap, the space character will be omitted. Additionally, after problematically inserting a space, then retyping space, the extra space will disappear. Steps to Reproduce: This is a really interesting bug because it happens with a bunch of different words in the line, but is inconsistent. I have managed to find a consistent repro case though. 1) With a html page as follows: <html> <head /> <body> <textarea style="height: 34px; width: 535px;"></textarea> </body> </html> 2) Edit the textarea to contain as many 'a' characters as takes to fill the line (another a would make it wrap) 3) Delete the last 'a' and add an 'l' character. The line should not wrap. 4) Try and add a space character - notice the line does not wrap. 5) You can try and add as many space characters as you like - they are not added to the val, and the textarea won't wrap. 6) Add another non space character. The line will wrap, however arrowing back will confirm the space character was not added. 7) Notice that adding space characters problematically, then repeating steps, truncates trailing spaces to a single space. Expected Results: - Space characters will make the line wrap - Space characters should be able to be added at the end of lines. Build Date & Platform: Repro'd on Chrome, Safari, and the nightly WebKit r87281 built on 25 May 2011. Only tested on OSX thus far. 410211 1 ap 2011-05-25 23:12:49 -0700 This behavior is very similar to what TextEdit has, and thus likely intentional. I do not know what the rationale is. Note that all the spaces are inserted - they just do not cause formatting changes, but if you resize the text area, they will appear. Similarly, they are sent with form submission and when copying into clipboard. 410588 2 peterbraden 2011-05-26 10:46:39 -0700 The main bug is that the spaces are _not_ inserted - programatic inspection or additional non-space character insertion shows that the spaces are not there. I also disagree that this behaviour is expected - the other browsers handle this by wrapping on space, as do many other apps - textedit likely has this behavior because it may use webkit under the covers? I have several users who have reported this as a bug, reinforcing the view that the behaviour is unexpected. Best, P (In reply to comment #1) > This behavior is very similar to what TextEdit has, and thus likely intentional. I do not know what the rationale is. > > Note that all the spaces are inserted - they just do not cause formatting changes, but if you resize the text area, they will appear. Similarly, they are sent with form submission and when copying into clipboard. 410629 3 95010 ap 2011-05-26 11:29:00 -0700 Created attachment 95010 test case > The main bug is that the spaces are _not_ inserted - programatic inspection or additional non-space character insertion shows that the spaces are not there. Oh, I see that now. the reason I didn't see it before is that's a regression from Safari 5 to nightly builds. In Safari 5, spaces are inserted, but visually it looks the same. > textedit likely has this behavior because it may use webkit under the covers? It does not. 410632 4 rniwa 2011-05-26 11:34:19 -0700 This is caused by the bug 54598. VisiblePosition is canonicalized before the space and disallowing any space be inserted at the end of line. *** This bug has been marked as a duplicate of bug 54598 *** 410669 5 ap 2011-05-26 11:49:10 -0700 This is a regression, so it's not a duplicate of bug bug 54598. 420881 6 rniwa 2011-06-14 17:23:20 -0700 I have confirmed that http://trac.webkit.org/changeset/88883 fixed this bug as well. ap, would you be interesting in making a DRT test that works on all ports/platform for this bug? 420887 7 ap 2011-06-14 17:31:19 -0700 Not any time soon, sorry. 420888 8 rniwa 2011-06-14 17:32:25 -0700 (In reply to comment #7) > Not any time soon, sorry. Okay. Let me try then. 420924 9 97210 rniwa 2011-06-14 18:21:55 -0700 Created attachment 97210 adds a regression test 421014 10 ap 2011-06-14 22:23:57 -0700 When I run this test in Safari 5.0.5 (which presumably didn't have this bug), the test says FAIL. Am I just confused, or does the test not capture the regression aspect of this problem? 421025 11 rniwa 2011-06-14 22:50:33 -0700 (In reply to comment #10) > When I run this test in Safari 5.0.5 (which presumably didn't have this bug), the test says FAIL. Am I just confused, or does the test not capture the regression aspect of this problem? Okay, I don't believe that this is a regression anymore. I can reproduce the exact bug on Safari 5. Just insert many 'a' as possible in the attached demo, and insert one space. You can't insert any more spaces after that. 421028 12 ap 2011-06-14 22:58:46 -0700 The regression part is that although spaces were not visible in Safari 5, they were inserted to DOM. 421040 13 rniwa 2011-06-14 23:20:36 -0700 (In reply to comment #12) > The regression part is that although spaces were not visible in Safari 5, they were inserted to DOM. That behavior is not reproducible at least on my MBP when I insert "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa " on the attached document. I can't insert anymore spaces after the space at the end. 421092 14 ap 2011-06-15 00:53:51 -0700 Please try steps to reproduce form the original description (fill the line with aaa's, delete the last one, type l, then press space multiple times). That's a regression. However, given your example, it's probably some small inconsequential change that caused it. Quite mysterious though. 421093 15 97210 ap 2011-06-15 00:54:22 -0700 Comment on attachment 97210 adds a regression test Either way, this is clearly good to land. 421247 16 97290 rniwa 2011-06-15 07:18:19 -0700 Created attachment 97290 demo (bug on Safari 5, works on ToT) (In reply to comment #14) > Please try steps to reproduce form the original description (fill the line with aaa's, delete the last one, type l, then press space multiple times). That's a regression. > > However, given your example, it's probably some small inconsequential change that caused it. Quite mysterious though. Right, but this is purely due to font-metric difference / line layout difference. In this new demo, the exact bug described in this bug reproduces on Safari 5 but does not reproduce on ToT WebKit. 421361 17 rniwa 2011-06-15 09:18:51 -0700 As noted in comments above, this isn't a regression after all. Only the exact condition by which the bug manifests changed over time. 421370 18 rniwa 2011-06-15 09:28:54 -0700 Committed r88946: <http://trac.webkit.org/changeset/88946> 431585 19 alexander.a.cabal 2011-07-01 23:10:53 -0700 Just wanted to pop in and mention that this bug isn't limited to textareas. Users of my web app ran into this problem with spans that have contenteditable="true" that wrap to a new line. If you have a span with contenteditable="true" nested within a div and then try to enter a space at the point where the span will wrap to a newline, this bug appears too: that is, the previous word in the span will wrap down, the space will disappear, and the previous word will run in to the new word you're tying because the space disappeared. I can't download the nightly to test that it's been fixed for contenteditables as well, but I just wanted you to be aware that this bug isn't limited to textareas. I can provide more information if necessary. 431586 20 rniwa 2011-07-01 23:20:18 -0700 (In reply to comment #19) > Just wanted to pop in and mention that this bug isn't limited to textareas. Users of my web app ran into this problem with spans that have contenteditable="true" that wrap to a new line. > > If you have a span with contenteditable="true" nested within a div and then try to enter a space at the point where the span will wrap to a newline, this bug appears too: that is, the previous word in the span will wrap down, the space will disappear, and the previous word will run in to the new word you're tying because the space disappeared. > > I can't download the nightly to test that it's been fixed for contenteditables as well, but I just wanted you to be aware that this bug isn't limited to textareas. I can provide more information if necessary. Yes, I'm fully aware of that. r88883 should have fixed that as well. 95010 2011-05-26 11:29:00 -0700 2011-05-26 11:29:00 -0700 test case test.html text/html 1057 ap PGh0bWw+Cjxib2R5Pgo8dGV4dGFyZWEgc3R5bGU9ImhlaWdodDogMzRweDsgd2lkdGg6IDUzNXB4 OyIgaWQ9dGV4dCBvbmlucHV0PSJjaGFuZ2VkKCkiPjwvdGV4dGFyZWE+CjxkaXYgaWQ9cmVzdWx0 PjwvZGl2Pgo8b2w+CjxsaT4gRWRpdCB0aGUgdGV4dGFyZWEgdG8gY29udGFpbiBhcyBtYW55ICdh JyBjaGFyYWN0ZXJzIGFzIHRha2VzIHRvIGZpbGwgdGhlIGxpbmUgKGFub3RoZXIgYSB3b3VsZCBt YWtlIGl0IHdyYXApCjxsaT4gRGVsZXRlIHRoZSBsYXN0ICdhJyBhbmQgYWRkIGFuICdsJyBjaGFy YWN0ZXIuIFRoZSBsaW5lIHNob3VsZCBub3Qgd3JhcC4KPGxpPiBUcnkgYW5kIGFkZCBhIHNwYWNl IGNoYXJhY3RlciAtIG5vdGljZSB0aGUgbGluZSBkb2VzIG5vdCB3cmFwLgo8bGk+IFlvdSBjYW4g dHJ5IGFuZCBhZGQgYXMgbWFueSBzcGFjZSBjaGFyYWN0ZXJzIGFzIHlvdSBsaWtlIC0gdGhleSBh cmUgbm90IGFkZGVkIHRvIHRoZSB2YWwsIGFuZCB0aGUgdGV4dGFyZWEgd29uJ3Qgd3JhcC4KPGxp PiBBZGQgYW5vdGhlciBub24gc3BhY2UgY2hhcmFjdGVyLiBUaGUgbGluZSB3aWxsIHdyYXAsIGhv d2V2ZXIgYXJyb3dpbmcgYmFjayB3aWxsIGNvbmZpcm0gdGhlIHNwYWNlIGNoYXJhY3RlciB3YXMg bm90IGFkZGVkLgo8bGk+IE5vdGljZSB0aGF0IGFkZGluZyBzcGFjZSBjaGFyYWN0ZXJzIHByb2Js ZW1hdGljYWxseSwgdGhlbiByZXBlYXRpbmcgc3RlcHMsIHRydW5jYXRlcyB0cmFpbGluZyBzcGFj ZXMgdG8gYSBzaW5nbGUgc3BhY2UuCjwvb2w+CjxzY3JpcHQ+CnZhciB0ZXh0ID0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoInRleHQiKTsKdmFyIHJlc3VsdCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJyZXN1bHQiKTsKCnRleHQuZm9jdXMoKTsKCmZ1bmN0aW9uIGNoYW5nZWQoKQp7CiAgICBy ZXN1bHQuaW5uZXJIVE1MID0gIkxlbmd0aDogIiArIHRleHQudGV4dExlbmd0aDsKICAgIHJlc3Vs dC5pbm5lckhUTUwgKz0gIjxicj4iICsgZXNjYXBlKHRleHQudmFsdWUpOwp9CgpjaGFuZ2VkKCk7 Cjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4gICAgCg== 97210 2011-06-14 18:21:55 -0700 2011-06-15 00:54:22 -0700 adds a regression test bug-61483-20110614182154.patch text/plain 2408 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDg4ODg4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDYtMTQgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUkVHUkVTU0lPTiAoU2FmYXJpIDUgLSBUb1QpOiBUZXh0YXJlYSB3aWxsIG5vdCBh Y2NlcHQgc3BhY2UgY2hhcmFjdGVycyBhdCBlbmQgb2YgbGluZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE0ODMKKworICAgICAgICBBZGRlZCBhIHJl Z3Jlc3Npb24gdGVzdCBub3cgdGhhdCB0aGUgYnVnIGhhcyBiZWVuIHJlc29sdmVkIGJ5IHI4ODg4 My4KKworICAgICAgICAqIGVkaXRpbmcvaW5wdXQvaW5zZXJ0LXdyYXBwaW5nLXNwYWNlLWluLXRl eHRhcmVhLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9pbnB1dC9pbnNl cnQtd3JhcHBpbmctc3BhY2UtaW4tdGV4dGFyZWEuaHRtbDogQWRkZWQuCisKIDIwMTEtMDYtMTQg IEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV1b UXRdIEFzc2lnbiBuZXcgYnVnIG51bWJlcnMgZm9yIHNsaWRlciBmYWlsdXJlcywgYW5kIHNraXAg YSB0ZXN0IG9uIFF0LgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9pbnB1dC9pbnNlcnQtd3Jh cHBpbmctc3BhY2UtaW4tdGV4dGFyZWEtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL2VkaXRpbmcvaW5wdXQvaW5zZXJ0LXdyYXBwaW5nLXNwYWNlLWluLXRleHRhcmVhLWV4 cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvaW5wdXQvaW5z ZXJ0LXdyYXBwaW5nLXNwYWNlLWluLXRleHRhcmVhLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSwzIEBACitUaGlzIHRlc3QgZW5zdXJlcyBXZWJLaXQgYWxsb3dzIHNwYWNlIGJl IGluc2VydGVkIGluIHRleHRhcmVhIGV2ZW4gd2hlbiBkb2luZyBzbyBmb3JjZXMgdGhlIHNwYWNl IHRvIHdyYXAgdG8gdGhlIG5leHQgbGluZS4KKworUEFTUwpJbmRleDogTGF5b3V0VGVzdHMvZWRp dGluZy9pbnB1dC9pbnNlcnQtd3JhcHBpbmctc3BhY2UtaW4tdGV4dGFyZWEuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL2lucHV0L2luc2VydC13cmFwcGluZy1zcGFjZS1p bi10ZXh0YXJlYS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGluZy9pbnB1 dC9pbnNlcnQtd3JhcHBpbmctc3BhY2UtaW4tdGV4dGFyZWEuaHRtbAkocmV2aXNpb24gMCkKQEAg LTAsMCArMSwyNiBAQAorPCFET0NUWVBFPgorPGh0bWw+Cis8Ym9keT4KKzxwPlRoaXMgdGVzdCBl bnN1cmVzIFdlYktpdCBhbGxvd3Mgc3BhY2UgYmUgaW5zZXJ0ZWQgaW4gdGV4dGFyZWEgZXZlbiB3 aGVuIGRvaW5nIHNvIGZvcmNlcyB0aGUgc3BhY2UgdG8gd3JhcCB0byB0aGUgbmV4dCBsaW5lLjwv cD4KKzx0ZXh0YXJlYSBzdHlsZT0iZm9udC1zaXplOiAzMHB4OyB3aWR0aDogNTBweDsiPmFiPC90 ZXh0YXJlYT4KKzxzY3JpcHQ+CisKK3ZhciB0ZXh0YXJlYSA9IGRvY3VtZW50LmdldEVsZW1lbnRz QnlUYWdOYW1lKCd0ZXh0YXJlYScpWzBdOwordGV4dGFyZWEuZm9jdXMoKTsKK3RleHRhcmVhLnNl bGVjdGlvblN0YXJ0ID0gdGV4dGFyZWEudmFsdWUubGVuZ3RoOwordGV4dGFyZWEuc2VsZWN0aW9u RW5kID0gdGV4dGFyZWEudmFsdWUubGVuZ3RoOworZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0luc2Vy dFRleHQnLCBmYWxzZSwgJyAnKTsKKwordmFyIG9yaWdpbmFsTGVuZ3RoID0gdGV4dGFyZWEudmFs dWUubGVuZ3RoOworZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0luc2VydFRleHQnLCBmYWxzZSwgJyAn KTsKKworZG9jdW1lbnQud3JpdGVsbihvcmlnaW5hbExlbmd0aCA8IHRleHRhcmVhLnZhbHVlLmxl bmd0aCA/ICdQQVNTJyA6ICdGQUlMJyk7CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xs ZXIpIHsKKyAgICB0ZXh0YXJlYS5wYXJlbnROb2RlLnJlbW92ZUNoaWxkKHRleHRhcmVhKTsKKyAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cit9CisKKzwvc2NyaXB0PgorPC9i b2R5PgorPC9odG1sPgo= 97290 2011-06-15 07:18:19 -0700 2011-06-15 07:18:19 -0700 demo (bug on Safari 5, works on ToT) insert-wrapping-space-in-textarea.html text/html 741 rniwa PCFET0NUWVBFPgo8aHRtbD4KPGJvZHk+CjxwPlRoaXMgdGVzdCBlbnN1cmVzIFdlYktpdCBhbGxv d3Mgc3BhY2UgYmUgaW5zZXJ0ZWQgaW4gdGV4dGFyZWEgZXZlbiB3aGVuIGRvaW5nIHNvIGZvcmNl cyB0aGUgc3BhY2UgdG8gd3JhcCB0byB0aGUgbmV4dCBsaW5lLjwvcD4KPHRleHRhcmVhIHN0eWxl PSJmb250LXNpemU6IDI1cHg7IHdpZHRoOiA0N3B4OyI+d2E8L3RleHRhcmVhPgo8c2NyaXB0PgoK dmFyIHRleHRhcmVhID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3RleHRhcmVhJylb MF07CnRleHRhcmVhLmZvY3VzKCk7CnRleHRhcmVhLnNlbGVjdGlvblN0YXJ0ID0gdGV4dGFyZWEu dmFsdWUubGVuZ3RoOwp0ZXh0YXJlYS5zZWxlY3Rpb25FbmQgPSB0ZXh0YXJlYS52YWx1ZS5sZW5n dGg7CmRvY3VtZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRUZXh0JywgZmFsc2UsICcgJyk7CmRvY3Vt ZW50LmV4ZWNDb21tYW5kKCdJbnNlcnRUZXh0JywgZmFsc2UsICcgJyk7CmRvY3VtZW50LmV4ZWND b21tYW5kKCdJbnNlcnRUZXh0JywgZmFsc2UsICcgJyk7Cgpkb2N1bWVudC53cml0ZWxuKGVzY2Fw ZSh0ZXh0YXJlYS52YWx1ZSkpOwoKaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewog ICAgdGV4dGFyZWEucGFyZW50Tm9kZS5yZW1vdmVDaGlsZCh0ZXh0YXJlYSk7CiAgICBsYXlvdXRU ZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cn0KCjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K