61481 2011-05-25 16:16:16 -0700 CachedResource overhead size calculation ignores the actual size of the URL 2011-05-25 18:08:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth dglazkov gustavo.noronha gustavo japhet koivisto webkit.review.bot xan.lopez oldest_to_newest 410002 0 jamesr 2011-05-25 16:16:16 -0700 CachedResource overhead size calculation ignores the actual size of the URL 410003 1 94878 jamesr 2011-05-25 16:19:18 -0700 Created attachment 94878 Patch 410005 2 jamesr 2011-05-25 16:20:23 -0700 This is one issue that contributes to the memory growth seen on the test page from https://bugs.webkit.org/show_bug.cgi?id=61006. 410007 3 94878 ggaren 2011-05-25 16:20:45 -0700 Comment on attachment 94878 Patch r=me 410016 4 94878 webkit-ews 2011-05-25 16:33:51 -0700 Comment on attachment 94878 Patch Attachment 94878 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/8731864 410057 5 94878 commit-queue 2011-05-25 17:37:17 -0700 Comment on attachment 94878 Patch Attachment 94878 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/8736095 410071 6 94878 gustavo.noronha 2011-05-25 17:46:01 -0700 Comment on attachment 94878 Patch Attachment 94878 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/8737021 410076 7 jamesr 2011-05-25 17:49:33 -0700 This collides a bit with http://trac.webkit.org/changeset/87239, hence all the EWS sadness. Will resolve before landing (the difference is that the request url now lives on m_resourceRequest instead of being a string hanging directly off the CachedResource). 410094 8 jamesr 2011-05-25 18:08:09 -0700 Committed r87344: <http://trac.webkit.org/changeset/87344> 94878 2011-05-25 16:19:18 -0700 2011-05-25 17:46:01 -0700 Patch bug-61481-20110525161916.patch text/plain 2040 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogODcxOTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3NmU1NDY2OTc2OWFmZGVh ZDM1NzM4ZmY2MjRjYmJiNDU2Y2EzMTJhLi44ZjA1OTEyZDJmMTY4ZDdkMjQyOTRjMmQ4ZGFmN2Y1 YTg2OTViMWNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDUtMjUgIEphbWVz IFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWNoZWRSZXNvdXJjZSBvdmVyaGVhZCBzaXplIGNh bGN1bGF0aW9uIGlnbm9yZXMgdGhlIGFjdHVhbCBzaXplIG9mIHRoZSBVUkwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxNDgxCisKKyAgICAgICAgQ2Fj aGVkUmVzb3VyY2U6Om92ZXJoZWFkU2l6ZSBpcyB1c2VkIHRvIGRldGVybWluZSB0aGUgc2l6ZSBv ZiBhbiBlbnRyeSBpbiB0aGUgbWVtb3J5IGNhY2hlIHRvIGtub3cgd2hlbiB0byBldmljdAorICAg ICAgICBpdC4gIFdoZW4gdGhlIHJlc291cmNlIGlzIGEgbGFyZ2UgZGF0YTogVVJMLCBmb3IgZXhh bXBsZSByZXByZXNlbnRpbmcgaW1hZ2Ugb3IgYXVkaW8gZGF0YSwgdGhlIFVSTCBzaXplIGl0c2Vs ZgorICAgICAgICBjYW4gYmUgc2lnbmlmaWNhbnQuCisKKyAgICAgICAgVGhpcyBwYXRjaCB1c2Vz IGFuIGVzdGltYXRlIG9mIGFjdHVhbCBudW1iZXIgb2YgYnl0ZXMgdXNlZCBieSB0aGUgVVJMIHRo YXQgaXMgdmFsaWQgZm9yIEFTQ0lJIHVybHMgYW5kIGNsb3NlIGZvcgorICAgICAgICBvdGhlciB0 eXBlcyBvZiBzdHJpbmdzIGluc3RlYWQgb2YgYSBmaXhlZCBudW1iZXIuCisKKyAgICAgICAgKiBs b2FkZXIvY2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q2FjaGVk UmVzb3VyY2U6Om92ZXJoZWFkU2l6ZSk6CisKIDIwMTEtMDUtMjQgIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJvYmluc29uLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9jYWNoZS9DYWNoZWRSZXNvdXJjZS5jcHAKaW5kZXgg OTUyOGU1YTg0OWUzYTFhYmZjZmEwOGE0NzQ0MGUzMWQ0OWFkYWVjYy4uYjZlYmI4ZTFiYjFjYWY1 MWU4MGMwNmUxMGFmZTQ2MGFlYmY0ZDNhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9h ZGVyL2NhY2hlL0NhY2hlZFJlc291cmNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv Y2FjaGUvQ2FjaGVkUmVzb3VyY2UuY3BwCkBAIC02MDcsMTEgKzYwNyw4IEBAIGJvb2wgQ2FjaGVk UmVzb3VyY2U6Ondhc1B1cmdlZCgpIGNvbnN0CiAKIHVuc2lnbmVkIENhY2hlZFJlc291cmNlOjpv dmVyaGVhZFNpemUoKSBjb25zdAogewotICAgIHJldHVybiBzaXplb2YoQ2FjaGVkUmVzb3VyY2Up ICsgbV9yZXNwb25zZS5tZW1vcnlVc2FnZSgpICsgNTc2OwotICAgIC8qCi0gICAgICAgIDU3NiA9 IDE5MiArICAgICAgICAgICAgICAgICAgIC8vIGF2ZXJhZ2Ugc2l6ZSBvZiBtX3VybAotICAgICAg ICAgICAgICAzODQ7ICAgICAgICAgICAgICAgICAgICAvLyBhdmVyYWdlIHNpemUgb2YgbV9jbGll bnRzIGhhc2ggbWFwCi0gICAgKi8KKyAgICBzdGF0aWMgY29uc3QgaW50IGtBdmVyYWdlQ2xpZW50 c0hhc2hNYXBTaXplID0gMzg0OworICAgIHJldHVybiBzaXplb2YoQ2FjaGVkUmVzb3VyY2UpICsg bV9yZXNwb25zZS5tZW1vcnlVc2FnZSgpICsga0F2ZXJhZ2VDbGllbnRzSGFzaE1hcFNpemUgKyBt X3VybC5sZW5ndGgoKSAqIDI7CiB9CiAgICAgCiB2b2lkIENhY2hlZFJlc291cmNlOjpzZXRMb2Fk UHJpb3JpdHkoUmVzb3VyY2VMb2FkUHJpb3JpdHkgbG9hZFByaW9yaXR5KSAK