61461 2011-05-25 12:42:07 -0700 REGRESSION: Fullscreen button on embedded Vimeo videos does nothing 2011-06-03 14:06:10 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble ademar oldest_to_newest 409856 0 jer.noble 2011-05-25 12:42:07 -0700 REGRESSION: Fullscreen button on embedded Vimeo videos does nothing 409857 1 jer.noble 2011-05-25 12:42:33 -0700 <rdar://problem/9495908> 409873 2 94845 jer.noble 2011-05-25 13:06:10 -0700 Created attachment 94845 Patch 409900 3 94845 darin 2011-05-25 14:02:17 -0700 Comment on attachment 94845 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94845&action=review I think the term “legacy full screen check” here is a little confusing; we might have been able to find a more specific name that would be clearer. I am puzzled by all the webkit prefixes on the function names. Those should be present only for functions exported to the DOM. There’s no point in having those prefixes in our own internal function names. > Source/WebCore/dom/Document.h:1062 > + typedef enum { > + UseStrictFullScreenCheck, > + UseLegacyFullScreenCheck, > + } FullScreenCheckType; The preferred C++ syntax is just: enum X { A, B, C }; The syntax you’re using here is C-ism. 409906 4 jer.noble 2011-05-25 14:08:27 -0700 (In reply to comment #3) > (From update of attachment 94845 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=94845&action=review > > I think the term “legacy full screen check” here is a little confusing; we might have been able to find a more specific name that would be clearer. Hm. How about "EnforceIFrameAllowFulScreenRequirement"? > I am puzzled by all the webkit prefixes on the function names. Those should be present only for functions exported to the DOM. There’s no point in having those prefixes in our own internal function names. The spec has changed a few times since I first added that function; webkitRequestFullScreenForElement used to be in the Document.idl, but has since been moved into Element. But you're right, these should have their prefixes snipped. > > Source/WebCore/dom/Document.h:1062 > > + typedef enum { > > + UseStrictFullScreenCheck, > > + UseLegacyFullScreenCheck, > > + } FullScreenCheckType; > > The preferred C++ syntax is just: > > enum X { A, B, C }; > > The syntax you’re using here is C-ism. You're right. Reflex. Changed. 409933 5 jer.noble 2011-05-25 14:38:42 -0700 Committed r87322: <http://trac.webkit.org/changeset/87322> 415178 6 ademar 2011-06-03 14:06:10 -0700 Revision r87322 cherry-picked into qtwebkit-2.2 with commit 10c0887 <http://gitorious.org/webkit/qtwebkit/commit/10c0887> 94845 2011-05-25 13:06:10 -0700 2011-05-25 14:02:17 -0700 Patch bug-61461-20110525130609.patch text/plain 8850 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogODczMDQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA2ODg3ZDFhOTdmZWI1Y2E3MDJhMzU2 MzhhMDEwNTFlYzgwOTI3NzFhLi5mYWRhNmNhZWQzMjE1NGUyYmE2YjhlYWY3NTk4NzQxZDI4YTdm MTZkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDUtMjUgIEplciBOb2JsZSAgPGplci5u b2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUkVHUkVTU0lPTjogRnVsbHNjcmVlbiBidXR0b24gb24gZW1iZWRkZWQgVmltZW8g dmlkZW9zIGRvZXMgbm90aGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjE0NjEKKworICAgICAgICAqIGZ1bGxzY3JlZW4vZnVsbC1zY3JlZW4taWZy YW1lLWxlZ2FjeS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZ1bGxzY3JlZW4vZnVs bC1zY3JlZW4taWZyYW1lLWxlZ2FjeS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmdWxsc2NyZWVu L3Jlc291cmNlcy9sZWdhY3kuaHRtbDogQWRkZWQuCisKIDIwMTEtMDUtMjUgIExlb24gU2Nyb2dn aW5zICA8c2Nyb2dnb0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFN0ZXZlIEJs b2NrLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZnVsbHNjcmVlbi9mdWxsLXNjcmVlbi1pZnJh bWUtbGVnYWN5LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Z1bGxzY3JlZW4vZnVsbC1zY3Jl ZW4taWZyYW1lLWxlZ2FjeS1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNmVkNjcxODdjYmI2ZTVk NGIzODhmYjI5YmZiYjVjZGZjYjA3NTUzYwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Z1bGxzY3JlZW4vZnVsbC1zY3JlZW4taWZyYW1lLWxlZ2FjeS1leHBlY3RlZC50eHQKQEAgLTAs MCArMSw4IEBACitUZXN0IGZvciBidWcgNjE0NjE6IEhhbmRsZSBlbnRlcmluZyBmdWxsIHNjcmVl biBzZWN1cml0eSByZXN0cmljdGlvbnMKKworVG8gdGVzdCBtYW51YWxseSwgY2xpY2sgdGhlIHZp ZGVvICJmdWxsIHNjcmVlbiIgYnV0dG9uIC0gdGhlIHBhZ2Ugc2hvdWxkIGVudGVyIGZ1bGwgc2Ny ZWVuIG1vZGUuCisKK0VWRU5UKHdlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UpCitURVNUKGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdmcmFtZScpLmNvbnRlbnREb2N1bWVudC53aWR0aD09ZG9jdW1lbnQu d2lkdGgpIE9LCitFTkQgT0YgVEVTVAorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mdWxsc2Ny ZWVuL2Z1bGwtc2NyZWVuLWlmcmFtZS1sZWdhY3kuaHRtbCBiL0xheW91dFRlc3RzL2Z1bGxzY3Jl ZW4vZnVsbC1zY3JlZW4taWZyYW1lLWxlZ2FjeS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmMyNzgwZThlMzM5 NWRjZmNmZWU3YzQ1MzlkZmZkOTI4MTJiYTFlZGIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWlmcmFtZS1sZWdhY3kuaHRtbApAQCAtMCwwICsx LDI3IEBACis8cD5UZXN0IGZvciA8YSBocmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjE0NjEiPmJ1ZyA2MTQ2MTwvYT46IAorSGFuZGxlIGVudGVyaW5nIGZ1bGwg c2NyZWVuIHNlY3VyaXR5IHJlc3RyaWN0aW9uczwvcD4KKzxwPlRvIHRlc3QgbWFudWFsbHksIGNs aWNrIHRoZSB2aWRlbyAiZnVsbCBzY3JlZW4iIGJ1dHRvbiAtIHRoZSBwYWdlIHNob3VsZCBlbnRl ciBmdWxsIHNjcmVlbiBtb2RlLjwvcD4KKzxzY3JpcHQgc3JjPSJmdWxsLXNjcmVlbi10ZXN0Lmpz Ij48L3NjcmlwdD4KKzxzY3JpcHQ+CitmdW5jdGlvbiBydW5UZXN0KCkgeworICAgIHZhciBmcmFt ZSA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdmcmFtZScpOworCisgICAgd2FpdEZvckV2ZW50 KGZyYW1lLmNvbnRlbnREb2N1bWVudCwgJ3dlYmtpdGZ1bGxzY3JlZW5jaGFuZ2UnLCBmdW5jdGlv bigpIHsgCisgICAgICAgICAgICB0ZXN0KCJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZnJhbWUn KS5jb250ZW50RG9jdW1lbnQud2lkdGg9PWRvY3VtZW50LndpZHRoIikKKyAgICAgICAgICAgIGVu ZFRlc3QoKTsKKyAgICB9KTsKKworICAgIHJ1bldpdGhLZXlEb3duKGZ1bmN0aW9uKCkgeworCisg ICAgICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7IAorICAgICAgICAgICAgY29uc29sZVdyaXRl KCJGQUlMIC0gZGlkIG5vdCBlbnRlciBmdWxsIHNjcmVlbiEiKTsgCisgICAgICAgICAgICBlbmRU ZXN0KCk7IAorICAgICAgICB9LCA1MCk7CisKKyAgICAgICAgdmFyIHZpZGVvID0gZnJhbWUuY29u dGVudERvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCd2aWRlbycpWzBdOworICAgICAgICB2 aWRlby53ZWJraXRFbnRlckZ1bGxTY3JlZW4oKTsKKyAgICB9KTsKK30KKzwvc2NyaXB0PgorPGlm cmFtZSBpZD0iZnJhbWUiIHNyYz0icmVzb3VyY2VzL2xlZ2FjeS5odG1sIiBvbmxvYWQ9InJ1blRl c3QoKSIgd2lkdGg9IjMzNiIgaGVpZ2h0PSIyNTYiPgorPC9pZnJhbWU+CmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mdWxsc2NyZWVuL3Jlc291cmNlcy9sZWdhY3kuaHRtbCBiL0xheW91dFRlc3Rz L2Z1bGxzY3JlZW4vcmVzb3VyY2VzL2xlZ2FjeS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmI2OTYzNTI3Mjk1 ZDYyMzViMzc2NTQ3ZTZiMjJhZGE5YWFkN2I5YTkKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mdWxsc2NyZWVuL3Jlc291cmNlcy9sZWdhY3kuaHRtbApAQCAtMCwwICsxLDcgQEAKKzx2 aWRlbyBjb250cm9scyB3aWR0aD0iMzIwIiBoZWlnaHQ9IjI0MCI+PC92aWRlbz4KKzxzY3JpcHQg c3JjPS4uLy4uL21lZGlhL21lZGlhLWZpbGUuanM+PC9zY3JpcHQ+Cis8c2NyaXB0PgorICAgIHZp ZGVvID0gbWVkaWFFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3ZpZGVv JylbMF07CisgICAgdmFyIG1lZGlhRmlsZSA9IGZpbmRNZWRpYUZpbGUoInZpZGVvIiwgIi4uLy4u L21lZGlhL2NvbnRlbnQvdGVzdCIpOworICAgIHZpZGVvLnNyYyA9IG1lZGlhRmlsZTsKKzwvc2Ny aXB0PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IGY0MGY1MmRjYjA1N2EwYjkxZmMwNjhiNmFmYmUyNmJiNzM0N2Vk YWYuLmFkOTExMjc3YTRiMGJjMmIyYWYyMzJkZDVmZWU0N2M1YTNiMWUwNzggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwyOCBAQAorMjAxMS0wNS0yNSAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS RUdSRVNTSU9OOiBGdWxsc2NyZWVuIGJ1dHRvbiBvbiBlbWJlZGRlZCBWaW1lbyB2aWRlb3MgZG9l cyBub3RoaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02MTQ2MQorCisgICAgICAgIFRlc3RzOiBmdWxsc2NyZWVuL2Z1bGwtc2NyZWVuLWlmcmFtZS1s ZWdhY3kuaHRtbAorCisgICAgICAgIEFsbG93IGNhbGxzIGZyb20gdGhlIGxlZ2FjeSBmdWxsLXNj cmVlbiBBUEkgdG8gYnlwYXNzIHRoZSBpZnJhbWUKKyAgICAgICAgIndlYmtpdGFsbG93ZnVsbHNj cmVlbiIgcmVxdWlyZW1lbnQgYnkgYWRkaW5nIGEgcGFyYW1ldGVyIHRvIAorICAgICAgICBEb2N1 bWVudDo6d2Via2l0UmVxdWVzdEZ1bGxTY3JlZW5Gb3JFbGVtZW50IHNwZWNpZnlpbmcgdGhlIHN0 cmljdG5lc3MKKyAgICAgICAgb2YgdGhhdCBjaGVjay4gIFNwZWNpZnkgdGhpcyBuZXcgcGFyYW1l dGVyIGV2ZXJ5d2hlcmUgdGhhdCBmdW5jdGlvbiBpcyAKKyAgICAgICAgY2FsbGVkLCBpbmNsdWRp bmcgaW4gdGhlIGRlZmF1bHQgY29udHJvbHMnIGZ1bGwtc2NyZWVuIGJ1dHRvbiBoYW5kbGVyLgor CisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50 Ojp3ZWJraXRSZXF1ZXN0RnVsbFNjcmVlbkZvckVsZW1lbnQpOgorICAgICAgICAqIGRvbS9Eb2N1 bWVudC5oOgorICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVs ZW1lbnQ6OndlYmtpdFJlcXVlc3RGdWxsU2NyZWVuKToKKyAgICAgICAgKiBodG1sL0hUTUxNZWRp YUVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6ZW50ZXJG dWxsc2NyZWVuKToKKyAgICAgICAgKiBodG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYUNvbnRyb2xGdWxsc2NyZWVuQnV0dG9uRWxlbWVu dDo6ZGVmYXVsdEV2ZW50SGFuZGxlcik6CisKIDIwMTEtMDUtMjQgIEplciBOb2JsZSAgPGplci5u b2JsZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvZG9tL0RvY3VtZW50LmNwcAppbmRleCA1Yzc1MjYwMGZiNjQwNmRlMzNkYWQxNWFlMDM3YjBl Y2Y2OTRlMDk4Li4yNWFhN2UyNjdlZjdlOGM2ZDEwYjdjZTUzMjdhZTdiNDdhN2M4ZTJjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9Eb2N1bWVudC5jcHAKQEAgLTQ4MjUsNyArNDgyNSw3IEBAIGJvb2wgRG9jdW1lbnQ6 OmZ1bGxTY3JlZW5Jc0FsbG93ZWRGb3JFbGVtZW50KEVsZW1lbnQqIGVsZW1lbnQpIGNvbnN0CiAg ICAgcmV0dXJuIHRydWU7CiB9CiAKLXZvaWQgRG9jdW1lbnQ6OndlYmtpdFJlcXVlc3RGdWxsU2Ny ZWVuRm9yRWxlbWVudChFbGVtZW50KiBlbGVtZW50LCB1bnNpZ25lZCBzaG9ydCBmbGFncykKK3Zv aWQgRG9jdW1lbnQ6OndlYmtpdFJlcXVlc3RGdWxsU2NyZWVuRm9yRWxlbWVudChFbGVtZW50KiBl bGVtZW50LCB1bnNpZ25lZCBzaG9ydCBmbGFncywgRnVsbFNjcmVlbkNoZWNrVHlwZSBjaGVja1R5 cGUpCiB7CiAgICAgaWYgKCFwYWdlKCkgfHwgIXBhZ2UoKS0+c2V0dGluZ3MoKS0+ZnVsbFNjcmVl bkVuYWJsZWQoKSkKICAgICAgICAgcmV0dXJuOwpAQCAtNDgzMyw3ICs0ODMzLDcgQEAgdm9pZCBE b2N1bWVudDo6d2Via2l0UmVxdWVzdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KEVsZW1lbnQqIGVsZW1l bnQsIHVuc2lnbmVkIHNob3IKICAgICBpZiAoIWVsZW1lbnQpCiAgICAgICAgIGVsZW1lbnQgPSBk b2N1bWVudEVsZW1lbnQoKTsKICAgICAKLSAgICBpZiAoIWZ1bGxTY3JlZW5Jc0FsbG93ZWRGb3JF bGVtZW50KGVsZW1lbnQpKQorICAgIGlmIChjaGVja1R5cGUgPT0gVXNlU3RyaWN0RnVsbFNjcmVl bkNoZWNrICYmICFmdWxsU2NyZWVuSXNBbGxvd2VkRm9yRWxlbWVudChlbGVtZW50KSkKICAgICAg ICAgcmV0dXJuOwogICAgIAogICAgIGlmICghU2NyaXB0Q29udHJvbGxlcjo6cHJvY2Vzc2luZ1Vz ZXJHZXN0dXJlKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBi L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4IGM0MTVjYTA1NjM0ZDZjN2IyODMy ZjhiMzUxZjIzMmE2Y2NkNWYyOTcuLjRmNWFkZTVmYjA2NWVhNTFlYzNjY2RiOWMyNDU0MTQ3YjVh YTAyMDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC0xMDU1LDcgKzEwNTUsMTMgQEAgcHVibGlj OgogICAgIGJvb2wgd2Via2l0SXNGdWxsU2NyZWVuKCkgY29uc3QgeyByZXR1cm4gbV9mdWxsU2Ny ZWVuRWxlbWVudC5nZXQoKTsgfQogICAgIGJvb2wgd2Via2l0RnVsbFNjcmVlbktleWJvYXJkSW5w dXRBbGxvd2VkKCkgY29uc3QgeyByZXR1cm4gbV9mdWxsU2NyZWVuRWxlbWVudC5nZXQoKSAmJiBt X2FyZUtleXNFbmFibGVkSW5GdWxsU2NyZWVuOyB9CiAgICAgRWxlbWVudCogd2Via2l0Q3VycmVu dEZ1bGxTY3JlZW5FbGVtZW50KCkgY29uc3QgeyByZXR1cm4gbV9mdWxsU2NyZWVuRWxlbWVudC5n ZXQoKTsgfQotICAgIHZvaWQgd2Via2l0UmVxdWVzdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KEVsZW1l bnQqLCB1bnNpZ25lZCBzaG9ydCBmbGFncyk7CisgICAgCisgICAgdHlwZWRlZiBlbnVtIHsKKyAg ICAgICAgVXNlU3RyaWN0RnVsbFNjcmVlbkNoZWNrLAorICAgICAgICBVc2VMZWdhY3lGdWxsU2Ny ZWVuQ2hlY2ssCisgICAgfSBGdWxsU2NyZWVuQ2hlY2tUeXBlOworCisgICAgdm9pZCB3ZWJraXRS ZXF1ZXN0RnVsbFNjcmVlbkZvckVsZW1lbnQoRWxlbWVudCosIHVuc2lnbmVkIHNob3J0IGZsYWdz LCBGdWxsU2NyZWVuQ2hlY2tUeXBlKTsKICAgICB2b2lkIHdlYmtpdENhbmNlbEZ1bGxTY3JlZW4o KTsKICAgICAKICAgICB2b2lkIHdlYmtpdFdpbGxFbnRlckZ1bGxTY3JlZW5Gb3JFbGVtZW50KEVs ZW1lbnQqKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCA0NGJiZTBmY2RjZDMzYjgxOTdjOWJj YzJlMDAxN2JhZGE4OTMzZDQzLi42ZmJjMWQ4YmIzZTEyN2Q2MzI5ZmQ5Zjg2YjliYTgwY2I0ZDdk ZjNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0xODg5LDcgKzE4ODksNyBAQCBib29sIEVs ZW1lbnQ6OmNoaWxkU2hvdWxkQ3JlYXRlUmVuZGVyZXIoTm9kZSogY2hpbGQpIGNvbnN0CiAjaWYg RU5BQkxFKEZVTExTQ1JFRU5fQVBJKQogdm9pZCBFbGVtZW50Ojp3ZWJraXRSZXF1ZXN0RnVsbFNj cmVlbih1bnNpZ25lZCBzaG9ydCBmbGFncykKIHsKLSAgICBkb2N1bWVudCgpLT53ZWJraXRSZXF1 ZXN0RnVsbFNjcmVlbkZvckVsZW1lbnQodGhpcywgZmxhZ3MpOworICAgIGRvY3VtZW50KCktPndl YmtpdFJlcXVlc3RGdWxsU2NyZWVuRm9yRWxlbWVudCh0aGlzLCBmbGFncywgRG9jdW1lbnQ6OlVz ZVN0cmljdEZ1bGxTY3JlZW5DaGVjayk7CiB9CiAjZW5kaWYgICAgCiAKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9o dG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCmluZGV4IGE0NGY5YTdhZWE4ZjlkMTRiYjljYWFmM2I3 ODUwZjQzNGI3MmQ5MzQuLjUxNjBmODcxMjk2NzNlYTdlNzljZDAxOGI1MTU5YmQ4OTM4YTcwYjAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcApAQCAtMjUzMSw3ICsy NTMxLDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjplbnRlckZ1bGxzY3JlZW4oKQogICAgIExP RyhNZWRpYSwgIkhUTUxNZWRpYUVsZW1lbnQ6OmVudGVyRnVsbHNjcmVlbiIpOwogI2lmIEVOQUJM RShGVUxMU0NSRUVOX0FQSSkKICAgICBpZiAoZG9jdW1lbnQoKSAmJiBkb2N1bWVudCgpLT5zZXR0 aW5ncygpICYmIGRvY3VtZW50KCktPnNldHRpbmdzKCktPmZ1bGxTY3JlZW5FbmFibGVkKCkpIHsK LSAgICAgICAgd2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4oMCk7CisgICAgICAgIGRvY3VtZW50KCkt PndlYmtpdFJlcXVlc3RGdWxsU2NyZWVuRm9yRWxlbWVudCh0aGlzLCAwLCBEb2N1bWVudDo6VXNl TGVnYWN5RnVsbFNjcmVlbkNoZWNrKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KICNlbmRpZgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVu dHMuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvTWVkaWFDb250cm9sRWxlbWVudHMu Y3BwCmluZGV4IDU0YTQ1MzkyNTU4NTczNzI5Mjg2NDU5OTFiYmJjMThlMzVlODQzNDEuLjYzNDA0 NDM2ZmJkMWI2MzYyN2NhZDk1MWE5NzI2YmM2MmJmZmI4YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2h0bWwvc2hhZG93L01lZGlhQ29udHJvbEVsZW1lbnRzLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9odG1sL3NoYWRvdy9NZWRpYUNvbnRyb2xFbGVtZW50cy5jcHAKQEAgLTc5Myw3ICs3 OTMsNyBAQCB2b2lkIE1lZGlhQ29udHJvbEZ1bGxzY3JlZW5CdXR0b25FbGVtZW50OjpkZWZhdWx0 RXZlbnRIYW5kbGVyKEV2ZW50KiBldmVudCkKICAgICAgICAgICAgICAgICBkb2N1bWVudCgpLT53 ZWJraXRDYW5jZWxGdWxsU2NyZWVuKCk7CiAgICAgICAgICAgICAgICAgbV9jb250cm9scy0+ZXhp dGVkRnVsbHNjcmVlbigpOwogICAgICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgICAgICBt ZWRpYUVsZW1lbnQoKS0+d2Via2l0UmVxdWVzdEZ1bGxTY3JlZW4oMCk7CisgICAgICAgICAgICAg ICAgZG9jdW1lbnQoKS0+d2Via2l0UmVxdWVzdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KG1lZGlhRWxl bWVudCgpLCAwLCBEb2N1bWVudDo6VXNlTGVnYWN5RnVsbFNjcmVlbkNoZWNrKTsKICAgICAgICAg ICAgICAgICBtX2NvbnRyb2xzLT5lbnRlcmVkRnVsbHNjcmVlbigpOwogICAgICAgICAgICAgfQog ICAgICAgICB9IGVsc2UK