61460 2011-05-25 12:27:32 -0700 Add 'noExtensions' option to Web/GraphicsContext3D attributes 2011-05-25 20:32:22 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 gman gman commit-queue kbr oldest_to_newest 409838 0 gman 2011-05-25 12:27:32 -0700 noExtensions requests that it would like the underlying system to turn off as many extensions as it can. Like depth, stencil and antialias this is a hint, not a requirement. WebGL sets this to true hoping that the underlying OpenGL ES implementation can turn off things like OES_texture_npot thereby not requiring WebGL to enforce it itself. Of course WebGL still has to check the extension as turned off 409847 1 94837 gman 2011-05-25 12:37:53 -0700 Created attachment 94837 Patch 409860 2 94837 kbr 2011-05-25 12:47:34 -0700 Comment on attachment 94837 Patch Sounds fine. 410150 3 94837 commit-queue 2011-05-25 20:32:18 -0700 Comment on attachment 94837 Patch Clearing flags on attachment: 94837 Committed r87353: <http://trac.webkit.org/changeset/87353> 410151 4 commit-queue 2011-05-25 20:32:22 -0700 All reviewed patches have been landed. Closing bug. 94837 2011-05-25 12:37:53 -0700 2011-05-25 20:32:18 -0700 Patch bug-61460-20110525123752.patch text/plain 3404 gman SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDg3MzE1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUt MjUgIEdyZWdnIFRhdmFyZXMgIDxnbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgJ25vRXh0ZW5zaW9ucycgb3B0aW9u IHRvIFdlYi9HcmFwaGljc0NvbnRleHQzRCBhdHRyaWJ1dGVzLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjE0NjAKKworICAgICAgICAqIFNvdXJjZS9X ZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHA6CisgICAgICAgICog U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaDoKKyAg ICAgICAgKiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQz RC5oOgorICAgICAgICAqIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNzQ29udGV4 dDNEQ2hyb21pdW0uY3BwOgorCiAyMDExLTA1LTI0ICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNoaUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpJbmRleDogU291 cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQu Y3BwCShyZXZpc2lvbiA4NzMxMCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdM UmVuZGVyaW5nQ29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2OSw2ICszNjksNyBAQCBQ YXNzT3duUHRyPFdlYkdMUmVuZGVyaW5nQ29udGV4dD4gV2ViR0xSCiAgICAgICAgICAgICBhdHRy aWJ1dGVzLmFudGlhbGlhcyA9IGZhbHNlOwogICAgIH0KIAorICAgIGF0dHJpYnV0ZXMubm9FeHRl bnNpb25zID0gdHJ1ZTsKICAgICBSZWZQdHI8R3JhcGhpY3NDb250ZXh0M0Q+IGNvbnRleHQoR3Jh cGhpY3NDb250ZXh0M0Q6OmNyZWF0ZShhdHRyaWJ1dGVzLCBob3N0V2luZG93KSk7CiAKICAgICBp ZiAoIWNvbnRleHQpIHsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dy YXBoaWNzQ29udGV4dDNELmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaAkocmV2aXNpb24gODczMTApCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oCSh3b3JraW5nIGNv cHkpCkBAIC00MjcsNiArNDI3LDcgQEAgcHVibGljOgogICAgICAgICAgICAgLCBwcmVtdWx0aXBs aWVkQWxwaGEodHJ1ZSkKICAgICAgICAgICAgICwgY2FuUmVjb3ZlckZyb21Db250ZXh0TG9zcyh0 cnVlKQogICAgICAgICAgICAgLCBwcmVzZXJ2ZURyYXdpbmdCdWZmZXIoZmFsc2UpCisgICAgICAg ICAgICAsIG5vRXh0ZW5zaW9ucyhmYWxzZSkKICAgICAgICAgewogICAgICAgICB9CiAKQEAgLTQz Nyw2ICs0MzgsNyBAQCBwdWJsaWM6CiAgICAgICAgIGJvb2wgcHJlbXVsdGlwbGllZEFscGhhOwog ICAgICAgICBib29sIGNhblJlY292ZXJGcm9tQ29udGV4dExvc3M7CiAgICAgICAgIGJvb2wgcHJl c2VydmVEcmF3aW5nQnVmZmVyOworICAgICAgICBib29sIG5vRXh0ZW5zaW9uczsKICAgICB9Owog CiAgICAgZW51bSBSZW5kZXJTdHlsZSB7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmgJKHJldmlzaW9uIDg3MzEwKQor KysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR3JhcGhpY3NDb250ZXh0M0QuaAko d29ya2luZyBjb3B5KQpAQCAtODUsNiArODUsNyBAQCBwdWJsaWM6CiAgICAgICAgICAgICAsIGFu dGlhbGlhcyh0cnVlKQogICAgICAgICAgICAgLCBwcmVtdWx0aXBsaWVkQWxwaGEodHJ1ZSkKICAg ICAgICAgICAgICwgY2FuUmVjb3ZlckZyb21Db250ZXh0TG9zcyh0cnVlKQorICAgICAgICAgICAg LCBub0V4dGVuc2lvbnMoZmFsc2UpCiAgICAgICAgIHsKICAgICAgICAgfQogCkBAIC05NCw2ICs5 NSw3IEBAIHB1YmxpYzoKICAgICAgICAgYm9vbCBhbnRpYWxpYXM7CiAgICAgICAgIGJvb2wgcHJl bXVsdGlwbGllZEFscGhhOwogICAgICAgICBib29sIGNhblJlY292ZXJGcm9tQ29udGV4dExvc3M7 CisgICAgICAgIGJvb2wgbm9FeHRlbnNpb25zOwogICAgIH07CiAKICAgICBjbGFzcyBXZWJHcmFw aGljc0NvbnRleHRMb3N0Q2FsbGJhY2sgewpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9z cmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RDaHJvbWl1bS5jcHAJKHJldmlzaW9u IDg3MzEwKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvR3JhcGhpY3NDb250ZXh0M0RD aHJvbWl1bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwOSw2ICsxMDksNyBAQCBib29sIEdyYXBo aWNzQ29udGV4dDNESW50ZXJuYWw6OmluaXRpYWxpCiAgICAgd2ViQXR0cmlidXRlcy5hbnRpYWxp YXMgPSBhdHRycy5hbnRpYWxpYXM7CiAgICAgd2ViQXR0cmlidXRlcy5wcmVtdWx0aXBsaWVkQWxw aGEgPSBhdHRycy5wcmVtdWx0aXBsaWVkQWxwaGE7CiAgICAgd2ViQXR0cmlidXRlcy5jYW5SZWNv dmVyRnJvbUNvbnRleHRMb3NzID0gYXR0cnMuY2FuUmVjb3ZlckZyb21Db250ZXh0TG9zczsKKyAg ICB3ZWJBdHRyaWJ1dGVzLm5vRXh0ZW5zaW9ucyA9IGF0dHJzLm5vRXh0ZW5zaW9uczsKICAgICBP d25QdHI8V2ViS2l0OjpXZWJHcmFwaGljc0NvbnRleHQzRD4gd2ViQ29udGV4dCA9IGFkb3B0UHRy KFdlYktpdDo6d2ViS2l0Q2xpZW50KCktPmNyZWF0ZUdyYXBoaWNzQ29udGV4dDNEKCkpOwogICAg IGlmICghd2ViQ29udGV4dCkKICAgICAgICAgcmV0dXJuIGZhbHNlOwo=