61416 2011-05-24 21:23:28 -0700 [JSC] malfunction during arithmetic condition check with negative number (-2147483648) 2011-05-30 16:50:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 0 hojong.han webkit-unassigned barraclough commit-queue ggaren gyuyoung.kim zherczeg oldest_to_newest 409438 0 hojong.han 2011-05-24 21:23:28 -0700 Example below doesn't work properly ------------------------------------------------------------------ <script type="text/javascript"> var f = 10; if (f < -2147483648) {alert("wrong");} </script> ------------------------------------------------------------------ The condition to check 0x80000000 is necessary when making CMN instruction for JIT. 409519 1 94754 hojong.han 2011-05-25 01:47:24 -0700 Created attachment 94754 Adding the condition to check 0x80000000 when making ARM instruction CMN for JIT 409546 2 94754 gyuyoung.kim 2011-05-25 02:50:35 -0700 Comment on attachment 94754 Adding the condition to check 0x80000000 when making ARM instruction CMN for JIT View in context: https://bugs.webkit.org/attachment.cgi?id=94754&action=review > Source/JavaScriptCore/ChangeLog:3 > + Not reviewed. Please Change "Not reviewed" with Reviewed by NOBODY (OOPS!). 409572 3 94754 hojong.han 2011-05-25 03:36:26 -0700 Comment on attachment 94754 Adding the condition to check 0x80000000 when making ARM instruction CMN for JIT >Index: Source/JavaScriptCore/ChangeLog >=================================================================== >--- Source/JavaScriptCore/ChangeLog (revision 87279) >+++ Source/JavaScriptCore/ChangeLog (working copy) >@@ -1,3 +1,13 @@ >+2011-05-25 Hojong Han <hojong.han@samsung.com> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ Adding the condition to check 0x80000000 when making ARM instruction CMN for JIT. >+ https://bugs.webkit.org/show_bug.cgi?id=61416 >+ >+ * assembler/MacroAssemblerARM.h: >+ (JSC::MacroAssemblerARM::branch32): >+ > 2011-05-24 Keishi Hattori <keishi@webkit.org> > > Reviewed by Kent Tamura. >Index: Source/JavaScriptCore/assembler/MacroAssemblerARM.h >=================================================================== >--- Source/JavaScriptCore/assembler/MacroAssemblerARM.h (revision 87276) >+++ Source/JavaScriptCore/assembler/MacroAssemblerARM.h (working copy) >@@ -416,7 +416,7 @@ > m_assembler.ldr_un_imm(ARMRegisters::S0, right.m_value); > m_assembler.cmp_r(left, ARMRegisters::S0); > } else { >- ARMWord tmp = m_assembler.getOp2(-right.m_value); >+ ARMWord tmp = (right.m_value == 0x80000000)?ARMAssembler::INVALID_IMM:m_assembler.getOp2(-right.m_value); > if (tmp != ARMAssembler::INVALID_IMM) > m_assembler.cmn_r(left, tmp); > else 409580 4 94768 hojong.han 2011-05-25 03:51:20 -0700 Created attachment 94768 Patch 409810 5 ggaren 2011-05-25 12:05:40 -0700 + ARMWord tmp = (right.m_value == 0x80000000)?ARMAssembler::INVALID_IMM:m_assembler.getOp2(-right.m_value); Spacing doesn't match the WebKit style guidelines. There should be spaces around "?" and ":". 409823 6 barraclough 2011-05-25 12:22:31 -0700 A fix like this really ought to be accompanied by a regression test. This can be really easy, you should be able to just find a test in the LayoutTests/fast/js directory with 'arithmetic' or 'comparisons' in the name, add something like: var testValue = 10; shouldBeFalse("testValue < -2147483648"); And run the layout test to get updated results (which will just be a line saying PASS). cheers, G. 410296 7 94944 hojong.han 2011-05-26 01:59:52 -0700 Created attachment 94944 Patch 410299 8 hojong.han 2011-05-26 02:05:00 -0700 Thank you for comment. I ran "Tools/Script/check-webkit-style", there're mistakes though. > + ARMWord tmp = (right.m_value == 0x80000000)?ARMAssembler::INVALID_IMM:m_assembler.getOp2(-right.m_value); > > Spacing doesn't match the WebKit style guidelines. There should be spaces around "?" and ":". 410307 9 hojong.han 2011-05-26 02:18:14 -0700 I'm appreciated your comment and trying to set layout regression test, but there's one thing difficult for me is that this issue happens at elf port with ARM and there is not an easy way to run the test. Could you let me know another way for test or something I don't catch? > A fix like this really ought to be accompanied by a regression test. > > This can be really easy, you should be able to just find a test in the LayoutTests/fast/js directory with 'arithmetic' or 'comparisons' in the name, add something like: > > var testValue = 10; > shouldBeFalse("testValue < -2147483648"); > > And run the layout test to get updated results (which will just be a line saying PASS). > > cheers, > G. 410308 10 gyuyoung.kim 2011-05-26 02:23:00 -0700 (In reply to comment #9) > I'm appreciated your comment and trying to set layout regression test, > but there's one thing difficult for me is that this issue happens at elf port with ARM and there is not an easy way to run the test. > Could you let me know another way for test or something I don't catch? > > A fix like this really ought to be accompanied by a regression test. > > > > This can be really easy, you should be able to just find a test in the LayoutTests/fast/js directory with 'arithmetic' or 'comparisons' in the name, add something like: > > > > var testValue = 10; > > shouldBeFalse("testValue < -2147483648"); > > > > And run the layout test to get updated results (which will just be a line saying PASS). > > > > cheers, > > G. EFL port doesn't have DRT yet. But, DRT for EFL port is going to contribute WebKit mainline soon. I think you may be able to test arthmetic test by EWebLauncher or jsc executable manually. 410315 11 gyuyoung.kim 2011-05-26 02:31:32 -0700 > EFL port doesn't have DRT yet. But, DRT for EFL port is going to contribute WebKit mainline soon. I think you may be able to test arthmetic test by EWebLauncher or jsc executable manually. Or, you can use DRT in GTK port. 410395 12 hojong.han 2011-05-26 06:41:24 -0700 (In reply to comment #6) > A fix like this really ought to be accompanied by a regression test. > > This can be really easy, you should be able to just find a test in the LayoutTests/fast/js directory with 'arithmetic' or 'comparisons' in the name, add something like: > > var testValue = 10; > shouldBeFalse("testValue < -2147483648"); > > And run the layout test to get updated results (which will just be a line saying PASS). > > cheers, > G. I added test code like below into the JS file (Source/JavaScriptCore/tests/mozilla/ecma/Array/15.4.1.1.js) for JSC regression test and then ran "./jsc_efl -s -f shell.js 15.4.1.1.js" [Test case code] array[item++] = new TestCase( SECTION, "var f = 10; var g; if(f < -2147483648) g = false; else g = true; g.toString()", "true", eval("var f = 10; var g; if(f < -2147483648) g = false; else g = true; g.toString()") ); [Before fixed] var f = 10; var g; if(f < -2147483648) g = false; else g = true; g.toString() = false FAILED! expected: true [After fixed] var f = 10; var g; if(f < -2147483648) g = false; else g = true; g.toString() = true PASSED! 410982 13 94944 barraclough 2011-05-26 16:31:56 -0700 Comment on attachment 94944 Patch Under the circumstances, adding this to a jsc test seems fine to me. Please put up a patch containing the added test case & new test results too. 411180 14 95118 hojong.han 2011-05-26 22:58:57 -0700 Created attachment 95118 Patch 411186 15 hojong.han 2011-05-26 23:07:44 -0700 (In reply to comment #13) > (From update of attachment 94944 [details]) > Under the circumstances, adding this to a jsc test seems fine to me. Please put up a patch containing the added test case & new test results too. I added new patch including test case, except test results because newly added test case with a fix doesn't throw any message when it's passed. 411203 16 zherczeg 2011-05-26 23:31:25 -0700 Nice catch! -INT_MIN == INT_MIN I like this patch, although I can't give you an r+. Hopefully someone will do. 412123 17 gyuyoung.kim 2011-05-29 22:41:02 -0700 (In reply to comment #16) > Nice catch! -INT_MIN == INT_MIN > I like this patch, although I can't give you an r+. Hopefully someone will do. Hello Geoffrey, How do you think about this patch ? It seems to me Zoltan give an internal review "+". 412390 18 95118 ggaren 2011-05-30 16:15:17 -0700 Comment on attachment 95118 Patch r=me 412399 19 95118 commit-queue 2011-05-30 16:50:03 -0700 Comment on attachment 95118 Patch Clearing flags on attachment: 95118 Committed r87702: <http://trac.webkit.org/changeset/87702> 412400 20 commit-queue 2011-05-30 16:50:10 -0700 All reviewed patches have been landed. Closing bug. 94754 2011-05-25 01:47:24 -0700 2011-05-25 03:51:11 -0700 Adding the condition to check 0x80000000 when making ARM instruction CMN for JIT patch_file.patch text/plain 1360 hojong.han SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODcyNzkpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDUtMjUgIEhvam9uZyBIYW4gIDxob2pvbmcuaGFuQHNhbXN1bmcuY29tPgorCisgICAg ICAgIE5vdCByZXZpZXdlZC4KKworICAgICAgICBBZGRpbmcgdGhlIGNvbmRpdGlvbiB0byBjaGVj ayAweDgwMDAwMDAwIHdoZW4gbWFraW5nIEFSTSBpbnN0cnVjdGlvbiBDTU4gZm9yIEpJVC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxNDE2CisKKyAg ICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaDoKKyAgICAgICAgKEpTQzo6TWFj cm9Bc3NlbWJsZXJBUk06OmJyYW5jaDMyKToKKwogMjAxMS0wNS0yNCAgS2Vpc2hpIEhhdHRvcmkg IDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4K SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0u aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNz ZW1ibGVyQVJNLmgJKHJldmlzaW9uIDg3Mjc2KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fz c2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCSh3b3JraW5nIGNvcHkpCkBAIC00MTYsNyArNDE2 LDcgQEAKICAgICAgICAgICAgIG1fYXNzZW1ibGVyLmxkcl91bl9pbW0oQVJNUmVnaXN0ZXJzOjpT MCwgcmlnaHQubV92YWx1ZSk7CiAgICAgICAgICAgICBtX2Fzc2VtYmxlci5jbXBfcihsZWZ0LCBB Uk1SZWdpc3RlcnM6OlMwKTsKICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIEFSTVdvcmQg dG1wID0gbV9hc3NlbWJsZXIuZ2V0T3AyKC1yaWdodC5tX3ZhbHVlKTsKKyAgICAgICAgICAgIEFS TVdvcmQgdG1wID0gKHJpZ2h0Lm1fdmFsdWUgPT0gMHg4MDAwMDAwMCk/QVJNQXNzZW1ibGVyOjpJ TlZBTElEX0lNTTptX2Fzc2VtYmxlci5nZXRPcDIoLXJpZ2h0Lm1fdmFsdWUpOwogICAgICAgICAg ICAgaWYgKHRtcCAhPSBBUk1Bc3NlbWJsZXI6OklOVkFMSURfSU1NKQogICAgICAgICAgICAgICAg IG1fYXNzZW1ibGVyLmNtbl9yKGxlZnQsIHRtcCk7CiAgICAgICAgICAgICBlbHNlCg== 94768 2011-05-25 03:51:20 -0700 2011-05-26 01:59:43 -0700 Patch bug-61416-20110525195117.patch text/plain 1387 hojong.han SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODcyODUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDUtMjUgIEhvam9uZyBIYW4gIDxob2pvbmcuaGFuQHNhbXN1bmcuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtKU0NdIG1hbGZ1bmN0 aW9uIGR1cmluZyBhcml0aG1ldGljIGNvbmRpdGlvbiBjaGVjayB3aXRoIG5lZ2F0aXZlIG51bWJl ciAoLTIxNDc0ODM2NDgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02MTQxNgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6 CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpicmFuY2gzMik6CisKIDIwMTEtMDUt MjQgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgS2VudCBUYW11cmEuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyQVJNLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCShyZXZpc2lvbiA4NzI3NikKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAkod29ya2luZyBj b3B5KQpAQCAtNDE2LDcgKzQxNiw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgIG1fYXNzZW1ibGVy Lmxkcl91bl9pbW0oQVJNUmVnaXN0ZXJzOjpTMCwgcmlnaHQubV92YWx1ZSk7CiAgICAgICAgICAg ICBtX2Fzc2VtYmxlci5jbXBfcihsZWZ0LCBBUk1SZWdpc3RlcnM6OlMwKTsKICAgICAgICAgfSBl bHNlIHsKLSAgICAgICAgICAgIEFSTVdvcmQgdG1wID0gbV9hc3NlbWJsZXIuZ2V0T3AyKC1yaWdo dC5tX3ZhbHVlKTsKKyAgICAgICAgICAgIEFSTVdvcmQgdG1wID0gKHJpZ2h0Lm1fdmFsdWUgPT0g MHg4MDAwMDAwMCk/QVJNQXNzZW1ibGVyOjpJTlZBTElEX0lNTTptX2Fzc2VtYmxlci5nZXRPcDIo LXJpZ2h0Lm1fdmFsdWUpOwogICAgICAgICAgICAgaWYgKHRtcCAhPSBBUk1Bc3NlbWJsZXI6OklO VkFMSURfSU1NKQogICAgICAgICAgICAgICAgIG1fYXNzZW1ibGVyLmNtbl9yKGxlZnQsIHRtcCk7 CiAgICAgICAgICAgICBlbHNlCg== 94944 2011-05-26 01:59:52 -0700 2011-05-26 22:58:47 -0700 Patch bug-61416-20110526175942.patch text/plain 1393 hojong.han SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODczNzApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTEtMDUtMjYgIEhvam9uZyBIYW4gIDxob2pvbmcuaGFuQHNhbXN1bmcuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtKU0NdIG1hbGZ1bmN0 aW9uIGR1cmluZyBhcml0aG1ldGljIGNvbmRpdGlvbiBjaGVjayB3aXRoIG5lZ2F0aXZlIG51bWJl ciAoLTIxNDc0ODM2NDgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02MTQxNgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6 CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpicmFuY2gzMik6CisKIDIwMTEtMDUt MjYgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENv cmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgJKHJldmlzaW9uIDg3MzU3KQorKysgU291 cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCSh3b3JraW5n IGNvcHkpCkBAIC00MTYsNyArNDE2LDcgQEAgcHVibGljOgogICAgICAgICAgICAgbV9hc3NlbWJs ZXIubGRyX3VuX2ltbShBUk1SZWdpc3RlcnM6OlMwLCByaWdodC5tX3ZhbHVlKTsKICAgICAgICAg ICAgIG1fYXNzZW1ibGVyLmNtcF9yKGxlZnQsIEFSTVJlZ2lzdGVyczo6UzApOwogICAgICAgICB9 IGVsc2UgewotICAgICAgICAgICAgQVJNV29yZCB0bXAgPSBtX2Fzc2VtYmxlci5nZXRPcDIoLXJp Z2h0Lm1fdmFsdWUpOworICAgICAgICAgICAgQVJNV29yZCB0bXAgPSAocmlnaHQubV92YWx1ZSA9 PSAweDgwMDAwMDAwKSA/IEFSTUFzc2VtYmxlcjo6SU5WQUxJRF9JTU0gOiBtX2Fzc2VtYmxlci5n ZXRPcDIoLXJpZ2h0Lm1fdmFsdWUpOwogICAgICAgICAgICAgaWYgKHRtcCAhPSBBUk1Bc3NlbWJs ZXI6OklOVkFMSURfSU1NKQogICAgICAgICAgICAgICAgIG1fYXNzZW1ibGVyLmNtbl9yKGxlZnQs IHRtcCk7CiAgICAgICAgICAgICBlbHNlCg== 95118 2011-05-26 22:58:57 -0700 2011-05-30 16:50:03 -0700 Patch bug-61416-20110527145841.patch text/plain 2202 hojong.han SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gODc0NzIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTEtMDUtMjYgIEhvam9uZyBIYW4gIDxob2pvbmcuaGFuQHNhbXN1bmcuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtKU0NdIG1hbGZ1bmN0 aW9uIGR1cmluZyBhcml0aG1ldGljIGNvbmRpdGlvbiBjaGVjayB3aXRoIG5lZ2F0aXZlIG51bWJl ciAoLTIxNDc0ODM2NDgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02MTQxNgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmg6 CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyQVJNOjpicmFuY2gzMik6CisgICAgICAgICog dGVzdHMvbW96aWxsYS9lY21hL0V4cHJlc3Npb25zLzExLjEyLTEuanM6CisgICAgICAgIChnZXRU ZXN0Q2FzZXMpOgorCiAyMDExLTA1LTI2ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyIEh1bnQuCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oCShyZXZp c2lvbiA4NzQ2NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3Nl bWJsZXJBUk0uaAkod29ya2luZyBjb3B5KQpAQCAtNDE2LDcgKzQxNiw3IEBAIHB1YmxpYzoKICAg ICAgICAgICAgIG1fYXNzZW1ibGVyLmxkcl91bl9pbW0oQVJNUmVnaXN0ZXJzOjpTMCwgcmlnaHQu bV92YWx1ZSk7CiAgICAgICAgICAgICBtX2Fzc2VtYmxlci5jbXBfcihsZWZ0LCBBUk1SZWdpc3Rl cnM6OlMwKTsKICAgICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIEFSTVdvcmQgdG1wID0gbV9h c3NlbWJsZXIuZ2V0T3AyKC1yaWdodC5tX3ZhbHVlKTsKKyAgICAgICAgICAgIEFSTVdvcmQgdG1w ID0gKHJpZ2h0Lm1fdmFsdWUgPT0gMHg4MDAwMDAwMCkgPyBBUk1Bc3NlbWJsZXI6OklOVkFMSURf SU1NIDogbV9hc3NlbWJsZXIuZ2V0T3AyKC1yaWdodC5tX3ZhbHVlKTsKICAgICAgICAgICAgIGlm ICh0bXAgIT0gQVJNQXNzZW1ibGVyOjpJTlZBTElEX0lNTSkKICAgICAgICAgICAgICAgICBtX2Fz c2VtYmxlci5jbW5fcihsZWZ0LCB0bXApOwogICAgICAgICAgICAgZWxzZQpJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL3Rlc3RzL21vemlsbGEvZWNtYS9FeHByZXNzaW9ucy8xMS4xMi0xLmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS90ZXN0cy9tb3ppbGxhL2VjbWEv RXhwcmVzc2lvbnMvMTEuMTItMS5qcwkocmV2aXNpb24gODc0NjYpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvdGVzdHMvbW96aWxsYS9lY21hL0V4cHJlc3Npb25zLzExLjEyLTEuanMJKHdvcmtp bmcgY29weSkKQEAgLTY5LDYgKzY5LDggQEAgZnVuY3Rpb24gZ2V0VGVzdENhc2VzKCkgewogCiAg ICAgYXJyYXlbaXRlbSsrXSA9IG5ldyBUZXN0Q2FzZSggU0VDVElPTiwgICAgInZhciBWQVIgPSB0 cnVlID8gLCA6ICdGQUlMRUQnIiwgIlBBU1NFRCIsICAgICAgICAgICAoVkFSID0gdHJ1ZSA/ICJQ QVNTRUQiIDogIkZBSUxFRCIpICk7CiAKKyAgICBhcnJheVtpdGVtKytdID0gbmV3IFRlc3RDYXNl KCBTRUNUSU9OLCAgICAiaXRlbSA9ICIgKyBpdGVtICsiOyBWQVIgPSAoaXRlbSA8IC0yMTQ3NDgz NjQ4KSA/ICdGQUlMRUQnIDogJ1BBU1NFRCciLCAiUEFTU0VEIiwgICAgICAgICAgIChWQVIgPSAo aXRlbSA8IC0yMTQ3NDgzNjQ4KSA/ICJGQUlMRUQiIDogIlBBU1NFRCIpICk7CisKICAgICByZXR1 cm4gKCBhcnJheSApOwogfQogZnVuY3Rpb24gdGVzdCgpIHsK