61395 2011-05-24 14:20:26 -0700 Add FIXME comments about removing FrameLoader::isProcessingUserGesture 2011-05-24 20:39:46 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth commit-queue eric jnd jochen oldest_to_newest 409201 0 abarth 2011-05-24 14:20:26 -0700 Add FIXME comments about removing FrameLoader::isProcessingUserGesture 409204 1 94687 abarth 2011-05-24 14:22:28 -0700 Created attachment 94687 Patch 409357 2 94687 eric 2011-05-24 19:11:58 -0700 Comment on attachment 94687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94687&action=review OK. > Source/WebCore/html/HTMLMediaElement.cpp:2410 > + return frame->loader()->isProcessingUserGesture(); A frame always has a frameloader? 409363 3 abarth 2011-05-24 19:20:21 -0700 (In reply to comment #2) > (From update of attachment 94687 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=94687&action=review > > OK. > > > Source/WebCore/html/HTMLMediaElement.cpp:2410 > > + return frame->loader()->isProcessingUserGesture(); > > A frame always has a frameloader? Yes, definitely. 409411 4 94687 commit-queue 2011-05-24 20:39:41 -0700 Comment on attachment 94687 Patch Clearing flags on attachment: 94687 Committed r87260: <http://trac.webkit.org/changeset/87260> 409413 5 commit-queue 2011-05-24 20:39:46 -0700 All reviewed patches have been landed. Closing bug. 94687 2011-05-24 14:22:28 -0700 2011-05-24 20:39:41 -0700 Patch bug-61395-20110524142227.patch text/plain 6977 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3MjAzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDUtMjQgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgRklYTUUgY29tbWVudHMgYWJvdXQgcmVtb3ZpbmcgRnJhbWVM b2FkZXI6OmlzUHJvY2Vzc2luZ1VzZXJHZXN0dXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTM5NQorCisgICAgICAgIEFsbCB0aGUgY2FsbGVycyBv ZiB0aGUgQVBJIGFyZSB3cm9uZy4gIFRoZXkgc2hvdWxkIGNhbGwgdGhlIG1vcmUgbW9kZXJuCisg ICAgICAgIHN0YXRpYyBtZW1iZXIgZnVuY3Rpb24gb2YgU2NyaXB0Q29udHJvbGxlciBpbnN0ZWFk LiAgSSdsbCByZW1vdmUgdGhlCisgICAgICAgIEZyYW1lTG9hZGVyIGZ1bmN0aW9uIGluIGEgZnV0 dXJlIHBhdGNoLgorCisgICAgICAgICogaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnByb2Nlc3NpbmdVc2VyR2VzdHVyZSk6Cisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckZpbGVVcGxvYWRDb250cm9sLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlbmRlckZpbGVVcGxvYWRDb250cm9sOjpjbGljayk6CisKIDIwMTEtMDUtMjQg IERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXZlIEh5YXR0LgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw CShyZXZpc2lvbiA4NjkwOCkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVu dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI0MDIsMTEgKzI0MDIsMTIgQEAgdm9pZCBIVE1MTWVk aWFFbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbAogCiBib29sIEhUTUxNZWRpYUVsZW1lbnQ6OnBy b2Nlc3NpbmdVc2VyR2VzdHVyZSgpIGNvbnN0CiB7CisgICAgLy8gRklYTUU6IFdlIHNob3VsZCBj YWxsIFNjcmlwdENvbnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2VzdHVyZSgpIHNvCisgICAgLy8g d2Uga25vdyB3aGF0IHRvIGRvIHdpdGhvdXQgYSBGcmFtZS4KICAgICBGcmFtZSogZnJhbWUgPSBk b2N1bWVudCgpLT5mcmFtZSgpOwotICAgIEZyYW1lTG9hZGVyKiBsb2FkZXIgPSBmcmFtZSA/IGZy YW1lLT5sb2FkZXIoKSA6IDA7Ci0KLSAgICAvLyByZXR1cm4gJ3RydWUnIGZvciBzYWZldHkgaWYg d2UgZG9uJ3Qga25vdyB0aGUgYW5zd2VyIAotICAgIHJldHVybiBsb2FkZXIgPyBsb2FkZXItPmlz UHJvY2Vzc2luZ1VzZXJHZXN0dXJlKCkgOiB0cnVlOworICAgIGlmICghZnJhbWUpCisgICAgICAg IHJldHVybiB0cnVlOworICAgIHJldHVybiBmcmFtZS0+bG9hZGVyKCktPmlzUHJvY2Vzc2luZ1Vz ZXJHZXN0dXJlKCk7CiB9CiAKICNpZiBFTkFCTEUoUExVR0lOX1BST1hZX0ZPUl9WSURFTykKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGaWxlVXBsb2FkQ29udHJvbC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZpbGVVcGxvYWRD b250cm9sLmNwcAkocmV2aXNpb24gODY5MDgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyRmlsZVVwbG9hZENvbnRyb2wuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMzAsNyArMTMw LDcgQEAgdm9pZCBSZW5kZXJGaWxlVXBsb2FkQ29udHJvbDo6Y2hvb3NlSWNvbgogCiB2b2lkIFJl bmRlckZpbGVVcGxvYWRDb250cm9sOjpjbGljaygpCiB7Ci0gICAgLy8gUmVxdWlyZXMgYSB1c2Vy IGdlc3R1cmUgdG8gb3BlbiB0aGUgZmlsZSBkaWFsb2cuCisgICAgLy8gRklYTUU6IFdlIHNob3Vs ZCBjYWxsIFNjcmlwdENvbnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2VzdHVyZSgpLgogICAgIGlm ICghZnJhbWUoKSB8fCAhZnJhbWUoKS0+bG9hZGVyKCktPmlzUHJvY2Vzc2luZ1VzZXJHZXN0dXJl KCkpCiAgICAgICAgIHJldHVybjsKICAgICBpZiAoQ2hyb21lKiBjaHJvbWVQb2ludGVyID0gY2hy b21lKCkpCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gODcyMDMpCisr KyBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDExLTA1LTI0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIEZJWE1F IGNvbW1lbnRzIGFib3V0IHJlbW92aW5nIEZyYW1lTG9hZGVyOjppc1Byb2Nlc3NpbmdVc2VyR2Vz dHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEz OTUKKworICAgICAgICAqIHNyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwOgorICAgICAgICAo V2ViS2l0OjpGcmFtZUxvYWRlckNsaWVudEltcGw6OmRpc3BhdGNoRGlkTmF2aWdhdGVXaXRoaW5Q YWdlKToKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViRnJhbWVJbXBsOjppc1Byb2Nlc3NpbmdVc2VyR2VzdHVyZSk6CisKIDIwMTEtMDUtMjQgIEph eSBDaXZlbGxpICA8amNpdmVsbGlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFkYW0gQmFydGguCkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRl ckNsaWVudEltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAJKHJldmlzaW9uIDg2OTA4KQorKysgU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2FkZXJDbGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNjM0LDYgKzYzNCw5IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRJbXBsOjpkaXNwYXRj aERpZE4KICAgICAgICAgICAgIC8vIGluc3VmZmljaWVudCB0byBjYXRjaCBhbmQgcHJvcGVybHkg ZmxhZyB0aGVzZSB0cmFuc2l0aW9ucy4gT25jZSBhCiAgICAgICAgICAgICAvLyBwcm9wZXIgZml4 IGZvciB0aGlzIGJ1ZyBpcyBpZGVudGlmaWVkIGFuZCBhcHBsaWVkIHRoZSBmb2xsb3dpbmcKICAg ICAgICAgICAgIC8vIGJsb2NrIG1heSBubyBsb25nZXIgYmUgcmVxdWlyZWQuCisgICAgICAgICAg ICAvLworICAgICAgICAgICAgLy8gRklYTUU6IFdoeSBkbyB3ZSBjYWxsIGlzUHJvY2Vzc2luZ1Vz ZXJHZXN0dXJlIGhlcmUgYnV0IG5vbmUgb2YKKyAgICAgICAgICAgIC8vIHRoZSBvdGhlciBwb3J0 cyBkbz8KICAgICAgICAgICAgIGJvb2wgd2FzQ2xpZW50UmVkaXJlY3QgPQogICAgICAgICAgICAg ICAgICh1cmwgPT0gbV9leHBlY3RlZENsaWVudFJlZGlyZWN0RGVzdCAmJiBjaGFpbkVuZCA9PSBt X2V4cGVjdGVkQ2xpZW50UmVkaXJlY3RTcmMpCiAgICAgICAgICAgICAgICAgfHwgIW1fd2ViRnJh bWUtPmlzUHJvY2Vzc2luZ1VzZXJHZXN0dXJlKCk7CkluZGV4OiBTb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJKHJldmlzaW9uIDg2OTA4KQorKysgU291cmNlL1dl YktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTA5 OSw2ICsxMDk5LDcgQEAgdW5zaWduZWQgV2ViRnJhbWVJbXBsOjp1bmxvYWRMaXN0ZW5lckNvdQog CiBib29sIFdlYkZyYW1lSW1wbDo6aXNQcm9jZXNzaW5nVXNlckdlc3R1cmUoKSBjb25zdAogewor ICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgY2FsbCBTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5n VXNlckdlc3R1cmUoKS4KICAgICByZXR1cm4gZnJhbWUoKS0+bG9hZGVyKCktPmlzUHJvY2Vzc2lu Z1VzZXJHZXN0dXJlKCk7CiB9CiAKSW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3MjAz KQorKysgU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTEtMDUtMjQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgRklYTUUg Y29tbWVudHMgYWJvdXQgcmVtb3ZpbmcgRnJhbWVMb2FkZXI6OmlzUHJvY2Vzc2luZ1VzZXJHZXN0 dXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTM5 NQorCisgICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJWaWV3IF9p c1Byb2Nlc3NpbmdVc2VyR2VzdHVyZV0pOgorCiAyMDExLTA1LTIwICBKZXJlbXkgTm9ibGUgIDxq ZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4K SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L21hYy9XZWJWaWV3L1dlYlZpZXcubW0JKHJldmlzaW9uIDg2OTA4KQor KysgU291cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBA IC0xMjM1LDYgKzEyMzUsNyBAQCAtICh2b2lkKV9jbG9zZQogLSAoQk9PTClfaXNQcm9jZXNzaW5n VXNlckdlc3R1cmUKIHsKICAgICBXZWJGcmFtZSAqZnJhbWUgPSBbc2VsZiBtYWluRnJhbWVdOwor ICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgY2FsbCBTY3JpcHRDb250cm9sbGVyOjpwcm9jZXNzaW5n VXNlckdlc3R1cmUoKS4KICAgICByZXR1cm4gY29yZShmcmFtZSktPmxvYWRlcigpLT5pc1Byb2Nl c3NpbmdVc2VyR2VzdHVyZSgpOwogfQogCkluZGV4OiBTb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwkocmV2aXNpb24gODcy MDMpCisrKyBTb3VyY2UvV2ViS2l0L3F0L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDExLTA1LTI0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIEZJWE1F IGNvbW1lbnRzIGFib3V0IHJlbW92aW5nIEZyYW1lTG9hZGVyOjppc1Byb2Nlc3NpbmdVc2VyR2Vz dHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEz OTUKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwOgor ICAgICAgICAoZHJ0UHJpbnRGcmFtZVVzZXJHZXN0dXJlU3RhdHVzKToKKwogMjAxMS0wNS0yMyAg THVpeiBBZ29zdGluaSAgPGx1aXouYWdvc3RpbmlAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpJbmRleDogU291cmNlL1dlYktpdC9xdC9XZWJDb3Jl U3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQuY3BwCShyZXZpc2lvbiA4 NjkwOCkKKysrIFNvdXJjZS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGll bnRRdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMyw2ICsxMTMsNyBAQCBzdGF0aWMgUVN0cmlu ZyBkcnREZXNjcmlwdGlvblN1aXRhYmxlRm9yCiAKIHN0YXRpYyBRU3RyaW5nIGRydFByaW50RnJh bWVVc2VyR2VzdHVyZVN0YXR1cyhXZWJDb3JlOjpGcmFtZSogZnJhbWUpCiB7CisgICAgLy8gRklY TUU6IFdlIHNob3VsZCBjYWxsIFNjcmlwdENvbnRyb2xsZXI6OnByb2Nlc3NpbmdVc2VyR2VzdHVy ZSgpLgogICAgIGlmIChmcmFtZS0+bG9hZGVyKCktPmlzUHJvY2Vzc2luZ1VzZXJHZXN0dXJlKCkp CiAgICAgICAgIHJldHVybiBRU3RyaW5nOjpmcm9tTGF0aW4xKCJGcmFtZSB3aXRoIHVzZXIgZ2Vz dHVyZSBcIiUxXCIiKS5hcmcoUUxhdGluMVN0cmluZygidHJ1ZSIpKTsKICAgICByZXR1cm4gUVN0 cmluZzo6ZnJvbUxhdGluMSgiRnJhbWUgd2l0aCB1c2VyIGdlc3R1cmUgXCIlMVwiIikuYXJnKFFM YXRpbjFTdHJpbmcoImZhbHNlIikpOwo=