61364 2011-05-24 08:29:12 -0700 Web Inspector: inspected page crashes when call stack is empty after live edit. 2011-05-25 02:03:36 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 podivilov podivilov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 408874 0 podivilov 2011-05-24 08:29:12 -0700 Web Inspector: inspected page crashes when call stack is empty after live edit. 408875 1 94614 podivilov 2011-05-24 08:29:46 -0700 Created attachment 94614 Patch. 408904 2 94614 yurys 2011-05-24 09:08:06 -0700 Comment on attachment 94614 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=94614&action=review > Source/WebCore/bindings/v8/ScriptDebugServer.cpp:252 > + if (currentCallFrameV8->IsObject()) Prefer early return. 408905 3 yurys 2011-05-24 09:08:29 -0700 Can we have a test for this case? 409528 4 podivilov 2011-05-25 02:03:36 -0700 Committed r87280: <http://trac.webkit.org/changeset/87280> 94614 2011-05-24 08:29:46 -0700 2011-05-24 09:08:06 -0700 Patch. patch text/plain 1771 podivilov ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBhOTkwYTEwLi5iZGYyNDMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDUtMjQgIFBhdmVsIFBvZGl2aWxvdiAgPHBvZGl2aWxvdkBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIElu c3BlY3RvcjogaW5zcGVjdGVkIHBhZ2UgY3Jhc2hlcyB3aGVuIGNhbGwgc3RhY2sgaXMgZW1wdHkg YWZ0ZXIgbGl2ZSBlZGl0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjEzNjQKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdERlYnVnU2VydmVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdERlYnVnU2VydmVyOjpjdXJyZW50Q2FsbEZy YW1lKToKKwogMjAxMS0wNS0yMCAgTU9SSVRBIEhhamltZSAgPG1vcnJpdGFAZ29vZ2xlLmNvbT4K IAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5jcHAKaW5kZXggYjkwMDkzMy4uYWRh ZGY3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0RGVidWdT ZXJ2ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdERlYnVnU2Vy dmVyLmNwcApAQCAtMjQ4LDcgKzI0OCw5IEBAIFNjcmlwdFZhbHVlIFNjcmlwdERlYnVnU2VydmVy OjpjdXJyZW50Q2FsbEZyYW1lKCkKICAgICB2ODo6SGFuZGxlPHY4OjpGdW5jdGlvbj4gY3VycmVu dENhbGxGcmFtZUZ1bmN0aW9uID0gdjg6OkxvY2FsPHY4OjpGdW5jdGlvbj46OkNhc3QobV9kZWJ1 Z2dlclNjcmlwdC5nZXQoKS0+R2V0KHY4OjpTdHJpbmc6Ok5ldygiY3VycmVudENhbGxGcmFtZSIp KSk7CiAgICAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGFyZ3ZbXSA9IHsgbV9leGVjdXRpb25TdGF0 ZS5nZXQoKSB9OwogICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjdXJyZW50Q2FsbEZyYW1lVjgg PSBjdXJyZW50Q2FsbEZyYW1lRnVuY3Rpb24tPkNhbGwobV9kZWJ1Z2dlclNjcmlwdC5nZXQoKSwg MSwgYXJndik7Ci0gICAgUmVmUHRyPEphdmFTY3JpcHRDYWxsRnJhbWU+IGN1cnJlbnRDYWxsRnJh bWUgPSBKYXZhU2NyaXB0Q2FsbEZyYW1lOjpjcmVhdGUodjg6OkRlYnVnOjpHZXREZWJ1Z0NvbnRl eHQoKSwgdjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdChjdXJyZW50Q2FsbEZyYW1lVjgpKTsK KyAgICBSZWZQdHI8SmF2YVNjcmlwdENhbGxGcmFtZT4gY3VycmVudENhbGxGcmFtZTsKKyAgICBp ZiAoY3VycmVudENhbGxGcmFtZVY4LT5Jc09iamVjdCgpKQorICAgICAgICBjdXJyZW50Q2FsbEZy YW1lID0gSmF2YVNjcmlwdENhbGxGcmFtZTo6Y3JlYXRlKHY4OjpEZWJ1Zzo6R2V0RGVidWdDb250 ZXh0KCksIHY4OjpIYW5kbGU8djg6Ok9iamVjdD46OkNhc3QoY3VycmVudENhbGxGcmFtZVY4KSk7 CiAgICAgdjg6OkNvbnRleHQ6OlNjb3BlIGNvbnRleHRTY29wZShtX3BhdXNlZENvbnRleHQpOwog ICAgIHJldHVybiBTY3JpcHRWYWx1ZSh0b1Y4KGN1cnJlbnRDYWxsRnJhbWUucmVsZWFzZSgpKSk7 CiB9Cg==