61357 2011-05-24 04:16:40 -0700 JSAudioContextCustom doesn't encode errors 2011-05-24 10:12:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61355 1 pnormand webkit-unassigned kling oldest_to_newest 408770 0 pnormand 2011-05-24 04:16:40 -0700 patch incoming about this 408771 1 94593 pnormand 2011-05-24 04:17:59 -0700 Created attachment 94593 Fix AudioContext return values 408801 2 94593 kling 2011-05-24 06:12:30 -0700 Comment on attachment 94593 Fix AudioContext return values Nice catch, but you should change the throwError() calls to throwVMError() instead. 408948 3 94632 pnormand 2011-05-24 10:05:06 -0700 Created attachment 94632 Fix AudioContext return values 408954 4 94632 kling 2011-05-24 10:09:11 -0700 Comment on attachment 94632 Fix AudioContext return values r=me 408957 5 pnormand 2011-05-24 10:12:54 -0700 Committed r87163: <http://trac.webkit.org/changeset/87163> 94593 2011-05-24 04:17:59 -0700 2011-05-24 10:05:06 -0700 Fix AudioContext return values Fix-AudioContext-return-values.patch text/plain 3774 pnormand RnJvbSA5ZGNhN2EyYzkyMjEzMjk0YmVmYTcwNmMyODczNjQ1NWY2ZDVhM2E0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDI1IEFwciAyMDExIDE0OjExOjI0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0g Rml4IEF1ZGlvQ29udGV4dCByZXR1cm4gdmFsdWVzCgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIC4uLi9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTQXVkaW9Db250ZXh0Q3VzdG9tLmNwcCAgIHwgICAxMCArKysr Ky0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDY4NTI3MzAuLjk0ZTM1OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAxMS0wNS0yNCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSlNBdWRp b0NvbnRleHRDdXN0b20gZG9lc24ndCBlbmNvZGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTM1NworCisgICAgICAgIEZpeCBBdWRpb0Nv bnRleHQgcmV0dXJuIHZhbHVlcworCisgICAgICAgICogYmluZGluZ3MvanMvSlNBdWRpb0NvbnRl eHRDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNBdWRpb0NvbnRleHRDb25zdHJ1Y3Rv cjo6Y29uc3RydWN0SlNBdWRpb0NvbnRleHQpOgorCiAyMDExLTA0LTEzICBTdGV2ZSBCbG9jayAg PHN0ZXZlYmxvY2tAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRl bC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQXVkaW9Db250ZXh0 Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQXVkaW9Db250ZXh0Q3Vz dG9tLmNwcAppbmRleCAyYmMyMDBmLi5mM2Y4YjliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU0F1ZGlvQ29udGV4dEN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNBdWRpb0NvbnRleHRDdXN0b20uY3BwCkBAIC01MiwxNCArNTIsMTQg QEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBKU0F1ZGlvQ29udGV4dENvbnN0cnVjdG9y Ojpjb25zdHJ1Y3RKU0F1ZGlvQ29udGV4dCgKIHsKICAgICBKU0F1ZGlvQ29udGV4dENvbnN0cnVj dG9yKiBqc0NvbnN0cnVjdG9yID0gc3RhdGljX2Nhc3Q8SlNBdWRpb0NvbnRleHRDb25zdHJ1Y3Rv cio+KGV4ZWMtPmNhbGxlZSgpKTsKICAgICBpZiAoIWpzQ29uc3RydWN0b3IpCi0gICAgICByZXR1 cm4gdGhyb3dFcnJvcihleGVjLCBjcmVhdGVSZWZlcmVuY2VFcnJvcihleGVjLCAiQXVkaW9Db250 ZXh0IGNvbnN0cnVjdG9yIGNhbGxlZSBpcyB1bmF2YWlsYWJsZSIpKTsKKyAgICAgICAgcmV0dXJu IEpTVmFsdWU6OmVuY29kZSh0aHJvd0Vycm9yKGV4ZWMsIGNyZWF0ZVJlZmVyZW5jZUVycm9yKGV4 ZWMsICJBdWRpb0NvbnRleHQgY29uc3RydWN0b3IgY2FsbGVlIGlzIHVuYXZhaWxhYmxlIikpKTsK IAogICAgIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQgPSBq c0NvbnN0cnVjdG9yLT5zY3JpcHRFeGVjdXRpb25Db250ZXh0KCk7CiAgICAgaWYgKCFzY3JpcHRF eGVjdXRpb25Db250ZXh0KQotICAgICAgcmV0dXJuIHRocm93RXJyb3IoZXhlYywgY3JlYXRlUmVm ZXJlbmNlRXJyb3IoZXhlYywgIkF1ZGlvQ29udGV4dCBjb25zdHJ1Y3RvciBzY3JpcHQgZXhlY3V0 aW9uIGNvbnRleHQgaXMgdW5hdmFpbGFibGUiKSk7CisgICAgICAgIHJldHVybiBKU1ZhbHVlOjpl bmNvZGUodGhyb3dFcnJvcihleGVjLCBjcmVhdGVSZWZlcmVuY2VFcnJvcihleGVjLCAiQXVkaW9D b250ZXh0IGNvbnN0cnVjdG9yIHNjcmlwdCBleGVjdXRpb24gY29udGV4dCBpcyB1bmF2YWlsYWJs ZSIpKSk7CiAgICAgICAgIAogICAgIGlmICghc2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+aXNEb2N1 bWVudCgpKQotICAgICAgcmV0dXJuIHRocm93RXJyb3IoZXhlYywgY3JlYXRlUmVmZXJlbmNlRXJy b3IoZXhlYywgIkF1ZGlvQ29udGV4dCBjb25zdHJ1Y3RvciBjYWxsZWQgaW4gYSBzY3JpcHQgZXhl Y3V0aW9uIGNvbnRleHQgd2hpY2ggaXMgbm90IGEgZG9jdW1lbnQiKSk7CisgICAgICAgIHJldHVy biBKU1ZhbHVlOjplbmNvZGUodGhyb3dFcnJvcihleGVjLCBjcmVhdGVSZWZlcmVuY2VFcnJvcihl eGVjLCAiQXVkaW9Db250ZXh0IGNvbnN0cnVjdG9yIGNhbGxlZCBpbiBhIHNjcmlwdCBleGVjdXRp b24gY29udGV4dCB3aGljaCBpcyBub3QgYSBkb2N1bWVudCIpKSk7CiAKICAgICBEb2N1bWVudCog ZG9jdW1lbnQgPSBzdGF0aWNfY2FzdDxEb2N1bWVudCo+KHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQp OwogCkBAIC03Miw3ICs3Miw3IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgSlNBdWRp b0NvbnRleHRDb25zdHJ1Y3Rvcjo6Y29uc3RydWN0SlNBdWRpb0NvbnRleHQoCiAgICAgICAgIC8v IENvbnN0cnVjdG9yIGZvciBvZmZsaW5lIChyZW5kZXItdGFyZ2V0KSBBdWRpb0NvbnRleHQgd2hp Y2ggcmVuZGVycyBpbnRvIGFuIEF1ZGlvQnVmZmVyLgogICAgICAgICAvLyBuZXcgQXVkaW9Db250 ZXh0KGluIHVuc2lnbmVkIGxvbmcgbnVtYmVyT2ZDaGFubmVscywgaW4gdW5zaWduZWQgbG9uZyBu dW1iZXJPZkZyYW1lcywgaW4gZmxvYXQgc2FtcGxlUmF0ZSk7CiAgICAgICAgIGlmIChleGVjLT5h cmd1bWVudENvdW50KCkgPCAzKQotICAgICAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoZXhlYywg Y3JlYXRlU3ludGF4RXJyb3IoZXhlYywgIk5vdCBlbm91Z2ggYXJndW1lbnRzIikpOworICAgICAg ICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZSh0aHJvd0Vycm9yKGV4ZWMsIGNyZWF0ZVN5bnRh eEVycm9yKGV4ZWMsICJOb3QgZW5vdWdoIGFyZ3VtZW50cyIpKSk7CiAKICAgICAgICAgdW5zaWdu ZWQgbnVtYmVyT2ZDaGFubmVscyA9IGV4ZWMtPmFyZ3VtZW50KDApLnRvSW50MzIoZXhlYyk7CiAg ICAgICAgIHVuc2lnbmVkIG51bWJlck9mRnJhbWVzID0gZXhlYy0+YXJndW1lbnQoMSkudG9JbnQz MihleGVjKTsKQEAgLTgyLDcgKzgyLDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FMTCBK U0F1ZGlvQ29udGV4dENvbnN0cnVjdG9yOjpjb25zdHJ1Y3RKU0F1ZGlvQ29udGV4dCgKICAgICB9 CiAKICAgICBpZiAoIWF1ZGlvQ29udGV4dC5nZXQoKSkKLSAgICAgICAgcmV0dXJuIHRocm93RXJy b3IoZXhlYywgY3JlYXRlUmVmZXJlbmNlRXJyb3IoZXhlYywgIkVycm9yIGNyZWF0aW5nIEF1ZGlv Q29udGV4dCIpKTsKKyAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZSh0aHJvd0Vycm9yKGV4 ZWMsIGNyZWF0ZVJlZmVyZW5jZUVycm9yKGV4ZWMsICJFcnJvciBjcmVhdGluZyBBdWRpb0NvbnRl eHQiKSkpOwogCiAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShhc09iamVjdCh0b0pTKGV4ZWMs IGpzQ29uc3RydWN0b3ItPmdsb2JhbE9iamVjdCgpLCBhdWRpb0NvbnRleHQuZ2V0KCkpKSk7CiB9 Ci0tIAoxLjcuNS4x 94632 2011-05-24 10:05:06 -0700 2011-05-24 10:09:11 -0700 Fix AudioContext return values Fix-AudioContext-return-values.patch text/plain 3695 pnormand RnJvbSBhYjdiNDUzN2IyYTgwOGI2ZDgzYzJjMThlZjQ5NGQ4Y2U1MmIzN2MzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDI1IEFwciAyMDExIDE0OjExOjI0IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0g Rml4IEF1ZGlvQ29udGV4dCByZXR1cm4gdmFsdWVzCgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysrKysrKysKIC4uLi9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTQXVkaW9Db250ZXh0Q3VzdG9tLmNwcCAgIHwgICAxMCArKysr Ky0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0p CgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDc1ZTFlZjYuLjVjYmNlNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NSBAQAorMjAxMS0wNS0yNCAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSlNBdWRp b0NvbnRleHRDdXN0b20gZG9lc24ndCBlbmNvZGUgZXJyb3JzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTM1NworCisgICAgICAgIEZpeCBBdWRpb0Nv bnRleHQgcmV0dXJuIHZhbHVlcworCisgICAgICAgICogYmluZGluZ3MvanMvSlNBdWRpb0NvbnRl eHRDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNBdWRpb0NvbnRleHRDb25zdHJ1Y3Rv cjo6Y29uc3RydWN0SlNBdWRpb0NvbnRleHQpOgorCiAyMDExLTA1LTI0ICBSb2IgQnVpcyAgPHJi dWlzQHJpbS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgRGlyayBTY2h1bHplLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNBdWRpb0NvbnRleHRDdXN0 b20uY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNBdWRpb0NvbnRleHRDdXN0b20u Y3BwCmluZGV4IDJiYzIwMGYuLjRiZGM5ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL0pTQXVkaW9Db250ZXh0Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9qcy9KU0F1ZGlvQ29udGV4dEN1c3RvbS5jcHAKQEAgLTUyLDE0ICs1MiwxNCBAQCBF bmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIEpTQXVkaW9Db250ZXh0Q29uc3RydWN0b3I6OmNv bnN0cnVjdEpTQXVkaW9Db250ZXh0KAogewogICAgIEpTQXVkaW9Db250ZXh0Q29uc3RydWN0b3Iq IGpzQ29uc3RydWN0b3IgPSBzdGF0aWNfY2FzdDxKU0F1ZGlvQ29udGV4dENvbnN0cnVjdG9yKj4o ZXhlYy0+Y2FsbGVlKCkpOwogICAgIGlmICghanNDb25zdHJ1Y3RvcikKLSAgICAgIHJldHVybiB0 aHJvd0Vycm9yKGV4ZWMsIGNyZWF0ZVJlZmVyZW5jZUVycm9yKGV4ZWMsICJBdWRpb0NvbnRleHQg Y29uc3RydWN0b3IgY2FsbGVlIGlzIHVuYXZhaWxhYmxlIikpOworICAgICAgICByZXR1cm4gdGhy b3dWTUVycm9yKGV4ZWMsIGNyZWF0ZVJlZmVyZW5jZUVycm9yKGV4ZWMsICJBdWRpb0NvbnRleHQg Y29uc3RydWN0b3IgY2FsbGVlIGlzIHVuYXZhaWxhYmxlIikpOwogCiAgICAgU2NyaXB0RXhlY3V0 aW9uQ29udGV4dCogc2NyaXB0RXhlY3V0aW9uQ29udGV4dCA9IGpzQ29uc3RydWN0b3ItPnNjcmlw dEV4ZWN1dGlvbkNvbnRleHQoKTsKICAgICBpZiAoIXNjcmlwdEV4ZWN1dGlvbkNvbnRleHQpCi0g ICAgICByZXR1cm4gdGhyb3dFcnJvcihleGVjLCBjcmVhdGVSZWZlcmVuY2VFcnJvcihleGVjLCAi QXVkaW9Db250ZXh0IGNvbnN0cnVjdG9yIHNjcmlwdCBleGVjdXRpb24gY29udGV4dCBpcyB1bmF2 YWlsYWJsZSIpKTsKKyAgICAgICAgcmV0dXJuIHRocm93Vk1FcnJvcihleGVjLCBjcmVhdGVSZWZl cmVuY2VFcnJvcihleGVjLCAiQXVkaW9Db250ZXh0IGNvbnN0cnVjdG9yIHNjcmlwdCBleGVjdXRp b24gY29udGV4dCBpcyB1bmF2YWlsYWJsZSIpKTsKICAgICAgICAgCiAgICAgaWYgKCFzY3JpcHRF eGVjdXRpb25Db250ZXh0LT5pc0RvY3VtZW50KCkpCi0gICAgICByZXR1cm4gdGhyb3dFcnJvcihl eGVjLCBjcmVhdGVSZWZlcmVuY2VFcnJvcihleGVjLCAiQXVkaW9Db250ZXh0IGNvbnN0cnVjdG9y IGNhbGxlZCBpbiBhIHNjcmlwdCBleGVjdXRpb24gY29udGV4dCB3aGljaCBpcyBub3QgYSBkb2N1 bWVudCIpKTsKKyAgICAgICAgcmV0dXJuIHRocm93Vk1FcnJvcihleGVjLCBjcmVhdGVSZWZlcmVu Y2VFcnJvcihleGVjLCAiQXVkaW9Db250ZXh0IGNvbnN0cnVjdG9yIGNhbGxlZCBpbiBhIHNjcmlw dCBleGVjdXRpb24gY29udGV4dCB3aGljaCBpcyBub3QgYSBkb2N1bWVudCIpKTsKIAogICAgIERv Y3VtZW50KiBkb2N1bWVudCA9IHN0YXRpY19jYXN0PERvY3VtZW50Kj4oc2NyaXB0RXhlY3V0aW9u Q29udGV4dCk7CiAKQEAgLTcyLDcgKzcyLDcgQEAgRW5jb2RlZEpTVmFsdWUgSlNDX0hPU1RfQ0FM TCBKU0F1ZGlvQ29udGV4dENvbnN0cnVjdG9yOjpjb25zdHJ1Y3RKU0F1ZGlvQ29udGV4dCgKICAg ICAgICAgLy8gQ29uc3RydWN0b3IgZm9yIG9mZmxpbmUgKHJlbmRlci10YXJnZXQpIEF1ZGlvQ29u dGV4dCB3aGljaCByZW5kZXJzIGludG8gYW4gQXVkaW9CdWZmZXIuCiAgICAgICAgIC8vIG5ldyBB dWRpb0NvbnRleHQoaW4gdW5zaWduZWQgbG9uZyBudW1iZXJPZkNoYW5uZWxzLCBpbiB1bnNpZ25l ZCBsb25nIG51bWJlck9mRnJhbWVzLCBpbiBmbG9hdCBzYW1wbGVSYXRlKTsKICAgICAgICAgaWYg KGV4ZWMtPmFyZ3VtZW50Q291bnQoKSA8IDMpCi0gICAgICAgICAgICByZXR1cm4gdGhyb3dFcnJv cihleGVjLCBjcmVhdGVTeW50YXhFcnJvcihleGVjLCAiTm90IGVub3VnaCBhcmd1bWVudHMiKSk7 CisgICAgICAgICAgICByZXR1cm4gdGhyb3dWTUVycm9yKGV4ZWMsIGNyZWF0ZVN5bnRheEVycm9y KGV4ZWMsICJOb3QgZW5vdWdoIGFyZ3VtZW50cyIpKTsKIAogICAgICAgICB1bnNpZ25lZCBudW1i ZXJPZkNoYW5uZWxzID0gZXhlYy0+YXJndW1lbnQoMCkudG9JbnQzMihleGVjKTsKICAgICAgICAg dW5zaWduZWQgbnVtYmVyT2ZGcmFtZXMgPSBleGVjLT5hcmd1bWVudCgxKS50b0ludDMyKGV4ZWMp OwpAQCAtODIsNyArODIsNyBAQCBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxMIEpTQXVkaW9D b250ZXh0Q29uc3RydWN0b3I6OmNvbnN0cnVjdEpTQXVkaW9Db250ZXh0KAogICAgIH0KIAogICAg IGlmICghYXVkaW9Db250ZXh0LmdldCgpKQotICAgICAgICByZXR1cm4gdGhyb3dFcnJvcihleGVj LCBjcmVhdGVSZWZlcmVuY2VFcnJvcihleGVjLCAiRXJyb3IgY3JlYXRpbmcgQXVkaW9Db250ZXh0 IikpOworICAgICAgICByZXR1cm4gdGhyb3dWTUVycm9yKGV4ZWMsIGNyZWF0ZVJlZmVyZW5jZUVy cm9yKGV4ZWMsICJFcnJvciBjcmVhdGluZyBBdWRpb0NvbnRleHQiKSk7CiAKICAgICByZXR1cm4g SlNWYWx1ZTo6ZW5jb2RlKGFzT2JqZWN0KHRvSlMoZXhlYywganNDb25zdHJ1Y3Rvci0+Z2xvYmFs T2JqZWN0KCksIGF1ZGlvQ29udGV4dC5nZXQoKSkpKTsKIH0KLS0gCjEuNy41LjE=