61356 2011-05-24 04:06:45 -0700 Enable FloatArray usage outside WebGL guards 2011-05-24 11:17:26 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61355 1 pnormand webkit-unassigned cmarrin crogers kbr mrobinson zan oldest_to_newest 408766 0 pnormand 2011-05-24 04:06:45 -0700 FloatArray has no strong dependency on WebGL AFAIK. It is used in WebAudio too. 408768 1 94592 pnormand 2011-05-24 04:11:20 -0700 Created attachment 94592 proposed patch 408984 2 pnormand 2011-05-24 10:44:22 -0700 Hi Chris, can you please look at this patch? Thanks! 409016 3 94592 kbr 2011-05-24 11:12:51 -0700 Comment on attachment 94592 proposed patch Agreed, now that the Typed Arrays are being unconditionally compiled in, these conditionals should be removed. r=me 409024 4 pnormand 2011-05-24 11:17:26 -0700 Committed r87173: <http://trac.webkit.org/changeset/87173> 94592 2011-05-24 04:11:20 -0700 2011-05-24 11:12:50 -0700 proposed patch proposed-patch.patch text/plain 5971 pnormand RnJvbSBkZmQ5YmFjNjRlZDUzZWE3MTBmZjFmZTMwNWRkNzkwOTdjM2I3OGM4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDE5IEFwciAyMDExIDE5OjEyOjI4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvd2ViYXVk aW8vQXVkaW9CdWZmZXIuY3BwICAgICAgICAgIHwgICAgNCArKy0tCiBTb3VyY2UvV2ViQ29yZS93 ZWJhdWRpby9BdWRpb0J1ZmZlci5pZGwgICAgICAgICAgfCAgICAyICstCiBTb3VyY2UvV2ViQ29y ZS93ZWJhdWRpby9SZWFsdGltZUFuYWx5c2VyLmNwcCAgICAgfCAgICA3IC0tLS0tLS0KIFNvdXJj ZS9XZWJDb3JlL3dlYmF1ZGlvL1JlYWx0aW1lQW5hbHlzZXIuaCAgICAgICB8ICAgIDUgLS0tLS0K IFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL1JlYWx0aW1lQW5hbHlzZXJOb2RlLmggICB8ICAgIDIg LS0KIFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL1JlYWx0aW1lQW5hbHlzZXJOb2RlLmlkbCB8ICAg IDYgKysrLS0tCiA3IGZpbGVzIGNoYW5nZWQsIDIwIGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9u cygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCA2ODUyNzMwLi5lNzRhYjUyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTcgQEAKKzIwMTEtMDUtMjQgIFphbiBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNv bT4gYW5kIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBGbG9hdEFycmF5 IHVzYWdlIG91dHNpZGUgV2ViR0wgZ3VhcmRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD02MTM1NgorCisgICAgICAgICogd2ViYXVkaW8vQXVkaW9CdWZm ZXIuY3BwOgorICAgICAgICAqIHdlYmF1ZGlvL0F1ZGlvQnVmZmVyLmlkbDoKKyAgICAgICAgKiB3 ZWJhdWRpby9SZWFsdGltZUFuYWx5c2VyLmNwcDoKKyAgICAgICAgKiB3ZWJhdWRpby9SZWFsdGlt ZUFuYWx5c2VyLmg6CisgICAgICAgICogd2ViYXVkaW8vUmVhbHRpbWVBbmFseXNlck5vZGUuaDoK KyAgICAgICAgKiB3ZWJhdWRpby9SZWFsdGltZUFuYWx5c2VyTm9kZS5pZGw6CisKIDIwMTEtMDQt MTMgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8v QXVkaW9CdWZmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9CdWZmZXIuY3Bw CmluZGV4IDcwNzU3NTIuLmZmNGYwNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1 ZGlvL0F1ZGlvQnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb0J1 ZmZlci5jcHAKQEAgLTI4LDcgKzI4LDcgQEAKIAogI2luY2x1ZGUgImNvbmZpZy5oIgogCi0jaWYg RU5BQkxFKFdFQl9BVURJTykgJiBFTkFCTEUoV0VCR0wpCisjaWYgRU5BQkxFKFdFQl9BVURJTykK IAogI2luY2x1ZGUgIkF1ZGlvQnVmZmVyLmgiCiAKQEAgLTEwNyw0ICsxMDcsNCBAQCB2b2lkIEF1 ZGlvQnVmZmVyOjp6ZXJvKCkKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCi0jZW5kaWYgLy8g RU5BQkxFKFdFQl9BVURJTykgJiBFTkFCTEUoV0VCR0wpCisjZW5kaWYgLy8gRU5BQkxFKFdFQl9B VURJTykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvQnVmZmVyLmlk bCBiL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvQnVmZmVyLmlkbAppbmRleCA1OTRlZTY5 Li44YTczNGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb0J1ZmZl ci5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9CdWZmZXIuaWRsCkBAIC0y OCw3ICsyOCw3IEBACiAKIG1vZHVsZSBhdWRpbyB7CiAgICAgaW50ZXJmYWNlIFsKLSAgICAgICAg Q29uZGl0aW9uYWw9V0VCX0FVRElPICYgV0VCR0wKKyAgICAgICAgQ29uZGl0aW9uYWw9V0VCX0FV RElPCiAgICAgXSBBdWRpb0J1ZmZlciB7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBsb25n IGxlbmd0aDsgLy8gaW4gc2FtcGxlLWZyYW1lcwogICAgICAgICByZWFkb25seSBhdHRyaWJ1dGUg ZmxvYXQgZHVyYXRpb247IC8vIGluIHNlY29uZHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3dlYmF1ZGlvL1JlYWx0aW1lQW5hbHlzZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8v UmVhbHRpbWVBbmFseXNlci5jcHAKaW5kZXggMWExZTkyMC4uNzI2NTc4NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvd2ViYXVkaW8vUmVhbHRpbWVBbmFseXNlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvd2ViYXVkaW8vUmVhbHRpbWVBbmFseXNlci5jcHAKQEAgLTMxLDExICszMSw4IEBA CiAjaW5jbHVkZSAiQXVkaW9CdXMuaCIKICNpbmNsdWRlICJBdWRpb1V0aWxpdGllcy5oIgogI2lu Y2x1ZGUgIkZGVEZyYW1lLmgiCi0KLSNpZiBFTkFCTEUoV0VCR0wpCiAjaW5jbHVkZSAiRmxvYXQz MkFycmF5LmgiCiAjaW5jbHVkZSAiVWludDhBcnJheS5oIgotI2VuZGlmCiAKICNpbmNsdWRlIDxh bGdvcml0aG0+CiAjaW5jbHVkZSA8bGltaXRzLmg+CkBAIC0xOTMsOCArMTkwLDYgQEAgdm9pZCBS ZWFsdGltZUFuYWx5c2VyOjpkb0ZGVEFuYWx5c2lzKCkKICAgICB9CiB9CiAKLSNpZiBFTkFCTEUo V0VCR0wpCi0KIHZvaWQgUmVhbHRpbWVBbmFseXNlcjo6Z2V0RmxvYXRGcmVxdWVuY3lEYXRhKEZs b2F0MzJBcnJheSogZGVzdGluYXRpb25BcnJheSkKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFk KCkpOwpAQCAtMjk0LDggKzI4OSw2IEBAIHZvaWQgUmVhbHRpbWVBbmFseXNlcjo6Z2V0Qnl0ZVRp bWVEb21haW5EYXRhKFVpbnQ4QXJyYXkqIGRlc3RpbmF0aW9uQXJyYXkpCiAgICAgfQogfQogCi0j ZW5kaWYgLy8gV0VCR0wKLQogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gRU5B QkxFKFdFQl9BVURJTykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL1JlYWx0 aW1lQW5hbHlzZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL1JlYWx0aW1lQW5hbHlzZXIu aAppbmRleCA4NGQyOTkyLi5hMDlmZjZmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJh dWRpby9SZWFsdGltZUFuYWx5c2VyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vUmVh bHRpbWVBbmFseXNlci5oCkBAIC0zMywxMSArMzMsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK IGNsYXNzIEF1ZGlvQnVzOwogY2xhc3MgRkZURnJhbWU7Ci0KLSNpZiBFTkFCTEUoV0VCR0wpCiBj bGFzcyBGbG9hdDMyQXJyYXk7CiBjbGFzcyBVaW50OEFycmF5OwotI2VuZGlmCiAKIGNsYXNzIFJl YWx0aW1lQW5hbHlzZXIgewogICAgIFdURl9NQUtFX05PTkNPUFlBQkxFKFJlYWx0aW1lQW5hbHlz ZXIpOwpAQCAtNjEsMTEgKzU4LDkgQEAgcHVibGljOgogICAgIHZvaWQgc2V0U21vb3RoaW5nVGlt ZUNvbnN0YW50KGZsb2F0IGspIHsgbV9zbW9vdGhpbmdUaW1lQ29uc3RhbnQgPSBrOyB9CiAgICAg ZmxvYXQgc21vb3RoaW5nVGltZUNvbnN0YW50KCkgY29uc3QgeyByZXR1cm4gc3RhdGljX2Nhc3Q8 ZmxvYXQ+KG1fc21vb3RoaW5nVGltZUNvbnN0YW50KTsgfQogCi0jaWYgRU5BQkxFKFdFQkdMKQog ICAgIHZvaWQgZ2V0RmxvYXRGcmVxdWVuY3lEYXRhKEZsb2F0MzJBcnJheSopOwogICAgIHZvaWQg Z2V0Qnl0ZUZyZXF1ZW5jeURhdGEoVWludDhBcnJheSopOwogICAgIHZvaWQgZ2V0Qnl0ZVRpbWVE b21haW5EYXRhKFVpbnQ4QXJyYXkqKTsKLSNlbmRpZgogCiAgICAgLy8gVGhlIGF1ZGlvIHRocmVh ZCB3cml0ZXMgaW5wdXQgZGF0YSBoZXJlLgogICAgIHZvaWQgd3JpdGVJbnB1dChBdWRpb0J1cyos IHNpemVfdCBmcmFtZXNUb1Byb2Nlc3MpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvd2Vi YXVkaW8vUmVhbHRpbWVBbmFseXNlck5vZGUuaCBiL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL1Jl YWx0aW1lQW5hbHlzZXJOb2RlLmgKaW5kZXggMDc0ODhlZS4uZDAwYTViNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvd2ViYXVkaW8vUmVhbHRpbWVBbmFseXNlck5vZGUuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS93ZWJhdWRpby9SZWFsdGltZUFuYWx5c2VyTm9kZS5oCkBAIC01OSwxMSArNTks OSBAQCBwdWJsaWM6CiAgICAgdm9pZCBzZXRTbW9vdGhpbmdUaW1lQ29uc3RhbnQoZmxvYXQgaykg eyBtX2FuYWx5c2VyLnNldFNtb290aGluZ1RpbWVDb25zdGFudChrKTsgfQogICAgIGZsb2F0IHNt b290aGluZ1RpbWVDb25zdGFudCgpIGNvbnN0IHsgcmV0dXJuIG1fYW5hbHlzZXIuc21vb3RoaW5n VGltZUNvbnN0YW50KCk7IH0KIAotI2lmIEVOQUJMRShXRUJHTCkKICAgICB2b2lkIGdldEZsb2F0 RnJlcXVlbmN5RGF0YShGbG9hdDMyQXJyYXkqIGFycmF5KSB7IG1fYW5hbHlzZXIuZ2V0RmxvYXRG cmVxdWVuY3lEYXRhKGFycmF5KTsgfQogICAgIHZvaWQgZ2V0Qnl0ZUZyZXF1ZW5jeURhdGEoVWlu dDhBcnJheSogYXJyYXkpIHsgbV9hbmFseXNlci5nZXRCeXRlRnJlcXVlbmN5RGF0YShhcnJheSk7 IH0KICAgICB2b2lkIGdldEJ5dGVUaW1lRG9tYWluRGF0YShVaW50OEFycmF5KiBhcnJheSkgeyBt X2FuYWx5c2VyLmdldEJ5dGVUaW1lRG9tYWluRGF0YShhcnJheSk7IH0KLSNlbmRpZgogCiBwcml2 YXRlOgogICAgIFJlYWx0aW1lQW5hbHlzZXJOb2RlKEF1ZGlvQ29udGV4dCosIGRvdWJsZSBzYW1w bGVSYXRlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL1JlYWx0aW1lQW5h bHlzZXJOb2RlLmlkbCBiL1NvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL1JlYWx0aW1lQW5hbHlzZXJO b2RlLmlkbAppbmRleCBmZGQ4ODE5Li5iODZiMmIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS93ZWJhdWRpby9SZWFsdGltZUFuYWx5c2VyTm9kZS5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUv d2ViYXVkaW8vUmVhbHRpbWVBbmFseXNlck5vZGUuaWRsCkBAIC0zOSwxMCArMzksMTAgQEAgbW9k dWxlIGF1ZGlvIHsKICAgICAgICAgCiAgICAgICAgIC8vIENvcGllcyB0aGUgY3VycmVudCBmcmVx dWVuY3kgZGF0YSBpbnRvIHRoZSBwYXNzZWQgYXJyYXkuCiAgICAgICAgIC8vIElmIHRoZSBhcnJh eSBoYXMgZmV3ZXIgZWxlbWVudHMgdGhhbiB0aGUgZnJlcXVlbmN5QmluQ291bnQsIHRoZSBleGNl c3MgZWxlbWVudHMgd2lsbCBiZSBkcm9wcGVkLgotICAgICAgICBbQ29uZGl0aW9uYWw9V0VCR0xd IHZvaWQgZ2V0RmxvYXRGcmVxdWVuY3lEYXRhKGluIEZsb2F0MzJBcnJheSBhcnJheSk7Ci0gICAg ICAgIFtDb25kaXRpb25hbD1XRUJHTF0gdm9pZCBnZXRCeXRlRnJlcXVlbmN5RGF0YShpbiBVaW50 OEFycmF5IGFycmF5KTsKKyAgICAgICAgdm9pZCBnZXRGbG9hdEZyZXF1ZW5jeURhdGEoaW4gRmxv YXQzMkFycmF5IGFycmF5KTsKKyAgICAgICAgdm9pZCBnZXRCeXRlRnJlcXVlbmN5RGF0YShpbiBV aW50OEFycmF5IGFycmF5KTsKIAogICAgICAgICAvLyBSZWFsLXRpbWUgd2F2ZWZvcm0gZGF0YQot ICAgICAgICBbQ29uZGl0aW9uYWw9V0VCR0xdIHZvaWQgZ2V0Qnl0ZVRpbWVEb21haW5EYXRhKGlu IFVpbnQ4QXJyYXkgYXJyYXkpOworICAgICAgICB2b2lkIGdldEJ5dGVUaW1lRG9tYWluRGF0YShp biBVaW50OEFycmF5IGFycmF5KTsKICAgICB9OwogfQotLSAKMS43LjUuMQ==