61350 2011-05-24 01:09:55 -0700 [CMAKE] Split JSC related files from WebCore/CMakeLists.txt 2011-07-25 22:21:26 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60244 1 ryuan.choi ryuan.choi dbates gyuyoung.kim kenneth leandro lucas.de.marchi paroga rakuco tonikitoo webkit.review.bot oldest_to_newest 408711 0 ryuan.choi 2011-05-24 01:09:55 -0700 I already moved JSC related files to UseJSC.cmake at bug 56624, but some files were missing. 408716 1 94582 ryuan.choi 2011-05-24 01:15:46 -0700 Created attachment 94582 Patch 408719 2 paroga 2011-05-24 01:26:04 -0700 LGTM 408795 3 rakuco 2011-05-24 06:03:46 -0700 It looks mostly OK to me too. Should the platform-specific ScriptController${PLATFORM}.cpp files still be included in WebCore/CMakeLists{Efl,WinCE}.cmake? 409343 4 ryuan.choi 2011-05-24 17:55:03 -0700 (In reply to comment #3) > It looks mostly OK to me too. Should the platform-specific ScriptController${PLATFORM}.cpp files still be included in WebCore/CMakeLists{Efl,WinCE}.cmake? It looks reasonable to me, but WinCE use ScriptControllerWin.cpp. Patrick, can we clone or rename ScriptControllerWin.cpp to ScriptControllerWinCE.cpp? 409493 5 paroga 2011-05-24 23:50:56 -0700 (In reply to comment #4) > (In reply to comment #3) > > It looks mostly OK to me too. Should the platform-specific ScriptController${PLATFORM}.cpp files still be included in WebCore/CMakeLists{Efl,WinCE}.cmake? > > It looks reasonable to me, > but WinCE use ScriptControllerWin.cpp. > > Patrick, can we clone or rename ScriptControllerWin.cpp to ScriptControllerWinCE.cpp? Don't WinApple and WinCairo use this file too? I don't think this is a good idea. IMHO using ${PLATFORM} for filenames and directories is a very bad idea, because different platforms share different code. An example where we have this problem already is http://trac.webkit.org/browser/trunk/Source/WebKit/CMakeLists.txt?rev=83792#L65. When I Create a WinApple, WinCairo and WinGDI port, all of them use the win-directory, but have different implementations of GraphicsCntext, NetworkInterface and so on. I'd like to keep adding of _all_ the platform specific files in different files. 409496 6 paroga 2011-05-24 23:54:43 -0700 What's about merging ScriptControllerBrew, ScriptControllerEfl, ScriptControllerGtk, ScriptControllerHaiku, ScriptControllerWin and ScriptControllerWx and give it a better name like ScriptControllerDefault? 409501 7 ryuan.choi 2011-05-25 00:31:03 -0700 (In reply to comment #6) > What's about merging ScriptControllerBrew, ScriptControllerEfl, ScriptControllerGtk, ScriptControllerHaiku, ScriptControllerWin and ScriptControllerWx and give it a better name like ScriptControllerDefault? Sure, It looks quite better. I wish to make different bug for that. 413380 8 ryuan.choi 2011-06-01 08:11:07 -0700 (In reply to comment #6) > What's about merging ScriptControllerBrew, ScriptControllerEfl, ScriptControllerGtk, ScriptControllerHaiku, ScriptControllerWin and ScriptControllerWx and give it a better name like ScriptControllerDefault? I consider it little more. ScripControllerDefault.cpp can be used to reduce duplication. but, we can't include this file in UseJSC.cmake because some port which use CMake may want own ScriptController${PORT}.cpp. For ScriptController${PLATFORM}.cpp now, I don't have idea without adding if statement to check JavaScript engine in each WebCore/CMakeLists{Efl,WinCE}.txt. 413387 9 95604 ryuan.choi 2011-06-01 08:20:11 -0700 Created attachment 95604 Patch 413389 10 95604 paroga 2011-06-01 08:21:50 -0700 Comment on attachment 95604 Patch LGTM 416190 11 ryuan.choi 2011-06-06 18:05:22 -0700 could anyone review this? 435567 12 100466 ryuan.choi 2011-07-12 04:29:19 -0700 Created attachment 100466 rebased_patch 442074 13 100466 dbates 2011-07-25 19:31:58 -0700 Comment on attachment 100466 rebased_patch OK 442109 14 100466 webkit.review.bot 2011-07-25 22:21:20 -0700 Comment on attachment 100466 rebased_patch Clearing flags on attachment: 100466 Committed r91742: <http://trac.webkit.org/changeset/91742> 442110 15 webkit.review.bot 2011-07-25 22:21:26 -0700 All reviewed patches have been landed. Closing bug. 94582 2011-05-24 01:15:46 -0700 2011-06-01 08:20:03 -0700 Patch bug-61350-20110524171540.patch text/plain 4033 ryuan.choi SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3MTM1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMjQgIFJ5dWFuIENo b2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtDTUFLRV0gU3BsaXQgSlNDIHJlbGF0ZWQgZmlsZXMgZnJv bSBXZWJDb3JlL0NNYWtlTGlzdHMudHh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02MTM1MAorCisgICAgICAgIE5vIG5ldyB0ZXN0cywganVzdCBtb3Zp bmcganNjIHJlbGF0ZWQgZmlsZXMgZnJvbSBDTWFrZUxpc3RzLnR4dCB0byBVc2VKU0MuY21ha2Uu CisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgKiBVc2VKU0MuY21ha2U6CisK IDIwMTEtMDUtMjQgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NNYWtlTGlz dHMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CShyZXZp c2lvbiA4NzA0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CSh3b3JraW5nIGNv cHkpCkBAIC00NTQsOCArNDU0LDYgQEAgU0VUKFdlYkNvcmVfU09VUkNFUwogICAgIGJpbmRpbmdz L2dlbmVyaWMvQWN0aXZlRE9NQ2FsbGJhY2suY3BwCiAgICAgYmluZGluZ3MvZ2VuZXJpYy9SdW50 aW1lRW5hYmxlZEZlYXR1cmVzLmNwcAogCi0gICAgYmluZGluZ3MvanMvQ2FsbGJhY2tGdW5jdGlv bi5jcHAKLQogICAgIGNzcy9DU1NCb3JkZXJJbWFnZVZhbHVlLmNwcAogICAgIGNzcy9DU1NDYW52 YXNWYWx1ZS5jcHAKICAgICBjc3MvQ1NTQ2hhcnNldFJ1bGUuY3BwCkBAIC0xNDkyLDkgKzE0OTAs NiBAQCBFTFNFICgpCiBFTkRJRiAoKQogCiBJRiAoRU5BQkxFX05PVElGSUNBVElPTlMpCi0gICAg TElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0gICAgICAgIGJpbmRpbmdzL2pzL0pTRGVza3Rv cE5vdGlmaWNhdGlvbnNDdXN0b20uY3BwCi0gICAgKQogICAgIExJU1QoQVBQRU5EIFdlYkNvcmVf SURMX0ZJTEVTCiAgICAgICAgIG5vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmlkbAogICAgICAg ICBub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbkNlbnRlci5pZGwKQEAgLTE1MDMsMTAgKzE0OTgs NiBAQCBFTkRJRiAoKQogCiBpZiAoRU5BQkxFX0ZJTEVfU1lTVEVNKQogICAgIExJU1QoQVBQRU5E IFdlYkNvcmVfU09VUkNFUwotICAgICAgICBiaW5kaW5ncy9qcy9KU0RpcmVjdG9yeUVudHJ5Q3Vz dG9tLmNwcAotICAgICAgICBiaW5kaW5ncy9qcy9KU0RpcmVjdG9yeUVudHJ5U3luY0N1c3RvbS5j cHAKLSAgICAgICAgYmluZGluZ3MvanMvSlNFbnRyeUN1c3RvbS5jcHAKLSAgICAgICAgYmluZGlu Z3MvanMvSlNFbnRyeVN5bmNDdXN0b20uY3BwCiAgICAgICAgIGZpbGVhcGkvRGlyZWN0b3J5RW50 cnkuY3BwCiAgICAgICAgIGZpbGVhcGkvRGlyZWN0b3J5RW50cnlTeW5jLmNwcAogICAgICAgICBm aWxlYXBpL0RpcmVjdG9yeVJlYWRlci5jcHAKQEAgLTE1NTcsOSArMTU0OCw2IEBAIEVORElGICgp CiAKIElGIChFTkFCTEVfU1ZHKQogICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwotICAg ICAgICBiaW5kaW5ncy9qcy9KU1NWR0VsZW1lbnRJbnN0YW5jZUN1c3RvbS5jcHAKLSAgICAgICAg YmluZGluZ3MvanMvSlNTVkdMZW5ndGhDdXN0b20uY3BwCi0gICAgICAgIGJpbmRpbmdzL2pzL0pT U1ZHUGF0aFNlZ0N1c3RvbS5jcHAKICAgICAgICAgY3NzL1NWR0NTU0NvbXB1dGVkU3R5bGVEZWNs YXJhdGlvbi5jcHAKICAgICAgICAgY3NzL1NWR0NTU1BhcnNlci5jcHAKICAgICAgICAgY3NzL1NW R0NTU1N0eWxlU2VsZWN0b3IuY3BwCkBAIC0xOTA5LDcgKzE4OTcsNiBAQCBFTkRJRigpCiAKIElG IChFTkFCTEVfVklERU8pCiAgICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0gICAgICAg IGJpbmRpbmdzL2pzL0pTQXVkaW9Db25zdHJ1Y3Rvci5jcHAKICAgICAgICAgaHRtbC9IVE1MQXVk aW9FbGVtZW50LmNwcAogICAgICAgICBodG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwCiAgICAgICAg IGh0bWwvSFRNTFNvdXJjZUVsZW1lbnQuY3BwCkBAIC0xOTM2LDcgKzE5MjMsNiBAQCBFTkRJRiAo KQogCiBJRiAoRU5BQkxFX01FRElBX1NUUkVBTSkKICAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NP VVJDRVMKLSAgICAgICAgYmluZGluZ3MvanMvSlNOYXZpZ2F0b3JDdXN0b20uY3BwCiAgICAgICAg IHBhZ2UvTWVkaWFTdHJlYW1Db250cm9sbGVyLmNwcAogICAgICAgICBwYWdlL01lZGlhU3RyZWFt RnJhbWVDb250cm9sbGVyLmNwcAogICAgICkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL1VzZUpTQy5j bWFrZQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Vc2VKU0MuY21ha2UJKHJldmlzaW9u IDg2MzEyKQorKysgU291cmNlL1dlYkNvcmUvVXNlSlNDLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBA IC04LDYgKzgsNyBAQCBMSVNUKEFQUEVORCBXZWJDb3JlX0lETF9JTkNMVURFUwogKQogCiBMSVNU KEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKKyAgICBiaW5kaW5ncy9qcy9DYWxsYmFja0Z1bmN0aW9u LmNwcAogICAgIGJpbmRpbmdzL2pzL0RPTU9iamVjdEhhc2hUYWJsZU1hcC5jcHAKICAgICBiaW5k aW5ncy9qcy9ET01XcmFwcGVyV29ybGQuY3BwCiAgICAgYmluZGluZ3MvanMvR0NDb250cm9sbGVy LmNwcApAQCAtMTc2LDYgKzE3Nyw0MSBAQCBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKICAg ICBicmlkZ2UvanNjL0JyaWRnZUpTQy5jcHAKICkKIAorSUYgKEVOQUJMRV9OT1RJRklDQVRJT05T KQorICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgICAgICBiaW5kaW5ncy9qcy9K U0Rlc2t0b3BOb3RpZmljYXRpb25zQ3VzdG9tLmNwcAorICAgICkKK0VORElGICgpCisKK2lmIChF TkFCTEVfRklMRV9TWVNURU0pCisgICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCisgICAg ICAgIGJpbmRpbmdzL2pzL0pTRGlyZWN0b3J5RW50cnlDdXN0b20uY3BwCisgICAgICAgIGJpbmRp bmdzL2pzL0pTRGlyZWN0b3J5RW50cnlTeW5jQ3VzdG9tLmNwcAorICAgICAgICBiaW5kaW5ncy9q cy9KU0VudHJ5Q3VzdG9tLmNwcAorICAgICAgICBiaW5kaW5ncy9qcy9KU0VudHJ5U3luY0N1c3Rv bS5jcHAKKyAgICApCitFTkRJRiAoKQorCitJRiAoRU5BQkxFX1NWRykKKyAgICBMSVNUKEFQUEVO RCBXZWJDb3JlX1NPVVJDRVMKKyAgICAgICAgYmluZGluZ3MvanMvSlNTVkdFbGVtZW50SW5zdGFu Y2VDdXN0b20uY3BwCisgICAgICAgIGJpbmRpbmdzL2pzL0pTU1ZHTGVuZ3RoQ3VzdG9tLmNwcAor ICAgICAgICBiaW5kaW5ncy9qcy9KU1NWR1BhdGhTZWdDdXN0b20uY3BwCisgICAgKQorRU5ESUYg KCkKKworSUYgKEVOQUJMRV9WSURFTykKKyAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMK KyAgICAgICAgYmluZGluZ3MvanMvSlNBdWRpb0NvbnN0cnVjdG9yLmNwcAorICAgICkKK0VORElG ICgpCisKK0lGIChFTkFCTEVfTUVESUFfU1RSRUFNKQorICAgIExJU1QoQVBQRU5EIFdlYkNvcmVf U09VUkNFUworICAgICAgICBiaW5kaW5ncy9qcy9KU05hdmlnYXRvckN1c3RvbS5jcHAKKyAgICAp CitFTkRJRiAoKQorCiBMSVNUKEFQUEVORCBTQ1JJUFRTX0JJTkRJTkdTCiAgICAgJHtXRUJDT1JF X0RJUn0vYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtCiApCg== 95604 2011-06-01 08:20:11 -0700 2011-07-12 04:29:06 -0700 Patch bug-61350-20110602002010.patch text/plain 4187 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogODc4MDAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NN YWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggYjg0N2M0 Y2VjYzcxODcwNzY3YTI5MTA4ZDUyOTNiMmE1NGMxZGFmNC4uN2EyN2EzMjU5NDExMWY4YmFjMWYy OTNhOGEwYTQ5MDljOWYzNjZhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTQ2MSw4ICs0NjEs NiBAQCBTRVQoV2ViQ29yZV9TT1VSQ0VTCiAgICAgYmluZGluZ3MvZ2VuZXJpYy9BY3RpdmVET01D YWxsYmFjay5jcHAKICAgICBiaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMu Y3BwCiAKLSAgICBiaW5kaW5ncy9qcy9DYWxsYmFja0Z1bmN0aW9uLmNwcAotCiAgICAgY3NzL0NT U0JvcmRlckltYWdlVmFsdWUuY3BwCiAgICAgY3NzL0NTU0NhbnZhc1ZhbHVlLmNwcAogICAgIGNz cy9DU1NDaGFyc2V0UnVsZS5jcHAKQEAgLTE1MDgsOSArMTUwNiw2IEBAIEVMU0UgKCkKIEVORElG ICgpCiAKIElGIChFTkFCTEVfTk9USUZJQ0FUSU9OUykKLSAgICBMSVNUKEFQUEVORCBXZWJDb3Jl X1NPVVJDRVMKLSAgICAgICAgYmluZGluZ3MvanMvSlNEZXNrdG9wTm90aWZpY2F0aW9uc0N1c3Rv bS5jcHAKLSAgICApCiAgICAgTElTVChBUFBFTkQgV2ViQ29yZV9JRExfRklMRVMKICAgICAgICAg bm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24uaWRsCiAgICAgICAgIG5vdGlmaWNhdGlvbnMvTm90 aWZpY2F0aW9uQ2VudGVyLmlkbApAQCAtMTUxOSwxMCArMTUxNCw2IEBAIEVORElGICgpCiAKIGlm IChFTkFCTEVfRklMRV9TWVNURU0pCiAgICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0g ICAgICAgIGJpbmRpbmdzL2pzL0pTRGlyZWN0b3J5RW50cnlDdXN0b20uY3BwCi0gICAgICAgIGJp bmRpbmdzL2pzL0pTRGlyZWN0b3J5RW50cnlTeW5jQ3VzdG9tLmNwcAotICAgICAgICBiaW5kaW5n cy9qcy9KU0VudHJ5Q3VzdG9tLmNwcAotICAgICAgICBiaW5kaW5ncy9qcy9KU0VudHJ5U3luY0N1 c3RvbS5jcHAKICAgICAgICAgZmlsZWFwaS9EaXJlY3RvcnlFbnRyeS5jcHAKICAgICAgICAgZmls ZWFwaS9EaXJlY3RvcnlFbnRyeVN5bmMuY3BwCiAgICAgICAgIGZpbGVhcGkvRGlyZWN0b3J5UmVh ZGVyLmNwcApAQCAtMTU3Myw5ICsxNTY0LDYgQEAgRU5ESUYgKCkKIAogSUYgKEVOQUJMRV9TVkcp CiAgICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0gICAgICAgIGJpbmRpbmdzL2pzL0pT U1ZHRWxlbWVudEluc3RhbmNlQ3VzdG9tLmNwcAotICAgICAgICBiaW5kaW5ncy9qcy9KU1NWR0xl bmd0aEN1c3RvbS5jcHAKLSAgICAgICAgYmluZGluZ3MvanMvSlNTVkdQYXRoU2VnQ3VzdG9tLmNw cAogICAgICAgICBjc3MvU1ZHQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcAogICAgICAg ICBjc3MvU1ZHQ1NTUGFyc2VyLmNwcAogICAgICAgICBjc3MvU1ZHQ1NTU3R5bGVTZWxlY3Rvci5j cHAKQEAgLTE5MjcsNyArMTkxNSw2IEBAIEVORElGKCkKIAogSUYgKEVOQUJMRV9WSURFTykKICAg ICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKLSAgICAgICAgYmluZGluZ3MvanMvSlNBdWRp b0NvbnN0cnVjdG9yLmNwcAogICAgICAgICBodG1sL0hUTUxBdWRpb0VsZW1lbnQuY3BwCiAgICAg ICAgIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKICAgICAgICAgaHRtbC9IVE1MU291cmNlRWxl bWVudC5jcHAKQEAgLTE5NTQsNyArMTk0MSw2IEBAIEVORElGICgpCiAKIElGIChFTkFCTEVfTUVE SUFfU1RSRUFNKQogICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwotICAgICAgICBiaW5k aW5ncy9qcy9KU05hdmlnYXRvckN1c3RvbS5jcHAKICAgICAgICAgZG9tL0dlbmVyYXRlZFN0cmVh bS5jcHAKICAgICAgICAgZG9tL1N0cmVhbS5jcHAKICAgICAgICAgcGFnZS9NZWRpYVN0cmVhbUNv bnRyb2xsZXIuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjJmM2EwYzFjMjEyZDdmNTk2ZGE2MDE2NGZmNmE5 NThjMjFlMmFjZC4uODNlZjQ2OGM4NzQxZGY5MWIxYjZhMDM0NGEzMjlhYmVhNDUzOTcwMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDExLTA2LTAxICBSeXVhbiBDaG9pICA8cnl1YW4u Y2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBbQ01BS0VdIFNwbGl0IEpTQyByZWxhdGVkIGZpbGVzIGZyb20gV2ViQ29yZS9D TWFrZUxpc3RzLnR4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjEzNTAKKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgbW92aW5nIGpzYyByZWxh dGVkIGZpbGVzIGZyb20gQ01ha2VMaXN0cy50eHQgdG8gVXNlSlNDLmNtYWtlLgorCisgICAgICAg ICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAgICogVXNlSlNDLmNtYWtlOgorCiAyMDExLTA2LTAx ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBV bnJldmlld2VkLCByb2xsaW5nIG91dCByODc3ODguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9Vc2VKU0MuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9Vc2VKU0MuY21ha2UKaW5kZXggZjg3NThm MGQ1YmViMDk1M2UyZmNmZWM4OWMyMGRmOTA3N2JjZDQ4ZC4uMzQ2YmEwZjlkMzg1MzRiYTg0MDU3 NzZmY2FkMWU2MjJmMDNiZTYzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvVXNlSlNDLmNt YWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1VzZUpTQy5jbWFrZQpAQCAtOCw2ICs4LDcgQEAgTElT VChBUFBFTkQgV2ViQ29yZV9JRExfSU5DTFVERVMKICkKIAogTElTVChBUFBFTkQgV2ViQ29yZV9T T1VSQ0VTCisgICAgYmluZGluZ3MvanMvQ2FsbGJhY2tGdW5jdGlvbi5jcHAKICAgICBiaW5kaW5n cy9qcy9ET01PYmplY3RIYXNoVGFibGVNYXAuY3BwCiAgICAgYmluZGluZ3MvanMvRE9NV3JhcHBl cldvcmxkLmNwcAogICAgIGJpbmRpbmdzL2pzL0dDQ29udHJvbGxlci5jcHAKQEAgLTE3NSw2ICsx NzYsNDEgQEAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCiAgICAgYnJpZGdlL2pzYy9Ccmlk Z2VKU0MuY3BwCiApCiAKK0lGIChFTkFCTEVfTk9USUZJQ0FUSU9OUykKKyAgICBMSVNUKEFQUEVO RCBXZWJDb3JlX1NPVVJDRVMKKyAgICAgICAgYmluZGluZ3MvanMvSlNEZXNrdG9wTm90aWZpY2F0 aW9uc0N1c3RvbS5jcHAKKyAgICApCitFTkRJRiAoKQorCitpZiAoRU5BQkxFX0ZJTEVfU1lTVEVN KQorICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgICAgICBiaW5kaW5ncy9qcy9K U0RpcmVjdG9yeUVudHJ5Q3VzdG9tLmNwcAorICAgICAgICBiaW5kaW5ncy9qcy9KU0RpcmVjdG9y eUVudHJ5U3luY0N1c3RvbS5jcHAKKyAgICAgICAgYmluZGluZ3MvanMvSlNFbnRyeUN1c3RvbS5j cHAKKyAgICAgICAgYmluZGluZ3MvanMvSlNFbnRyeVN5bmNDdXN0b20uY3BwCisgICAgKQorRU5E SUYgKCkKKworSUYgKEVOQUJMRV9TVkcpCisgICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VT CisgICAgICAgIGJpbmRpbmdzL2pzL0pTU1ZHRWxlbWVudEluc3RhbmNlQ3VzdG9tLmNwcAorICAg ICAgICBiaW5kaW5ncy9qcy9KU1NWR0xlbmd0aEN1c3RvbS5jcHAKKyAgICAgICAgYmluZGluZ3Mv anMvSlNTVkdQYXRoU2VnQ3VzdG9tLmNwcAorICAgICkKK0VORElGICgpCisKK0lGIChFTkFCTEVf VklERU8pCisgICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCisgICAgICAgIGJpbmRpbmdz L2pzL0pTQXVkaW9Db25zdHJ1Y3Rvci5jcHAKKyAgICApCitFTkRJRiAoKQorCitJRiAoRU5BQkxF X01FRElBX1NUUkVBTSkKKyAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKKyAgICAgICAg YmluZGluZ3MvanMvSlNOYXZpZ2F0b3JDdXN0b20uY3BwCisgICAgKQorRU5ESUYgKCkKKwogTElT VChBUFBFTkQgU0NSSVBUU19CSU5ESU5HUwogICAgICR7V0VCQ09SRV9ESVJ9L2JpbmRpbmdzL3Nj cmlwdHMvQ29kZUdlbmVyYXRvci5wbQogKQo= 100466 2011-07-12 04:29:19 -0700 2011-07-25 22:21:20 -0700 rebased_patch bug-61350-20110712202927.patch text/plain 4848 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogOTA4MTEKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NN YWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKaW5kZXggNjI5OTgy YWQ5NjFiMDNmMzQwMjBiMzA3ZjZmZjAwOWMxNGZhMjNiZi4uNjMyZTEzYjc2ODZhODVjM2YyMjdl YjNmZDcxMGQzZTdkNzE5NjE0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0 cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTQyMyw4ICs0MjMs NiBAQCBTRVQoV2ViQ29yZV9TT1VSQ0VTCiAgICAgYmluZGluZ3MvZ2VuZXJpYy9BY3RpdmVET01D YWxsYmFjay5jcHAKICAgICBiaW5kaW5ncy9nZW5lcmljL1J1bnRpbWVFbmFibGVkRmVhdHVyZXMu Y3BwCiAKLSAgICBiaW5kaW5ncy9qcy9DYWxsYmFja0Z1bmN0aW9uLmNwcAotCiAgICAgY3NzL0NT U0JvcmRlckltYWdlVmFsdWUuY3BwCiAgICAgY3NzL0NTU0NhbnZhc1ZhbHVlLmNwcAogICAgIGNz cy9DU1NDaGFyc2V0UnVsZS5jcHAKQEAgLTE1MjAsOSArMTUxOCw2IEBAIElGIChFTkFCTEVfTkVU U0NBUEVfUExVR0lOX0FQSSkKIEVORElGICgpCiAKIElGIChFTkFCTEVfTk9USUZJQ0FUSU9OUykK LSAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKLSAgICAgICAgYmluZGluZ3MvanMvSlNE ZXNrdG9wTm90aWZpY2F0aW9uc0N1c3RvbS5jcHAKLSAgICApCiAgICAgTElTVChBUFBFTkQgV2Vi Q29yZV9JRExfRklMRVMKICAgICAgICAgbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb24uaWRsCiAg ICAgICAgIG5vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uQ2VudGVyLmlkbApAQCAtMTUzMSwxMCAr MTUyNiw2IEBAIEVORElGICgpCiAKIGlmIChFTkFCTEVfRklMRV9TWVNURU0pCiAgICAgTElTVChB UFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0gICAgICAgIGJpbmRpbmdzL2pzL0pTRGlyZWN0b3J5RW50 cnlDdXN0b20uY3BwCi0gICAgICAgIGJpbmRpbmdzL2pzL0pTRGlyZWN0b3J5RW50cnlTeW5jQ3Vz dG9tLmNwcAotICAgICAgICBiaW5kaW5ncy9qcy9KU0VudHJ5Q3VzdG9tLmNwcAotICAgICAgICBi aW5kaW5ncy9qcy9KU0VudHJ5U3luY0N1c3RvbS5jcHAKICAgICAgICAgZmlsZWFwaS9EaXJlY3Rv cnlFbnRyeS5jcHAKICAgICAgICAgZmlsZWFwaS9EaXJlY3RvcnlFbnRyeVN5bmMuY3BwCiAgICAg ICAgIGZpbGVhcGkvRGlyZWN0b3J5UmVhZGVyLmNwcApAQCAtMTU5NSw5ICsxNTg2LDYgQEAgRU5E SUYgKCkKIAogSUYgKEVOQUJMRV9TVkcpCiAgICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VT Ci0gICAgICAgIGJpbmRpbmdzL2pzL0pTU1ZHRWxlbWVudEluc3RhbmNlQ3VzdG9tLmNwcAotICAg ICAgICBiaW5kaW5ncy9qcy9KU1NWR0xlbmd0aEN1c3RvbS5jcHAKLSAgICAgICAgYmluZGluZ3Mv anMvSlNTVkdQYXRoU2VnQ3VzdG9tLmNwcAogICAgICAgICBjc3MvU1ZHQ1NTQ29tcHV0ZWRTdHls ZURlY2xhcmF0aW9uLmNwcAogICAgICAgICBjc3MvU1ZHQ1NTUGFyc2VyLmNwcAogICAgICAgICBj c3MvU1ZHQ1NTU3R5bGVTZWxlY3Rvci5jcHAKQEAgLTE5NjUsNyArMTk1Myw2IEBAIEVORElGKCkK IAogSUYgKEVOQUJMRV9WSURFTykKICAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKLSAg ICAgICAgYmluZGluZ3MvanMvSlNBdWRpb0NvbnN0cnVjdG9yLmNwcAogICAgICAgICBodG1sL0hU TUxBdWRpb0VsZW1lbnQuY3BwCiAgICAgICAgIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKICAg ICAgICAgaHRtbC9IVE1MU291cmNlRWxlbWVudC5jcHAKQEAgLTIwMDcsNyArMTk5NCw2IEBAIEVO RElGICgpCiAKIElGIChFTkFCTEVfTUVESUFfU1RSRUFNKQogICAgIExJU1QoQVBQRU5EIFdlYkNv cmVfU09VUkNFUwotICAgICAgICBiaW5kaW5ncy9qcy9KU05hdmlnYXRvckN1c3RvbS5jcHAKICAg ICAgICAgZG9tL0xvY2FsTWVkaWFTdHJlYW0uY3BwCiAgICAgICAgIGRvbS9NZWRpYVN0cmVhbS5j cHAKICAgICAgICAgZG9tL01lZGlhU3RyZWFtTGlzdC5jcHAKQEAgLTIwODEsOCArMjA2Nyw2IEBA IElGIChFTkFCTEVfV0VCR0wpCiAgICAgICAgICR7VEhJUkRQQVJUWV9ESVJ9L0FOR0xFL3NyYy9j b21waWxlci9WYWxpZGF0ZUxpbWl0YXRpb25zLmNwcAogICAgICAgICAke1RISVJEUEFSVFlfRElS fS9BTkdMRS9zcmMvY29tcGlsZXIvVmFyaWFibGVJbmZvLmNwcAogCi0gICAgICAgIGJpbmRpbmdz L2pzL0pTV2ViR0xSZW5kZXJpbmdDb250ZXh0Q3VzdG9tLmNwcAotCiAgICAgICAgIGh0bWwvY2Fu dmFzL1dlYkdMQnVmZmVyLmNwcAogICAgICAgICBodG1sL2NhbnZhcy9XZWJHTENvbnRleHRBdHRy aWJ1dGVzLmNwcAogICAgICAgICBodG1sL2NhbnZhcy9XZWJHTENvbnRleHRFdmVudC5jcHAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCAxZjI2NjQzN2Q0MDFkNTBkYmI2NWNmMzIzMmNmZTA4YzFiNDUyNTVmLi40NDQ3 MjVmNzZmMDg3MGMwOWJiMWE2OTQwNDllYTg2NzY5OWRlODM4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMTEtMDctMTIgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29t PgorCisgICAgICAgIFtDTUFLRV0gU3BsaXQgSlNDIHJlbGF0ZWQgZmlsZXMgZnJvbSBXZWJDb3Jl L0NNYWtlTGlzdHMudHh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02MTM1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywganVzdCBtb3ZpbmcganNjIHJlbGF0ZWQgZmlsZXMgZnJvbSBD TWFrZUxpc3RzLnR4dCB0byBVc2VKU0MuY21ha2UuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4 dDoKKyAgICAgICAgKiBVc2VKU0MuY21ha2U6CisKIDIwMTEtMDctMTIgIE9saXZlciBWYXJnYSAg PFZhcmdhLk9saXZlckBzdHVkLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5p a29sYXMgWmltbWVybWFubi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1VzZUpTQy5jbWFr ZSBiL1NvdXJjZS9XZWJDb3JlL1VzZUpTQy5jbWFrZQppbmRleCA0MmY4NGU0OTkzNjg2YzJhMzc4 MGMxZjVlMDFhNTBkYzQ3MjEzMWNjLi5hYjRiOTEzZmY4ODUxYjBhNjlhYTNiNzU3M2QxZjNkZTFk MDI2NzQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Vc2VKU0MuY21ha2UKKysrIGIvU291 cmNlL1dlYkNvcmUvVXNlSlNDLmNtYWtlCkBAIC04LDYgKzgsNyBAQCBMSVNUKEFQUEVORCBXZWJD b3JlX0lETF9JTkNMVURFUwogKQogCiBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKKyAgICBi aW5kaW5ncy9qcy9DYWxsYmFja0Z1bmN0aW9uLmNwcAogICAgIGJpbmRpbmdzL2pzL0RPTU9iamVj dEhhc2hUYWJsZU1hcC5jcHAKICAgICBiaW5kaW5ncy9qcy9ET01XcmFwcGVyV29ybGQuY3BwCiAg ICAgYmluZGluZ3MvanMvR0NDb250cm9sbGVyLmNwcApAQCAtMTYyLDcgKzE2Myw2IEBAIExJU1Qo QVBQRU5EIFdlYkNvcmVfU09VUkNFUwogICAgIGJyaWRnZS9qc2MvQnJpZGdlSlNDLmNwcAogKQog Ci0KIElGIChFTkFCTEVfQkxPQikKICAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMKICAg ICAgICAgYmluZGluZ3MvanMvSlNGaWxlUmVhZGVyQ3VzdG9tLmNwcApAQCAtMjEyLDYgKzIxMiw0 NyBAQCBJRiAoRU5BQkxFX1hQQVRIKQogRU5ESUYgKCkKIAogCitJRiAoRU5BQkxFX05PVElGSUNB VElPTlMpCisgICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCisgICAgICAgIGJpbmRpbmdz L2pzL0pTRGVza3RvcE5vdGlmaWNhdGlvbnNDdXN0b20uY3BwCisgICAgKQorRU5ESUYgKCkKKwor aWYgKEVOQUJMRV9GSUxFX1NZU1RFTSkKKyAgICBMSVNUKEFQUEVORCBXZWJDb3JlX1NPVVJDRVMK KyAgICAgICAgYmluZGluZ3MvanMvSlNEaXJlY3RvcnlFbnRyeUN1c3RvbS5jcHAKKyAgICAgICAg YmluZGluZ3MvanMvSlNEaXJlY3RvcnlFbnRyeVN5bmNDdXN0b20uY3BwCisgICAgICAgIGJpbmRp bmdzL2pzL0pTRW50cnlDdXN0b20uY3BwCisgICAgICAgIGJpbmRpbmdzL2pzL0pTRW50cnlTeW5j Q3VzdG9tLmNwcAorICAgICkKK0VORElGICgpCisKK0lGIChFTkFCTEVfU1ZHKQorICAgIExJU1Qo QVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgICAgICBiaW5kaW5ncy9qcy9KU1NWR0VsZW1lbnRJ bnN0YW5jZUN1c3RvbS5jcHAKKyAgICAgICAgYmluZGluZ3MvanMvSlNTVkdMZW5ndGhDdXN0b20u Y3BwCisgICAgICAgIGJpbmRpbmdzL2pzL0pTU1ZHUGF0aFNlZ0N1c3RvbS5jcHAKKyAgICApCitF TkRJRiAoKQorCitJRiAoRU5BQkxFX1ZJREVPKQorICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfU09V UkNFUworICAgICAgICBiaW5kaW5ncy9qcy9KU0F1ZGlvQ29uc3RydWN0b3IuY3BwCisgICAgKQor RU5ESUYgKCkKKworSUYgKEVOQUJMRV9NRURJQV9TVFJFQU0pCisgICAgTElTVChBUFBFTkQgV2Vi Q29yZV9TT1VSQ0VTCisgICAgICAgIGJpbmRpbmdzL2pzL0pTTmF2aWdhdG9yQ3VzdG9tLmNwcAor ICAgICkKK0VORElGICgpCisKK0lGIChFTkFCTEVfV0VCR0wpCisgICAgTElTVChBUFBFTkQgV2Vi Q29yZV9TT1VSQ0VTCisgICAgICAgIGJpbmRpbmdzL2pzL0pTV2ViR0xSZW5kZXJpbmdDb250ZXh0 Q3VzdG9tLmNwcAorICAgICkKK0VORElGICgpCisKIExJU1QoQVBQRU5EIFNDUklQVFNfQklORElO R1MKICAgICAke1dFQkNPUkVfRElSfS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3IucG0K ICkK