61340 2011-05-23 20:41:57 -0700 Undo gets broken in contenteditable area when a text field's value is set by script 2013-12-02 14:19:38 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Critical --- 1 rniwa rniwa adele alex darin enrica justin.garcia leviw morrita sullivan tkent xji oldest_to_newest 408606 0 rniwa 2011-05-23 20:41:57 -0700 Reproduction steps: 1. Open the attached demo 2. Type something into the black box. 3. Undo Expected result: Undo works. Actual result: Undo doesn't work. 408607 1 rniwa 2011-05-23 20:42:22 -0700 This is why simple-rte.rniwa.com doesn't work properly on WebKit / Chrome. 408661 2 94567 rniwa 2011-05-23 22:46:02 -0700 Created attachment 94567 demo Apparently, I forgot to attach the test case earlier. It turned out that this bug is nothing to with event handler. The problem reproduces whenever you modify input element's value. 409062 3 rniwa 2011-05-24 11:49:43 -0700 Of course this is broken because we call clearUndoRedoOperations() in RenderTextControl::setInnerTextValue. Relevant changesets: http://trac.webkit.org/changeset/15565 http://trac.webkit.org/changeset/29748 409099 4 94662 rniwa 2011-05-24 12:18:42 -0700 Created attachment 94662 fixes the bug 409137 5 rniwa 2011-05-24 12:52:40 -0700 Thanks for the review, Darin. Landing it now. 409205 6 rniwa 2011-05-24 14:22:32 -0700 Committed r87204: <http://trac.webkit.org/changeset/87204> 955574 7 dbates 2013-12-02 14:19:38 -0800 *** Bug 48665 has been marked as a duplicate of this bug. *** 94567 2011-05-23 22:46:02 -0700 2011-05-23 22:46:02 -0700 demo test.html text/html 347 rniwa PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8Ym9keT4KPGlucHV0IGlkPSJ0Ij4KPGRpdiBpZD0iZSIg Y29udGVudGVkaXRhYmxlPlBBU1M8L2Rpdj4KPHNjcmlwdD4KCmRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdlJykuZm9jdXMoKTsKZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ1NlbGVjdEFsbCcsIGZhbHNl LCBudWxsKTsKZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ0luc2VydFRleHQnLCBmYWxzZSwgJ0ZBSUwn KTsKZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3QnKS52YWx1ZSA9ICd3b3JsZCc7CmRvY3VtZW50 LmV4ZWNDb21tYW5kKCdVbmRvJywgZmFsc2UsIG51bGwpOwoKPC9zY3JpcHQ+CjwvYm9keT4KPC9o dG1sPgo= 94662 2011-05-24 12:18:42 -0700 2011-05-24 12:48:05 -0700 fixes the bug bug-61340-20110524121840.patch text/plain 4742 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogODcxNzMKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmYjRjMmRlNTAxMDU1YjYxOGIzMjUy NGFhYTc2OWFkYjQyZmFhYjc3Li5kZDc1YzgzMjRhYzhiOTk4NWZlYmVlMzRlMzBhODUwZDgxNzAz MjdlIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDUtMjQgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgVW5kbyBnZXRzIGJyb2tlbiBpbiBjb250ZW50ZWRpdGFibGUgYXJlYSB3aGVuIGEg dGV4dCBmaWVsZCdzIHZhbHVlIGlzIHNldCBieSBzY3JpcHQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMzQwCisKKyAgICAgICAgQWRkZWQgYSB0ZXN0 IHRvIGVuc3VyZSBXZWJLaXQgZG9lcyBub3QgY2xlYXIgdW5kbyBzdGFjayB3aGVuIHNldHRpbmcg dGhlIHZhbHVlIG9mIGlucHV0IG9yIHRleHRhcmVhLgorCisgICAgICAgICogZWRpdGluZy91bmRv L3VuZG8tYWZ0ZXItc2V0dGluZy12YWx1ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAq IGVkaXRpbmcvdW5kby91bmRvLWFmdGVyLXNldHRpbmctdmFsdWUuaHRtbDogQWRkZWQuCisKIDIw MTEtMDUtMjQgIEFkYW0gS2xlaW4gIDxhZGFta0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjg3MTQ1LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRp dGluZy91bmRvL3VuZG8tYWZ0ZXItc2V0dGluZy12YWx1ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9lZGl0aW5nL3VuZG8vdW5kby1hZnRlci1zZXR0aW5nLXZhbHVlLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwLi5lZDQyNDBiNWUzNzFjZTU0Mzg0YmMyYmYzMjViYzU5NDIyMTMxYjNmCi0tLSAv ZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy91bmRvL3VuZG8tYWZ0ZXItc2V0dGlu Zy12YWx1ZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw0IEBACitUaGlzIHRlc3QgZW5zdXJlcyBX ZWJLaXQgZG9lcyBub3QgY2xlYXIgdW5kbyBzdGFjayBpbiBhIGNvbnRlbnRlZGl0YWJsZSBlbGVt ZW50IHdoZW4gc2V0dGluZyB0aGUgdmFsdWUgb2YgaW5wdXQgb3IgdGV4dGFyZWEgZWxlbWVudC4K KworIAorUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy91bmRvL3VuZG8tYWZ0 ZXItc2V0dGluZy12YWx1ZS5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy91bmRvL3VuZG8tYWZ0 ZXItc2V0dGluZy12YWx1ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmQxYmUwYmI0ZmJmNmE4NTYzZjgxMTk3 MTRhY2Q2NGEzMGU4M2QyYzQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9lZGl0aW5n L3VuZG8vdW5kby1hZnRlci1zZXR0aW5nLXZhbHVlLmh0bWwKQEAgLTAsMCArMSwyMiBAQAorPCFE T0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHA+VGhpcyB0ZXN0IGVuc3VyZXMgV2ViS2l0 IGRvZXMgbm90IGNsZWFyIHVuZG8gc3RhY2sgaW4gYSBjb250ZW50ZWRpdGFibGUgZWxlbWVudCB3 aGVuIHNldHRpbmcgdGhlIHZhbHVlIG9mIGlucHV0IG9yIHRleHRhcmVhIGVsZW1lbnQuPC9wPgor PGlucHV0IHR5cGU9InRleHQiPgorPHRleHRhcmVhPjwvdGV4dGFyZWE+Cis8ZGl2IGNvbnRlbnRl ZGl0YWJsZT5QQVNTPC9kaXY+Cis8c2NyaXB0PgorCitkb2N1bWVudC5nZXRFbGVtZW50c0J5VGFn TmFtZSgnZGl2JylbMF0uZm9jdXMoKTsKK2RvY3VtZW50LmV4ZWNDb21tYW5kKCdTZWxlY3RBbGwn LCBmYWxzZSwgbnVsbCk7Citkb2N1bWVudC5leGVjQ29tbWFuZCgnSW5zZXJ0VGV4dCcsIGZhbHNl LCAnRkFJTCcpOworZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ2lucHV0JylbMF0udmFs dWUgPSAnaGVsbG8nOworZG9jdW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoJ3RleHRhcmVhJylb MF0udmFsdWUgPSAnd29ybGQnOworZG9jdW1lbnQuZXhlY0NvbW1hbmQoJ1VuZG8nLCBmYWxzZSwg bnVsbCk7CisKK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxMjA1NWIxOTcwZmRiN2UzNjNiYzI2OThkMDA2NjVkMmQ3YmZiZWQzLi43 YTcyZDRiNDUzN2E5MjM5ZTVmY2EzZDIwZTc0MWJlNjNmNDE0Mzk5IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjIgQEAKKzIwMTEtMDUtMjQgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5kbyBn ZXRzIGJyb2tlbiBpbiBjb250ZW50ZWRpdGFibGUgYXJlYSB3aGVuIGEgdGV4dCBmaWVsZCdzIHZh bHVlIGlzIHNldCBieSBzY3JpcHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTYxMzQwCisKKyAgICAgICAgVGhlIGJ1ZyB3YXMgY2F1c2VkIGJ5IFJlbmRl clRleHRDb250cm9sOjpzZXRJbm5lclRleHRWYWx1ZSdzIGNsZWFyaW5nIHVuZG8gc3RhY2sgYnkK KyAgICAgICAgY2FsbGluZyBjbGVhclVuZG9SZWRvT3BlcmF0aW9ucyB3aGVuZXZlciBzY3JpcHQg c2V0cyBuZXcgdmFsdWUgdG8gaW5wdXQgb3IgdGV4dGFyZWEuCisKKyAgICAgICAgRml4ZWQgdGhl IGJ1ZyBieSByZW1vdmluZyB0aGUgb2ZmZW5kaW5nIGNhbGwgdG8gY2xlYXJVbmRvUmVkb09wZXJh dGlvbnMuIFdoaWxlIHRoaXMgY2FsbAorICAgICAgICB3YXMgYWRkZWQgYnkgcjE1NTY1IHRvIGZp eCBhIGNyYXNoLCBTaW1wbGVFZGl0Q29tbWFuZHMgaGF2ZSBzaW5jZSBiZWNvbWUgbXVjaCBtb3Jl IHJvYnVzdAorICAgICAgICBhbmQgdGhlIHRlc3QgYWRkZWQgYnkgcjE1NTY1IChmYXN0L2Zvcm1z L3RleHQtZmllbGQtc2V0dmFsdWUtY3Jhc2guaHRtbCkgc3RpbGwgcGFzc2VzLgorCisgICAgICAg IFRlc3Q6IGVkaXRpbmcvdW5kby91bmRvLWFmdGVyLXNldHRpbmctdmFsdWUuaHRtbAorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJlbmRlclRleHRDb250cm9sOjpzZXRJbm5lclRleHRWYWx1ZSk6CisKIDIwMTEtMDUtMjQgIFph biBEb2JlcnNlayAgPHphbmRvYmVyc2VrQGdtYWlsLmNvbT4gYW5kIFBoaWxpcHBlIE5vcm1hbmQg IDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUnVz c2VsbC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29u dHJvbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGV4dENvbnRyb2wuY3Bw CmluZGV4IDU4ZDA0NTAwMWFjYWM4OWFiZjQ3NGRlOWE0ZDEwYzM1NmQ4NWViMmIuLjhkNDg4YjRi Y2ExY2IwNThiNmIyMTFlMzE4N2ExN2ZiZDhlNzVkZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJUZXh0Q29udHJvbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRleHRDb250cm9sLmNwcApAQCAtMTQ3LDE0ICsxNDcsOCBAQCB2b2lk IFJlbmRlclRleHRDb250cm9sOjpzZXRJbm5lclRleHRWYWx1ZShjb25zdCBTdHJpbmcmIGlubmVy VGV4dFZhbHVlKQogewogICAgIFN0cmluZyB2YWx1ZSA9IGlubmVyVGV4dFZhbHVlOwogICAgIGlm ICh2YWx1ZSAhPSB0ZXh0KCkgfHwgIWlubmVyVGV4dEVsZW1lbnQoKS0+aGFzQ2hpbGROb2Rlcygp KSB7Ci0gICAgICAgIGlmICh2YWx1ZSAhPSB0ZXh0KCkpIHsKLSAgICAgICAgICAgIGlmIChGcmFt ZSogZnJhbWUgPSB0aGlzLT5mcmFtZSgpKSB7Ci0gICAgICAgICAgICAgICAgZnJhbWUtPmVkaXRv cigpLT5jbGVhclVuZG9SZWRvT3BlcmF0aW9ucygpOwotICAgICAgICAgICAgICAgIAotICAgICAg ICAgICAgICAgIGlmIChBWE9iamVjdENhY2hlOjphY2Nlc3NpYmlsaXR5RW5hYmxlZCgpKQotICAg ICAgICAgICAgICAgICAgICBkb2N1bWVudCgpLT5heE9iamVjdENhY2hlKCktPnBvc3ROb3RpZmlj YXRpb24odGhpcywgQVhPYmplY3RDYWNoZTo6QVhWYWx1ZUNoYW5nZWQsIGZhbHNlKTsKLSAgICAg ICAgICAgIH0KLSAgICAgICAgfQorICAgICAgICBpZiAodmFsdWUgIT0gdGV4dCgpICYmIGRvY3Vt ZW50KCkgJiYgQVhPYmplY3RDYWNoZTo6YWNjZXNzaWJpbGl0eUVuYWJsZWQoKSkKKyAgICAgICAg ICAgIGRvY3VtZW50KCktPmF4T2JqZWN0Q2FjaGUoKS0+cG9zdE5vdGlmaWNhdGlvbih0aGlzLCBB WE9iamVjdENhY2hlOjpBWFZhbHVlQ2hhbmdlZCwgZmFsc2UpOwogCiAgICAgICAgIEV4Y2VwdGlv bkNvZGUgZWMgPSAwOwogICAgICAgICBpbm5lclRleHRFbGVtZW50KCktPnNldElubmVyVGV4dCh2 YWx1ZSwgZWMpOwo=