61322 2011-05-23 16:37:47 -0700 [Qt] Selectstart event tests added by r87096 are failing on Qt 2014-02-03 03:17:50 -0800 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID LayoutTestFailure, Qt, QtTriaged P1 Normal --- 19489 61393 1 rniwa webkit-unassigned benjamin cshu luiz mamacdon ossy robert tonikitoo yael oldest_to_newest 408461 0 rniwa 2011-05-23 16:37:47 -0700 The following tests are all failing on Qt: fast/events/selectstart-by-double-triple-clicks.html fast/events/selectstart-by-drag.html fast/events/selectstart-by-single-click-with-shift.html http://build.webkit.org/results/Qt%20Linux%20Release/r87096%20(33230)/results.html 409185 1 94682 robert 2011-05-24 13:57:15 -0700 Created attachment 94682 Patch 409187 2 robert 2011-05-24 13:59:43 -0700 This fixes one of the tests. The others are due to EventSenderQt's leapForward(), which I don't fully understand yet. It at least looks like we don't have dragMode there, and are just delaying the firing of events instead of queuing them. This is partially borne out by the fact that you can get the other two tests to pass by commenting out some of the leapForward() calls. 409191 3 rniwa 2011-05-24 14:03:24 -0700 (In reply to comment #2) > This fixes one of the tests. The others are due to EventSenderQt's leapForward(), which I don't fully understand yet. It at least looks like we don't have dragMode there, and are just delaying the firing of events instead of queuing them. Maybe dragMode is initialized to a different value on Qt? 409263 4 rniwa 2011-05-24 15:25:43 -0700 Mn... after looking at the failures on WK2, I concur with your point that Qt doesn't implement dragMode. 409843 5 cshu 2011-05-25 12:31:39 -0700 (In reply to comment #4) > Mn... after looking at the failures on WK2, I concur with your point that Qt doesn't implement dragMode. You mean WK1, right? There's known issue of Drag&Drop on Qt DRT. https://bugs.webkit.org/show_bug.cgi?id=31332 409845 6 rniwa 2011-05-25 12:32:57 -0700 (In reply to comment #5) > (In reply to comment #4) > > Mn... after looking at the failures on WK2, I concur with your point that Qt doesn't implement dragMode. > > You mean WK1, right? There's known issue of Drag&Drop on Qt DRT. > https://bugs.webkit.org/show_bug.cgi?id=31332 Yes. Okay. Should we merge this bug into that one? 409854 7 cshu 2011-05-25 12:40:28 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Mn... after looking at the failures on WK2, I concur with your point that Qt doesn't implement dragMode. > > > > You mean WK1, right? There's known issue of Drag&Drop on Qt DRT. > > https://bugs.webkit.org/show_bug.cgi?id=31332 > > Yes. Okay. Should we merge this bug into that one? What happened to Robert's patch? I thought he at least fixed one test. After this, if the remaining issues are all related to drag, I agree we can merge the bugs. 409861 8 rniwa 2011-05-25 12:49:35 -0700 It was landed on the bug 61393. 409955 9 robert 2011-05-25 15:09:46 -0700 Looking at EventSenderQt I can't really see a good reason for matching other ports' behaviour of introducing a delay in the event queue when leapForward() is called. The purpose of leapForward() (if I understand it correctly) is to introduce a delay long enough to simulate a drag event to the port's toolkit. This isn't necessary for Qt, which lets the application decide when to create a drag event loop. Removing the delay in leapForward() (and replacing it with m_drag=true) allows the remaining two failing tests to pass and causes only one regression in the layout tests. This can be fixed in the test itself: [22:33] <rniwa> editing/selection/select-out-of-editable.html? [22:33] <mwenge> rniwa:yup [22:33] <rniwa> mwenge: oh you can remove the second mouseMoveTo, mouseDown, and leapForward now [22:34] <mwenge> ok, why's that? [22:34] <rniwa> mwenge: there was a bug in EventHandler [22:34] <rniwa> mwenge: luckily, evmar found a reduction for the bug and I fixed it a couple of weeks ago :) [22:34] <rniwa> mwenge: http://trac.webkit.org/changeset/81053 [22:34] <rniwa> mwenge: after this revision, the test shouldn't require additional moveMove Yael, what are your thoughts on this? OK to remove the delay? 411720 10 yael 2011-05-27 16:56:09 -0700 (In reply to comment #9) > Yael, what are your thoughts on this? OK to remove the delay? Can you elaborate on the regression? The fact that removing the timeout causes regression sounds to me that we should have a timeout. I learnt recently that mac and chromium simply modify the time stamp on the event and do not sleep. Is it possible to do that for Qt too ? . 454388 11 rniwa 2011-08-21 00:28:35 -0700 (In reply to comment #10) > I learnt recently that mac and chromium simply modify the time stamp on the event and do not sleep. Is it possible to do that for Qt too ? > . The same bug exists on Windows, GTK, and Qt DRT and causing a bunch of tests in editing/selection to permanently fail. 454396 12 yael 2011-08-21 05:21:20 -0700 (In reply to comment #11) > (In reply to comment #10) > > I learnt recently that mac and chromium simply modify the time stamp on the event and do not sleep. Is it possible to do that for Qt too ? > > . > > The same bug exists on Windows, GTK, and Qt DRT and causing a bunch of tests in editing/selection to permanently fail. I added the delay based on the Windows implementation, which now seems to be wrong. Since QEvent does not have a public API for setting a timestamp, I am not sure what is the alternative. 975222 13 jturcotte 2014-02-03 03:17:50 -0800 === Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines. 94682 2011-05-24 13:57:15 -0700 2011-05-24 14:55:52 -0700 Patch bug-61322-20110524215710.patch text/plain 5524 robert U3VidmVyc2lvbiBSZXZpc2lvbjogODcxOTgKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0NThlNzVjYWM0NGQ4OWM5NjczMzlj MGUwYTg2ZTNlNWM4Yzk2NzMyLi5mZWQzNGZmNzc5MjY4ODZjNjhkNWZiYWEwYmU3ODRmYTI0Njll YzM2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDUtMjQgIFJvYmVydCBIb2dhbiAgPHJv YmVydEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtRdF0gU2VsZWN0c3RhcnQgZXZlbnQgdGVzdHMgYWRkZWQgYnkgcjg3MDk2IGFy ZSBmYWlsaW5nIG9uIFF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02MTMyMgorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDogVW5za2lwIGZh c3QvZXZlbnRzL3NlbGVjdHN0YXJ0LWJ5LXNpbmdsZS1jbGljay13aXRoLXNoaWZ0Lmh0bWwKKwog MjAxMS0wNS0wOCAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAppbmRleCA1 YTE0YjkxZmM5ODdmZmE2MWRlZDgxZGExOTBlNWY1YTMyZThiNzk3Li41ZDA3ZWU0MTBkN2FmMzQx YzA4OGEyNzY3NGQxY2RmNDUwYWJiYjgyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKQEAgLTI1 MTgsNCArMjUxOCwzIEBAIGZhc3QvZXZlbnRzL3JlbW92ZS10YXJnZXQtaW4tbW91c2V1cC5odG1s CiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTMyMgogZmFzdC9l dmVudHMvc2VsZWN0c3RhcnQtYnktZG91YmxlLXRyaXBsZS1jbGlja3MuaHRtbAogZmFzdC9ldmVu dHMvc2VsZWN0c3RhcnQtYnktZHJhZy5odG1sCi1mYXN0L2V2ZW50cy9zZWxlY3RzdGFydC1ieS1z aW5nbGUtY2xpY2std2l0aC1zaGlmdC5odG1sCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTg5YmJmYjMyZjkyMjE2YjdiYmRjMzg0OTdkYzJkNzY5 ZTc5YzBjOC4uYmRlYmVjMDg4OGIyYWI2OWRhZTQ0MTE0ODlmYjI4MWRhOWQ3MjQzNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDExLTA1LTI0ICBSb2JlcnQgSG9nYW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFNlbGVjdHN0 YXJ0IGV2ZW50IHRlc3RzIGFkZGVkIGJ5IHI4NzA5NiBhcmUgZmFpbGluZyBvbiBRdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEzMjIKKworICAgICAg ICAqIER1bXBSZW5kZXJUcmVlL3F0L0V2ZW50U2VuZGVyUXQuY3BwOgorICAgICAgICAoZ2V0TW9k aWZpZXJzKTogc3RhdGljIGZ1bmN0aW9uIGZvciBpbnRlcnByZXRpbmcgbW9kaWZpZXJzCisgICAg ICAgIChFdmVudFNlbmRlcjo6bW91c2VEb3duKTogUmVzcGVjdCBrZXlib2FyZCBtb2RpZmllcnMK KyAgICAgICAgKEV2ZW50U2VuZGVyOjprZXlEb3duKTogdXNlIG5ldyBzdGF0aWMgZnVuY3Rpb24K KyAgICAgICAgKEV2ZW50U2VuZGVyOjpzZW5kT3JRdWV1ZUV2ZW50KTogd2hpdGVzcGFjZSBmaXgK KwogMjAxMS0wNS0yNCAgSmF5IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5k ZXJUcmVlL3F0L0V2ZW50U2VuZGVyUXQuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRXZl bnRTZW5kZXJRdC5jcHAKaW5kZXggOWUyYzhhYmQ3MjliNjViNDU5NDc0ZTE1NjJhNTJkYTA5Mzg5 NTQyZi4uMWVjYjczOTdiZGY4NzI0OGUzMWFiZDY0ZWQ5YmFmNTM1ZmQ5OTE4NSAxMDA2NDQKLS0t IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRXZlbnRTZW5kZXJRdC5jcHAKKysrIGIvVG9vbHMv RHVtcFJlbmRlclRyZWUvcXQvRXZlbnRTZW5kZXJRdC5jcHAKQEAgLTc0LDggKzc0LDI2IEBAIEV2 ZW50U2VuZGVyOjpFdmVudFNlbmRlcihRV2ViUGFnZSogcGFyZW50KQogICAgIFFBcHBsaWNhdGlv bjo6c2V0V2hlZWxTY3JvbGxMaW5lcygyKTsKIH0KIAotdm9pZCBFdmVudFNlbmRlcjo6bW91c2VE b3duKGludCBidXR0b24pCitzdGF0aWMgUXQ6OktleWJvYXJkTW9kaWZpZXJzIGdldE1vZGlmaWVy cyhjb25zdCBRU3RyaW5nTGlzdCYgbW9kaWZpZXJzKQogeworICAgIFF0OjpLZXlib2FyZE1vZGlm aWVycyBtb2RpZnMgPSAwOworICAgIGZvciAoaW50IGkgPSAwOyBpIDwgbW9kaWZpZXJzLnNpemUo KTsgKytpKSB7CisgICAgICAgIGNvbnN0IFFTdHJpbmcmIG0gPSBtb2RpZmllcnMuYXQoaSk7Cisg ICAgICAgIGlmIChtID09ICJjdHJsS2V5IikKKyAgICAgICAgICAgIG1vZGlmcyB8PSBRdDo6Q29u dHJvbE1vZGlmaWVyOworICAgICAgICBlbHNlIGlmIChtID09ICJzaGlmdEtleSIpCisgICAgICAg ICAgICBtb2RpZnMgfD0gUXQ6OlNoaWZ0TW9kaWZpZXI7CisgICAgICAgIGVsc2UgaWYgKG0gPT0g ImFsdEtleSIpCisgICAgICAgICAgICBtb2RpZnMgfD0gUXQ6OkFsdE1vZGlmaWVyOworICAgICAg ICBlbHNlIGlmIChtID09ICJtZXRhS2V5IikKKyAgICAgICAgICAgIG1vZGlmcyB8PSBRdDo6TWV0 YU1vZGlmaWVyOworICAgIH0KKyAgICByZXR1cm4gbW9kaWZzOworfQorCit2b2lkIEV2ZW50U2Vu ZGVyOjptb3VzZURvd24oaW50IGJ1dHRvbiwgY29uc3QgUVN0cmluZ0xpc3QmIG1vZGlmaWVycykK K3sKKyAgICBRdDo6S2V5Ym9hcmRNb2RpZmllcnMgbW9kaWZzID0gZ2V0TW9kaWZpZXJzKG1vZGlm aWVycyk7CiAgICAgUXQ6Ok1vdXNlQnV0dG9uIG1vdXNlQnV0dG9uOwogICAgIHN3aXRjaCAoYnV0 dG9uKSB7CiAgICAgY2FzZSAwOgpAQCAtMTE0LDExICsxMzIsMTEgQEAgdm9pZCBFdmVudFNlbmRl cjo6bW91c2VEb3duKGludCBidXR0b24pCiAgICAgaWYgKGlzR3JhcGhpY3NCYXNlZCgpKSB7CiAg ICAgICAgIGV2ZW50ID0gY3JlYXRlR3JhcGhpY3NTY2VuZU1vdXNlRXZlbnQoKG1fY2xpY2tDb3Vu dCA9PSAyKSA/CiAgICAgICAgICAgICAgICAgICAgIFFFdmVudDo6R3JhcGhpY3NTY2VuZU1vdXNl RG91YmxlQ2xpY2sgOiBRRXZlbnQ6OkdyYXBoaWNzU2NlbmVNb3VzZVByZXNzLAotICAgICAgICAg ICAgICAgICAgICBtX21vdXNlUG9zLCBtX21vdXNlUG9zLCBtb3VzZUJ1dHRvbiwgbV9tb3VzZUJ1 dHRvbnMsIFF0OjpOb01vZGlmaWVyKTsKKyAgICAgICAgICAgICAgICAgICAgbV9tb3VzZVBvcywg bV9tb3VzZVBvcywgbW91c2VCdXR0b24sIG1fbW91c2VCdXR0b25zLCBtb2RpZnMpOwogICAgIH0g ZWxzZSB7CiAgICAgICAgIGV2ZW50ID0gbmV3IFFNb3VzZUV2ZW50KChtX2NsaWNrQ291bnQgPT0g MikgPyBRRXZlbnQ6Ok1vdXNlQnV0dG9uRGJsQ2xpY2sgOgogICAgICAgICAgICAgICAgICAgICBR RXZlbnQ6Ok1vdXNlQnV0dG9uUHJlc3MsIG1fbW91c2VQb3MsIG1fbW91c2VQb3MsCi0gICAgICAg ICAgICAgICAgICAgIG1vdXNlQnV0dG9uLCBtX21vdXNlQnV0dG9ucywgUXQ6Ok5vTW9kaWZpZXIp OworICAgICAgICAgICAgICAgICAgICBtb3VzZUJ1dHRvbiwgbV9tb3VzZUJ1dHRvbnMsIG1vZGlm cyk7CiAgICAgfQogCiAgICAgc2VuZE9yUXVldWVFdmVudChldmVudCk7CkBAIC0yMjIsMTggKzI0 MCw3IEBAIHZvaWQgRXZlbnRTZW5kZXI6OmxlYXBGb3J3YXJkKGludCBtcykKIHZvaWQgRXZlbnRT ZW5kZXI6OmtleURvd24oY29uc3QgUVN0cmluZyYgc3RyaW5nLCBjb25zdCBRU3RyaW5nTGlzdCYg bW9kaWZpZXJzLCB1bnNpZ25lZCBpbnQgbG9jYXRpb24pCiB7CiAgICAgUVN0cmluZyBzID0gc3Ry aW5nOwotICAgIFF0OjpLZXlib2FyZE1vZGlmaWVycyBtb2RpZnMgPSAwOwotICAgIGZvciAoaW50 IGkgPSAwOyBpIDwgbW9kaWZpZXJzLnNpemUoKTsgKytpKSB7Ci0gICAgICAgIGNvbnN0IFFTdHJp bmcmIG0gPSBtb2RpZmllcnMuYXQoaSk7Ci0gICAgICAgIGlmIChtID09ICJjdHJsS2V5IikKLSAg ICAgICAgICAgIG1vZGlmcyB8PSBRdDo6Q29udHJvbE1vZGlmaWVyOwotICAgICAgICBlbHNlIGlm IChtID09ICJzaGlmdEtleSIpCi0gICAgICAgICAgICBtb2RpZnMgfD0gUXQ6OlNoaWZ0TW9kaWZp ZXI7Ci0gICAgICAgIGVsc2UgaWYgKG0gPT0gImFsdEtleSIpCi0gICAgICAgICAgICBtb2RpZnMg fD0gUXQ6OkFsdE1vZGlmaWVyOwotICAgICAgICBlbHNlIGlmIChtID09ICJtZXRhS2V5IikKLSAg ICAgICAgICAgIG1vZGlmcyB8PSBRdDo6TWV0YU1vZGlmaWVyOwotICAgIH0KKyAgICBRdDo6S2V5 Ym9hcmRNb2RpZmllcnMgbW9kaWZzID0gZ2V0TW9kaWZpZXJzKG1vZGlmaWVycyk7CiAgICAgaWYg KGxvY2F0aW9uID09IDMpCiAgICAgICAgIG1vZGlmcyB8PSBRdDo6S2V5cGFkTW9kaWZpZXI7CiAg ICAgaW50IGNvZGUgPSAwOwpAQCAtNTM2LDEwICs1NDMsMTAgQEAgcmVkbzoKIAogdm9pZCBFdmVu dFNlbmRlcjo6c2VuZE9yUXVldWVFdmVudChRRXZlbnQqIGV2ZW50KQogewotICAgIC8vIE1vdXNl IG1vdmUgZXZlbnRzIGFyZSBxdWV1ZWQgaWYgCisgICAgLy8gTW91c2UgbW92ZSBldmVudHMgYXJl IHF1ZXVlZCBpZgogICAgIC8vIDEuIEEgcHJldmlvdXMgZXZlbnQgd2FzIHF1ZXVlZC4KICAgICAv LyAyLiBBIGRlbGF5IHdhcyBzZXQtdXAgYnkgbGVhcEZvcndhcmQoKS4KLSAgICAvLyAzLiBBIGNh bGwgdG8gbW91c2VNb3ZlVG8gd2hpbGUgdGhlIG1vdXNlIGJ1dHRvbiBpcyBwcmVzc2VkIGNvdWxk IGluaXRpYXRlIGEgZHJhZyBvcGVyYXRpb24sIGFuZCB0aGF0IGRvZXMgbm90IHJldHVybiB1bnRp bCBtb3VzZVVwIGlzIHByb2Nlc3NlZC4gCisgICAgLy8gMy4gQSBjYWxsIHRvIG1vdXNlTW92ZVRv IHdoaWxlIHRoZSBtb3VzZSBidXR0b24gaXMgcHJlc3NlZCBjb3VsZCBpbml0aWF0ZSBhIGRyYWcg b3BlcmF0aW9uLCBhbmQgdGhhdCBkb2VzIG5vdCByZXR1cm4gdW50aWwgbW91c2VVcCBpcyBwcm9j ZXNzZWQuCiAgICAgLy8gVG8gYmUgc2FmZSBhbmQgYXZvaWQgYSBkZWFkbG9jaywgdGhpcyBldmVu dCBpcyBxdWV1ZWQuCiAgICAgaWYgKGVuZE9mUXVldWUgPT0gc3RhcnRPZlF1ZXVlICYmICFldmVu dFF1ZXVlW2VuZE9mUXVldWVdLm1fZGVsYXkgJiYgKCEobV9tb3VzZUJ1dHRvblByZXNzZWQgJiYg KG1fZXZlbnRMb29wICYmIGV2ZW50LT50eXBlKCkgPT0gUUV2ZW50OjpNb3VzZUJ1dHRvblJlbGVh c2UpKSkpIHsKICAgICAgICAgc2VuZEV2ZW50KG1fcGFnZS0+dmlldygpLCBldmVudCk7Cg==