6132 2005-12-18 09:21:18 -0800 Incorrect selection highlighting for ATSUI text when selected range is "CG-safe" 2005-12-19 23:23:02 -0800 1 1 1 Unclassified WebKit Layout and Rendering 420+ Mac OS X 10.4 VERIFIED FIXED P2 Normal --- 5166 1 mitz webkit-unassigned oldest_to_newest 26112 0 mitz 2005-12-18 09:21:18 -0800 [Split off from bug 5166] Summary: The selection highlight is partial or offset when the selection consists of "CG-safe" characters only but it is preceded by "need-ATSUI" characters. To reproduce: double-click "dolor" in the testcase. The position of the highlight rectangle depends on the width of all text before the selection, so the ATSUI code path should be used to draw the highlight even if the selected range itself does not require ATSUI. The same applies to drawing text for the drag image when dragging a partial selection. The fix for both is to change shouldUseATSU to always scan from the beginning. This should not affect layout and rendering performance, since run->from is zero anyway in all but the above two cases. 26113 1 5133 mitz 2005-12-18 09:23:16 -0800 Created attachment 5133 testcase 26115 2 5134 mitz 2005-12-18 09:41:11 -0800 Created attachment 5134 patch (incl. layout test) Pixel mode required to detect regressions. 26134 3 5134 mitz 2005-12-18 14:14:02 -0800 Comment on attachment 5134 patch (incl. layout test) The code changes in this patch are identical to those in attachment 4965. 26141 4 5134 darin 2005-12-18 14:31:50 -0800 Comment on attachment 5134 patch (incl. layout test) r=me 5133 2005-12-18 09:23:16 -0800 2005-12-18 09:23:16 -0800 testcase 6132_testcase.html text/html 191 mitz PGh0bWw+CjxoZWFkPgo8dGl0bGU+PC90aXRsZT4KPC9oZWFkPgo8Ym9keT4KRG91YmxlLWNsaWNr IG9yIGRyYWcgdG8gc2VsZWN0ICZsZHF1bztkb2xvciZyZHF1bzsgYmVsb3cuIFRyeSBkcmFnZ2lu ZyB0aGUgc2VsZWN0ZWQgd29yZC4KPGhyPgpMbyYjeDAzMDg7cmUmI3gwMzAwO20gaXBzdW0gZG9s b3Igc2l0IGFtZXQKPC9ib2R5Pgo= 5134 2005-12-18 09:41:11 -0800 2005-12-18 14:31:50 -0800 patch (incl. layout test) 6132_r1.patch text/plain 6275 mitz SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jv b3QvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE2MgpkaWZm IC1wIC11IC1yMS4xNjIgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCi0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJMTcgRGVjIDIwMDUgMTg6MTA6MzUgLTAwMDAJMS4xNjIKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkxOCBEZWMgMjAwNSAxNzo0MjoyNyAtMDAwMApAQCAtMSwzICsxLDE1IEBACisyMDA1 LTEyLSMjICBNaXR6IFBldHRlbCAgPG9wZW5kYXJ3aW4ub3JnQG1pdHpwZXR0ZWwuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gdGVzdCBmb3Ig aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD02MTMyCisgICAg ICAgICAgSW5jb3JyZWN0IHNlbGVjdGlvbiBoaWdobGlnaHRpbmcgZm9yIEFUU1VJIHRleHQgd2hl biBzZWxlY3RlZCByYW5nZSBpcyAiQ0ctc2FmZSIKKworICAgICAgICAqIGZhc3QvdGV4dC9zaG91 bGQtdXNlLWF0c3VpLWV4cGVjdGVkLmNoZWNrc3VtOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3Rl eHQvc2hvdWxkLXVzZS1hdHN1aS1leHBlY3RlZC5wbmc6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv dGV4dC9zaG91bGQtdXNlLWF0c3VpLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFz dC90ZXh0L3Nob3VsZC11c2UtYXRzdWkuaHRtbDogQWRkZWQuCisKIDIwMDUtMTItMTcgIE1pdHog UGV0dGVsICA8b3BlbmRhcndpbi5vcmdAbWl0enBldHRlbC5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYW5kIGxhbmRlZCBieSBEYXJpbi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdGV4dC9zaG91 bGQtdXNlLWF0c3VpLWV4cGVjdGVkLmNoZWNrc3VtCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KZGlmZiAtTnB1IExheW91 dFRlc3RzL2Zhc3QvdGV4dC9zaG91bGQtdXNlLWF0c3VpLWV4cGVjdGVkLmNoZWNrc3VtCi0tLSBM YXlvdXRUZXN0cy9mYXN0L3RleHQvc2hvdWxkLXVzZS1hdHN1aS1leHBlY3RlZC5jaGVja3N1bQkx IEphbiAxOTcwIDAwOjAwOjAwIC0wMDAwCisrKyBMYXlvdXRUZXN0cy9mYXN0L3RleHQvc2hvdWxk LXVzZS1hdHN1aS1leHBlY3RlZC5jaGVja3N1bQkxOCBEZWMgMjAwNSAxNzoyNjo0OSAtMDAwMApA QCAtMCwwICsxIEBACis0YjZlZmRkM2ZkM2YxN2VjNjE0NDlmNGY1M2JjY2QyNApcIE5vIG5ld2xp bmUgYXQgZW5kIG9mIGZpbGUKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvdGV4dC9zaG91bGQtdXNl LWF0c3VpLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09CmRpZmYgLU5wdSBMYXlvdXRUZXN0cy9mYXN0 L3RleHQvc2hvdWxkLXVzZS1hdHN1aS1leHBlY3RlZC50eHQKLS0tIExheW91dFRlc3RzL2Zhc3Qv dGV4dC9zaG91bGQtdXNlLWF0c3VpLWV4cGVjdGVkLnR4dAkxIEphbiAxOTcwIDAwOjAwOjAwIC0w MDAwCisrKyBMYXlvdXRUZXN0cy9mYXN0L3RleHQvc2hvdWxkLXVzZS1hdHN1aS1leHBlY3RlZC50 eHQJMTggRGVjIDIwMDUgMTc6MjY6NDkgLTAwMDAKQEAgLTAsMCArMSwyNyBAQAorRURJVElORyBE RUxFR0FURTogd2ViVmlld0RpZENoYW5nZVNlbGVjdGlvbjpXZWJWaWV3RGlkQ2hhbmdlU2VsZWN0 aW9uTm90aWZpY2F0aW9uCitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyQ2Fu dmFzIGF0ICgwLDApIHNpemUgODAweDYwMAorbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisg IFJlbmRlckJsb2NrIHtIVE1MfSBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgICBSZW5kZXJCb2R5 IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4NHg1ODQKKyAgICAgIFJlbmRlckJsb2NrIHtQfSBhdCAo MCwwKSBzaXplIDc4NHgzNgorICAgICAgICBSZW5kZXJUZXh0IHtURVhUfSBhdCAoMCwwKSBzaXpl IDUzeDE4CisgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggNTM6ICJUZXN0IGZvciAi CisgICAgICAgIFJlbmRlcklubGluZSB7SX0gYXQgKDAsMCkgc2l6ZSA3MzZ4MzYKKyAgICAgICAg ICBSZW5kZXJUZXh0IHtURVhUfSBhdCAoNTMsMCkgc2l6ZSA3MzZ4MzYKKyAgICAgICAgICAgIHRl eHQgcnVuIGF0ICg1MywwKSB3aWR0aCA2ODM6ICJodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5v cmcvc2hvd19idWcuY2dpP2lkPTYxMzIgSW5jb3JyZWN0IHNlbGVjdGlvbiBoaWdobGlnaHRpbmcg Zm9yIEFUU1VJIHRleHQgd2hlbiIKKyAgICAgICAgICAgIHRleHQgcnVuIGF0ICgwLDE4KSB3aWR0 aCAxNzY6ICJzZWxlY3RlZCByYW5nZSBpcyBcIkNHLXNhZmVcIiIKKyAgICAgICAgUmVuZGVyVGV4 dCB7VEVYVH0gYXQgKDE3NiwxOCkgc2l6ZSA0eDE4CisgICAgICAgICAgdGV4dCBydW4gYXQgKDE3 NiwxOCkgd2lkdGggNDogIi4iCisgICAgICBSZW5kZXJCbG9jayB7UH0gYXQgKDAsNTIpIHNpemUg Nzg0eDE4CisgICAgICAgIFJlbmRlclRleHQge1RFWFR9IGF0ICgwLDApIHNpemUgNzA5eDE4Cisg ICAgICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggNzA5OiAiVGhlIHdvcmQgXHh7MjAxQ31k b2xvclx4ezIwMUR9IGJlbG93IHNob3VsZCBiZSBoaWdobGlnaHRlZCBpbiBpdHMgZW50aXJldHku IFRoZSBoaWdobGlnaHQgc2hvdWxkIG5vdCBleHRlbmQgYmV5b25kIHRoYXQgd29yZC4iCisgICAg ICBSZW5kZXJCbG9jayB7SFJ9IGF0ICgwLDg2KSBzaXplIDc4NHgyIFtib3JkZXI6ICgxcHggaW5z ZXQgIzAwMDAwMCldCisgICAgICBSZW5kZXJCbG9jayAoYW5vbnltb3VzKSBhdCAoMCw5Nikgc2l6 ZSA3ODR4MTgKKyAgICAgICAgUmVuZGVySW5saW5lIHtTUEFOfSBhdCAoMCwwKSBzaXplIDE3M3gx OAorICAgICAgICAgIFJlbmRlclRleHQge1RFWFR9IGF0ICgwLDApIHNpemUgMTczeDE4CisgICAg ICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAxNzM6ICJMb1x4ezMwOH1yZVx4ezMwMH1t IGlwc3VtIGRvbG9yIHNpdCBhbWV0IgorICAgICAgICBSZW5kZXJUZXh0IHtURVhUfSBhdCAoMCww KSBzaXplIDB4MAorICAgICAgICBSZW5kZXJUZXh0IHtURVhUfSBhdCAoMCwwKSBzaXplIDB4MAor c2VsZWN0aW9uIHN0YXJ0OiBwb3NpdGlvbiAxNCBvZiBjaGlsZCAwIHtURVhUfSBvZiBjaGlsZCA3 IHtTUEFOfSBvZiBjaGlsZCAxIHtCT0RZfSBvZiBjaGlsZCAwIHtIVE1MfSBvZiBkb2N1bWVudAor c2VsZWN0aW9uIGVuZDogICBwb3NpdGlvbiAxOSBvZiBjaGlsZCAwIHtURVhUfSBvZiBjaGlsZCA3 IHtTUEFOfSBvZiBjaGlsZCAxIHtCT0RZfSBvZiBjaGlsZCAwIHtIVE1MfSBvZiBkb2N1bWVudApJ bmRleDogTGF5b3V0VGVzdHMvZmFzdC90ZXh0L3Nob3VsZC11c2UtYXRzdWkuaHRtbAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09CmRpZmYgLU5wdSBMYXlvdXRUZXN0cy9mYXN0L3RleHQvc2hvdWxkLXVzZS1hdHN1aS5odG1s Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L3RleHQvc2hvdWxkLXVzZS1hdHN1aS5odG1sCTEgSmFuIDE5 NzAgMDA6MDA6MDAgLTAwMDAKKysrIExheW91dFRlc3RzL2Zhc3QvdGV4dC9zaG91bGQtdXNlLWF0 c3VpLmh0bWwJMTggRGVjIDIwMDUgMTc6MjU6MzcgLTAwMDAKQEAgLTAsMCArMSwyNCBAQAorPGh0 bWw+Cis8aGVhZD4KKzx0aXRsZT48L3RpdGxlPgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3Jp cHQiPgorZnVuY3Rpb24gdGVzdCgpCit7CisgICAgdmFyIHQgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgidCIpLmZpcnN0Q2hpbGQ7CisgICAgd2luZG93LmdldFNlbGVjdGlvbigpLnNldEJhc2VB bmRFeHRlbnQodCwgMTQsIHQsIDE5KTsKK30KKzwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25s b2FkPSJ0ZXN0KCkiPgorPHA+CitUZXN0IGZvciA8aT5odHRwOi8vYnVnemlsbGEub3BlbmRhcndp bi5vcmcvc2hvd19idWcuY2dpP2lkPTYxMzIKK0luY29ycmVjdCBzZWxlY3Rpb24gaGlnaGxpZ2h0 aW5nIGZvciBBVFNVSSB0ZXh0IHdoZW4gc2VsZWN0ZWQgcmFuZ2UgaXMKKyJDRy1zYWZlIjwvaT4u Cis8L3A+Cis8cD4KK1RoZSB3b3JkICZsZHF1bztkb2xvciZyZHF1bzsgYmVsb3cgc2hvdWxkIGJl IGhpZ2hsaWdodGVkIGluIGl0cyBlbnRpcmV0eS4gVGhlCitoaWdobGlnaHQgc2hvdWxkIG5vdCBl eHRlbmQgYmV5b25kIHRoYXQgd29yZC4KKzwvcD4KKzxocj4KKzxzcGFuIGlkPSJ0Ij5MbyYjeDAz MDg7cmUmI3gwMzAwO20gaXBzdW0gZG9sb3Igc2l0IGFtZXQ8L3NwYW4+Cis8L2JvZHk+CkluZGV4 OiBXZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJLaXQv Q2hhbmdlTG9nLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjM0MDcKZGlmZiAtcCAtdSAtcjEuMzQw NyBXZWJLaXQvQ2hhbmdlTG9nCi0tLSBXZWJLaXQvQ2hhbmdlTG9nCTE3IERlYyAyMDA1IDE4OjEw OjI3IC0wMDAwCTEuMzQwNworKysgV2ViS2l0L0NoYW5nZUxvZwkxOCBEZWMgMjAwNSAxNzo0NDo0 MCAtMDAwMApAQCAtMSwzICsxLDE2IEBACisyMDA1LTEyLSMjICBNaXR6IFBldHRlbCAgPG9wZW5k YXJ3aW4ub3JnQG1pdHpwZXR0ZWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorICAgICAgICAKKyAgICAgICAgVGVzdDogZmFzdC90ZXh0L3Nob3VsZC11c2UtYXRz dWkuaHRtbAorCisgICAgICAgIC0gZml4IGZvciBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5v cmcvc2hvd19idWcuY2dpP2lkPTYxMzIKKyAgICAgICAgICBJbmNvcnJlY3Qgc2VsZWN0aW9uIGhp Z2hsaWdodGluZyBmb3IgQVRTVUkgdGV4dCB3aGVuIHNlbGVjdGVkIHJhbmdlIGlzICJDRy1zYWZl IgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVuZGVyZXIubToK KyAgICAgICAgKHNob3VsZFVzZUFUU1UpOiBBbHdheXMgc3RhcnQgc2Nhbm5pbmcgZnJvbSAwIHNp bmNlIGRyYXdpbmcgYW5kCisgICAgICAgIGhpZ2hsaWdodGluZyBhbHNvIG1lYXN1cmUgZXZlcnl0 aGluZyB1cCB0byBydW4tPmZyb20uCisKIDIwMDUtMTItMTcgIE1pdHogUGV0dGVsICA8b3BlbmRh cndpbi5vcmdAbWl0enBldHRlbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYW5kIGxhbmRlZCBi eSBEYXJpbi4KSW5kZXg6IFdlYktpdC9XZWJDb3JlU3VwcG9ydC5zdWJwcm9qL1dlYlRleHRSZW5k ZXJlci5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9XZWJLaXQvV2ViQ29yZVN1cHBv cnQuc3VicHJvai9XZWJUZXh0UmVuZGVyZXIubSx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4yMDMK ZGlmZiAtcCAtdSAtcjEuMjAzIFdlYktpdC9XZWJDb3JlU3VwcG9ydC5zdWJwcm9qL1dlYlRleHRS ZW5kZXJlci5tCi0tLSBXZWJLaXQvV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVuZGVy ZXIubQkxNyBEZWMgMjAwNSAxODoxMDozNCAtMDAwMAkxLjIwMworKysgV2ViS2l0L1dlYkNvcmVT dXBwb3J0LnN1YnByb2ovV2ViVGV4dFJlbmRlcmVyLm0JMTggRGVjIDIwMDUgMTc6NDU6MjcgLTAw MDAKQEAgLTE4NTksNyArMTg1OSw4IEBAIHN0YXRpYyBib29sIHNob3VsZFVzZUFUU1UoY29uc3Qg V2ViQ29yZVQKICAgICBjb25zdCBVbmlDaGFyICpjaGFyYWN0ZXJzID0gcnVuLT5jaGFyYWN0ZXJz OwogICAgIGludCB0byA9IHJ1bi0+dG87CiAgICAgaW50IGk7Ci0gICAgZm9yIChpID0gcnVuLT5m cm9tOyBpIDwgdG87IGkrKykgeworICAgIC8vIFN0YXJ0IGZyb20gMCBzaW5jZSBkcmF3aW5nIGFu ZCBoaWdobGlnaHRpbmcgYWxzbyBtZWFzdXJlIHRoZSBjaGFyYWN0ZXJzIGJlZm9yZSBydW4tPmZy b20KKyAgICBmb3IgKGkgPSAwOyBpIDwgdG87IGkrKykgewogICAgICAgICBVbmlDaGFyIGMgPSBj aGFyYWN0ZXJzW2ldOwogICAgICAgICBpZiAoYyA8IDB4MzAwKSAgICAgIC8vIFUrMDMwMCB0aHJv dWdoIFUrMDM2RiBDb21iaW5pbmcgZGlhY3JpdGljYWwgbWFya3MKICAgICAgICAgICAgIGNvbnRp bnVlOwo=