61314 2011-05-23 15:21:04 -0700 [Qt] QtWebKit crashes when dragging not loaded images 2011-05-26 08:56:47 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 1 igor.oliveira igor.oliveira ademar benjamin commit-queue diegohcg eric pnormand simon.fraser tonikitoo webkit.review.bot oldest_to_newest 408386 0 igor.oliveira 2011-05-23 15:21:04 -0700 QtWebKit crashes when dragging not loaded images. 408387 1 94500 igor.oliveira 2011-05-23 15:22:17 -0700 Created attachment 94500 Test Case To reproduce the bug try to drag the image when the page is loading. 408390 2 94502 igor.oliveira 2011-05-23 15:27:27 -0700 Created attachment 94502 Patch Proposed patch 408395 3 webkit.review.bot 2011-05-23 15:32:23 -0700 Attachment 94502 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/qt/DragImageQt.cpp:66: Declaration has space between type name and * in QPixmap *dragImage [whitespace/declaration] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 408405 4 94507 igor.oliveira 2011-05-23 15:43:50 -0700 Created attachment 94507 Patch Proposed patch. 408445 5 94507 menard 2011-05-23 16:10:51 -0700 Comment on attachment 94507 Patch Looks good but can you do a layout test? I know drag and drop are tricky but is there any existing drag and drop tests you could reuse? 408772 6 94507 kling 2011-05-24 04:30:09 -0700 Comment on attachment 94507 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94507&action=review Good catch! Needs a test though. > Source/WebCore/platform/qt/DragImageQt.cpp:70 > - if (!image) > - return 0; > + QPixmap* dragImage = 0; > + if (image && image->nativeImageForCurrentFrame()) > + dragImage = new QPixmap(*image->nativeImageForCurrentFrame()); > > - return new QPixmap(*image->nativeImageForCurrentFrame()); > + return dragImage; This would read better as: if (!image || !image->nativeImageForCurrentFrame()) return 0; return new QPixmap(*image->nativeImageForCurrentFrame()); 409258 7 94702 igor.oliveira 2011-05-24 15:19:34 -0700 Created attachment 94702 Patch Proposed patch. Add test. 409615 8 94702 menard 2011-05-25 07:01:10 -0700 Comment on attachment 94702 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94702&action=review > LayoutTests/ChangeLog:8 > + Checks if WebKit crashes when dragging a not loaded image. dragging an image not yet loaded. better no? 409618 9 94778 igor.oliveira 2011-05-25 07:05:40 -0700 Created attachment 94778 Patch Proposed patch. 409688 10 94778 commit-queue 2011-05-25 09:34:09 -0700 Comment on attachment 94778 Patch Clearing flags on attachment: 94778 Committed r87298: <http://trac.webkit.org/changeset/87298> 409689 11 commit-queue 2011-05-25 09:34:14 -0700 All reviewed patches have been landed. Closing bug. 410152 12 simon.fraser 2011-05-25 20:33:22 -0700 This test is crashing on Mac too. Seems like other platforms need a similar fix. 410154 13 simon.fraser 2011-05-25 20:34:20 -0700 I filed bug 61499. 410164 14 tonikitoo 2011-05-25 20:57:27 -0700 It was failing on Qt and no bot email/bug_comment was added to this bug, as it usually happen. Failing on Mac too (according to Simon and nothing yet from the emailer bot). Maybe there is a problem with them? 410312 15 pnormand 2011-05-26 02:30:15 -0700 Filed bug 61513 for GTK 410327 16 igor.oliveira 2011-05-26 03:07:21 -0700 After http://trac.webkit.org/changeset/87366 , mac is not failing anymore. 410473 17 ademar 2011-05-26 08:56:47 -0700 Revision r87298 cherry-picked into qtwebkit-2.2 with commit 8cfca23 <http://gitorious.org/webkit/qtwebkit/commit/8cfca23> 94500 2011-05-23 15:22:17 -0700 2011-05-23 15:22:17 -0700 Test Case index.html text/html 184 igor.oliveira PGh0bWw+CjxoZWFkPgo8Ym9keT4KPGltYWdlIHNyYz0iaHR0cDovL3Z1bGNhbi53ci51c2dzLmdv di9JbWdzL0pwZy9OZXdiZXJyeS9JbWFnZXMvTmV3YmVycnk4N19hZXJpYWxfYmlnX29ic2lkaWFu X2Zsb3dfMTAtODcuanBnIiB3aWR0aD0iMzU5NSIgaGVpZ2h0PSIyNDMxIi8+CjwvYm9keT4KPC9o ZWFkPgo8L2h0bWw+Cg== 94502 2011-05-23 15:27:27 -0700 2011-05-23 15:43:50 -0700 Patch 0001-Qt-QtWebKit-crashes-when-dragging-not-loaded-images.patch text/plain 1788 igor.oliveira RnJvbSA4YjcwZjg3Y2NmMzQ2N2U2MGVlODY5OGE3MDQ1NjUwYzYwNzU4YjVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJZ29yIE9saXZlaXJhIDxpZ29yLm9saXZlaXJhQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IE1vbiwgMjMgTWF5IDIwMTEgMTg6MjM6MTEgLTA0MDAKU3ViamVjdDogW1BB VENIXSBbUXRdIFF0V2ViS2l0IGNyYXNoZXMgd2hlbiBkcmFnZ2luZyBub3QgbG9hZGVkIGltYWdl cwoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgfCAgIDEy ICsrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvRHJhZ0ltYWdlUXQuY3Bw IHwgICAgNyArKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDFkZTYzZGYuLjY0NDAwMjkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wNS0yMyAgSWdvciBPbGl2ZWlyYSAgPGlnb3Iub2xpdmVpcmFA b3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbUXRdIFF0V2ViS2l0IGNyYXNoZXMgd2hlbiBkcmFnZ2luZyBub3QgbG9hZGVkIGlt YWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEz MTQKKworICAgICAgICBDaGVja3MgaWYgbmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUgaXMgYSB2 YWxpZCBwb2ludGVyLgorCisgICAgICAgICogcGxhdGZvcm0vcXQvRHJhZ0ltYWdlUXQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlRHJhZ0ltYWdlRnJvbUltYWdlKToKKwogMjAxMS0wNS0x NiAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vcXQvRHJhZ0ltYWdlUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQv RHJhZ0ltYWdlUXQuY3BwCmluZGV4IDkwYjFiYmMuLmJlZDJmNDggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3F0L0RyYWdJbWFnZVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9xdC9EcmFnSW1hZ2VRdC5jcHAKQEAgLTYzLDEwICs2MywxMSBAQCBEcmFnSW1h Z2VSZWYgZGlzc29sdmVEcmFnSW1hZ2VUb0ZyYWN0aW9uKERyYWdJbWFnZVJlZiBpbWFnZSwgZmxv YXQpCiAKIERyYWdJbWFnZVJlZiBjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UoSW1hZ2UqIGltYWdl KQogewotICAgIGlmICghaW1hZ2UpCi0gICAgICAgIHJldHVybiAwOworICAgIFFQaXhtYXAgKmRy YWdJbWFnZSA9IDA7CisgICAgaWYgKGltYWdlICYmIGltYWdlLT5uYXRpdmVJbWFnZUZvckN1cnJl bnRGcmFtZSgpKQorICAgICAgICBkcmFnSW1hZ2UgPSBuZXcgUVBpeG1hcCgqaW1hZ2UtPm5hdGl2 ZUltYWdlRm9yQ3VycmVudEZyYW1lKCkpOwogCi0gICAgcmV0dXJuIG5ldyBRUGl4bWFwKCppbWFn ZS0+bmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKSk7CisgICAgcmV0dXJuIGRyYWdJbWFnZTsK IH0KIAogRHJhZ0ltYWdlUmVmIGNyZWF0ZURyYWdJbWFnZUljb25Gb3JDYWNoZWRJbWFnZShDYWNo ZWRJbWFnZSopCi0tIAoxLjcuMQoK 94507 2011-05-23 15:43:50 -0700 2011-05-24 15:19:34 -0700 Patch 0001-Qt-QtWebKit-crashes-when-dragging-not-loaded-images.patch text/plain 1788 igor.oliveira RnJvbSA1YmQ4MmRjY2E2Y2E1ODFhMGRmYmNhOTBhMTA5YWI1MWRmMmMxYWM1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJZ29yIE9saXZlaXJhIDxpZ29yLm9saXZlaXJhQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IE1vbiwgMjMgTWF5IDIwMTEgMTg6MjM6MTEgLTA0MDAKU3ViamVjdDogW1BB VENIXSBbUXRdIFF0V2ViS2l0IGNyYXNoZXMgd2hlbiBkcmFnZ2luZyBub3QgbG9hZGVkIGltYWdl cwoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgfCAgIDEy ICsrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvRHJhZ0ltYWdlUXQuY3Bw IHwgICAgNyArKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDMgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDFkZTYzZGYuLjY0NDAwMjkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMS0wNS0yMyAgSWdvciBPbGl2ZWlyYSAgPGlnb3Iub2xpdmVpcmFA b3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbUXRdIFF0V2ViS2l0IGNyYXNoZXMgd2hlbiBkcmFnZ2luZyBub3QgbG9hZGVkIGlt YWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEz MTQKKworICAgICAgICBDaGVja3MgaWYgbmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUgaXMgYSB2 YWxpZCBwb2ludGVyLgorCisgICAgICAgICogcGxhdGZvcm0vcXQvRHJhZ0ltYWdlUXQuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6Y3JlYXRlRHJhZ0ltYWdlRnJvbUltYWdlKToKKwogMjAxMS0wNS0x NiAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBZdXJ5IFNlbWlraGF0c2t5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vcXQvRHJhZ0ltYWdlUXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQv RHJhZ0ltYWdlUXQuY3BwCmluZGV4IDkwYjFiYmMuLjkxYTA4YzUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3F0L0RyYWdJbWFnZVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9xdC9EcmFnSW1hZ2VRdC5jcHAKQEAgLTYzLDEwICs2MywxMSBAQCBEcmFnSW1h Z2VSZWYgZGlzc29sdmVEcmFnSW1hZ2VUb0ZyYWN0aW9uKERyYWdJbWFnZVJlZiBpbWFnZSwgZmxv YXQpCiAKIERyYWdJbWFnZVJlZiBjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UoSW1hZ2UqIGltYWdl KQogewotICAgIGlmICghaW1hZ2UpCi0gICAgICAgIHJldHVybiAwOworICAgIFFQaXhtYXAqIGRy YWdJbWFnZSA9IDA7CisgICAgaWYgKGltYWdlICYmIGltYWdlLT5uYXRpdmVJbWFnZUZvckN1cnJl bnRGcmFtZSgpKQorICAgICAgICBkcmFnSW1hZ2UgPSBuZXcgUVBpeG1hcCgqaW1hZ2UtPm5hdGl2 ZUltYWdlRm9yQ3VycmVudEZyYW1lKCkpOwogCi0gICAgcmV0dXJuIG5ldyBRUGl4bWFwKCppbWFn ZS0+bmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKSk7CisgICAgcmV0dXJuIGRyYWdJbWFnZTsK IH0KIAogRHJhZ0ltYWdlUmVmIGNyZWF0ZURyYWdJbWFnZUljb25Gb3JDYWNoZWRJbWFnZShDYWNo ZWRJbWFnZSopCi0tIAoxLjcuMQoK 94702 2011-05-24 15:19:34 -0700 2011-05-25 07:05:40 -0700 Patch 0001-Qt-QtWebKit-crashes-when-dragging-not-loaded-images.patch text/plain 4551 igor.oliveira RnJvbSAzMDgwZTMxYzNiZDdjMDU2N2VjNWY5N2JlODczZGZlZDFiYzM4NmRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJZ29yIE9saXZlaXJhIDxpZ29yLm9saXZlaXJhQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IFR1ZSwgMjQgTWF5IDIwMTEgMTg6MTQ6NDEgLTA0MDAKU3ViamVjdDogW1BB VENIXSBbUXRdIFF0V2ViS2l0IGNyYXNoZXMgd2hlbiBkcmFnZ2luZyBub3QgbG9hZGVkIGltYWdl cwoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB8ICAgMTIgKysrKysKIC4uLi90ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1pbWFnZS1leHBl Y3RlZC50eHQgIHwgICAgMyArCiAuLi4vaHR0cC90ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1p bWFnZS5odG1sICAgICB8ICAgNDUgKysrKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysKIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3F0L0RyYWdJbWFnZVF0LmNwcCAgICAgICAgIHwgICAgMiArLQog NSBmaWxlcyBjaGFuZ2VkLCA3NSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQogY3JlYXRl IG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9kcmFnLW5vdC1sb2FkZWQt aW1hZ2UtZXhwZWN0ZWQudHh0CiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1pbWFnZS5odG1sCgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDFmN2VhMWYuLmU2 ZjgxNWMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wNS0yNCAgSWdvciBPbGl2ZWlyYSAg PGlnb3Iub2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFF0V2ViS2l0IGNyYXNoZXMgd2hlbiBkcmFnZ2lu ZyBub3QgbG9hZGVkIGltYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjEzMTQKKworICAgICAgICBDaGVja3MgaWYgV2ViS2l0IGNyYXNoZXMgd2hl biBkcmFnZ2luZyBhIG5vdCBsb2FkZWQgaW1hZ2UuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21p c2MvZHJhZy1ub3QtbG9hZGVkLWltYWdlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog aHR0cC90ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1pbWFnZS5odG1sOiBBZGRlZC4KKwogMjAx MS0wNS0xOCAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBS ZW1vdmUgd2hpdGVzcGFjZSBmcm9tIHRoZSBsaW5lIG9mIGZhc3QvZm9ybXMvVmFsaWRpdHlTdGF0 ZS12YWx1ZU1pc3NpbmctMDAyLmh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvbWlzYy9kcmFnLW5vdC1sb2FkZWQtaW1hZ2UtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv aHR0cC90ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1pbWFnZS1leHBlY3RlZC50eHQKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNzQ3NTBmMwotLS0gL2Rldi9udWxsCisrKyBi L0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9kcmFnLW5vdC1sb2FkZWQtaW1hZ2UtZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorCitTdWNjZXNzCisKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvbWlzYy9kcmFnLW5vdC1sb2FkZWQtaW1hZ2UuaHRtbCBiL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvbWlzYy9kcmFnLW5vdC1sb2FkZWQtaW1hZ2UuaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi4xNDhjYzVkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1pbWFnZS5odG1sCkBAIC0w LDAgKzEsNDUgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRU ZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUo KTsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cit9CisKK2Z1bmN0aW9u IGxvZyh0ZXh0KQoreworICAgIHZhciBjb25zb2xlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J2NvbnNvbGUnKTsKKyAgICBjb25zb2xlLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHRO b2RlKHRleHQpKTsKKyAgICBjb25zb2xlLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1l bnQoJ2JyJykpOworfQorPC9zY3JpcHQ+Cis8Ym9keT4KKzxpbWcgaWQ9ImltYWdlU2xvdyIgCisg ICAgIHNyYz0icmVzb3VyY2VzL2ltYWdlLXNsb3cucGwiIHdpZHRoPSIxMjgiIGhlaWdodD0iMTI4 Ij4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdCBsYW5ndWFnZT0iSmF2YVNjcmlw dCI+IAorICAgIHZhciBlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImltYWdlU2xvdyIpOwor ICAgIHZhciBpID0gMDsKKyAgICBmdW5jdGlvbiBydW5UZXN0KCkgeworICAgICAgICByZWFkeVN0 YXRlID0gZG9jdW1lbnQucmVhZHlTdGF0ZTsKKyAgICAgICAgaWYgKHJlYWR5U3RhdGUgPT0gJ2Nv bXBsZXRlJykgeworICAgICAgICAgICAgbG9nKCJTdWNjZXNzIikKKyAgICAgICAgICAgIGxheW91 dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKQorICAgICAgICB9IGVsc2UgaWYgKHJlYWR5U3Rh dGUgPT0gJ2xvYWRpbmcnIHx8IHJlYWR5U3RhdGUgPT0gJ2ludGVyYWN0aXZlJykgeworICAgICAg ICAgICAgeCA9IGUub2Zmc2V0TGVmdCArIGUub2Zmc2V0V2lkdGggLyAyOworICAgICAgICAgICAg eSA9IGUub2Zmc2V0VG9wICsgZS5vZmZzZXRIZWlnaHQgLyAyOworICAgIAorICAgICAgICAgICAg ZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oeCwgeSk7CisgICAgICAgICAgICBldmVudFNlbmRlci5t b3VzZURvd24oKTsgICAgCisgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyh4ICsg MTAwLCB5ICsgMTAwKTsKKyAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKKyAgICAg ICAgICAgIHNldFRpbWVvdXQoInJ1blRlc3QoKSIsIDUwKTsKKyAgICAgICAgfQorICAgIH0KKwor ICAgIHJ1blRlc3QoKTsKKzwvc2NyaXB0PgorPC9ib2R5PgorPC9oZWFkPgorPC9odG1sPgorCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKaW5kZXggMWRlNjNkZi4uNmY0ODcxYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDExLTA1LTI0ICBJZ29yIE9saXZlaXJhICA8aWdvci5vbGl2ZWlyYUBvcGVuYm9zc2Eub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g UXRXZWJLaXQgY3Jhc2hlcyB3aGVuIGRyYWdnaW5nIG5vdCBsb2FkZWQgaW1hZ2VzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTMxNAorCisgICAgICAg IENoZWNrcyBpZiBuYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSBpcyBhIHZhbGlkIHBvaW50ZXIu CisKKyAgICAgICAgVGVzdDogaHR0cC90ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1pbWFnZS5o dG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9EcmFnSW1hZ2VRdC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UpOgorCiAyMDExLTA1LTE2ICBQYXZlbCBQ b2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9x dC9EcmFnSW1hZ2VRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9EcmFnSW1hZ2VR dC5jcHAKaW5kZXggOTBiMWJiYy4uNDJhZDZlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vcXQvRHJhZ0ltYWdlUXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L3F0L0RyYWdJbWFnZVF0LmNwcApAQCAtNjMsNyArNjMsNyBAQCBEcmFnSW1hZ2VSZWYgZGlzc29s dmVEcmFnSW1hZ2VUb0ZyYWN0aW9uKERyYWdJbWFnZVJlZiBpbWFnZSwgZmxvYXQpCiAKIERyYWdJ bWFnZVJlZiBjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UoSW1hZ2UqIGltYWdlKQogewotICAgIGlm ICghaW1hZ2UpCisgICAgaWYgKCFpbWFnZSB8fCAhaW1hZ2UtPm5hdGl2ZUltYWdlRm9yQ3VycmVu dEZyYW1lKCkpCiAgICAgICAgIHJldHVybiAwOwogCiAgICAgcmV0dXJuIG5ldyBRUGl4bWFwKCpp bWFnZS0+bmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKSk7Ci0tIAoxLjcuMQoK 94778 2011-05-25 07:05:40 -0700 2011-05-25 09:34:08 -0700 Patch 0001-Qt-QtWebKit-crashes-when-dragging-not-loaded-images.patch text/plain 4540 igor.oliveira RnJvbSA0MTZiMTFhYWI4NzRiNGM3ZjE2NzQ2NzZlNzFiMzljMDAwNWMwZDgxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJZ29yIE9saXZlaXJhIDxpZ29yLm9saXZlaXJhQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IFR1ZSwgMjQgTWF5IDIwMTEgMTg6MTQ6NDEgLTA0MDAKU3ViamVjdDogW1BB VENIXSBbUXRdIFF0V2ViS2l0IGNyYXNoZXMgd2hlbiBkcmFnZ2luZyBub3QgbG9hZGVkIGltYWdl cwoKLS0tCiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICB8ICAgMTIgKysrKysKIC4uLi90ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1pbWFnZS1leHBl Y3RlZC50eHQgIHwgICAgMyArCiAuLi4vaHR0cC90ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1p bWFnZS5odG1sICAgICB8ICAgNDQgKysrKysrKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysKIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3F0L0RyYWdJbWFnZVF0LmNwcCAgICAgICAgIHwgICAgMiArLQog NSBmaWxlcyBjaGFuZ2VkLCA3NCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQogY3JlYXRl IG1vZGUgMTAwNjQ0IExheW91dFRlc3RzL2h0dHAvdGVzdHMvbWlzYy9kcmFnLW5vdC1sb2FkZWQt aW1hZ2UtZXhwZWN0ZWQudHh0CiBjcmVhdGUgbW9kZSAxMDA2NDQgTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1pbWFnZS5odG1sCgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDFmN2VhMWYuLjMz ZmUxODEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMS0wNS0yNCAgSWdvciBPbGl2ZWlyYSAg PGlnb3Iub2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFF0V2ViS2l0IGNyYXNoZXMgd2hlbiBkcmFnZ2lu ZyBub3QgbG9hZGVkIGltYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NjEzMTQKKworICAgICAgICBDaGVja3MgaWYgV2ViS2l0IGNyYXNoZXMgd2hl biBkcmFnZ2luZyBhbiBpbWFnZSBub3QgeWV0IGxvYWRlZC4KKworICAgICAgICAqIGh0dHAvdGVz dHMvbWlzYy9kcmFnLW5vdC1sb2FkZWQtaW1hZ2UtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBodHRwL3Rlc3RzL21pc2MvZHJhZy1ub3QtbG9hZGVkLWltYWdlLmh0bWw6IEFkZGVkLgor CiAyMDExLTA1LTE4ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgogCiAgICAg ICAgIFJlbW92ZSB3aGl0ZXNwYWNlIGZyb20gdGhlIGxpbmUgb2YgZmFzdC9mb3Jtcy9WYWxpZGl0 eVN0YXRlLXZhbHVlTWlzc2luZy0wMDIuaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1pbWFnZS1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL21pc2MvZHJhZy1ub3QtbG9hZGVkLWltYWdlLWV4cGVjdGVkLnR4dApu ZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi43NDc1MGYzCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1pbWFnZS1l eHBlY3RlZC50eHQKQEAgLTAsMCArMSwzIEBACisKK1N1Y2Nlc3MKKwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1pbWFnZS5odG1sIGIvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL2RyYWctbm90LWxvYWRlZC1pbWFnZS5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjUyNDIzN2EKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2MvZHJhZy1ub3QtbG9hZGVkLWltYWdlLmh0bWwK QEAgLTAsMCArMSw0NCBAQAorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQ+CitpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKSB7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGls RG9uZSgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKK30KKworZnVu Y3Rpb24gbG9nKHRleHQpCit7CisgICAgdmFyIGNvbnNvbGUgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgnY29uc29sZScpOworICAgIGNvbnNvbGUuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRl VGV4dE5vZGUodGV4dCkpOworICAgIGNvbnNvbGUuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgnYnInKSk7Cit9Cis8L3NjcmlwdD4KKzxib2R5PgorPGltZyBpZD0iaW1hZ2VTbG93 IiAKKyAgICAgc3JjPSJyZXNvdXJjZXMvaW1hZ2Utc2xvdy5wbCIgd2lkdGg9IjEyOCIgaGVpZ2h0 PSIxMjgiPgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0IGxhbmd1YWdlPSJKYXZh U2NyaXB0Ij4gCisgICAgdmFyIGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiaW1hZ2VTbG93 Iik7CisgICAgZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAgICAgICAgcmVhZHlTdGF0ZSA9IGRvY3Vt ZW50LnJlYWR5U3RhdGU7CisgICAgICAgIGlmIChyZWFkeVN0YXRlID09ICdjb21wbGV0ZScpIHsK KyAgICAgICAgICAgIGxvZygiU3VjY2VzcyIpCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5ub3RpZnlEb25lKCkKKyAgICAgICAgfSBlbHNlIGlmIChyZWFkeVN0YXRlID09ICdsb2Fk aW5nJyB8fCByZWFkeVN0YXRlID09ICdpbnRlcmFjdGl2ZScpIHsKKyAgICAgICAgICAgIHggPSBl Lm9mZnNldExlZnQgKyBlLm9mZnNldFdpZHRoIC8gMjsKKyAgICAgICAgICAgIHkgPSBlLm9mZnNl dFRvcCArIGUub2Zmc2V0SGVpZ2h0IC8gMjsKKyAgICAKKyAgICAgICAgICAgIGV2ZW50U2VuZGVy Lm1vdXNlTW92ZVRvKHgsIHkpOworICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7 ICAgIAorICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oeCArIDEwMCwgeSArIDEw MCk7CisgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CisgICAgICAgICAgICBzZXRU aW1lb3V0KCJydW5UZXN0KCkiLCA1MCk7CisgICAgICAgIH0KKyAgICB9CisKKyAgICBydW5UZXN0 KCk7Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaGVhZD4KKzwvaHRtbD4KKwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IDFkZTYzZGYuLjZmNDg3MWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwor KysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMS0wNS0y NCAgSWdvciBPbGl2ZWlyYSAgPGlnb3Iub2xpdmVpcmFAb3BlbmJvc3NhLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFF0V2ViS2l0IGNy YXNoZXMgd2hlbiBkcmFnZ2luZyBub3QgbG9hZGVkIGltYWdlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEzMTQKKworICAgICAgICBDaGVja3MgaWYg bmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUgaXMgYSB2YWxpZCBwb2ludGVyLgorCisgICAgICAg IFRlc3Q6IGh0dHAvdGVzdHMvbWlzYy9kcmFnLW5vdC1sb2FkZWQtaW1hZ2UuaHRtbAorCisgICAg ICAgICogcGxhdGZvcm0vcXQvRHJhZ0ltYWdlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Y3Jl YXRlRHJhZ0ltYWdlRnJvbUltYWdlKToKKwogMjAxMS0wNS0xNiAgUGF2ZWwgUG9kaXZpbG92ICA8 cG9kaXZpbG92QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlr aGF0c2t5LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvRHJhZ0ltYWdl UXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvRHJhZ0ltYWdlUXQuY3BwCmluZGV4 IDkwYjFiYmMuLjQyYWQ2ZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0 L0RyYWdJbWFnZVF0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9EcmFnSW1h Z2VRdC5jcHAKQEAgLTYzLDcgKzYzLDcgQEAgRHJhZ0ltYWdlUmVmIGRpc3NvbHZlRHJhZ0ltYWdl VG9GcmFjdGlvbihEcmFnSW1hZ2VSZWYgaW1hZ2UsIGZsb2F0KQogCiBEcmFnSW1hZ2VSZWYgY3Jl YXRlRHJhZ0ltYWdlRnJvbUltYWdlKEltYWdlKiBpbWFnZSkKIHsKLSAgICBpZiAoIWltYWdlKQor ICAgIGlmICghaW1hZ2UgfHwgIWltYWdlLT5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpKQog ICAgICAgICByZXR1cm4gMDsKIAogICAgIHJldHVybiBuZXcgUVBpeG1hcCgqaW1hZ2UtPm5hdGl2 ZUltYWdlRm9yQ3VycmVudEZyYW1lKCkpOwotLSAKMS43LjEKCg==