61310 2011-05-23 14:34:37 -0700 keypress doesn't fire for the first key down event when contenteditable is set by an event handler 2011-06-10 21:29:55 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Unspecified Unspecified NEW P1 Normal --- 38696 1 rniwa webkit-unassigned ap cshu darin enrica leviw morrita swivelgames oldest_to_newest 408309 0 94490 rniwa 2011-05-23 14:34:37 -0700 Created attachment 94490 demo When contenteditable is set true in an event handler of click event, the first key down does not fire keypress event in the editable root. 408337 1 rniwa 2011-05-23 14:54:34 -0700 Mn... it seems like the problem isn't really that WebKit not firing keypress event but rather that WebKit renderers caret in the editable region even though it doesn't have a focus. On Firefox 3.6 and Internet Explorer 9, focus is never set on the editable element and the caret is never drawn. Only when the user clicks for the second time, they start rendering caret. 408396 2 94504 rniwa 2011-05-23 15:32:57 -0700 Created attachment 94504 work in progress This work-in-progress patch will make WebKit not to render a caret inside an editable region if it's not focused. But I'm not sure if this is what a user would expect because the editable element is focused when a user modifies selection by pressing arrow keys or other means. This is glitch caused by https://bugs.webkit.org/show_bug.cgi?id=38696. Any opinions / suggestions as to what to do here? 408400 3 ap 2011-05-23 15:38:33 -0700 I do not have a suggestion, but I have an edge case to consider. When conteneditable is set on body (or presumably when designMode is on), the body does not get a focus highlight, but is of course editable. 408596 4 morrita 2011-05-23 20:27:02 -0700 (In reply to comment #2) > Created an attachment (id=94504) [details] > work in progress > > This work-in-progress patch will make WebKit not to render a caret inside an editable region if it's not focused. But I'm not sure if this is what a user would expect because the editable element is focused when a user modifies selection by pressing arrow keys or other means. This is glitch caused by https://bugs.webkit.org/show_bug.cgi?id=38696. > > Any opinions / suggestions as to what to do here? According to the demo, we can input the first character even if we don't render the caret. Is that right? If so, it's strange for me, even if your wip change itself makes sense. 408597 5 morrita 2011-05-23 20:28:03 -0700 > According to the demo, we can input the first character even if we don't render the caret. > Is that right? If so, it's strange for me, even if your wip change itself makes sense. I noticed that is another bug which is filed as Bug 38696. 408601 6 rniwa 2011-05-23 20:33:14 -0700 (In reply to comment #4) > (In reply to comment #2) > > Any opinions / suggestions as to what to do here? > According to the demo, we can input the first character even if we don't render the caret. > Is that right? If so, it's strange for me, even if your wip change itself makes sense. I agree. It's definitely a strange behavior. Maybe this bug needs to be blocked by the bug 38696. 408808 7 cshu 2011-05-24 06:27:05 -0700 > > According to the demo, we can input the first character even if we don't render the caret. > > Is that right? If so, it's strange for me, even if your wip change itself makes sense. > > I agree. It's definitely a strange behavior. Maybe this bug needs to be blocked by the bug 38696. It seems we observed two issues and we do have two patches now. :) It will be good to test the build with both patches. 408960 8 leviw 2011-05-24 10:17:05 -0700 (In reply to comment #7) > It seems we observed two issues and we do have two patches now. :) It will be good to test the build with both patches. I'm slightly confused. Does the patch from 38696 fix this on its own? 408978 9 cshu 2011-05-24 10:34:33 -0700 (In reply to comment #8) > (In reply to comment #7) > > It seems we observed two issues and we do have two patches now. :) It will be good to test the build with both patches. > > I'm slightly confused. Does the patch from 38696 fix this on its own? You are the author of 38696 patch and you must have the build. Can you quickly test the link above and tell us the result? :) 408992 10 leviw 2011-05-24 10:56:00 -0700 (In reply to comment #9) > You are the author of 38696 patch and you must have the build. Can you quickly test the link above and tell us the result? :) Now I understand the problem, and agree that this should be dependent upon 38696, but these patches are complimentary. With the fix in 38696, you are unable to enter a character into the newly-editable field with just one click, but the caret is still rendered. 408993 11 rniwa 2011-05-24 10:58:28 -0700 (In reply to comment #8) > (In reply to comment #7) > > It seems we observed two issues and we do have two patches now. :) It will be good to test the build with both patches. > > I'm slightly confused. Does the patch from 38696 fix this on its own? No. It's just that your patch would make WebKit's behavior more reasonable. This patch stops WebKit's rendering of caret in a contenteditable element with a selection when the element doesn't have a focus. However, due to the bug 38696, a user can still type text in the element (because focus is automatically moved to the element) and the element will be focused. 408995 12 rniwa 2011-05-24 11:00:22 -0700 http://crbug.com/81783. 419149 13 ap 2011-06-10 21:29:55 -0700 *** Bug 62388 has been marked as a duplicate of this bug. *** 94490 2011-05-23 14:34:37 -0700 2011-05-23 14:34:37 -0700 demo editable.html text/html 159 rniwa PCFET0NUWVBFIGh0bWw+CjxodG1sPgo8Ym9keT4KPGRpdiBvbmNsaWNrPSJ0aGlzLnNldEF0dHJp YnV0ZSgnY29udGVudGVkaXRhYmxlJywgJ3RydWUnKSIgb25rZXlwcmVzcz0iYWxlcnQoJ1BBU1Mn KSI+Y2xpY2sgYW5kIHR5cGUgaGVyZTwvZGl2Pgo8L2JvZHk+CjwvaHRtbD4K 94504 2011-05-23 15:32:57 -0700 2011-05-23 15:32:57 -0700 work in progress wip61310 text/plain 3303 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCShyZXZpc2lv biA4NzA5NikKKysrIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0xMjE0LDE5ICsxMjE0LDIzIEBACiAgICAgaWYgKFJlbmRlclZpZXcq IHZpZXcgPSB0b1JlbmRlclZpZXcobV9mcmFtZS0+ZG9jdW1lbnQoKS0+cmVuZGVyZXIoKSkpIHsK ICAgICAgICAgLy8gRklYTUU6IG1ha2UgY2FyZXQgcmVwYWludGluZyBjb250YWluZXItYXdhcmUu CiAgICAgICAgIHZpZXctPnJlcGFpbnRSZWN0YW5nbGVJblZpZXdBbmRDb21wb3NpdGVkTGF5ZXJz KG9sZEFic29sdXRlQ2FyZXRSZXBhaW50Qm91bmRzLCBmYWxzZSk7Ci0gICAgICAgIGlmIChzaG91 bGRSZXBhaW50Q2FyZXQodmlldywgaXNDb250ZW50RWRpdGFibGUoKSkpCisgICAgICAgIGlmIChz aG91bGRSZXBhaW50Q2FyZXQodmlldy0+ZnJhbWVWaWV3KCkgPyB2aWV3LT5mcmFtZVZpZXcoKS0+ ZnJhbWUoKSA6IDAsIHJvb3RFZGl0YWJsZUVsZW1lbnQoKSkpCiAgICAgICAgICAgICB2aWV3LT5y ZXBhaW50UmVjdGFuZ2xlSW5WaWV3QW5kQ29tcG9zaXRlZExheWVycyhtX2Fic29sdXRlQ2FyZXRS ZXBhaW50Qm91bmRzLCBmYWxzZSk7CiAgICAgfQogI2VuZGlmCiAgICAgcmV0dXJuIHRydWU7CiB9 CiAKLWJvb2wgQ2FyZXRCYXNlOjpzaG91bGRSZXBhaW50Q2FyZXQoY29uc3QgUmVuZGVyVmlldyog dmlldywgYm9vbCBpc0NvbnRlbnRFZGl0YWJsZSkgY29uc3QKK2Jvb2wgQ2FyZXRCYXNlOjpzaG91 bGRSZXBhaW50Q2FyZXQoY29uc3QgRnJhbWUqIGZyYW1lLCBOb2RlKiBub2RlKSBjb25zdAogewot ICAgIEFTU0VSVCh2aWV3KTsKLSAgICBGcmFtZSogZnJhbWUgPSB2aWV3LT5mcmFtZVZpZXcoKSA/ IHZpZXctPmZyYW1lVmlldygpLT5mcmFtZSgpIDogMDsgLy8gVGhlIGZyYW1lIHdoZXJlIHRoZSBz ZWxlY3Rpb24gc3RhcnRlZC4KLSAgICBib29sIGNhcmV0QnJvd3NpbmcgPSBmcmFtZSAmJiBmcmFt ZS0+c2V0dGluZ3MoKSAmJiBmcmFtZS0+c2V0dGluZ3MoKS0+Y2FyZXRCcm93c2luZ0VuYWJsZWQo KTsKLSAgICByZXR1cm4gKGNhcmV0QnJvd3NpbmcgfHwgaXNDb250ZW50RWRpdGFibGUpOworICAg IGlmIChmcmFtZSAmJiBmcmFtZS0+c2V0dGluZ3MoKSAmJiBmcmFtZS0+c2V0dGluZ3MoKS0+Y2Fy ZXRCcm93c2luZ0VuYWJsZWQoKSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICBpZiAoZnJh bWUgJiYgZnJhbWUtPmRvY3VtZW50KCkgJiYgZnJhbWUtPmRvY3VtZW50KCktPmZvY3VzZWROb2Rl KCkKKyAgICAgICAgJiYgZnJhbWUtPmRvY3VtZW50KCktPmZvY3VzZWROb2RlKCktPmNvbnRhaW5z KG5vZGUpICYmIG5vZGUtPmlzQ29udGVudEVkaXRhYmxlKCkpCisgICAgICAgIHJldHVybiB0cnVl OworCisgICAgcmV0dXJuIGZhbHNlOwogfQogCiB2b2lkIEZyYW1lU2VsZWN0aW9uOjppbnZhbGlk YXRlQ2FyZXRSZWN0KCkKQEAgLTEyNTQsNyArMTI1OCw3IEBACiAKICAgICBpZiAoIWNhcmV0UmVj dENoYW5nZWQpIHsKICAgICAgICAgUmVuZGVyVmlldyogdmlldyA9IHRvUmVuZGVyVmlldyhub2Rl LT5kb2N1bWVudCgpLT5yZW5kZXJlcigpKTsKLSAgICAgICAgaWYgKHZpZXcgJiYgc2hvdWxkUmVw YWludENhcmV0KHZpZXcsIG5vZGUtPmlzQ29udGVudEVkaXRhYmxlKCkpKQorICAgICAgICBpZiAo dmlldyAmJiBzaG91bGRSZXBhaW50Q2FyZXQodmlldy0+ZnJhbWVWaWV3KCkgPyB2aWV3LT5mcmFt ZVZpZXcoKS0+ZnJhbWUoKSA6IDAsIG5vZGUpKQogICAgICAgICAgICAgdmlldy0+cmVwYWludFJl Y3RhbmdsZUluVmlld0FuZENvbXBvc2l0ZWRMYXllcnMoY2FyZXRSZXBhaW50UmVjdChub2RlKSwg ZmFsc2UpOwogICAgIH0KIH0KQEAgLTE2MTksMTAgKzE2MjMsOCBAQAogewogI2lmIEVOQUJMRShU RVhUX0NBUkVUKQogICAgIGJvb2wgY2FyZXRSZWN0Q2hhbmdlZCA9IHJlY29tcHV0ZUNhcmV0UmVj dCgpOworICAgIGJvb2wgc2hvdWxkQmxpbmsgPSBjYXJldElzVmlzaWJsZSgpICYmIGlzQ2FyZXQo KSAmJiBzaG91bGRSZXBhaW50Q2FyZXQobV9mcmFtZSwgcm9vdEVkaXRhYmxlRWxlbWVudCgpKTsK IAotICAgIGJvb2wgY2FyZXRCcm93c2luZyA9IG1fZnJhbWUtPnNldHRpbmdzKCkgJiYgbV9mcmFt ZS0+c2V0dGluZ3MoKS0+Y2FyZXRCcm93c2luZ0VuYWJsZWQoKTsKLSAgICBib29sIHNob3VsZEJs aW5rID0gY2FyZXRJc1Zpc2libGUoKSAmJiBpc0NhcmV0KCkgJiYgKGlzQ29udGVudEVkaXRhYmxl KCkgfHwgY2FyZXRCcm93c2luZyk7Ci0KICAgICAvLyBJZiB0aGUgY2FyZXQgbW92ZWQsIHN0b3Ag dGhlIGJsaW5rIHRpbWVyIHNvIHdlIGNhbiByZXN0YXJ0IHdpdGggYQogICAgIC8vIGJsYWNrIGNh cmV0IGluIHRoZSBuZXcgbG9jYXRpb24uCiAgICAgaWYgKGNhcmV0UmVjdENoYW5nZWQgfHwgIXNo b3VsZEJsaW5rKQpJbmRleDogU291cmNlL1dlYkNvcmUvZWRpdGluZy9GcmFtZVNlbGVjdGlvbi5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2VkaXRpbmcvRnJhbWVTZWxlY3Rpb24uaAko cmV2aXNpb24gODcwOTYpCisrKyBTb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0ZyYW1lU2VsZWN0aW9u LmgJKHdvcmtpbmcgY29weSkKQEAgLTYwLDcgKzYwLDcgQEAKICAgICBib29sIHVwZGF0ZUNhcmV0 UmVjdChEb2N1bWVudCosIGNvbnN0IFZpc2libGVQb3NpdGlvbiYgY2FyZXRQb3NpdGlvbik7CiAg ICAgSW50UmVjdCBhYnNvbHV0ZUJvdW5kc0ZvckxvY2FsUmVjdChOb2RlKiwgY29uc3QgSW50UmVj dCYpIGNvbnN0OwogICAgIEludFJlY3QgY2FyZXRSZXBhaW50UmVjdChOb2RlKikgY29uc3Q7Ci0g ICAgYm9vbCBzaG91bGRSZXBhaW50Q2FyZXQoY29uc3QgUmVuZGVyVmlldyosIGJvb2wgaXNDb250 ZW50RWRpdGFibGUpIGNvbnN0OworICAgIGJvb2wgc2hvdWxkUmVwYWludENhcmV0KGNvbnN0IEZy YW1lKiwgTm9kZSogbm9kZSkgY29uc3Q7CiAgICAgdm9pZCBwYWludENhcmV0KE5vZGUqLCBHcmFw aGljc0NvbnRleHQqLCBpbnQgdHgsIGludCB0eSwgY29uc3QgSW50UmVjdCYgY2xpcFJlY3QpIGNv bnN0OwogICAgIFJlbmRlck9iamVjdCogY2FyZXRSZW5kZXJlcihOb2RlKikgY29uc3Q7CiAK