61250 2011-05-22 09:27:52 -0700 Use double quotes for filename arguments 2011-05-22 11:08:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 55811 1 paroga paroga abarth commit-queue oldest_to_newest 407651 0 paroga 2011-05-22 09:27:52 -0700 Use double quotes for filename arguments 407657 1 94346 paroga 2011-05-22 09:31:21 -0700 Created attachment 94346 Patch 407659 2 94346 abarth 2011-05-22 09:34:49 -0700 Comment on attachment 94346 Patch Test? 407660 3 paroga 2011-05-22 09:38:57 -0700 (In reply to comment #2) > (From update of attachment 94346 [details]) > Test? How? Are there any tests for the non VCSUtils perl scripts? 407673 4 abarth 2011-05-22 10:26:18 -0700 > How? Are there any tests for the non VCSUtils perl scripts? Dunno. Maybe we need to add more infrastructure to test-webkitperl ? Someone else might be willing to r+ your patch without tests, but, personally, I think we should have tests for all this stuff. 407674 5 paroga 2011-05-22 10:28:32 -0700 (In reply to comment #4) > > How? Are there any tests for the non VCSUtils perl scripts? > > Dunno. Maybe we need to add more infrastructure to test-webkitperl ? Someone else might be willing to r+ your patch without tests, but, personally, I think we should have tests for all this stuff. I'm not against the tests, but I don't want to write the whole test infrastructure. :-/ 407688 6 94346 commit-queue 2011-05-22 11:08:14 -0700 Comment on attachment 94346 Patch Clearing flags on attachment: 94346 Committed r87040: <http://trac.webkit.org/changeset/87040> 407689 7 commit-queue 2011-05-22 11:08:19 -0700 All reviewed patches have been landed. Closing bug. 94346 2011-05-22 09:31:21 -0700 2011-05-22 11:08:13 -0700 Patch bug-61250-20110522183119.patch text/plain 1216 paroga U3VidmVyc2lvbiBSZXZpc2lvbjogODY1NTIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxN2UxODU1MzZhZWU0MTkyNWMwYzZiN2NlZmUxMzJhZThk YTRlZWNkLi4wMmI3MDlhYWNkMWFjNzAwMzEyZmZlZDBmYWZlMWViMDFmMWIwMjkyIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTEtMDUtMjIgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIGRvdWJs ZSBxdW90ZXMgZm9yIGZpbGVuYW1lIGFyZ3VtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjEyNTAKKworICAgICAgICBXaW5kb3dzIGRvZXMgbm90 IHN1cHBvcnQgc2luZ2xlIHF1b3RlcyBvbiB0aGUgY29tbWFuZCBsaW5lLAorICAgICAgICBzbyBy ZXBsYWNlIHRoZW0gd2l0aCBkb3VibGUgcXVvdGVzLgorCisgICAgICAgICogU2NyaXB0cy9wcmVw YXJlLUNoYW5nZUxvZzoKKwogMjAxMS0wNS0xNSAgRG9taW5pYyBDb29uZXkgIDxkb21pbmljY0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZDogYWRkaW5nIG15c2VsZiB0byBjb21t aXR0ZXJzLnB5LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZyBi L1Rvb2xzL1NjcmlwdHMvcHJlcGFyZS1DaGFuZ2VMb2cKaW5kZXggZTZmZWY0MDhhN2JhMGQ0ZmJh OWYyMDUyNmMyZWVhNTlmZWI1ZjliNi4uM2I2NWZjMmFjN2VmN2JiODk3Yjk2M2M5NTRlOWQ2MjYy NjkxZTk1MiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9wcmVwYXJlLUNoYW5nZUxvZworKysg Yi9Ub29scy9TY3JpcHRzL3ByZXBhcmUtQ2hhbmdlTG9nCkBAIC0xMzAzLDcgKzEzMDMsNyBAQCBz dWIgc3RhdHVzQ29tbWFuZChAKQogewogICAgIG15IEBmaWxlcyA9IEBfOwogCi0gICAgbXkgJGZp bGVzU3RyaW5nID0gIiciIC4gam9pbiAoIicgJyIsIEBmaWxlcykgLiAiJyI7CisgICAgbXkgJGZp bGVzU3RyaW5nID0gIlwiIiAuIGpvaW4gKCJcIiBcIiIsIEBmaWxlcykgLiAiXCIiOwogICAgIG15 ICRjb21tYW5kOwogICAgIGlmICgkaXNTVk4pIHsKICAgICAgICAgJGNvbW1hbmQgPSAiJFNWTiBz dGF0ICRmaWxlc1N0cmluZyI7Cg==