61244 2011-05-21 22:37:07 -0700 Undo operations for a web page linger after page is destroyed 2011-05-22 15:36:21 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sullivan sullivan oldest_to_newest 407602 0 sullivan 2011-05-21 22:37:07 -0700 Page editing commands are registered with an NSUndoManager on Mac (and a similar mechanism on windows), but there’s no code to tell the NSUndoManager that these operations are no longer valid for Undoing once the page has been closed. This can lead to crashes downstream. In Radar as <rdar://problem/9482856>. 407603 1 94335 sullivan 2011-05-21 22:42:09 -0700 Created attachment 94335 Patch to clear edit commands in WebPageProxy::closePage() 407604 2 94336 sullivan 2011-05-21 22:43:29 -0700 Created attachment 94336 Same patch as last time but without Xcode-initiated tweak to project file. 407655 3 sullivan 2011-05-22 09:30:27 -0700 Fixed in <http://trac.webkit.org/changeset/87030>. 407710 4 sullivan 2011-05-22 15:30:23 -0700 I accidentally checked into a branch instead of trunk, rolled out in 87045. 407711 5 sullivan 2011-05-22 15:36:21 -0700 Checked into tip of tree in http://trac.webkit.org/changeset/87046 94335 2011-05-21 22:42:09 -0700 2011-05-21 22:43:29 -0700 Patch to clear edit commands in WebPageProxy::closePage() 9482856_patch.txt text/plain 1879 sullivan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3MDI2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMjEgIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYxMjQ0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85NDgyODU2PgorICAgICAgICBVbmRv IG9wZXJhdGlvbnMgZm9yIGEgd2ViIHBhZ2UgbGluZ2VyIGFmdGVyIHBhZ2UgaXMgZGVzdHJveWVk CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUGFnZVByb3h5OjpjbG9zZVBhZ2UpOgorICAgICAgICBDbGVhciBlZGl0aW5nIGNvbW1h bmRzIGJlZm9yZSB0ZWxsaW5nIFVJIGNsaWVudCB0byBjbG9zZSB0aGUgcGFnZSAodGhpcyBtdXN0 IGJlIGRvbmUKKyAgICAgICAgd2hpbGUgdGhlIHBhZ2UgaXMgc3RpbGwgaW4gYSB3aW5kb3cgc28g aXRzIHVuZG8gbWFuYWdlciBjYW4gYmUgYWNjZXNzZWQsIHNvIHdhaXRpbmcKKyAgICAgICAgZm9y IFdlYlBhZ2VQcm94eTo6Y2xvc2UoKSBpcyB0b28gbGF0ZSkuCisKIDIwMTEtMDUtMTkgIEx1Y2Fz IEZvcnNjaGxlciAgPGxmb3JzY2hsZXJAYXBwbGUuY29tCiAKICAgICBNZXJnZWQgcjg2ODUxLgpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHJldmlzaW9u IDg3MDIzKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE5MjgsNiArMTkyOCw3IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpjbG9z ZVBhZ2UoYm9vbCBzdG9wUmUKICAgICBpZiAoc3RvcFJlc3BvbnNpdmVuZXNzVGltZXIpCiAgICAg ICAgIHByb2Nlc3MoKS0+cmVzcG9uc2l2ZW5lc3NUaW1lcigpLT5zdG9wKCk7CiAKKyAgICBtX3Bh Z2VDbGllbnQtPmNsZWFyQWxsRWRpdENvbW1hbmRzKCk7CiAgICAgbV91aUNsaWVudC5jbG9zZSh0 aGlzKTsKIH0KIApJbmRleDogU291cmNlL1dlYktpdDIvV2ViS2l0Mi54Y29kZXByb2ovcHJvamVj dC5wYnhwcm9qCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYktpdDIueGNvZGVwcm9q L3Byb2plY3QucGJ4cHJvagkocmV2aXNpb24gODcwMjMpCisrKyBTb3VyY2UvV2ViS2l0Mi9XZWJL aXQyLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oJKHdvcmtpbmcgY29weSkKQEAgLTM5MjAsNyAr MzkyMCw2IEBACiAJCQlpc2EgPSBQQlhQcm9qZWN0OwogCQkJYnVpbGRDb25maWd1cmF0aW9uTGlz dCA9IDFERUI5MUIxMDg3MzNEQTUwMDEwRTlDRCAvKiBCdWlsZCBjb25maWd1cmF0aW9uIGxpc3Qg Zm9yIFBCWFByb2plY3QgIldlYktpdDIiICovOwogCQkJY29tcGF0aWJpbGl0eVZlcnNpb24gPSAi WGNvZGUgMy4xIjsKLQkJCWRldmVsb3BtZW50UmVnaW9uID0gRW5nbGlzaDsKIAkJCWhhc1NjYW5u ZWRGb3JFbmNvZGluZ3MgPSAxOwogCQkJa25vd25SZWdpb25zID0gKAogCQkJCUVuZ2xpc2gsCg== 94336 2011-05-21 22:43:29 -0700 2011-05-22 08:36:25 -0700 Same patch as last time but without Xcode-initiated tweak to project file. 9482856_patch.txt text/plain 1322 sullivan SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3MDI2KQorKysgU291cmNlL1dlYktpdDIvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDUtMjEgIEpvaG4gU3Vs bGl2YW4gIDxzdWxsaXZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTYxMjQ0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85NDgyODU2PgorICAgICAgICBVbmRv IG9wZXJhdGlvbnMgZm9yIGEgd2ViIHBhZ2UgbGluZ2VyIGFmdGVyIHBhZ2UgaXMgZGVzdHJveWVk CisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcDoKKyAgICAgICAgKFdlYktp dDo6V2ViUGFnZVByb3h5OjpjbG9zZVBhZ2UpOgorICAgICAgICBDbGVhciBlZGl0aW5nIGNvbW1h bmRzIGJlZm9yZSB0ZWxsaW5nIFVJIGNsaWVudCB0byBjbG9zZSB0aGUgcGFnZSAodGhpcyBtdXN0 IGJlIGRvbmUKKyAgICAgICAgd2hpbGUgdGhlIHBhZ2UgaXMgc3RpbGwgaW4gYSB3aW5kb3cgc28g aXRzIHVuZG8gbWFuYWdlciBjYW4gYmUgYWNjZXNzZWQsIHNvIHdhaXRpbmcKKyAgICAgICAgZm9y IFdlYlBhZ2VQcm94eTo6Y2xvc2UoKSBpcyB0b28gbGF0ZSkuCisKIDIwMTEtMDUtMTkgIEx1Y2Fz IEZvcnNjaGxlciAgPGxmb3JzY2hsZXJAYXBwbGUuY29tCiAKICAgICBNZXJnZWQgcjg2ODUxLgpJ bmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHJldmlzaW9u IDg3MDIzKQorKysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTE5MjgsNiArMTkyOCw3IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpjbG9z ZVBhZ2UoYm9vbCBzdG9wUmUKICAgICBpZiAoc3RvcFJlc3BvbnNpdmVuZXNzVGltZXIpCiAgICAg ICAgIHByb2Nlc3MoKS0+cmVzcG9uc2l2ZW5lc3NUaW1lcigpLT5zdG9wKCk7CiAKKyAgICBtX3Bh Z2VDbGllbnQtPmNsZWFyQWxsRWRpdENvbW1hbmRzKCk7CiAgICAgbV91aUNsaWVudC5jbG9zZSh0 aGlzKTsKIH0KIAo=