61236 2011-05-20 22:00:32 -0700 [chromium] Updating chromium DEPS 2011-05-22 23:08:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 gregsimon webkit-unassigned commit-queue ukai vitalyr oldest_to_newest 407498 0 gregsimon 2011-05-20 22:00:32 -0700 [chromium] Updating chromium DEPS 407499 1 94318 gregsimon 2011-05-20 22:01:57 -0700 Created attachment 94318 Patch 407593 2 gregsimon 2011-05-21 19:50:09 -0700 Rolling chromium DEPS to pick up the ScopedTempDir export from webkit_support so it can be used in chromium LayoutTests. 407595 3 94318 fishd 2011-05-21 21:40:08 -0700 Comment on attachment 94318 Patch r=me but we probably dont want code in the webkit repository to depend on ScopedTempDir. it would make it very painful if someone ever changed that class in an incompatible way. how would the average chromium hacker know to fixup webkit? and if they did know they would then have to deal with the circular dependency. (hard to roll webkit w/o things being temporarily broken .) the contents of webkit_support.h mostly encapsulates the extent of the circular deps which we have. if you dont want to copy code into webkit, then consider exposing the "algorithm" of interest as new functions in webkit_support.h. 407597 4 gregsimon 2011-05-21 21:46:48 -0700 The current application is for a LayoutTest so the temp dir does not get filled up. There are not enough primitives in platform/FileSystem.h to do this sort of work entirely in WebCore. However, now that this API is set up in webkit_support its impl can be changed (only in chrome) so it does not use ScopedTempDir to avoid the problems you mention. 407770 5 94318 ukai 2011-05-22 23:07:57 -0700 Comment on attachment 94318 Patch Clearing flags on attachment: 94318 Committed r87050: <http://trac.webkit.org/changeset/87050> 407771 6 ukai 2011-05-22 23:08:05 -0700 All reviewed patches have been landed. Closing bug. 94318 2011-05-20 22:01:57 -0700 2011-05-22 23:07:57 -0700 Patch bug-61236-20110520220156.patch text/plain 994 gregsimon U3VidmVyc2lvbiBSZXZpc2lvbjogODcwMDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXgg MTMyN2M5MTM4Mjc4Y2ExZWM0NTFkZmMzYTY2YzdiM2RhNTRkMmQyYS4uYjZjMDgxMDdhMjM4OTdk NGY0M2Q5MTc3ZmJkNjI5ZDFlYTY3OTQ4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxMyBAQAorMjAxMS0wNS0yMCAgR3JlZyBTaW1vbiAgPGdyZWdzaW1vbkBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W2Nocm9taXVtXSBVcGRhdGluZyBjaHJvbWl1bSBERVBTCisKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTYxMjM2CisKKyAgICAgICAgKiBERVBTOgorCiAy MDExLTA1LTIwICBNaWNoYWVsIE5vcmRtYW4gIDxtaWNoYWVsbkBnb29nbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vREVQUyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vREVQUwppbmRleCAxZWZmNmJi ZjI0Y2Y0ZTg1ZmIxMzI2NTE0ZmYyNDI4NzZkOTJjNWZkLi42YzAwMjQ2MjUwNmVjZGJkOTkzM2Nk YmUyMTk1OTg2YWU0MWUzYWRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL0RF UFMKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9ERVBTCkBAIC0zMiw3ICszMiw3IEBACiAK IHZhcnMgPSB7CiAgICdjaHJvbWl1bV9zdm4nOiAnaHR0cDovL3NyYy5jaHJvbWl1bS5vcmcvc3Zu L3RydW5rL3NyYycsCi0gICdjaHJvbWl1bV9yZXYnOiAnODYwNzAnCisgICdjaHJvbWl1bV9yZXYn OiAnODYxOTInCiB9CiAKIGRlcHMgPSB7Cg==