<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>61235</bug_id>
          
          <creation_ts>2011-05-20 20:28:24 -0700</creation_ts>
          <short_desc>JavaScriptCore doesn&apos;t build on MinGW-w64</short_desc>
          <delta_ts>2011-08-28 00:52:59 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Windows 7</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>65313</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Jonathan Liu">net147</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>benjamin</cc>
    
    <cc>vanboxem.ruben</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>407483</commentid>
    <comment_count>0</comment_count>
      <attachid>94311</attachid>
    <who name="Jonathan Liu">net147</who>
    <bug_when>2011-05-20 20:28:24 -0700</bug_when>
    <thetext>Created attachment 94311
Fix compilation on MinGW-w64

On MinGW-w64, ENABLE_EXECUTABLE_ALLOCATOR_FIXED is defined to 1 which causes JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp to fail to compile as it includes sys/mman.h which MinGW-w64 doesn&apos;t have.

Previously, sys/mman.h was only included by JavaScriptCore/jit/ExecutableAllocatorFixedVMPool.cpp if the OS is Darwin.
To fix this, JavaScriptCore/wtf/Platform.h is modified to only define ENABLE_EXECUTABLE_ALLOCATOR_FIXED to 1 if OS is Darwin.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>407485</commentid>
    <comment_count>1</comment_count>
      <attachid>94313</attachid>
    <who name="Jonathan Liu">net147</who>
    <bug_when>2011-05-20 20:37:25 -0700</bug_when>
    <thetext>Created attachment 94313
Fix compilation on MinGW-w64

As sys/mman.h is available on Linux, i&apos;ve updated the patch to check whether the compiler is not MinGW instead of whether it is Darwin.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>446541</commentid>
    <comment_count>2</comment_count>
    <who name="">vanboxem.ruben</who>
    <bug_when>2011-08-04 09:11:13 -0700</bug_when>
    <thetext>Note that this probably also affects MSVC x64 by the looks of it. So any Win64 compiler really.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>458000</commentid>
    <comment_count>3</comment_count>
    <who name="Jonathan Liu">net147</who>
    <bug_when>2011-08-28 00:52:59 -0700</bug_when>
    <thetext>Disabling JIT as in bug 65313 means that ENABLE_ASSEMBLER will not be enabled. As a result, an executable allocator won&apos;t be enabled and compilation will succeed.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>94311</attachid>
            <date>2011-05-20 20:28:24 -0700</date>
            <delta_ts>2011-05-20 20:37:25 -0700</delta_ts>
            <desc>Fix compilation on MinGW-w64</desc>
            <filename>jsc-mingw-w64.patch</filename>
            <type>text/plain</type>
            <size>682</size>
            <attacher name="Jonathan Liu">net147</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaCBiL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAppbmRleCA3MTZkOWUxLi41M2ZiMWE1IDEw
MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291
cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCkBAIC0xMTEyLDkgKzExMTIsOSBAQAog
I2VuZGlmCiAKIC8qIFBpY2sgd2hpY2ggYWxsb2NhdG9yIHRvIHVzZTsgd2Ugb25seSBuZWVkIGFu
IGV4ZWN1dGFibGUgYWxsb2NhdG9yIGlmIHRoZSBhc3NlbWJsZXIgaXMgY29tcGlsZWQgaW4uCi0g
ICBPbiB4ODYtNjQgd2UgdXNlIGEgc2luZ2xlIGZpeGVkIG1tYXAsIG9uIG90aGVyIHBsYXRmb3Jt
cyB3ZSBtbWFwIG9uIGRlbWFuZC4gKi8KKyAgIE9uIERhcndpbiB4ODYtNjQgd2UgdXNlIGEgc2lu
Z2xlIGZpeGVkIG1tYXAsIG9uIG90aGVyIHBsYXRmb3JtcyB3ZSBtbWFwIG9uIGRlbWFuZC4gKi8K
ICNpZiBFTkFCTEUoQVNTRU1CTEVSKQotI2lmIENQVShYODZfNjQpCisjaWYgT1MoREFSV0lOKSAm
JiBDUFUoWDg2XzY0KQogI2RlZmluZSBFTkFCTEVfRVhFQ1VUQUJMRV9BTExPQ0FUT1JfRklYRUQg
MQogI2Vsc2UKICNkZWZpbmUgRU5BQkxFX0VYRUNVVEFCTEVfQUxMT0NBVE9SX0RFTUFORCAxCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>94313</attachid>
            <date>2011-05-20 20:37:25 -0700</date>
            <delta_ts>2011-05-20 20:37:25 -0700</delta_ts>
            <desc>Fix compilation on MinGW-w64</desc>
            <filename>jsc-mingw-w64.patch</filename>
            <type>text/plain</type>
            <size>588</size>
            <attacher name="Jonathan Liu">net147</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaCBiL1NvdXJj
ZS9KYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAppbmRleCA3MTZkOWUxLi45ZWRhMDA5IDEw
MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKKysrIGIvU291
cmNlL0phdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCkBAIC0xMTE0LDcgKzExMTQsNyBAQAog
LyogUGljayB3aGljaCBhbGxvY2F0b3IgdG8gdXNlOyB3ZSBvbmx5IG5lZWQgYW4gZXhlY3V0YWJs
ZSBhbGxvY2F0b3IgaWYgdGhlIGFzc2VtYmxlciBpcyBjb21waWxlZCBpbi4KICAgIE9uIHg4Ni02
NCB3ZSB1c2UgYSBzaW5nbGUgZml4ZWQgbW1hcCwgb24gb3RoZXIgcGxhdGZvcm1zIHdlIG1tYXAg
b24gZGVtYW5kLiAqLwogI2lmIEVOQUJMRShBU1NFTUJMRVIpCi0jaWYgQ1BVKFg4Nl82NCkKKyNp
ZiAhQ09NUElMRVIoTUlOR1cpICYmIENQVShYODZfNjQpCiAjZGVmaW5lIEVOQUJMRV9FWEVDVVRB
QkxFX0FMTE9DQVRPUl9GSVhFRCAxCiAjZWxzZQogI2RlZmluZSBFTkFCTEVfRVhFQ1VUQUJMRV9B
TExPQ0FUT1JfREVNQU5EIDEK
</data>

          </attachment>
      

    </bug>

</bugzilla>