61226 2011-05-20 16:49:53 -0700 AudioBufferSourceNode noteOff() method must respect scheduling time 2011-05-21 02:42:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 crogers webkit-unassigned commit-queue kbr oldest_to_newest 407407 0 crogers 2011-05-20 16:49:53 -0700 AudioBufferSourceNode noteOff() method must respect scheduling time 407424 1 94296 crogers 2011-05-20 17:09:46 -0700 Created attachment 94296 Patch 407449 2 94296 kbr 2011-05-20 17:59:14 -0700 Comment on attachment 94296 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=94296&action=review Looks fine. One comment about testing. > Source/WebCore/ChangeLog:8 > + No new tests since audio API is not yet implemented. Now that you have a mechanism for rendering to a buffer, would it make sense to start writing layout tests? 407469 3 crogers 2011-05-20 19:18:06 -0700 Hi Ken, I'm still working with Dirk Pranke (currently on vacation) to get everything landed in ORWT and NWRT so I can get the layout tests going. 407516 4 94296 commit-queue 2011-05-21 02:42:21 -0700 Comment on attachment 94296 Patch Clearing flags on attachment: 94296 Committed r87013: <http://trac.webkit.org/changeset/87013> 407517 5 commit-queue 2011-05-21 02:42:26 -0700 All reviewed patches have been landed. Closing bug. 94296 2011-05-20 17:09:46 -0700 2011-05-21 02:42:20 -0700 Patch bug-61226-20110520170945.patch text/plain 7127 crogers SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDg3MDAxKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDUtMjAgIENocmlzIFJv Z2VycyAgPGNyb2dlcnNAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBdWRpb0J1ZmZlclNvdXJjZU5vZGUgbm90ZU9mZigpIG1ldGhv ZCBtdXN0IHJlc3BlY3Qgc2NoZWR1bGluZyB0aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02MTIyNgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBzaW5j ZSBhdWRpbyBBUEkgaXMgbm90IHlldCBpbXBsZW1lbnRlZC4KKworICAgICAgICAqIHdlYmF1ZGlv L0F1ZGlvQnVmZmVyU291cmNlTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0J1ZmZl clNvdXJjZU5vZGU6OkF1ZGlvQnVmZmVyU291cmNlTm9kZSk6CisgICAgICAgIChXZWJDb3JlOjpB dWRpb0J1ZmZlclNvdXJjZU5vZGU6OnByb2Nlc3MpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9C dWZmZXJTb3VyY2VOb2RlOjpwcm92aWRlSW5wdXQpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9C dWZmZXJTb3VyY2VOb2RlOjpmaW5pc2gpOgorICAgICAgICAoV2ViQ29yZTo6QXVkaW9CdWZmZXJT b3VyY2VOb2RlOjpub3RlR3JhaW5Pbik6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0J1ZmZlclNv dXJjZU5vZGU6Om5vdGVPZmYpOgorICAgICAgICAqIHdlYmF1ZGlvL0F1ZGlvQnVmZmVyU291cmNl Tm9kZS5oOgorCiAyMDExLTA1LTIwICBNaWNoYWVsIE5vcmRtYW4gIDxtaWNoYWVsbkBnb29nbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3dlYmF1ZGlvL0F1ZGlvQnVmZmVyU291cmNlTm9kZS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9CdWZmZXJTb3VyY2VOb2RlLmNwcAkocmV2aXNp b24gODcwMDEpCisrKyBTb3VyY2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb0J1ZmZlclNvdXJjZU5v ZGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zOCw2ICszOCw3IEBAIHVzaW5nIG5hbWVzcGFjZSBz dGQ7CiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNvbnN0IGRvdWJsZSBEZWZhdWx0R3JhaW5EdXJh dGlvbiA9IDAuMDIwOyAvLyAyMG1zCitjb25zdCBkb3VibGUgVW5rbm93blRpbWUgPSAtMTsKIAog UGFzc1JlZlB0cjxBdWRpb0J1ZmZlclNvdXJjZU5vZGU+IEF1ZGlvQnVmZmVyU291cmNlTm9kZTo6 Y3JlYXRlKEF1ZGlvQ29udGV4dCogY29udGV4dCwgZG91YmxlIHNhbXBsZVJhdGUpCiB7CkBAIC01 MSw2ICs1Miw3IEBAIEF1ZGlvQnVmZmVyU291cmNlTm9kZTo6QXVkaW9CdWZmZXJTb3VyY2UKICAg ICAsIG1faXNMb29waW5nKGZhbHNlKQogICAgICwgbV9oYXNGaW5pc2hlZChmYWxzZSkKICAgICAs IG1fc3RhcnRUaW1lKDAuMCkKKyAgICAsIG1fZW5kVGltZShVbmtub3duVGltZSkKICAgICAsIG1f c2NoZWR1bGluZ0ZyYW1lRGVsYXkoMCkKICAgICAsIG1fcmVhZEluZGV4KDApCiAgICAgLCBtX2lz R3JhaW4oZmFsc2UpCkBAIC05NCw2ICs5NiwxMyBAQCB2b2lkIEF1ZGlvQnVmZmVyU291cmNlTm9k ZTo6cHJvY2VzcyhzaXplCiAgICAgICAgIGRvdWJsZSBxdWFudHVtU3RhcnRUaW1lID0gY29udGV4 dCgpLT5jdXJyZW50VGltZSgpOwogICAgICAgICBkb3VibGUgcXVhbnR1bUVuZFRpbWUgPSBxdWFu dHVtU3RhcnRUaW1lICsgZnJhbWVzVG9Qcm9jZXNzIC8gc2FtcGxlUmF0ZTsKIAorICAgICAgICAv LyBJZiB3ZSBrbm93IHRoZSBlbmQgdGltZSBhbmQgaXQncyBhbHJlYWR5IHBhc3NlZCwgdGhlbiBk b24ndCBib3RoZXIgZG9pbmcgYW55IG1vcmUgcmVuZGVyaW5nIHRoaXMgY3ljbGUuCisgICAgICAg IGlmIChtX2VuZFRpbWUgIT0gVW5rbm93blRpbWUgJiYgbV9lbmRUaW1lIDw9IHF1YW50dW1TdGFy dFRpbWUpIHsKKyAgICAgICAgICAgIG1faXNQbGF5aW5nID0gZmFsc2U7CisgICAgICAgICAgICBt X3JlYWRJbmRleCA9IDA7CisgICAgICAgICAgICBmaW5pc2goKTsKKyAgICAgICAgfQorICAgICAg ICAKICAgICAgICAgaWYgKCFtX2lzUGxheWluZyB8fCBtX2hhc0ZpbmlzaGVkIHx8ICFidWZmZXIo KSB8fCBtX3N0YXJ0VGltZSA+PSBxdWFudHVtRW5kVGltZSkgewogICAgICAgICAgICAgLy8gRklY TUU6IGNhbiBvcHRpbWl6ZSBoZXJlIGJ5IHByb3BhZ2F0aW5nIHNpbGVudCBoaW50IGluc3RlYWQg b2YgZm9yY2luZyB0aGUgd2hvbGUgY2hhaW4gdG8gcHJvY2VzcyBzaWxlbmNlLgogICAgICAgICAg ICAgb3V0cHV0QnVzLT56ZXJvKCk7CkBAIC0xMjcsNiArMTM2LDI1IEBAIHZvaWQgQXVkaW9CdWZm ZXJTb3VyY2VOb2RlOjpwcm9jZXNzKHNpemUKICAgICAgICAgZG91YmxlIHRvdGFsR2FpbiA9IGdh aW4oKS0+dmFsdWUoKSAqIG1fYnVmZmVyLT5nYWluKCk7CiAgICAgICAgIG91dHB1dEJ1cy0+Y29w eVdpdGhHYWluRnJvbSgqb3V0cHV0QnVzLCAmbV9sYXN0R2FpbiwgdG90YWxHYWluKTsKIAorICAg ICAgICAvLyBJZiB0aGUgZW5kIHRpbWUgaXMgc29tZXdoZXJlIGluIHRoZSBtaWRkbGUgb2YgdGhp cyB0aW1lIHF1YW50dW0sIHRoZW4gc2ltcGx5IHplcm8gb3V0IHRoZQorICAgICAgICAvLyBmcmFt ZXMgc3RhcnRpbmcgYXQgdGhlIGVuZCB0aW1lLgorICAgICAgICBpZiAobV9lbmRUaW1lICE9IFVu a25vd25UaW1lICYmIG1fZW5kVGltZSA+PSBxdWFudHVtU3RhcnRUaW1lICYmIG1fZW5kVGltZSA8 IHF1YW50dW1FbmRUaW1lKSB7CisgICAgICAgICAgICB1bnNpZ25lZCB6ZXJvU3RhcnRGcmFtZSA9 IChtX2VuZFRpbWUgLSBxdWFudHVtU3RhcnRUaW1lKSAqIHNhbXBsZVJhdGU7CisgICAgICAgICAg ICB1bnNpZ25lZCBmcmFtZXNUb1plcm8gPSBmcmFtZXNUb1Byb2Nlc3MgLSB6ZXJvU3RhcnRGcmFt ZTsKKworICAgICAgICAgICAgYm9vbCBpc1NhZmUgPSB6ZXJvU3RhcnRGcmFtZSA8IGZyYW1lc1Rv UHJvY2VzcyAmJiBmcmFtZXNUb1plcm8gPD0gZnJhbWVzVG9Qcm9jZXNzICYmIHplcm9TdGFydEZy YW1lICsgZnJhbWVzVG9aZXJvIDw9IGZyYW1lc1RvUHJvY2VzczsKKyAgICAgICAgICAgIEFTU0VS VChpc1NhZmUpOworICAgICAgICAgICAgCisgICAgICAgICAgICBpZiAoaXNTYWZlKSB7CisgICAg ICAgICAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG91dHB1dEJ1cy0+bnVtYmVyT2ZD aGFubmVscygpOyArK2kpCisgICAgICAgICAgICAgICAgICAgIG1lbXNldChvdXRwdXRCdXMtPmNo YW5uZWwoaSktPmRhdGEoKSArIHplcm9TdGFydEZyYW1lLCAwLCBzaXplb2YoZmxvYXQpICogZnJh bWVzVG9aZXJvKTsKKyAgICAgICAgICAgIH0KKworICAgICAgICAgICAgbV9pc1BsYXlpbmcgPSBm YWxzZTsKKyAgICAgICAgICAgIG1fcmVhZEluZGV4ID0gMDsKKyAgICAgICAgICAgIGZpbmlzaCgp OworICAgICAgICB9CisKICAgICAgICAgbV9wcm9jZXNzTG9jay51bmxvY2soKTsKICAgICB9IGVs c2UgewogICAgICAgICAvLyBUb28gYmFkIC0gdGhlIHRyeUxvY2soKSBmYWlsZWQuICBXZSBtdXN0 IGJlIGluIHRoZSBtaWRkbGUgb2YgY2hhbmdpbmcgYnVmZmVycyBhbmQgd2VyZSBhbHJlYWR5IG91 dHB1dHRpbmcgc2lsZW5jZSBhbnl3YXkuCkBAIC0yNDksMTEgKzI3Nyw3IEBAIHZvaWQgQXVkaW9C dWZmZXJTb3VyY2VOb2RlOjpwcm92aWRlSW5wdXQKICAgICAgICAgICAgICAgICAgICAgICAgIG1l bXNldChkZXN0aW5hdGlvblIsIDAsIHNpemVvZihmbG9hdCkgKiBmcmFtZXNUb1Byb2Nlc3MpOwog ICAgICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgICAgIGlmICghbV9oYXNGaW5pc2hlZCkg ewotICAgICAgICAgICAgICAgICAgICAvLyBMZXQgdGhlIGNvbnRleHQgZGVyZWZlcmVuY2UgdGhp cyBBdWRpb05vZGUuCi0gICAgICAgICAgICAgICAgICAgIGNvbnRleHQoKS0+bm90aWZ5Tm9kZUZp bmlzaGVkUHJvY2Vzc2luZyh0aGlzKTsKLSAgICAgICAgICAgICAgICAgICAgbV9oYXNGaW5pc2hl ZCA9IHRydWU7Ci0gICAgICAgICAgICAgICAgfQorICAgICAgICAgICAgICAgIGZpbmlzaCgpOwog ICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KICAgICAgICAgfQpAQCAtMzQy LDYgKzM2NiwxNSBAQCB2b2lkIEF1ZGlvQnVmZmVyU291cmNlTm9kZTo6cmVzZXQoKQogICAgIG1f bGFzdEdhaW4gPSBnYWluKCktPnZhbHVlKCk7CiB9CiAKK3ZvaWQgQXVkaW9CdWZmZXJTb3VyY2VO b2RlOjpmaW5pc2goKQoreworICAgIGlmICghbV9oYXNGaW5pc2hlZCkgeworICAgICAgICAvLyBM ZXQgdGhlIGNvbnRleHQgZGVyZWZlcmVuY2UgdGhpcyBBdWRpb05vZGUuCisgICAgICAgIGNvbnRl eHQoKS0+bm90aWZ5Tm9kZUZpbmlzaGVkUHJvY2Vzc2luZyh0aGlzKTsKKyAgICAgICAgbV9oYXNG aW5pc2hlZCA9IHRydWU7CisgICAgfQorfQorCiB2b2lkIEF1ZGlvQnVmZmVyU291cmNlTm9kZTo6 c2V0QnVmZmVyKEF1ZGlvQnVmZmVyKiBidWZmZXIpCiB7CiAgICAgQVNTRVJUKGlzTWFpblRocmVh ZCgpKTsKQEAgLTM5OSw3ICs0MzIsNyBAQCB2b2lkIEF1ZGlvQnVmZmVyU291cmNlTm9kZTo6bm90 ZUdyYWluT24oCiAgICAgbWF4R3JhaW5PZmZzZXQgPSBtYXgoMC4wLCBtYXhHcmFpbk9mZnNldCk7 CiAKICAgICBncmFpbk9mZnNldCA9IG1heCgwLjAsIGdyYWluT2Zmc2V0KTsKLSAgICBncmFpbk9m ZnNldCA9IG1pbihtYXhHcmFpbk9mZnNldCwgZ3JhaW5PZmZzZXQpOyAgICAKKyAgICBncmFpbk9m ZnNldCA9IG1pbihtYXhHcmFpbk9mZnNldCwgZ3JhaW5PZmZzZXQpOwogICAgIG1fZ3JhaW5PZmZz ZXQgPSBncmFpbk9mZnNldDsKIAogICAgIG1fZ3JhaW5EdXJhdGlvbiA9IGdyYWluRHVyYXRpb247 CkBAIC00MTEsMTUgKzQ0NCwxNCBAQCB2b2lkIEF1ZGlvQnVmZmVyU291cmNlTm9kZTo6bm90ZUdy YWluT24oCiAgICAgbV9pc1BsYXlpbmcgPSB0cnVlOwogfQogCi12b2lkIEF1ZGlvQnVmZmVyU291 cmNlTm9kZTo6bm90ZU9mZihkb3VibGUpCit2b2lkIEF1ZGlvQnVmZmVyU291cmNlTm9kZTo6bm90 ZU9mZihkb3VibGUgd2hlbikKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkpOwogICAgIGlm ICghbV9pc1BsYXlpbmcpCiAgICAgICAgIHJldHVybjsKLSAgICAgICAgCi0gICAgLy8gRklYTUU6 IHRoZSAid2hlbiIgYXJndW1lbnQgdG8gdGhpcyBtZXRob2QgaXMgaWdub3JlZC4KLSAgICBtX2lz UGxheWluZyA9IGZhbHNlOwotICAgIG1fcmVhZEluZGV4ID0gMDsKKyAgICAKKyAgICB3aGVuID0g bWF4KDAuMCwgd2hlbik7CisgICAgbV9lbmRUaW1lID0gd2hlbjsKIH0KIAogZG91YmxlIEF1ZGlv QnVmZmVyU291cmNlTm9kZTo6dG90YWxQaXRjaFJhdGUoKQpJbmRleDogU291cmNlL1dlYkNvcmUv d2ViYXVkaW8vQXVkaW9CdWZmZXJTb3VyY2VOb2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvd2ViYXVkaW8vQXVkaW9CdWZmZXJTb3VyY2VOb2RlLmgJKHJldmlzaW9uIDg3MDAxKQor KysgU291cmNlL1dlYkNvcmUvd2ViYXVkaW8vQXVkaW9CdWZmZXJTb3VyY2VOb2RlLmgJKHdvcmtp bmcgY29weSkKQEAgLTEwNCw2ICsxMDQsMTEgQEAgcHJpdmF0ZToKICAgICAvLyBtX3N0YXJ0VGlt ZSBpcyB0aGUgdGltZSB0byBzdGFydCBwbGF5aW5nIGJhc2VkIG9uIHRoZSBjb250ZXh0J3MgdGlt ZWxpbmUgKDAuMCBvciBhIHRpbWUgbGVzcyB0aGFuIHRoZSBjb250ZXh0J3MgY3VycmVudCB0aW1l IG1lYW5zICJub3ciKS4KICAgICBkb3VibGUgbV9zdGFydFRpbWU7IC8vIGluIHNlY29uZHMKIAor ICAgIC8vIG1fZW5kVGltZSBpcyB0aGUgdGltZSB0byBzdG9wIHBsYXlpbmcgYmFzZWQgb24gdGhl IGNvbnRleHQncyB0aW1lbGluZSAoMC4wIG9yIGEgdGltZSBsZXNzIHRoYW4gdGhlIGNvbnRleHQn cyBjdXJyZW50IHRpbWUgbWVhbnMgIm5vdyIpLgorICAgIC8vIElmIGl0IGhhc24ndCBiZWVuIHNl dCBleHBsaWNpdGx5LCB0aGVuIHRoZSBzb3VuZCB3aWxsIG5vdCBzdG9wIHBsYXlpbmcgKGlmIGxv b3BpbmcpIG9yIHdpbGwgc3RvcCB3aGVuIHRoZSBlbmQgb2YgdGhlIEF1ZGlvQnVmZmVyCisgICAg Ly8gaGFzIGJlZW4gcmVhY2hlZC4KKyAgICBkb3VibGUgbV9lbmRUaW1lOyAvLyBpbiBzZWNvbmRz CisgICAgCiAgICAgLy8gbV9zY2hlZHVsaW5nRnJhbWVEZWxheSBpcyB0aGUgc2FtcGxlLWFjY3Vy YXRlIHNjaGVkdWxpbmcgb2Zmc2V0LgogICAgIC8vIEl0J3MgdXNlZCBzbyB0aGF0IHdlIHN0YXJ0 IHJlbmRlcmluZyBhdWRpbyBzYW1wbGVzIGF0IGEgdmVyeSBwcmVjaXNlIHBvaW50IGluIHRpbWUu CiAgICAgLy8gSXQgd2lsbCBvbmx5IGJlIGEgbm9uLXplcm8gdmFsdWUgdGhlIHZlcnkgZmlyc3Qg cmVuZGVyIHF1YW50dW0gdGhhdCB3ZSByZW5kZXIgZnJvbSB0aGUgYnVmZmVyLgpAQCAtMTQwLDYg KzE0NSw5IEBAIHByaXZhdGU6CiAKICAgICAvLyByZWFkRnJvbUJ1ZmZlcldpdGhHcmFpbkVudmVs b3BlKCkgaXMgYSBsb3ctbGV2ZWwgYmxpdHRlciB3aGljaCByZWFkcyBmcm9tIHRoZSBBdWRpb0J1 ZmZlciBhbmQgYXBwbGllcyBhIGdyYWluIGVudmVsb3BlLgogICAgIHZvaWQgcmVhZEZyb21CdWZm ZXJXaXRoR3JhaW5FbnZlbG9wZShmbG9hdCogc291cmNlTCwgZmxvYXQqIHNvdXJjZVIsIGZsb2F0 KiBkZXN0aW5hdGlvbkwsIGZsb2F0KiBkZXN0aW5hdGlvblIsIHNpemVfdCBmcmFtZXNUb1Byb2Nl c3MpOworCisgICAgLy8gSGFuZGxlcyB0aGUgdGltZSB3aGVuIHdlIHJlYWNoIHRoZSBlbmQgb2Yg c2FtcGxlIGRhdGEgKG5vbi1sb29waW5nKSBvciB0aGUgbm90ZU9mZigpIHRpbWUgaGFzIGJlZW4g cmVhY2hlZC4KKyAgICB2b2lkIGZpbmlzaCgpOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29y ZQo=